Minetest logo

IRC log for #minetest-dev, 2019-08-01

| Channels | #minetest-dev index | Today | | Google Search | Plaintext

All times shown according to UTC.

Time Nick Message
01:47 p_gimeno joined #minetest-dev
02:41 MillersMan joined #minetest-dev
02:52 Cornelia joined #minetest-dev
04:23 Lone_Wolf joined #minetest-dev
04:27 Lone_Wolf joined #minetest-dev
04:55 rootyjr joined #minetest-dev
04:56 rootyjr Is there some kind of command to color an entity for a little while, like what happens when a player stands in lava?
05:23 ensonic joined #minetest-dev
05:23 rootyjr joined #minetest-dev
05:24 ANAND set_texture_mod
05:24 ANAND https://github.com/minetest/minetest/blob/245e628d401e421abc512ee0c3b057735fbccaea/doc/lua_api.txt#L5351
05:25 ANAND Please note that this is the Minetest engine development channel. Modding discussion would be better received in #minetest.
05:26 rootyjr thank you.
05:58 ANAND You're welcome :)
07:27 ssieb joined #minetest-dev
07:52 ANAND I'm having trouble displaying a mesh instead of an extruded texture :(
07:53 ANAND Would someone be able to point me to a part in our codebase that sets a scene node's mesh and its texture?
07:54 ANAND I did take a look at content_cao.cpp, but couldn't figure out much
07:55 ANAND It seems like IAnimatedMesh objects are created by using Client::getMesh("path_to_model")
07:55 ANAND But how do I assign textures?
08:40 proller joined #minetest-dev
08:42 Krock joined #minetest-dev
09:12 ANAND Anything left to do in #8682?
09:12 ShadowBot https://github.com/minetest/minetest/issues/8682 -- Make players immortal using immortal=1 by ClobberXD
09:12 ANAND Krock, sfan5 ^
09:12 twoelk joined #minetest-dev
09:19 MrChiantos joined #minetest-dev
09:20 ANAND p_gimeno: Are you working on #8318 (or planning to)?
09:20 ShadowBot https://github.com/minetest/minetest/issues/8318 -- Add "Recently visited" category to the server list
09:20 MrChiantos ServerModConfiguration::ServerModConfiguration(const std::string &worldpath):ModConfiguration(worldpath){SubgameSpec gamespec = findWorldSubgame(worldpath);// Add all game mods and all world modsaddModsInPath(gamespec.gamemods_path);addModsInPath(worldpath + DIR_DELIM + "worldmods");addModsInPath(path_share + DIR_DELIM + "files");// Load nor
09:20 MrChiantos mal modsstd::string worldmt = worldpath + DIR_DELIM + "world.mt";addModsFormConfig(worldmt, gamespec.addon_mods_paths);}
09:20 ANAND Uhh...
09:20 MrChiantos addModsInPath(path_share + DIR_DELIM + "files"); ? Can work ?
09:20 p_gimeno ANAND: no, I gave up on that
09:20 ANAND Oh :(
09:20 MrChiantos this is for enable files for all subgames idea
09:21 ANAND What do you think should be done with respect to #8034?
09:21 ShadowBot https://github.com/minetest/minetest/issues/8034 -- Disable auto-setting server as favorite on connect; display "Add Favorite" button by ClobberXD
09:21 MrChiantos filles (not duplicate) -> games (moon, earth, mars)
09:21 ANAND MrChiantos: Using a pastebin service could help making more people read the wall of text you pasted here. ;)
09:22 MrChiantos https://pastebin.com/wkS3jTw5
09:23 MrChiantos The idea would be to avoid duplicating the same mods used by all games and load them by default.
09:24 MrChiantos This would avoid having copies of files that would be identical for all games.
09:24 MrChiantos (this for my fork)
09:25 MrChiantos As I saw that we could do that in worldmods, I tell myself that I could do this directly in a folder outside the worlds.
09:26 p_gimeno ANAND: I very much like the way that the server list works now, marking every site I visit as favourite as a way to remind me that I have visited them and in what order (a date of last visit would be awesome to have too)
09:26 p_gimeno my only problem is that if I use favourites as markers for history, I can't use them for personalized favs.
09:27 ANAND Hm, but that beats the purpose of "Favourites" :)
09:27 p_gimeno yeah, I'm currently used it as "visit history" which to me is more important
09:27 p_gimeno using* it
09:28 ANAND My problem with the way favourites work is that every server I've tried or been to for even one second, gets marked as a favourite.
09:29 p_gimeno yes, that's why I created 8318 which makes the necessary separation
09:29 p_gimeno however, when I checked the code I was pretty disappointed because that separation was nearly impossible, and then also people seemed to prefer to only have a handful of recently visited servers instead of a full history
09:30 MrChiantos can i look your pr or commit ?
09:34 p_gimeno my personal preference would be to be able to remove servers from history manually, but I don't think that's going to be popular
09:38 ANAND I agree with DS-Minetest's proposal - limited size of recently visited list, and if the list grows larger than the limit, remove the oldest one.
09:39 ANAND Mrchiantos: Which PR?
09:42 ANAND If one doesn't want a server to be removed from the recently visited list, they could just add it as a favourite
09:43 rubenwardy I don't like making the system much more complex for what is a fairly minor issue
09:43 rubenwardy The code is already gross in this area
09:51 p_gimeno I like having a history, which is why I don't like the idea of removing old servers. Perhaps that problem could be solved via a separate server connection log or something.
09:51 p_gimeno It's just that I find it convenient to be able to sort the server list in order of recently visited.
09:52 MrChiantos joined #minetest-dev
09:52 MrChiantos crash
09:54 twoelk could the serverlist maybe feed from three sources? 1.my edited favorites list 2.last visited-excluding doubles from 1 and 3.public serverlist excluding entries from 1. and 2.
09:56 twoelk having a favorites list that keeps my edits and might contain personal notes about those servers would be great
10:00 Krock easy PR: #8731
10:00 ShadowBot https://github.com/minetest/minetest/issues/8731 -- Mainmenu: Use textarea in error formspecs by SmallJoker
10:24 MrChiantos https://blockcolor.net/git/MrChiantos/BlockColor-Engine/commit/2708f0769e7027f25c97159dff8802fcc9dde37f
10:25 MrChiantos work ;)
10:25 MrChiantos i can add now default file game in /files and use custom files games in /games/files
11:12 Krock joined #minetest-dev
11:32 calcul0n joined #minetest-dev
12:04 Fixer joined #minetest-dev
12:05 DS-minetest joined #minetest-dev
12:13 ANAND Krock: Awesome! I always felt that it'd be great to be able to select and copy the text. :D
12:15 DS-minetest indeed, for people that do not use the terminal to start minetest, this removes the need of opening debug.txt
12:28 Krock merging #8731 in 10 minutes
12:28 ShadowBot https://github.com/minetest/minetest/issues/8731 -- Mainmenu: Use textarea in error formspecs by SmallJoker
12:28 sfan5 review my PRs too pleaseeeeeeeeeeeeee
12:29 Krock rubenwardy: when you originally made it, there were no scrollbards
12:29 Krock -d
12:29 ANAND Testing 8731 in 2 minutes (my PC is potato)
12:29 Krock sfan5: but I have 13 of them pending
12:29 Krock ANAND: the C++ change is irrelevant anyway
12:30 Krock only changes the label to indicate whether it's a Lua error or another issue
12:30 ANAND Eeet works! :D
12:30 ANAND Oh ok
12:30 DS-minetest won't it say not Mod error: Mod error: ...
12:30 DS-minetest ?
12:30 DS-minetest now*
12:31 DS-minetest here https://github.com/minetest/minetest/pull/8731/files#diff-7f71a92de20504e8a5636b4317ea67b2R4261
12:31 Krock Not for me
12:31 ANAND Has the OK button increased in height all of a sudden?
12:31 Kimapr joined #minetest-dev
12:31 Krock ANAND: thanks to real_coodinates
12:31 ANAND Oh
12:31 ANAND Kewl
12:32 Krock DS-minetest: errorstream and error_message are two different things
12:32 DS-minetest but it does errorstream << "ModError: " << std::string("ModError: ") + e.what() + strgettext("\nCheck debug.txt for details.") << std::endl;
12:32 Krock *headdesk*
12:37 ANAND yay
12:38 sfan5 ANAND: where is the code that "automatically [sets] [the group] to all players when damage is disabled on the server"?
12:39 Cornelia joined #minetest-dev
12:39 ANAND I don't think it's explicitly set anywhere. But it should work as if it is set. I'll check...
12:40 Krock on join. depends on enable_damage
12:40 Krock https://github.com/minetest/minetest/blob/master/src/content_sao.cpp#L895-L896
12:40 sfan5 ah it already exists
12:40 ANAND Ah yes
12:40 sfan5 merging #8682 in 5m
12:40 ShadowBot https://github.com/minetest/minetest/issues/8682 -- Make players immortal using immortal=1 by ClobberXD
12:41 Krock merging #8731 (trivial changes only)
12:41 ShadowBot https://github.com/minetest/minetest/issues/8731 -- Mainmenu: Use textarea in error formspecs by SmallJoker
12:41 Krock DS-minetest: aaagh
12:41 DS-minetest hm?
12:41 Krock why would you even want to draw that box above anything else
12:42 Krock delaying merge after 8682
12:42 sfan5 Krock: not sure if that counts as trivial but it has 1 approval anyway
12:42 DS-minetest no, draw the box first, so it's beneath everything else
12:42 sfan5 its also hard to tell what really changed due to the style changes
12:42 Krock sfan5: not the PR itself but the changes that happened after the approval
12:43 rubenwardy It doesn't count as trivial imo, and isn't a bugfix
12:43 sfan5 oh that's what you meant, alright
12:45 ANAND Re: #8730. Glad to see someone took the time and effort to implement SSCSM, but the implementation uses mod channels :(
12:45 ShadowBot https://github.com/minetest/minetest/issues/8730 -- SSCSM implementation by Kimapr
12:45 sfan5 merged
12:45 Krock "but"? It's not bad to use existing methods
12:45 DS-minetest there's also someone who made sscsm with lua https://git.minetest.land/luk3yx/sscsm
12:46 Krock damaged website contents ^
12:47 ANAND Krock: Agreed. What I meant is that if we're going to implement SSCSM, we might as well do it right.
12:47 ANAND Usinsg mod-channels works, and is a neat idea, but it might not be the best solution
12:47 Krock ANAND: as in: adding 2 new packets to 1) send the mods and 2) to trigger callbacks in these mods or provide data
12:48 DS-minetest it's not needed to send sscsm code after player join
12:48 Krock server admins may disagree
12:48 DS-minetest what is the problem with new packets┬┐
12:49 * DS-minetest might have misread, sorry
12:50 Krock my message was meant as a reply for "send sscsm after player join". depending on realms, the mods should probably feed different data
12:50 DS-minetest is there someone with windows or mac who can test #8665?
12:50 ShadowBot https://github.com/minetest/minetest/issues/8665 -- Formspec: change the appeareance of the cursor on fields and co. by DS-Minetest
12:50 Krock or when a player enters a special mode (opt-in features), then the mods need to be loaded afterwards
12:50 sfan5 sending different data is what modchannels are for IMO
12:50 sfan5 you just send all mods you might need and keep them disabled if not applicable
12:51 DS-minetest one could make a sscsm that loads code from modchannels
12:51 Krock that's also a method. sending all data on join rather than incrementally afterwards
12:51 DS-minetest sending mods after join is a rather edge-case scenario I think
12:52 sfan5 DS-minetest: sure but I that shouldn't be encouraged
12:52 Krock modchannels are a simple and suitable idea which I previously also had in mind. just never found the motivation to implement it
12:52 Krock the node definition was also meant to be static for the entire game after join, but modder still want to change it
12:53 Krock may it be for time-based special visuals or whatever they imagine
12:54 Krock rubenwardy: is the formspec PR still fine or would you like to see some changes there aswell?
12:54 DS-minetest but that needs all functions of the api to be useable all the time
12:57 Krock huh? the client does not register content
12:57 Krock and callbacks can be registered at any time
12:59 DS-minetest lua_api.txt says, callbacks should only be registered at load time: https://github.com/minetest/minetest/blob/ec3142af990ea55775185e04e46ebf8eb16e2268/doc/lua_api.txt#L3820
13:01 Krock for the mod it's the load time
13:01 Krock https://github.com/minetest/minetest/blob/master/doc/client_lua_api.txt#L651
13:02 Krock so the sentence is still valid, but depends on the perspective
13:02 DS-minetest I see
13:02 Krock is there a TLDR for #8727?
13:02 ShadowBot https://github.com/minetest/minetest/issues/8727 -- Formally Support Games Distributing Their Own Clients
13:05 DS-minetest I think, it's about something like subgame provided mainmenu
13:05 Kimapr joined #minetest-dev
13:05 Krock for me it looks like "remove minimal and minetest_game from minetest"
13:08 Kimapr_ joined #minetest-dev
13:10 Cornelia joined #minetest-dev
13:31 Kimapr joined #minetest-dev
13:45 pauloue joined #minetest-dev
13:47 Cornelia joined #minetest-dev
13:49 ANAND #8731 hasn't been merged yet?
13:49 ShadowBot https://github.com/minetest/minetest/issues/8731 -- Mainmenu: Use textarea in error formspecs by SmallJoker
13:50 ANAND Also, #8656
13:50 ShadowBot https://github.com/minetest/minetest/issues/8656 -- Hide chat when console is open by ClobberXD
13:50 ANAND ...requires one more approval
13:51 DS-minetest Krock's 10 mins are long ;)
13:52 ANAND :P
13:52 Krock asked for confirmation. judging from the zero responses I'll merge it now
13:56 pauloue I think it would look better with a little spacing between the error title and textarea
13:56 Krock that spacing is given by the textare itself
13:57 pauloue oh
13:57 pauloue delete wordwrap_quickhack ?
13:57 Krock huh?
13:58 pauloue oh you did
13:58 Krock oh. I didn't push all changes to the PR branch
13:58 Krock whatever
14:08 ANAND More inputs required for #8271
14:08 ShadowBot https://github.com/minetest/minetest/issues/8271 -- Fix extra bubbles being displayed for high breath_max values by ClobberXD
14:09 ANAND Or... we could improve the statbars in another PR, and let this remain a simple bug-fix PR
14:12 p_gimeno twoelk: that's kinda what the favourites list already does, but I gave up trying to keep the same list for both favourites and history.
14:13 Krock ANAND: not sure if that's even an issue
14:14 ANAND 8271?
14:14 Krock yes. if it hides at max breath it's fine
14:14 Krock no matter whether 9.5 bubbles or 10
14:16 ANAND The problem is that the current implementation doesn't scale well with high breath_max values
14:16 ANAND See #8210
14:16 ShadowBot https://github.com/minetest/minetest/issues/8210 -- Breath statbar might show 10.5 bubbles for high breath values
14:17 Krock using math.floor could solve that too
14:18 Krock but that might also require decreasing the max value
14:18 ANAND The PR does the latter
14:18 ANAND + already
14:19 ANAND MAX_BREATH_DEFAULT used to be 11
14:19 ANAND This PR makes it 10
14:20 ANAND If showing all 10 bubbles before hiding the breath bar is necessary, we can simply make it show 10 bubbles, and then hide the breath bar after a delay.
14:25 Krock indeed
14:25 ANAND Alright. On it
14:27 Krock or just scale to 10 and hide if it's at the maximum
14:30 Lone_Wolf joined #minetest-dev
14:34 ANAND #8732
14:34 ShadowBot https://github.com/minetest/minetest/issues/8732 -- Attempt to improve GitHub Pull Request template by ClobberXD
14:36 ANAND I feel there's just too much raw text in the template
14:37 ANAND Most of the text can be converted into comments, saving the PR author from having to delete most of it.
15:30 Kimapr joined #minetest-dev
16:08 ensonic joined #minetest-dev
16:13 sfan5 merging #8733
16:13 ShadowBot https://github.com/minetest/minetest/issues/8733 -- Correct ServerActiveObject's virtual getArmorGroups() to be const. by shacknetisp
16:14 sfan5 merged
16:40 pauloue Krock: what's blocking approval of #8712? I have a bunch more crafting bugfixes and features planned :)
16:40 ShadowBot https://github.com/minetest/minetest/issues/8712 -- Fix some issues with minetest.clear_craft by pauloue
16:52 Krock didn't see the new commit. testing.
16:57 Krock pauloue: how about group clearing?
16:59 pauloue clearing by input with groups?
16:59 Krock yes, or output
16:59 Krock but I don't think that's one of the intended functions
16:59 Krock *functionalities
17:00 pauloue clearing by input with a group will clear the recipe if it is registered with the group (maybe I should add a test for that)
17:01 pauloue I don't think it should clear recipes if they are registered with any item that matches the group because them you might unintentionally clear multiple recipes
17:02 Krock indeed
17:04 pauloue for clearing all recipes with an output that matches a group you could do a loop over minetest.registered_items and clear if it has the group
17:20 Sokomine p_gimeno: a server connection log would be great
17:53 MillersMan joined #minetest-dev
18:19 twoelk left #minetest-dev
18:19 DS-minetest joined #minetest-dev
18:33 Megaf joined #minetest-dev
18:52 ssieb joined #minetest-dev
19:03 Krock news: something broke the texture pack description backwards compatibility
19:19 Lone_Wolf I think we failed to test properly https://github.com/minetest/minetest/issues/8734
19:20 Lone_Wolf @Krock IIRC you're SmallJoker ^
19:20 Lone_Wolf (Related to your attachment PR)
19:23 Krock does not mean that it's entirely broken
19:23 Krock I'd go as far that this is less an issue than missing attachments on rejoin
19:23 Krock is there a chance to narrow down this issue to a few lines?
19:24 Lone_Wolf Changed the title
19:24 Lone_Wolf And sure
19:25 Krock the player is detached from the parent upon death
19:25 Krock that's what should happen
19:26 Lone_Wolf It's attached in `on_respawnplayer()`
19:27 Krock create_deathholder attaches the player after 1s
19:27 Krock after 2s, loop(name) removes the attachment
19:28 Krock or what am I missing there?
19:29 Lone_Wolf After 2s it starts a timer, which is by default 8. After the timer is over the attachment is removed and the player is allowed to play
19:30 Krock when minetest.after and callbacks aren't good enough..
19:31 Lone_Wolf I'm working on a simple version that still has the bug
19:31 Lone_Wolf left #minetest-dev
19:32 Lone_Wolf joined #minetest-dev
19:32 Lone_Wolf Whoops lol
19:33 Krock create_loop() will immediately call to loop() which then goes into the first condition due to p.time not being set
19:33 Krock missed the assignment there. it's set in dieplayer
19:50 Krock got a little testing mod ready.. but I can still not escape the attachment
19:53 Krock not sure if THAT's supposed to happen but it does https://i.imgur.com/N1FIjjC.png
19:53 Krock the player model scales with the parent size
19:54 sfan5 merging #2429
19:54 ShadowBot https://github.com/minetest/minetest/issues/2429 -- Update credits by Zeno-
19:54 sfan5 game#2429
19:54 ShadowBot https://github.com/minetest/minetest_game/issues/2429 -- Warn when a mod registers a stairs node with an existing name by HybridDog
19:54 Krock credits might need updating somewhen too
19:54 sfan5 before a release should be fine
19:57 benrob0329 joined #minetest-dev
20:02 Krock Lone_Wolf: my testing worked so far https://pastebin.com/raw/jj8BNwjT
20:02 Krock garbage value in L12. should be __builtin:item
20:16 proller joined #minetest-dev
20:55 pmpp joined #minetest-dev
21:05 Lone_Wolf Hmmmm, I wonder if the server's version has to be different too...
21:10 Krock the attachment PR was client-side only
21:13 rubenwardy updated #8383
21:13 ShadowBot https://github.com/minetest/minetest/issues/8383 -- Add formspec styling using a style[] tag by rubenwardy
21:13 rubenwardy I should probably remove testing of unsupported features in the formspec thing, to avoid confusing
21:17 Lone_Wolf I'm able to reproduce with my modded server which was just updated to the latest dev a little bit ago but I can't reproduce it in singleplayer :thinking:
21:57 rubenwardy argh, CLion is useless
22:22 rubenwardy updated #8592
22:22 ShadowBot https://github.com/minetest/minetest/issues/8592 -- Add core.open_url() to main menu API by rubenwardy
22:29 TBSliver_ joined #minetest-dev
23:13 Ritchie_ joined #minetest-dev
23:14 T4im joined #minetest-dev
23:39 Lia joined #minetest-dev
23:55 unclouded joined #minetest-dev

| Channels | #minetest-dev index | Today | | Google Search | Plaintext