Time Nick Message 02:24 ANAND Anyone up for approving #7557? 02:24 ShadowBot https://github.com/minetest/minetest/issues/7557 -- Expose player FOV to Lua API by ClobberXD 02:24 ANAND It's already got an approval from Krock 02:27 ANAND !tell paramat You've done some considerable amount of reviewing on #7557. Would you be able to approve it or suggest changes if any? 02:27 ShadowBot ANAND: O.K. 02:27 ANAND <3 05:47 nerzhul hello: play store remininder: By August 1, 2019, all apps that use native code must provide a 64-bit version in order to publish an update. As of the sending of this email, at least one of your apps* does not yet meet the requirement: 07:24 ANAND #8529 requires approvals 07:24 ShadowBot https://github.com/minetest/minetest/issues/8529 -- Allow customising chat message format by ClobberXD 07:24 ANAND rubenwardy's suggestion has been implemented too 09:39 ANAND Could anyone tell me what's the difference between wide_to_narrow and wide_to_utf8? 10:04 celeron55 what's the difference between the C standard wcstombs and microsoft's WideCharToMultiByte 10:05 celeron55 wide_to_narrow uses the first one if it can and otherwise a custom implementation, and wide_to_utf8 uses the microsoft one when it can and otherwise a custom implementation 10:05 celeron55 doesn't make any sense to me 10:13 sfan5 wcstombs is apparently deprecated and has locale-dependent behaviour 10:13 sfan5 WideCharToMultiByte does not 10:29 ANAND I remember seeing a commit by est31 (the one that probably added wide_to_utf8). It said use wide_to_utf8 wherever possible 10:30 ANAND Should I use wide_to_utf8 over wide_to_narrow in all of my PRs? 10:53 p_gimeno ANAND: I agree with DS-minetest that the setting in 8529 should be removed. If a mod overrides the function, the setting will no longer be used. The drawback, of course, is that in that case only mods can change it, and not regular users. So I'm divided. 10:54 p_gimeno By the way, does it admit colouring as is? 12:09 ANAND p_gimeno: Without the setting, there's no configurable way to set the chat message format, which is the whole point of the PR. 12:12 ANAND I haven't tested this with coloured chat, but it should work, AFAIK 12:13 p_gimeno I was thinking about leaving that up to mods 12:14 p_gimeno that way, if a mod overrides the function, people won't blame the core for not honouring the setting 12:17 p_gimeno on the other hand, regular users lose the setting, that's why I'm divided 12:18 p_gimeno do regular users need the setting more than mod authors? 12:18 p_gimeno err, sorry 12:18 p_gimeno do regular users need to change the text format more than mod authors? 13:01 ANAND p_gimeno: This is set by the server. Clients can't change this format 13:05 DS-minetest if there was no such setting, someone could just make a mod that adds such a setting 13:10 DS-minetest would someone like to review or approve #8433? 13:10 ShadowBot https://github.com/minetest/minetest/issues/8433 -- Fix/Add inventory_overlay for nodes without inventory_image by DS-Minetest 14:27 ANAND DS-minetest: If a mod is going to add this setting anyway, then why not the engine? 14:28 DS-minetest because many servers don't want to change the chat format, it doesn't have to be very user friendly 14:29 DS-minetest and if a server wants to change it (I think, singleplayer won't need a chat), it can install a mod to do so 14:29 ANAND Servers needn't change the chat format if they don't want to. It defaults to the same " message" format that's being used at the moment 14:29 DS-minetest I know 14:31 ANAND Btw, ust added documentation for minetest.format_chat_command. Thanks for reminding me. :) 14:31 ANAND just* 14:31 DS-minetest anyway, as I wrote, the setting doesn't hurt. so, if core devs don't have anything against it, just add it 14:32 ANAND Ok, thanks 14:36 DS-minetest the pr looks good now 14:36 ANAND Thanks. Is the documentation OK? 14:36 DS-minetest yes 14:36 DS-minetest (but I'm not a native speaker) 14:37 DS-minetest (you add a second indentation level in the second line for the function parameters, it is possible that this shouldn't be done) 14:38 ANAND In the C++ code, right? 14:38 ANAND Yea I remember you saying this for another PR. I'll remove the extra indents. 14:40 DS-minetest in s_server.h the other functions have the same, maybe just leave it there as it is 14:45 ANAND Fixed indents in touched code (and also in a couple of nearby declarations in s_server.h) 14:45 ANAND They need to be changed anyway