Time  Nick             Message
16:46 * BuckarooBanzai took a deep dive in the mt code today :)
16:47 BuckarooBanzai   Is there a reason for all the mutexes in server.cpp and map.cpp? As far as i saw there is only one thread accessing that.. :P
16:53 Krock            there's also ServerThread
16:53 Krock            which thread did you find?
16:56 BuckarooBanzai   This one: https://github.com/minetest/minetest/blob/master/src/server.cpp#L471
16:57 BuckarooBanzai   It is only called by this: https://github.com/minetest/minetest/blob/master/src/server.cpp#L92
16:59 BuckarooBanzai   The thread is started in https://github.com/minetest/minetest/blob/master/src/server.cpp#L421 Server::start() (only once though)
17:43 BuckarooBanzai   For anyone interested in long-term engine metrics, i added a few hooks into the engine: https://pandorabox.io/grafana/d/ifuy9KSZz/minetest-engine?orgId=1&refresh=5s
17:44 Krock            impressive
17:45 BuckarooBanzai   I'm trying to find out where i can improve the performance, currently its the environment step that consumes the most cpu...
17:45 BuckarooBanzai   wip-branch is here: https://github.com/thomasrudin-mt/minetest/commits/pandorabox
17:46 BuckarooBanzai   I find the map-save chart mo
17:46 BuckarooBanzai   *the map-save chart is pretty confusing: those aren't the times i set for the map_save_interval... :/
17:47 Krock            maybe a force-save?
17:47 Krock            dunno
20:29 paramat          can anyone review/approve a texture PR game#2399 ? i know almost no-one has time for MTG but i can't merge PRs on my own =)
20:29 ShadowBot        https://github.com/minetest/minetest_game/issues/2399 -- new_default_grass_texture by TumeniNodes
20:30 Lone_Wolf        From the screenshots it looked great, one sec...
20:36 Lone_Wolf        Commented
20:45 paramat          sofar this simple keys PR just needs another +1 game#2290 it looks like you might be able to +1 it now
20:45 ShadowBot        https://github.com/minetest/minetest_game/issues/2290 -- can_interact_with_node check for group key by Lejo1
20:54 paramat          merging game#2275
20:54 ShadowBot        https://github.com/minetest/minetest_game/issues/2275 -- Sfinv creative tweaks by bell07
21:11 DS-minetest      #8662 and #8665 are missing formspec labels
21:11 ShadowBot        https://github.com/minetest/minetest/issues/8662 -- TextArea output color is ignored after first line of text.
21:11 ShadowBot        https://github.com/minetest/minetest/issues/8665 -- Formspec: change the appeareance of the cursor on fields and co. by DS-Minetest
21:22 paramat          ok
21:23 paramat          done
23:34 paramat          much needed new permafrost texture game#2406
23:34 ShadowBot        https://github.com/minetest/minetest_game/issues/2406 -- New lighter, greyer permafrost texture by paramat
23:35 paramat          for dungeons i'll now first experiment with making multiple large rooms possible within 1 dungeon, this seems quite easy but need to check it's practical