Time  Nick          Message
02:39 pauloue       ANAND: do you have a minute to help me debug #8607 ?
02:39 ShadowBot     https://github.com/minetest/minetest/issues/8607 -- minetest.get_craft_result regression
02:40 pauloue       you said the assertion doesn't fail every time for you which seems odd to me
05:44 ANAND         pauloue: Yes, that's correct. The assertion fails only 3 out of 5 times or so.
05:45 ANAND         Let me know how I can help you.
13:18 pauloue       ANAND: could you try initializing priority on this line: https://github.com/minetest/minetest/blob/master/src/craftdef.h#L186 to NO_RECIPE and see if that makes it fail every time?
13:59 ANAND         pauloue: Ok, will do
14:23 ANAND         pauloue: You're right. Assertion fails every single time, if I initialize priority to NO_RECIPE in the class decl. itself
14:46 pauloue       ANAND: Thanks, working on a fix
15:39 Exe_Virus     Hello is there a core dev around who can help steer me in the right direction to start helping to document the minetest engine?
15:39 sfan5         what exactly do you intend to document
15:40 Exe_Virus     essentially all of it. starting from the beginning. I want to learn the engine and I want to document it as I go along
15:40 Exe_Virus     Preferably in the Doxygen style comments
15:40 sfan5         i think there's an issue open on gitub
15:40 sfan5         github*
15:40 sfan5         have you searched?
15:43 Exe_Virus     I have, there are no issues that specifically point to conributing to engine documentation, rather they point to lots of small specific cases through the minetest codebase
15:43 sfan5         an issue about doxygen, i mean
15:43 rubenwardy    Exe_Virus: I suggest starting by looking into the structure, and writing wiki page guides about it
15:43 rubenwardy    then doxygen could come later when you understand the structure more
15:44 Exe_Virus     okay so wiki is better in this case? got it. How do I contibute to the wiki?
15:44 rubenwardy    actually, idk
15:47 Exe_Virus     Okay found a forum topic about it: https://forum.minetest.net/viewtopic.php?f=3&t=10473 looks like I need to ask on IRC :)
15:49 pauloue       msg Calinou
15:50 Exe_Virus     okay will do
16:40 LoneWolfHT    If support was added for drawing a second wieldhand on the opposite side of the screen modders could probably come up with a mod to allow dual-wielding in their games. Or even a mod that allows players to switch their wieldhand to the opposite side of the screen
16:40 LoneWolfHT    Neat, I can talk here now
19:38 paramat       merging #8653 (thanks!)
19:38 ShadowBot     https://github.com/minetest/minetest/issues/8653 -- Move more dungeon parameter selection to mapgens by paramat
19:39 Krock         np. didn't have the time to test this earlier
19:43 paramat       next i'll create a PR for more dungeon structure variety, the fun part
19:44 Krock         nice :D
20:22 nerzhul       paramat cool
21:44 rubenwardy    nerzhul: do you have any opinions on implementing set_table and get_table?
21:45 rubenwardy    #8663
21:45 ShadowBot     https://github.com/minetest/minetest/issues/8663 -- Meta data set_table and get_table with caching
21:45 rubenwardy    specifically, caching the results in the future
21:49 nerzhul       table is the most hard thing to implement
21:50 rubenwardy    raw get_table and set_table would just use JSON encoding
21:50 rubenwardy    the caching and making that efficient is difficult
21:50 nerzhul       yep
21:50 rubenwardy    maybe there should be some flag which says that "Lua currently holds the value to this"
21:51 rubenwardy    and so when the save code tries to save, it triggers a read from Lua
21:51 rubenwardy    but for good OOP, this shouldn't couple meta to lua
21:51 rubenwardy    maybe it could be callback based or something
21:51 * DS-minetest having seen others promoting their PRs on irc, does this now, too: #8664, #8665
21:51 ShadowBot     https://github.com/minetest/minetest/issues/8664 -- Add nodebox type leveled_with_offset by DS-Minetest
21:51 ShadowBot     https://github.com/minetest/minetest/issues/8665 -- Formspec: change the appeareance of the cursor on fields and co. by DS-Minetest
21:52 rubenwardy    nice
21:52 rubenwardy    for the second one, the performance problemi s quite a big issue
21:52 DS-minetest   nah, the delay is fixed
21:52 rubenwardy    oh ok
21:53 * DS-minetest forgot to write something to the commit, but will do now.
21:53 rubenwardy    what was the issue with that?
21:54 DS-minetest   see comment
21:54 rubenwardy    ha, lol
21:54 rubenwardy    classic
22:32 rubenwardy    I've found a deadlock
22:57 paramat       looking