Time Nick Message 00:18 paramat hm 8611 seems fairly simple, i'm tempted to +1 by trustng you. what is the 'if (engine->m_startgame)' check for? 00:18 paramat *trusting 00:18 rubenwardy m_startgame is the bool which is true if the next main menu tick should start a game 00:19 paramat ok 00:54 pauloue paramat: any reason why the default mg_flags (except dungeons) are set in mapgen.h instead of defaultsettings.cpp? 00:54 pauloue it causes incorrect display in the settings menu 01:04 paramat hmm 01:05 paramat there probably is good reason, but our previous mapgen dev 'hmmmm' would be the person to ask. all other mapgen setting are set in headers not in defaultsettings 01:06 paramat *settings 01:06 paramat the issue is, why does it display incorrectly? 01:07 paramat oh i see 01:07 paramat settings->setDefault("mg_flags", "dungeons"); 01:08 paramat this was done for backwards compatibility reasons, so that old worlds did not have dungeons added to them (they used to be default disabled oddly) 01:08 paramat i remember hmmmm insisting it be done this way for that reason 01:09 pauloue wouldn't old worlds only be affected if map_meta.txt is modified? 01:09 paramat in the header is 'u32 flags = MG_CAVES | MG_LIGHT | MG_DECORATIONS | MG_BIOMES;' no dungeons 01:09 paramat i'm not sure 01:09 paramat well, hmmmm was probably correct 01:10 paramat i added rivers to mgcarpathian recently, if i set rivers as enabled in the header they were forced on old worlds 01:11 paramat so it seems map meta txt is overriden, oddly 01:13 paramat thanks for reviewing that PR, i'm rather dreading it because it's quite complex and confusing 01:15 pauloue it worked fine for me other than the things I mentioned 01:16 paramat well, 'all settings' does display correctly, it displays what is in defaultsettings, but of course that ignores the hardcoded mg_flags so is confusing 01:18 paramat maybe in defaultsettings it should set all the flags? like each mapgen's 'spflags'? 01:19 paramat settings->setDefault("mg_flags", "caves,dungeons,light,decorations,biomes"); 01:19 paramat worth a try 01:32 pauloue that does make all the checkboxes ticked in the menu as expected 01:32 paramat nice 01:34 pauloue but if you have 'mg_flaggs=nodecorations' in minetest.conf, it shows 'nodecorations' ticked, yet new worlds have 'mg_flags=caves,nodungeons,light,nodecorations,biomes' 01:36 pauloue so flags in set in mapgen.h are enabled if not specified, but flags in defaultsettings are disabled if not specified 02:09 paramat possibly related: i have found it's necessary to specify all flags when setting flags in .conf, to avoid odd behaviour 02:09 paramat thanks afk 02:12 pauloue bad internet 18:23 Krock rubenwardy: reverted getmetatable, added comment. too bad it can be used to escape 18:23 Krock dump() will not work properly this way 18:23 Krock however, the PR is only to fix general CSM loading/env issues. dump can be fixed in a later PR 18:24 Krock that's some very sweet work you did on the mainmenu. hat's off 18:26 rubenwardy thanks 18:28 Krock any opinions on #8616? Thinking about closing that for poor design choices 18:28 ShadowBot https://github.com/minetest/minetest/issues/8616 -- Give more player information by Lejo1