Time  Nick          Message
00:05 rubenwardy    A reminder to add stuff to the meeting notes for when we next have a meeting
00:06 rubenwardy    those with dev wiki accounts should add it to the Meetings page
00:06 rubenwardy    those without can post here, and I'll copy it across: https://github.com/orgs/minetest/teams/engine/discussions/18
00:34 rubenwardy    nerzhul: can I request a gitlab pipeline on a PR?
01:03 rubenwardy    #8611
01:03 ShadowBot     https://github.com/minetest/minetest/issues/8611 -- Add support for set_formspec_prepend in main menu by rubenwardy
01:06 rubenwardy    #8612
01:06 ShadowBot     https://github.com/minetest/minetest/issues/8612 -- Add background to main menu by rubenwardy
01:06 rubenwardy    not sure on that
05:46 nerzhul       rubenwardy, can you be more precise about your need ? yes i think it's possible
19:48 rubenwardy    Argh, dev is so slow
19:49 rubenwardy    Hwh
19:50 rubenwardy    Hmmm, wondering how to test formspecs
19:51 Krock         testing mod which includes all elements?
19:51 rubenwardy    If you could create a headless renderer instance of minetest, then you could export the formspecs as PNG and then check for similarities against a source of truth
19:51 rubenwardy    I meant autotest
19:51 rubenwardy    This is something I've seen in UI testing for other libraries
19:52 Krock         hmm.. render Irrlicht to a file
19:52 rubenwardy    If a test fails, then the person making the change can compare the two images and commit the new one if it is correct
19:53 rubenwardy    Oh also, nerzhul: I wanted a Windows build of a pr because I dual boot windows but don't have the capability to build for Windows. Hence why I asked about gitlab pipelines
19:55 Krock         vcpkg?
19:56 rubenwardy    lol
19:56 rubenwardy    I probably should check that out
19:56 Krock         building should now be easier
19:56 rubenwardy    I also mildly detest Windows
19:56 Krock         it's somewhat compiling-unfriendly
20:23 rubenwardy    and so begins a whole world of pain https://i.rubenwardy.com/Et5Lb.png
20:27 Krock         oof. good luck with that
20:27 rubenwardy    grrrr
20:27 rubenwardy    I hate singletons
20:51 DS-minetest   rubenwardy: can't you just make screenshots and compare them?
20:51 DS-minetest   (this can be done automatically with xdotool)
20:53 rubenwardy    heh
20:53 rubenwardy    you could automate it by starting up a world and taking screenshots I guess
20:53 rubenwardy    I feel like that would be slow and painful to co-ordinate
20:53 DS-minetest   pff
20:54 DS-minetest   maybe change the mainmenu formspec and also add a white background, then there's no need to start a world
20:55 rubenwardy    that could work better
20:55 rubenwardy    I'll try that if this proves infeasible
21:02 rubenwardy    ok, I've decided it's a good idea to do that
21:02 rubenwardy    :D
21:02 DS-minetest   this means that you gave up on the other plan heh
21:04 rubenwardy    :D
21:04 rubenwardy    it was painful
21:05 rubenwardy    I'll make a fake mainmenu using  main_menu_script   and add a core.take_screenshot function to the main menu API
21:06 rubenwardy    also, thanks DS-minetest for all the reviewing you've been doing lately, it's very helpful
21:06 DS-minetest   core.take_screenshot is not documented
21:06 rubenwardy    add a core.take_screenshot function to the main menu API
21:06 DS-minetest   you're welcome :)
21:07 rubenwardy    it'll be easier to script using a combination of update_formspec and take_screenshot
21:07 rubenwardy    although, not sure how to do comparisons
21:07 rubenwardy    I guess it should render everything then exit to a bash scripe
21:07 rubenwardy    -e+t
21:07 DS-minetest   just xor each pixel and look which are not 0
21:09 DS-minetest   I mean which ones are not -1
21:26 rubenwardy    eugh
21:26 rubenwardy    so, the screenshot is black because the menu hasn't started yet
22:02 rubenwardy    https://github.com/rubenwardy/minetest/tree/fstest
22:06 DS-minetest   ?
22:07 rubenwardy    I nicked the test formspec from the co-ordinates PR
22:07 rubenwardy    https://i.rubenwardy.com/hXNme.png
22:07 rubenwardy    an output image from the thing ^
22:08 DS-minetest   are the tabheaders cut off because of the window size?
22:08 rubenwardy    yeah
22:08 rubenwardy    the window size is 860x480
22:09 rubenwardy    maybe something more square would be better
22:09 rubenwardy    actually, I recall the window size in the main menu being set to something
22:10 rubenwardy    ahh
22:10 rubenwardy    it's looked to 800x600
22:12 DS-minetest   and default screen size is 800*600
22:12 DS-minetest   oops
22:12 DS-minetest   I mean 1024*600
22:13 DS-minetest   so... can this be made to a unittest?
22:14 rubenwardy    probably not
22:14 rubenwardy    idk
22:14 rubenwardy    it's currently ran like this:    ./bin/minetest --config util/fstest/test.conf
22:16 rubenwardy    coming [soon] on my todo list: main menu sandboxing, and the ability to put an init.lua file in a game's menu/ folder
22:16 DS-minetest   why did you set the selected_world_path?
22:16 rubenwardy    but before then, I'd like to fix the tab header element
22:16 rubenwardy    oh, that's accidental
22:16 rubenwardy    it happens when running the program
22:17 DS-minetest   ah, I see
22:17 rubenwardy    maybe I should do something like    cp util/fstest/test.conf /tmp/fstest.conf; ./bin/minetest --config /tmp/fstest.conf
22:20 rubenwardy    pushed to fix that
22:26 rubenwardy    #8615
22:26 ShadowBot     https://github.com/minetest/minetest/issues/8615 -- Add formspec rendering automated testing by rubenwardy
22:45 DS-minetest   sadly this won't work perfectly on things like dropdowns
22:45 DS-minetest   or tooltips
22:45 rubenwardy    yeah
22:46 DS-minetest   you still have to make the script to compare the images ;)
22:48 rubenwardy    yeah, that's in the todo
23:05 rubenwardy    ARGH, so many blocking things in formspec land
23:06 DS-minetest   5.1-dev is a good cycle for formspec
23:06 rubenwardy    yeah
23:07 rubenwardy    argh
23:07 rubenwardy    I also need to work on contentdb dependency installing
23:07 rubenwardy    I need some way to queue content downloading, and show progress on them
23:07 rubenwardy    like the download tab of Firefox/Chrome
23:07 rubenwardy    and then correctly not break the network
23:07 rubenwardy    like, it should cap to 2 at a time maybe
23:08 rubenwardy    actually, I don't know
23:08 * DS-minetest will probably never use cdb as it doesn't use git and ergo is useless
23:08 rubenwardy    bundling git inside Minetest would be a bit ridiculous
23:09 rubenwardy    well, maybe it could be ok if there's a small build for it
23:11 rubenwardy    ContentDB does track git versions though
23:11 rubenwardy    so you could theorectically use git with it
23:13 DS-minetest   is it actually possible to make a script that releases a new mod version on cdb automatically?
23:13 rubenwardy    yes
23:13 rubenwardy    one already exists
23:13 rubenwardy    by War something
23:17 rubenwardy    also, ContentDB (the backend) does use git, it's just triggered manually currently
23:17 rubenwardy    https://gitlab.com/sztest/cdbrelease
23:18 DS-minetest   maybe a mirror feature would be useful
23:19 rubenwardy    certainly
23:57 rubenwardy    hmmm
23:57 rubenwardy    I've been refreshing reviews on PRs where users have fixed things
23:57 rubenwardy    but I realise that's probably not that useful