Time  Nick      Message
04:24 paramat   core devs, these 2 mapgen PRs are ready #8473 #8481 , they are well tested so you don't need to. although labelled 'feature' these are important steps in cleaning up some horrible hardcoded stuff in mapgen
04:24 ShadowBot https://github.com/minetest/minetest/issues/8473 -- Dungeons: Settable density noise, move number calculation to mapgens by paramat
04:24 ShadowBot https://github.com/minetest/minetest/issues/8481 -- Allow multiple cave liquids in a biome definition by paramat
08:35 ANAND     Does nerzhul's approval still apply for #8264?
08:36 ShadowBot https://github.com/minetest/minetest/issues/8264 -- PlayerSAO: Range-limit values passed to setHP and setBreath by ClobberXD
09:35 ANAND     One more approval required for trivial #8488
09:35 ShadowBot https://github.com/minetest/minetest/issues/8488 -- Improve readability of debug menu by using '|' by ClobberXD
09:37 p_gimeno  unfortunately it's not marked as trivial, although it looks like
09:38 p_gimeno  if it's trivial, 1 approval suffices
09:51 Krock     Yet Another Debug Information PR
10:14 ANAND     Krock: Added https://github.com/minetest/minetest/pull/8488/commits/36db3e37ac4c16e911d32935060f2e9fca4baa22 after your approval. Just letting you know.
10:28 Krock     will merge #8261 #8264 and #8488 in 10 mins
10:28 ShadowBot https://github.com/minetest/minetest/issues/8261 -- Use player as starting point instead of camera when pointing node by srifqi
10:28 ShadowBot https://github.com/minetest/minetest/issues/8264 -- PlayerSAO: Range-limit values passed to setHP and setBreath by ClobberXD
10:28 ShadowBot https://github.com/minetest/minetest/issues/8488 -- Improve readability of debug menu by using '|' by ClobberXD
10:28 Krock     ack
10:41 ANAND     More opinions needed on #7557
10:41 ShadowBot https://github.com/minetest/minetest/issues/7557 -- Expose player FOV to Lua API by ClobberXD
10:44 Krock     merging
11:14 ANAND     Krock: #8261 had some changes pending. See https://github.com/minetest/minetest/pull/8261#discussion_r279099091
11:14 ShadowBot https://github.com/minetest/minetest/issues/8261 -- Use player as starting point instead of camera when pointing node by srifqi
11:15 ANAND     Not strictly related to the PR itself, but would've been nice to combine it with the PR.
11:31 ANAND     It looks like the final revision of #8264 has nothing to do with fixing #8212 unlike what it claims. XD
11:31 ShadowBot https://github.com/minetest/minetest/issues/8264 -- PlayerSAO: Range-limit values passed to setHP and setBreath by ClobberXD
11:31 ShadowBot https://github.com/minetest/minetest/issues/8212 -- Players's breath can be greater than breath_max
11:34 ANAND     #8493 :tada:
11:34 ShadowBot https://github.com/minetest/minetest/issues/8493 -- Check for out-of-bounds breath when setting breath_max by ClobberXD
11:35 ANAND     3-line addition + minor codestyle/readability improvements around the touched code. I'd consider that trivial. :)
12:40 ANAND     'nother trivial PR #8494 (sorry :P)
12:40 ShadowBot https://github.com/minetest/minetest/issues/8494 -- [NO SQUASH PLS] PlayerSAO::setHP - Don't call on_hpchange callbacks if HP hasn't changed by ClobberXD
12:41 ANAND     ^ also improves the documentation of on_punchplayer, with respect to it being invoked even if the punched player is dead.
21:44 sfan5     paramat: you might be interested in some quick code I wrote to get all biomes in floatlands https://github.com/sfan5/minetest_game/tree/floatlands_all
21:45 paramat   i am, thanks
21:46 paramat   i'm actually a little unhappy with the current way floatland biomes are registered
21:48 paramat   howerver, i think i prefer specialised biomes for the floatlands, instead of repeating surface biomes
21:48 paramat   *however
21:49 sfan5     so different types of biomes?
21:54 paramat   yes, hmm, maybe partly different. but that would be a lot of work and new content. repeating might be fine for now
21:56 paramat   of course, the current nodes and resources will be wanted and needed in the floatlands
22:00 paramat   i'll look at your code later
22:02 sfan5     it's a proof of concept that repeating surface biomes in floatlands isn't too complicated
23:41 paramat   merging #8140
23:41 ShadowBot https://github.com/minetest/minetest/issues/8140 -- Force send a mapblock to a player. by sofar
23:42 p_gimeno  yay
23:44 paramat   and #8485
23:44 ShadowBot https://github.com/minetest/minetest/issues/8485 -- Remove unnecessary CSM warning by paramat
23:56 sfan5     there seems to be a bug with positioning of the nametag of players sitting in carts when they are not moving