Time Nick Message 08:53 ANAND Can settings_translation_file.cpp be modified directly? I see a comment that says the file is auto-generated, but from where? 08:55 ANAND Silly me - it's builtin/settingtypes.txt >.< 10:12 ANAND #8434 10:12 ANAND ShadowBot? 10:13 ANAND Grr... 10:13 ANAND https://github.com/minetest/minetest/pull/8434 10:13 ANAND !title 10:13 ANAND Dang 10:13 ShadowBot https://github.com/minetest/minetest/issues/8434 -- Rename logfile to minetest.log by default by ClobberXD 10:13 ShadowBot Rename logfile to minetest.log by default by ClobberXD · Pull Request #8434 · minetest/minetest · GitHub 10:17 ANAND That was quick :P 10:17 ANAND Thanks, ShadowBot 10:44 Krock ANAND: consider removing the debug.txt file from your commit 10:44 ANAND Oh crud :) 10:45 ANAND Should it remain in .gitignore? Existing versions still use it, and it will mess up future PRs like mine :) 10:54 ANAND Removed debug.txt, thanks for pointing that out. 10:57 ANAND Re-added debug.txt to .gitignore 11:08 rubenwardy you should still keep the file in the ignore 11:08 rubenwardy ah nvm 12:40 nerzhul i agree to add it in the .gitignore, without doubt :) 17:24 nerzhul can someone review #8435 ? i added my approval 17:24 ShadowBot https://github.com/minetest/minetest/issues/8435 -- Find PostgreSQL correctly by adrido 17:26 nerzhul merging #8432 17:26 ShadowBot https://github.com/minetest/minetest/issues/8432 -- Use unordered_map instead of map for craft definitions by HybridDog 18:15 Lone-Star can someone look at this error and tell me what i'm missing? https://pastebin.com/iQ4WhG5p 18:16 p_gimeno " ‘move’ was not declared in this scope" is pretty explicit 18:17 p_gimeno it's one of the clearest error messages you'll get from gcc :) 18:19 p_gimeno seems it's a ncurses function 18:27 Lone-Star if you look, there is a lot of "was not declared in this scope" errors. never had this before when building MT 18:27 calcul0n_ probably some missing include 18:28 calcul0n_ or a version mismatch with dependencies 18:29 p_gimeno from a quick look, it seems all the missing stuff is from curses 18:29 p_gimeno check your cmake output, there might be some error detecting curses 18:29 p_gimeno if you just don't have curses, disable it with cmake 18:33 Lone-Star this is in terminal_chat_console.cpp "#include ", i don't see that dir in the source 18:33 p_gimeno https://github.com/minetest/minetest/blob/master/src/terminal_chat_console.cpp#L34 - it seems to need an additional #else #error No Curses library found there 18:33 nerzhul merginbg #8425 18:33 ShadowBot https://github.com/minetest/minetest/issues/8425 -- Cleanups around the mapgen init by nerzhul 18:34 nerzhul (after build pass) 18:36 p_gimeno Lone-Star: that's not in the source, that's supposed to be pre-installed in the system 18:37 p_gimeno the #include < > form is typically used to include stuff that does not come in the source, and the #include " " form for stuff that does 18:42 p_gimeno that's not actually minetest development/maintenance discussion though, so it's a bit off-topic here 19:14 paramat rubenwardy sfan5 nerzhul Krock are you free to release 5.0.1 now? or maybe later this evening? i'm here from now on 19:15 Krock I'm here 19:36 sfan5 me too 19:56 rubenwardy here 19:59 paramat woohoo 20:14 sfan5 paramat: https://github.com/minetest/minetest_game/commit/806b29c2a14fd0146bc326a34febefb3ab31e6d2 20:14 sfan5 do you have any idea why this commit is on the stable-5 branch? 20:14 sfan5 is it supposed to be in 5.0.1? 20:15 rubenwardy tenplus1 made the PR to the wrong branch 20:15 rubenwardy and no one noticed 20:17 sfan5 guess i'll push it to master then 20:20 sfan5 done 20:26 paramat oops 20:26 sfan5 backport-5 created 20:26 paramat it's not needed in 5.0.1 but no harm if it is 20:28 paramat nice thanks 20:28 paramat i've just carefully tested that the dungeon loot fixes work fine 20:28 paramat .. when various mods are removed from MTG 20:34 paramat ok MTG backport-5 looks good 20:42 paramat actually i mean, that blueberries commit shouldn't be in 5.0.1. thanks for moving it to master 20:45 sfan5 is the engine backport-5 branch missing commits? 20:48 rubenwardy sfan5: seems fine to me 20:48 rubenwardy the refactors by nerzhul shouldn't go it 20:48 rubenwardy *in 20:51 paramat as far as i can see nothing is missing from backport-5 20:52 sfan5 yup, same here 20:53 nerzhul no my commits doesn't need it's for 5.1 20:55 sfan5 well i'm going to go ahead, then 20:55 paramat ok 21:04 paramat rubenwardy do you have access to the play store page? i think the new controls and 'fixed joystick' option need mentioning in the 'what's new' section. some reviews don't like the moving joystick 21:08 nerzhul he can modify if i remember 21:14 sfan5 minetest crashes somewhere in libcurl when I open the online content tab 21:15 sfan5 rubenwardy: any idea? 21:19 paramat merging game#2332 21:19 ShadowBot https://github.com/minetest/minetest_game/issues/2332 -- Flowers mod: Light check optimisation in mushroom spread by HybridDog 21:29 rubenwardy sfan5: can't reproduce 21:30 sfan5 well, I don't get it on linux either 21:30 sfan5 just the windows binaries I built 21:30 rubenwardy ohh right 21:30 rubenwardy could've said :) 21:30 rubenwardy heh 21:30 rubenwardy any chance of a backtrace? 21:31 rubenwardy Big different between the server list and CDB is that CDB uses HSTS 21:31 rubenwardy so maybe it's related to that 21:31 sfan5 serverlist works 21:31 sfan5 you think it's HTTPS? 21:31 nerzhul hsts is only for browsers 21:32 sfan5 rubenwardy: good guess, you're correct 21:32 rubenwardy well, CDB doesn't allow plaintext HTTP 21:32 nerzhul i think curl doesn't handle it, because it needs a storage to store the hsts policy, else it's useless :p 21:32 sfan5 serverlist_url = https://[...] crashes it too 21:32 sfan5 maybe it's just wine messing up then? 21:32 rubenwardy nerzhul: true, I meant that HTTPs is enforced for CDB 21:32 rubenwardy *what I meant to say is that 21:33 rubenwardy hopefully 21:35 sfan5 I highly doubt curl has broken their winssl implementation 21:40 sfan5 doesn't crash on actual windows 21:40 sfan5 yay 21:42 sfan5 rubenwardy: the minetest window might become unresponsive while cdb installation is in progress, this is problematic 21:42 rubenwardy that shouldn't happen on the installation 21:42 rubenwardy wait 21:43 rubenwardy it shouldn't happen on the downloading 21:43 rubenwardy but the existing extract zip API that I used has a dependency on GUIEngine 21:43 rubenwardy so you can assume that it blocks the UI thread 21:43 sfan5 i don't see any more network traffic so I guess it was installing 21:48 rubenwardy I mostly reused things that was left by MMDB to implement CDB support 21:48 rubenwardy it isn't great 21:48 rubenwardy MMDB uses the exact same way to download screenshots that I do now 21:48 rubenwardy and it's eugh 21:58 paramat 5.0.1 is released, thanks 22:01 sfan5 rubenwardy: you can tweet about the release 22:01 sfan5 and someone should go tell the maintainers 22:01 rubenwardy sweet 22:01 nerzhul nice, i will build for android this week and publish to betra 22:01 nerzhul beta* 22:05 rubenwardy tweeted