Time  Nick       Message
17:46 paramat    hmm, perhaps we can merge #8019 so it gets as much testing as possible?
17:46 ShadowBot  https://github.com/minetest/minetest/issues/8019 -- Use true pitch/yaw/roll rotations without loss of precision by pgimeno by pauloue
18:07 paramat    nerzhul if the code is good for you perhaps you could approve it? it's fairly well tested
18:20 nerzhul    looking
18:20 paramat    rubenwardy #8164 needs minor codestyle fixes
18:20 ShadowBot  https://github.com/minetest/minetest/issues/8164 -- Disable confirmation dialog on localhost by rubenwardy
18:33 nerzhul    paramat okay for me just a minior change
18:51 paramat    thanks
18:59 paramat    i'll merge it once that's done, or maybe fix that on merge
20:38 paramat    will merge #8019 in 15 mins
20:38 ShadowBot  https://github.com/minetest/minetest/issues/8019 -- Use true pitch/yaw/roll rotations without loss of precision by pgimeno by pauloue
20:39 * p_gimeno starts his clock
21:12 * p_gimeno looks at his clock
21:22 paramat    got distracted, merging
21:28 paramat    thanks for your good work on this
21:29 paramat    now we should replace RC1 or release RC2 with this in for testing
21:31 p_gimeno   thanks for merging :)
21:52 pauloue    the commit author got set to me for some reason
21:53 p_gimeno   heh I guess that happens when squashing
21:54 rubenwardy git commit --amend --author "p_gimeno <EMAIL>"
21:55 p_gimeno   yeah but it's in master already
21:55 pauloue    no one pulled it yet probably
21:56 rubenwardy you can amend within 15 minutes
21:56 rubenwardy bit late though
22:02 p_gimeno   it's OK with me anyway
22:02 paramat    sorry about that
22:03 paramat    didn't know squashing did that
22:05 p_gimeno   no one knew
22:05 rubenwardy correct squashing shouldn't
22:06 p_gimeno   squashing through MSGH probably does
22:14 rubenwardy https://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines
22:15 rubenwardy a lot of this is kinda BS
23:17 entuland   sorry for the noise but I'm not sure how I would proceed, I posted a comment there: https://github.com/minetest/minetest_game/commit/697b39d40dfe7a36b4487ddbb0ba3eb758df4714
23:18 entuland   should I open an issue instead to ask for info about that?