Minetest logo

IRC log for #minetest-dev, 2019-02-05

| Channels | #minetest-dev index | Today | | Google Search | Plaintext

All times shown according to UTC.

Time Nick Message
00:01 rubenwardy VanessaE: what do they mean by lag?
00:01 paramat will merge game#2301 in 15 mins, trivial
00:01 ShadowBot https://github.com/minetest/minetest_game/issues/2301 -- 'permafrost_with_stones/moss' drops itself instead of permafrost by paramat
00:02 paramat merging game#2299
00:02 ShadowBot https://github.com/minetest/minetest_game/issues/2299 -- Add screenshot.png, and more info to game.conf by rubenwardy
00:05 Lone-Star so there's in game screenshots now?
00:05 VanessaE rubenwardy: for example, issuing the profiler dump command, which of course produces log output.  she had an ssh session open to watch the log.  the command wrote its output there so fast that she couldn't switch windows fast enough to see it flood in -- just as it should be -- yet the command also produces a chat message that it's writing its output the log.  this message might take up to 30s to appear.
00:05 paramat rubenwardy why is that PR important for 5.0.0? don't mind merging, just wondering
00:06 rubenwardy It provides the meta for contentdb
00:06 VanessaE rubenwardy: so client -> server is obviously fast, but server -> client is slow
00:06 paramat ok merging
00:06 VanessaE (even if out-of-band comms like an ssh session is fast both ways)
00:08 VanessaE rubenwardy: and like I said, it seemed fine for me, and I'm on IPv6 (but without needing a 6rd tunnel).  I have not changed any settings on the server (or my client) since the update.
00:10 VanessaE I've advised her to open a github issue about this, but in the meantime is there something I should check on that might be breaking things for her.
00:10 VanessaE ?
00:22 paramat seems like an exotic issue with no obvious cause or advice we can give. need more info in an issue
00:23 paramat merging game 2301
00:28 VanessaE yeah I thought so, too.
00:56 Cornelia joined #minetest-dev
01:08 Cornelia joined #minetest-dev
01:24 sofar nerzhul: looks like there's almost no diff, except new openssl defines OPENSSL_cleanse to be straight memset, we probably want to take that change?
01:36 kilbith joined #minetest-dev
01:54 machinehum joined #minetest-dev
01:54 machinehum left #minetest-dev
03:08 machinehum joined #minetest-dev
03:41 ANAND joined #minetest-dev
04:10 machinehum Digging through the code
04:10 machinehum It's a well put togeather project
04:10 machinehum Are there more docs than this https://dev.minetest.net/Main_Page
04:29 ssieb joined #minetest-dev
06:11 nerzhul sofar don't know
06:29 ___ joined #minetest-dev
06:46 p_gimeno joined #minetest-dev
08:16 proller joined #minetest-dev
08:56 kaeza joined #minetest-dev
10:32 YuGiOhJCJ joined #minetest-dev
11:38 proller joined #minetest-dev
12:00 proller joined #minetest-dev
12:29 Fixer joined #minetest-dev
12:35 JDCodeIt joined #minetest-dev
12:37 JDCodeIt Hi All - I found a possibly unintended behavior in function getDigParams(...) - anyone here want to discuss?
12:39 Fixer joined #minetest-dev
12:49 Fixer_ joined #minetest-dev
12:54 Fixer joined #minetest-dev
12:54 JDCodeIt Hi Fixer
12:57 JDCodeIt To discuss if this was intended in  minetest/src/tool.cpp:201 - return value not checked. Has a side effect under certain conditions.  code: int rating = itemgroup_get(groups, groupname);
13:10 JDCodeIt conditions: the node does not define a level, and the tool defines at least one groupcaps with a times entry for level=0 - maybe these are invalid, but nothing is noted during loading of the mods with these settings.
13:41 entuland joined #minetest-dev
13:46 Fixer joined #minetest-dev
13:56 Lia joined #minetest-dev
13:58 Cornelia joined #minetest-dev
14:03 proller joined #minetest-dev
14:27 Lia joined #minetest-dev
14:48 kaeza joined #minetest-dev
14:51 JDCodeIt The effect is that tools that have no match for groups with another node's groups - are able to dig the node
15:07 p_gimeno JDCodeIt: that's best suited for the issue tracker, https://github.com/minetest/minetest/issues
15:16 proller joined #minetest-dev
15:22 Lia joined #minetest-dev
15:27 Cornelia joined #minetest-dev
15:27 JDCodeIt Ok. wasn't sure it was an issue or an intended behavior - thought someone here might know.
15:30 JDCodeIt If for sure - we don't want tools to dig nodes where there is no match between their groups, then yes I will raise as an issue
15:32 p_gimeno the best way to get it visibility is to file it as an issue, eventually it will be looked into to see if it's a problem
15:32 p_gimeno - it
15:32 JDCodeIt Will do. thanks.
15:33 p_gimeno thank you :)
15:51 Fixer_ joined #minetest-dev
15:52 JDCodeIt Issue #8180 posted
15:52 ShadowBot https://github.com/minetest/minetest/issues/8180 -- Tools without groups match to node can sometimes still dig the node
16:00 Fixer joined #minetest-dev
16:18 Gael-de-Sailly joined #minetest-dev
16:30 Ritchie joined #minetest-dev
16:47 proller joined #minetest-dev
16:50 T4im joined #minetest-dev
17:10 JDCodeIt left #minetest-dev
17:13 paramat joined #minetest-dev
17:38 Lia joined #minetest-dev
17:41 Cornelia joined #minetest-dev
18:04 machinehum joined #minetest-dev
18:07 kaeza joined #minetest-dev
18:14 Lia joined #minetest-dev
18:16 Cornelia joined #minetest-dev
19:26 kaeza joined #minetest-dev
19:31 ssieb joined #minetest-dev
19:33 rubenwardy joined #minetest-dev
19:38 Taoki joined #minetest-dev
19:49 machinehum is '#ifdef SERVER' L189 main.cpp legacy? Because I don't see where that would be defined.
19:50 sfan5 its defined in cmake
19:50 rubenwardy SERVER is defined from CMake
19:51 rubenwardy when -DBUILD_SERVER=1 is true a server-only target is made
19:51 rubenwardy SERVER means that it's only a server, no client
19:53 machinehum Got it.
19:53 machinehum Thanks
19:54 machinehum This is a really well built project
19:54 machinehum It's going to take me another couple of weeks to completely get my head around it... but so far so good.
20:09 sofar it's taking me 3 years
20:39 machinehum sofar: Fair enough
21:08 VanessaE guys don't forget to fix the behavior of  /give[me] for counts larger than stack_max.
21:11 Foz joined #minetest-dev
21:13 Foz1 joined #minetest-dev
21:14 VanessaE related:  https://github.com/minetest/minetest/pull/6159
21:23 troller joined #minetest-dev
21:54 paramat joined #minetest-dev
21:54 kaeza joined #minetest-dev
22:27 paramat VanessaE there's no github issue for this problem, could you open one? requests in IRC will be missed/forgotten
22:28 VanessaE paramat: see above.
22:28 VanessaE #6159
22:28 ShadowBot https://github.com/minetest/minetest/issues/6159 -- Builtin: Give any stack size to player by SmallJoker
22:36 paramat that's a PR not an issue :) nothings been done because there isn't an issue
22:36 VanessaE ...
22:37 VanessaE don't split hairs.
22:40 p_gimeno Paramat has a point. The PR was closed because the code it implemented wasn't desired; that's what happens with PRs. Closed = not visible.
22:41 paramat well, it is a PR. attention is brought to issues by creating a github issue, relying on a comment in a closed PR is much less likely to make anything happen. the existing comments in that PR didn't make anything happen either, probably because there isn't an issue ;) it's up to you
22:41 VanessaE the PR was closed without a clearly-stated reason, and it obviously WAS wanted.
22:42 VanessaE and anyway read the comments.  there's enough there to fill any issue someone could open.
22:45 paramat you're an obvious person to open the issue as you care about it, it would have taken less effort than what you have posted here ;)
22:46 paramat but yes, a core dev should have opened an issue when that PR was closed
22:47 cheapie joined #minetest-dev
23:00 Fixer *cough* spawning in trees
23:03 Fixer someone was mentioning cacti digging problems, so I can dig it with axe only... as intended?
23:23 diemartin joined #minetest-dev
23:34 paramat 'groups = {choppy = 3},' expected, but we could add more groups
23:34 paramat well
23:34 paramat pickaxe, sword and shovel don't make sense
23:43 Fixer also, if I quit from singleplayer on a boat, then start again, I'm detached from the boat and sinking down, not good, this must be like that for age
23:43 Fixer s

| Channels | #minetest-dev index | Today | | Google Search | Plaintext