Time Nick Message 01:53 Wuzzy p_gimeno: woah. will you post this thing somewhere? 01:53 Wuzzy nice nice 08:25 nerzhul merging #7956 08:25 ShadowBot https://github.com/minetest/minetest/issues/7956 -- Add eat sound by Wuzzy2 08:53 p_gimeno Wuzzy: post? 08:53 Wuzzy in GitHub, for example 08:53 p_gimeno I squashed the commits into one, it's available here: https://notabug.org/pgimeno/minetest/commits/translation-toolchain together with nore's 08:54 Wuzzy just to make sure this code is not overlooked by the core devs ... 08:55 p_gimeno I guess it still needs docs 08:55 p_gimeno so it's not in an acceptable state 08:55 p_gimeno I'll add a comment to the thread with the pointer 08:56 Wuzzy good 08:57 p_gimeno ah, you have already 12:40 nerzhul dev team, i asked for a renew on the jetbrain pack and it's renewed for 1 year, our license model match 12:42 nerzhul if some coredev wants they extended from 2 licenses to 6 12:43 nerzhul you can use any jetbrains product 13:47 nerzhul merging #7957 13:47 ShadowBot https://github.com/minetest/minetest/issues/7957 -- Fix dissector script to work with newer versions of Wireshark (>2.6) by meme 14:20 ANAND Very trivial bugfix PR: #7960 14:20 ShadowBot https://github.com/minetest/minetest/issues/7960 -- Replace all occurrences of `func` with `function` in docs by ClobberXD 14:21 ANAND Oh no... created that branch off another PR branch 14:21 ANAND *sigh* 14:22 rubenwardy that's not a bug fix, technically 14:22 rubenwardy much better notation though 14:22 ANAND I agree, poor wording 14:22 ANAND But it does throw an error 14:22 ANAND How do I rename it? 14:23 ANAND Also, removed the additional commit that crept in 14:23 ANAND Nvm, I haven't mentioned "bugfix" anywhere in the PR itself 14:28 nerzhul ANAND why it's a docfix ? 14:28 nerzhul because it refers to the lua keyword function ? 14:33 ANAND Are you referring to the branch name? 14:34 ANAND Yes, because it fixes an error which is thrown when `func` is used 14:35 ANAND I assume the API docs are supposed to be copy-paste-friendly, hence the PR 14:36 ANAND Why does Travis build the whole app when the PR just modifies a couple of txt files? 14:36 Unarelith because Travis build everything all the time 14:37 ANAND I mean, can't it be configured to just run luacheck when no C++ files have been touched? 14:37 Unarelith Nope, how could Travis know that a C++ file has been edited or not? 14:37 rubenwardy Minetest doesn't even use LuaCheck yet 14:38 rubenwardy #7895 14:38 ShadowBot https://github.com/minetest/minetest/issues/7895 -- [WIP] Add luacheck to check builtin by rubenwardy 14:38 ANAND Oh o_O 14:38 sfan5 https://travis-ci.org/minetest/minetest/jobs/466011831 it didn't actually build any C++ code 14:38 rubenwardy oh good 14:38 ANAND lol 14:39 ANAND That seemed to be taking a lot of time. Good to know it didn't build the code. 14:39 sfan5 https://github.com/minetest/minetest/blob/master/util/travis/common.sh#L43 see here 14:40 ANAND Neat 14:40 Unarelith ANAND, a full build takes 20-30 min (for all the jobs) 14:44 nerzhul sfan5 it's anoying sometimes, when you modify cmakelists only 14:45 nerzhul or another build related file 14:45 nerzhul can't remember but on my refactor pr i got the problem 15:00 p_gimeno you could have a trigger-build.h: /* 2018-12-12T15:00:00Z */ 15:00 sfan5 manually triggering builds? sounds annoying 15:01 p_gimeno less annoying than not having builds running when they should 15:01 p_gimeno (IMO anyway) 15:26 nerzhul a little bit hacky 15:26 p_gimeno is Minetest physics prepared to deal with collision between non-axis-aligned boxes? 16:13 Unarelith guys, what's the status of #7891 ? this PR has been tested twice and looks ready to be merged (would close #7447 too) 16:13 ShadowBot https://github.com/minetest/minetest/issues/7891 -- Fix ContentDB packages timing out by using download_file instead by rubenwardy 16:13 ShadowBot https://github.com/minetest/minetest/issues/7447 -- Content store does not retrieve any packages 16:17 sfan5 as always, no reviews 16:21 Unarelith sfan5, Krock asked a change which has been made, paramat tested and it works, ClobberXD tested and it works 16:22 Unarelith I checked the code and everything looks good 16:22 Unarelith I don't know what's left to review on this PR 16:44 nerzhul if i remember ruben said it has a refactor on this part no ? 16:55 Unarelith if he said something about it here then idk, rubenwardy what's the state of this PR? 16:57 rubenwardy the PR is ready 16:57 rubenwardy refactors will come after 16:57 rubenwardy refactors are for how it tracks content, not how it downloads the list 18:01 Krock will merge #7952 in ~10 minutes (+1) 18:01 ShadowBot https://github.com/minetest/minetest/issues/7952 -- Fix wrong parameter order for inventory callbacks by pauloue 18:17 Krock mergign.. 18:49 sfan5 Unarelith: indeed, there is nothing left to review here, what's missing is a formal approval 19:46 nerzhul rubenwardy is #7962 correct to you ? 19:46 ShadowBot https://github.com/minetest/minetest/issues/7962 -- Content store: Fix missing screenshot in package view dialog by random-geek 19:50 Krock +1 quick fix 19:56 Unarelith sfan5, rubenwardy, is #7870 ok to you? 19:57 ShadowBot https://github.com/minetest/minetest/issues/7870 -- Add 'item' visual type by GreenXenith 19:58 sfan5 concept-wise sure 19:58 sfan5 well the code too, it's just 15 changed lines 19:59 Unarelith it already has one approval (even if there isn't the tag) 20:00 Unarelith Krock, you still approve this PR? 20:01 sfan5 oh indeed 20:01 Krock moment 20:03 Krock yes. the target of that drawtype is to represent nodes as exact as possible, so it's fine for now - paramtype2 support can also be added in another PR (although it would've been nice to have it in this PR) 20:05 Krock considering it was not done by the author I think someone else would have to implement it ... if that ever happens 20:05 Unarelith sfan5, Krock, nerzhul, #7891 lgtm and rubenwardy says it's ready 20:05 ShadowBot https://github.com/minetest/minetest/issues/7891 -- Fix ContentDB packages timing out by using download_file instead by rubenwardy 20:06 Krock not sure about the garbage collector of the temporary directory. On windows the user would have to do that if it's not cleaned up by the script 20:07 Krock core.delete_dir(tmpdir) nvm me 20:14 rubenwardy merging #7962 in 5 20:14 ShadowBot https://github.com/minetest/minetest/issues/7962 -- Content store: Fix missing screenshot in package view dialog by random-geek