Time Nick Message 00:03 p_gimeno I think the limit may be based on the ability to assign key bindings to them 00:03 VanessaE if you can come up with 23 keys for slots, you can come up with 9 more :) 00:04 T4im my number keys stop already at 22 though :( 00:05 VanessaE I don't even have defines for more than the first 9 slots, nevermind 23. I just use the mouse wheel. 00:05 epoch super+letters for 26. 36 for numbers too. 00:09 p_gimeno mmm I think I'm going to take that back 00:09 VanessaE ? 00:09 p_gimeno the PR that introduced key bindings for 23 slots was #4929 00:09 ShadowBot https://github.com/minetest/minetest/issues/4929 -- Make direct item selection keys freely bindable by Wuzzy2 00:10 p_gimeno the commit that introduced 23 as a limit is from May 4, 2013 - not sure if there's a PR for it 00:11 VanessaE I referenced it in my issue. 00:13 epoch there's another loop in game.cpp that uses 23 just after line 2000 00:14 epoch I was going to comment but it didn't seem to want to include the lines as a preview like it did for the lines you linked to 00:14 p_gimeno #699 is the PR 00:14 ShadowBot https://github.com/minetest/minetest/issues/699 -- Add ObjectRef.hud_set_hotbar_itemcount by kahrl 00:16 p_gimeno unfortunately, no discussion about why 23 00:18 p_gimeno is it possible that by that time, the slots had a fixed size and that was based on a reasonable maximum screen width of the time? 00:18 VanessaE maybe 00:22 VanessaE epoch: to get the preview, you have to reference the code at a specific commit 00:22 VanessaE https://github.com/minetest/minetest/blob/5f1cd555cd9d1c64426e173b30b5b792d211c835/src/client/game.cpp#L2004-L2012 f.ex 00:22 epoch oh, oki doki. 00:23 epoch oh, I had a specific commit but I think I was missing the L before the second line. >_> 00:23 VanessaE I added that ^ to my issue. 00:24 epoch kk. btw, my username on github is kkabrams so if I comment later you'll know. 00:24 VanessaE I'd make a PR, but I'm sure to miss something. better to just have what code refs you and I found. :) 00:25 VanessaE https://github.com/kkabrams this? 00:28 p_gimeno more discussion: http://irc.minetest.net/minetest-dev/2013-05-04 - no mention of 23 either 00:29 epoch yep 00:29 VanessaE epoch: ok, issue updated. 00:29 epoch kk. I'm going to be AFK for a while in a second. 00:36 * VanessaE tries to code up request.. 00:36 * VanessaE tries to code up a pull request.. 00:45 VanessaE https://github.com/minetest/minetest/pull/7916 00:47 VanessaE seems to work for me, but I only gave it a cursory test. 00:51 VanessaE sofar: would it be prudent to make the equivalent change for 0.4.x also? or would that be too close to "feature"? (to me, it's borderline because 23 is clearly arbitrary) 01:06 * VanessaE ponders who else to ping :) 04:20 paramat merging #7918 (trivial revert) in 15 mins 04:20 ShadowBot https://github.com/minetest/minetest/issues/7918 -- Fix sky bugs when using sun or moon textures by paramat 05:03 paramat merging 7918 05:04 paramat done 07:27 ANAND Would someone be able to merge #7738 please? There's nothing left to do, from my side. 07:27 ShadowBot https://github.com/minetest/minetest/issues/7738 -- Spatial Vectors: Add vector.angle(a, b) by ClobberXD 07:28 ANAND IIRC, paramat supports the concept, but he hasn't officially approved yet. 08:34 Krock will merge #7817 in 15 minutes 08:34 ShadowBot https://github.com/minetest/minetest/issues/7817 -- Add pitch fly mode by Gael-de-Sailly 08:35 nerzhul nice 08:49 ANAND Yay! 09:01 Krock merging after 25 minutes 09:01 Krock oh well. past tense slipped in. whatever. 09:20 Krock rebased #7768 09:20 ShadowBot https://github.com/minetest/minetest/issues/7768 -- Network: Send IEEE floats by SmallJoker 13:03 VanessaE #7916 updated. 13:03 ShadowBot https://github.com/minetest/minetest/issues/7916 -- raise hotbar limit to 32 slots, add associated keybinding options by VanessaE 15:29 ANAND #7923 How and why did this happen? o_O 15:29 ShadowBot https://github.com/minetest/minetest/issues/7923 -- Content Store: Missing package short descriptions 15:29 ANAND rubenwardy: ^ 15:30 ANAND I even triple-checked by re-cloning MT twice. 15:31 ANAND #7863 was the last PR that touched dlg_contentstore.lua 15:31 ShadowBot https://github.com/minetest/minetest/issues/7863 -- Don't display page-nav buttons when #store.packages == 0 by ClobberXD 15:32 ANAND And even that did nothing to packages or their short descriptions 15:32 ANAND "Not a bug"? 15:33 ANAND Ahh.. 15:34 ANAND I suggest keeping the issue open until #7891 has been merged (which I hope will happen soon :D) 15:34 ShadowBot https://github.com/minetest/minetest/issues/7891 -- Fix ContentDB packages timing out by using download_file instead by rubenwardy 16:20 ANAND Has "Keycodes.h" been renamed? Where would I be able to find that file? 16:30 T4im rename src/{ => client}/keycode.h 16:31 ANAND keycode.h depends on a "Keycodes.h" which I can't seem to be able to find 16:32 sfan5 we don't have headers beginning with uppercase in minetests codebase 16:33 ANAND Oh, IrrLicht's then? 16:34 ANAND I thought this was caused by the refactor of client-related src files 16:35 ANAND Oh, it is: http://irrlicht.sourceforge.net/docu/_keycodes_8h_source.html 16:37 ANAND IrrLicht is present on my computer: /usr/include/irrlicht 16:38 ANAND Why then is it not being included properly? 16:48 nerzhul same for me but works properly 17:03 ANAND The Travis builds don't pass either 17:03 ANAND I'm getting the exact same error messages as those builds 17:04 ANAND https://travis-ci.org/minetest/minetest/builds/462200956 17:14 nerzhul interesting to see the refactor was not tested against client 17:44 nerzhul some includes are badly configured in code 17:48 sfan5 why didn't travis catch that? 17:49 nerzhul somebody ignore it ? 18:41 rubenwardy nerzhul, sfan5: I think this is only on that PR 18:41 rubenwardy because master travis works 18:41 sfan5 possible 18:42 sfan5 hm yeah, the rename will need to be applied to the change incldues in that pr too 21:54 p_gimeno how would I go about compiling an Irrlicht for use with Minetest only? something like, compile it in a directory and then point some cmake variable to it? 21:58 sfan5 clone the irrlicht source, compile it, then point MT's cmake to the appropriate paths 22:06 p_gimeno thanks sfan5, which variable(s) should I use? does it suffice to use IRRLICHT_SOURCE_DIR, for cmake to take care of the rest? 22:08 p_gimeno or should I also change IRRLICHT_LIBRARY and IRRLICHT_INCLUDE_PATH manually? 22:08 p_gimeno err, _DIR not _PATH 22:08 sfan5 latter 22:08 p_gimeno ok, thank you 22:35 p_gimeno well, this is irritating, 'ldd bin/minetest' keeps showing that the system's irrlicht is being used 22:43 sfan5 if you link to a shared library, your system paths will be searched for first 22:43 sfan5 link to the static one 23:23 p_gimeno weird, no rpath is being added 23:24 sfan5 rpaths are annoying to deal with and most people actually want them stripped out in the end, I can understand Irrlicht not adding them 23:28 p_gimeno I would expect cmake to add a rpath to where the library I specify is, no wonder it can't find it 23:29 p_gimeno it's more convenient for me to make changes to irrlicht if it's shared, that way I don't have to relink MT 23:35 p_gimeno pfff... if I specify IRRLICHT_LIBRARY=...libIrrlicht.so *then* it generates rpath, BUT I also have to make a symbolic link libIrrlicht.so.1.8 23:36 p_gimeno anyway, got it to work