Time  Nick      Message
19:32 p_gimeno  can someone please create a PR out of #7914?
19:32 ShadowBot https://github.com/minetest/minetest/issues/7914 -- Future-proof 5.0.0 for fixing #4183
19:33 p_gimeno  it's easy to review, almost trivial
19:58 p_gimeno  added as a PR here: https://notabug.org/pgimeno/minetest/pulls/3
19:59 p_gimeno  if anyone wants to test it: git remote add pgimeno https://notabug.org/pgimeno/minetest ; git fetch pgimeno futureproof-mod-enabled ; git checkout futureproof-mod-enabled
20:00 p_gimeno  you can even push that branch to your repo and submit it as a PR to MS-Github
23:13 VanessaE  so...any core devs around?Z
23:13 VanessaE  -Z
23:16 sofar     good question
23:16 VanessaE  https://github.com/minetest/minetest/blob/b298b0339c79db7f5b3873e73ff9ea0130f05a8a/src/hud.h#L53  why exactly is this limited to 23?
23:16 VanessaE  why not 24 or 32?
23:17 sofar     there was an issue about it
23:17 VanessaE  link?
23:17 * sofar   github-search-fu's
23:17 VanessaE  I only ever found an old commit that changes it
23:18 VanessaE  which was unexplained, and which I can't find now
23:19 epoch     how wide are the item slots in pixels?
23:19 VanessaE  there it is.  96fe1de83
23:19 epoch     might be limited based on screen width of 800 wide
23:19 sofar     epoch: they don't need to be linear on the screen
23:19 VanessaE  epoch: it varies by gui scaling and window size.
23:19 sofar     so the visual limit is not relevant
23:19 sofar     a gui could have 3 lines of hotbar items
23:19 epoch     I dunno then.
23:20 epoch     heh
23:20 VanessaE  sofar: it looks like the 23 is arbitrary.
23:20 * epoch   checks for places it is used
23:22 VanessaE  I'd like to raise it to 32 officially, let the user decide how much will fit their screen (mine can fit about 27 slots, and it's a plain old 4:3 aspect screen)
23:22 VanessaE  well, it could - if the limit weren't 23.
23:23 epoch     well, not network protocol limited.
23:23 epoch     it uses a signed 32bit integer
23:23 epoch     which is checked against that value of 23
23:24 epoch     there are only 3 results for that define
23:24 epoch     server, client, and the define
23:24 epoch     seems arbitrary to me. :P
23:25 epoch     how do you select them above 9? (or 10 if 0 is 10)
23:26 VanessaE  mouse wheel;
23:26 epoch     oh yeah. I never use that.
23:28 VanessaE  so can I request that this limit be raised to 32 for 5.0.0?  unless it's possible to make it work on 0.4.x without needing a client-side patch
23:29 VanessaE  (I assume the latter is a 'no')
23:29 sofar     I don't see why not, so, open a PR
23:30 epoch     it isn't treated consistently.
23:30 epoch     sometimes it is s32 and sometimes u16
23:32 * epoch   searches for "23"
23:32 epoch     heh
23:33 epoch     found something
23:33 epoch     https://github.com/minetest/minetest/blob/b298b0339c79db7f5b3873e73ff9ea0130f05a8a/src/client/keys.h
23:33 epoch     goes up to SLOT_23
23:34 VanessaE  where are their default values set?
23:37 epoch     https://github.com/minetest/minetest/blob/b298b0339c79db7f5b3873e73ff9ea0130f05a8a/src/client/inputhandler.cpp
23:37 epoch     it loops over a magic number instead of using the defined value.
23:38 VanessaE  *growl*
23:39 epoch     not sure how to make an enum do SLOT_1..N
23:40 epoch     any of the changes that set 23 there might explain the 23 elsewhere. guess I'll look at histories.
23:43 VanessaE  well changing the value in hud.h is enough for the hotbar.
23:43 VanessaE  just checked.
23:44 VanessaE  (the #define)
23:44 epoch     https://github.com/minetest/minetest/commit/640ba7727629392211ed3c2bd116e938883a6f90#diff-e09178b90d2f3ff1ba6e0db38bd4c627
23:46 epoch     there's a link with every single "Key for selecting the 21th hotbar slot"
23:46 epoch     that just lists key codes they can be set to I guess.
23:50 VanessaE  I'll open a new issue.
23:57 VanessaE  https://github.com/minetest/minetest/issues/7915