Time  Nick       Message
01:55 ANAND      paramat, I've fixed `..` in #7612
01:55 ShadowBot  https://github.com/minetest/minetest/issues/7612 -- Misc. fixes to dlg_contentstore.lua by ClobberXD
01:56 paramat    thanks
01:57 ANAND      :)
02:14 paramat    ANAND and you retested it?
02:15 paramat    hm well it's a minor change, nevermind if you didn't
02:15 paramat    +1
02:17 paramat    merging #7612 in 5 mins
02:18 ShadowBot  https://github.com/minetest/minetest/issues/7612 -- Misc. fixes to dlg_contentstore.lua by ClobberXD
02:21 ANAND      Was AFK, sorry. I didn't retest it, as `..` is perfectly valid too. :)
02:22 paramat    no prob
02:22 paramat    merging
02:27 paramat    done
02:27 ANAND      Thanks
18:36 Krock      rubenwardy: https://github.com/minetest/minetest/pull/7834#issuecomment-438374660
18:36 Krock      or just downscale everything above 10x10 so that it fits on screen
18:37 Krock      and keep the proportions for smaller ones
18:37 Krock      that would also help on PC where a few scale factors may cause formspecs to go outside of the screen
18:37 rubenwardy yes
18:37 rubenwardy that's what I meant
18:38 rubenwardy so  things smaller than WxH stay the same
18:38 Krock      oh. after reading it the 2nd time I now also noticed that
18:38 rubenwardy basically, 10x10 could be defined as a max resolution. Anything above is scaled down
18:38 Krock      exactly, that would be the desirable solution
18:39 Krock      except not just for Android, but for all platforms
18:40 rubenwardy yeah
19:14 Krock      merging #7860 in 10'
19:15 ShadowBot  https://github.com/minetest/minetest/issues/7860 -- Rename hasprivs command to haspriv by Ezhh
19:24 Krock      merging..
20:53 crazyR     could anyone have a look at this please: https://github.com/minetest/minetest_game/pull/2224
20:53 crazyR     * any devs
20:58 sofar      please squash the commit into 1
20:58 sofar      then please fix the title and description
20:58 sofar      you don't mention that this is for just the doors
20:59 sofar      so it should mention that in the title
20:59 sofar      the rest is all fine, +1 from me (I wrote most of that code)
21:00 sofar      crazyR: ^
22:07 crazyR     Could some one help me fix the mess ive made with this please: https://github.com/minetest/minetest_game/pull/2224/commits
22:07 crazyR     my git skills are shocking
22:25 paramat    hmm merge commits, nasty
22:27 paramat    i'm not so good with git either. however, it's much better to use branches to make PRs instead of using your master branch. github help has a good 'bootcamp' that takes you through that clearly
22:27 sofar      crazyR: git rebase -i HEAD~10
22:27 sofar      crazyR: make everything 's' except your topmost own commit
22:28 sofar      crazyR: don't change the ones older than your own commit (above them)
22:28 sofar      then force push to your branch on your tree
22:29 nore       you can make them 'f' too, will only keep the first commit's message
22:30 sofar      I should make a darn youtube video showing how to do this
22:31 sofar      it's ridonkulously simple
23:02 paramat    please can anyone look at #7828 ? it's semi-trivial and easy to review, also checked by numberZero
23:02 ShadowBot  https://github.com/minetest/minetest/issues/7828 -- Framed glasslike: Don't use cuboids to draw glass faces by paramat
23:22 octacian   oh that reminds me. I originally popped in here just to say #7862
23:22 ShadowBot  https://github.com/minetest/minetest/issues/7862 -- Lua API: Add register_on_chatcommand to SSM and CSM by octacian
23:37 paramat    pooped in? ;)
23:47 * octacian said popped
23:47 octacian   Although as I was typing it I kinda wondered if I should use a different word because of the similarities lol
23:48 paramat    hehe was just teasing you
23:48 octacian   yeah IK lol
23:57 octacian   BTW, I heard that MT recently switched to C++11. Why not C++14? Or even C++17?
23:57 rubenwardy C++11 is only recently supported in most stable OSes
23:57 rubenwardy because some Ubuntu version came out of LTS
23:58 octacian   But it's not at all problematic to install a newer compiler. Although maybe that's just because I'm running Ubuntu 18.04.
23:58 rubenwardy Ubuntu 18.04 already ships with a C++17 supporting compiler
23:58 rubenwardy well
23:58 rubenwardy in the repos
23:59 rubenwardy I believe it was hmmmm or celeron55 who made this decision
23:59 octacian   Yeah, I had to install a newer version of GCC and I think I had to install the next release of clang.
23:59 rubenwardy to wait until Ubuntu something was out of LTS