Time  Nick      Message
13:52 crazyR_   Is there any devs able to take a look at game#2224 ? thanks
13:52 ShadowBot https://github.com/minetest/minetest_game/issues/2224 -- Allow on_rightclick to be overidden by Ryan-Nolan
17:12 Krock     > uses "fabs(x)", clang fails.
17:13 Krock     > uses "std::fabs", clang fails.
17:13 Krock     the fsck
17:15 p_gimeno  huh? content_cao.cpp uses std::fabs without problems... missing include?
17:15 Krock     yeah was about to comment that. didn't commit the change in the header file >.<
17:15 p_gimeno  ahh
17:15 Krock     I wonder where gcc took that definition from.. hmm
17:16 Krock     maybe it's using a different file compiling order so that it was already a known definition
17:17 p_gimeno  in my version I #include <math.h>
17:18 p_gimeno  hm, different file I think
17:33 calcul0n  iirc gcc won't complain about missing declarations without -Wall
17:33 Krock     calcul0n: in that case it would result in linker errors since the declarations cannot be resolvedf
17:34 calcul0n  ho, i see
17:36 p_gimeno  oh but libm is linked
17:36 p_gimeno  so maybe calcul0n is right on the cause
17:38 Krock     interesting
19:10 nerzhul   please note #include <cmath> is c++ style
19:17 Krock     more std::'s
19:37 p_gimeno  std__fabs ? what's that?
19:39 p_gimeno  is it a typo? https://github.com/minetest/minetest/pull/7768/commits/3d09ef1e5a534610e52418c36f980334e3b1f142#diff-f1fbcab557b1d896d2dafa18ba882ab2R664