Time  Nick         Message
01:41 paramat      forgot to merge #7703, doing so now
01:41 ShadowBot    https://github.com/minetest/minetest/issues/7703 -- Fix clipped content tab description by SmallJoker
01:47 paramat      merged
08:38 crazy_baboon ShadowBot 'drowning = 1' does not exist in the default codebase
08:38 crazy_baboon what exists is 'drowning = 0' in 'nodedef.cpp'
08:38 crazy_baboon and if you comment it out, the drowning still occurs
08:40 crazy_baboon maybe if you comment the one in nodedef.h it will work
08:41 crazy_baboon nop, it does not work either
08:41 crazy_baboon gcc spits out "c_content.cpp:675:4: error: ‘struct ContentFeatures’ has no member named ‘drowning’
08:41 crazy_baboon f.drowning = getintfield_default(L, index,
08:41 crazy_baboon "
08:49 crazy_baboon anyone knows the reason why drawning is a u8 rather than a bool in nodedef.cpp?
08:51 crazy_baboon is it the oxigen levels?
08:55 ANAND        likely
09:06 crazy_baboon yep, i can confirm now
10:26 p_gimeno     !tell crazy_baboon you can override drowning with a mod
10:26 ShadowBot    p_gimeno: O.K.
14:43 ANAND        What is test_config.h used for? It's generated everytime I build from source
14:46 Hijiri       crazy_baboon: drowning = 1 is something you put in node definitions. like https://github.com/minetest/minetest_game/blob/20b433881b733409e13729d6d7b9df3607c9ca82/mods/default/nodes.lua
14:46 Hijiri       https://github.com/minetest/minetest_game/search?q=drowning&unscoped_q=drowning
14:47 Hijiri       You could just go through all node definitions and set drowning to 0 on all of them (assuming you want to disable drowning everywhere)
14:47 Hijiri       you could do this programatically too, using minetest.after with a time of 0
14:49 crazy_baboon Thanks Hijiri, but I opted to control drowning from the C++ core of the engine (since drowning is so fundamental)
14:49 crazy_baboon so I added a flag for minetest.conf
14:49 crazy_baboon https://github.com/minetest/minetest/pull/7706
14:50 crazy_baboon this might even improve efficiency, I don't know if it is noticeable in the FPS
14:50 crazy_baboon probably not
14:51 crazy_baboon anyway, efficiency is not the point here
14:51 crazy_baboon ANAND, that file seems to contain the directory paths to the world and to the subgames?
15:17 ANAND        Yes I know, but I think it's useless and has nothing to do with the actual source. Just wanted to confirm this... :)
15:20 sfan5        it's used for unittests
15:22 ANAND        Shall I add it to gitignore?
15:23 ANAND        https://github.com/minetest/minetest/pull/7708
15:23 ANAND        !title
15:23 ShadowBot    Add test_config.h to gitignore by ClobberXD · Pull Request #7708 · minetest/minetest · GitHub
15:23 ANAND        I hope I wasn't too hasty... :)
15:25 ANAND        Oh, also #7707
15:25 ShadowBot    https://github.com/minetest/minetest/issues/7707 -- Expose min/max_net_proto_version to on_prejoinplayer callbacks by ClobberXD
15:31 crazy_baboon In minetest, what are particles?
15:34 Hijiri       they are floating sprite things with basic kinematics
15:34 Hijiri       crazy_baboon: ^
15:35 crazy_baboon when can you see them?
15:42 Hijiri       most commonly from digging, otherwise when a mod calls add_particle or add_particlespawner crazy_baboon
15:42 crazy_baboon cool I see! It's nice
17:44 Krock        Could someone please review #7666? Git only wants to pull when the change is stashed (and applied afterwards) .. annoying
17:44 ShadowBot    https://github.com/minetest/minetest/issues/7666 -- Change OpenGL preference to LEGACY by SmallJoker
23:33 paramat      merging #7682 in 5 mins
23:33 ShadowBot    https://github.com/minetest/minetest/issues/7682 -- Particles: Make collision with objects optional by paramat
23:37 paramat      merging
23:40 paramat      merged! :D this will improve particle performance