Time Nick Message 09:04 red-001 ModChannelRef::l_is_writeable seems problematic 12:16 paramat nerzhul please could you move the play store MT app back to 0.4.16 until the issue is fixed? also, it may be a good idea for a second core dev to also have access to it 12:18 celeron55 has anyone emailed him? 12:19 paramat not that i know 12:20 paramat i'm not sure that would be faster 12:22 paramat i expect he'll appear at the end of the weekend :) 12:24 celeron55 it seems he hasn't taken note of the particular issue at all, as he has reviewed some PRs meanwhile 12:29 paramat discussed last monday http://irc.minetest.net/minetest-dev/2018-06-18#i_5336070 12:31 paramat it's a bit obscure what went wrong. also to be fair we wrall 12:31 paramat oops 12:31 paramat .. we were all a bit lazy about this 12:46 Krock paramat, this MTG code https://hastebin.com/owixizubiw.pl results in undecorated areas like this: https://i.imgur.com/gAEUkPW.png . what am I doing wrong? 12:50 Krock Will push this fix for the free_move settings crash and an rtt >= 0.0f failed assertion in 15 minutes unless there are objections: https://hastebin.com/raw/otezunihic 12:51 Krock perhaps I should move the array initialisation into the C++ file 12:54 paramat hmm 12:54 Krock is it sidelen which shouldn't be there? 12:57 paramat the code looks ok. seems to have missed a mapchunk 12:57 paramat maybe caused by teleportation? 12:58 rubenwardy oh no, teleporting decorations 12:58 rubenwardy hate it when that happens 12:58 paramat lol 12:59 paramat maybe i'll test using your deco code 13:01 paramat sidelen is fine 13:02 paramat i'll test and try teleporting 13:10 Krock pushing.. 13:32 paramat can't reproduce your issue, Krock maybe add a line specifying biomes? although it theoretically should not need that 13:33 Krock hmm 13:33 paramat hang on let me try again 13:42 paramat anyway marked as WIP and will test further 13:43 paramat thanks 13:44 Krock maybe something got messed up due to the slow processing in that debug build with the address sanitizer enabled 13:44 paramat i can't get your code to work in master branch either, weird 13:47 Krock do you mean the crash fix commit or the decoration? 13:47 paramat deco 13:47 paramat ok i know why 13:47 paramat the 'name' of the deco registration is a duplicate 13:48 paramat use 'name = "",' 13:48 paramat now it works 13:48 paramat retesting 13:49 Krock paramat, the only duplicate of this name is in the mgv6 registrations 13:49 Krock I replaced/changed the one in the other registration function 13:58 paramat ok will test 14:02 paramat yes it's happening for me know, near water 14:02 paramat using your code. running along mapblock edges 14:03 paramat will work on it 14:05 paramat the pattern gives me a clue 14:06 paramat i only tested in mgflat so i missed this 14:07 paramat yes, only happens with fill ratio >= 10. good thing you tested then :3 14:08 Krock heh :) 14:10 paramat oh duh there are 'continues' aborting the loop i created .. 14:16 paramat my XZ incrementing code was at the end so the 'continues' bypassed it 14:24 paramat Krock updated and retested 14:25 red-001 #7479 14:25 ShadowBot https://github.com/minetest/minetest/issues/7479 -- Dangling mod channel pointer. 14:27 Krock red-001, any chance for you to fix it? 14:28 red-001 I'm not sure what the best approch is 14:29 Krock there must be a callback/anything for the Lua bindings so they know that the object turned invalid 14:30 Krock so they can still handle the isWritable functions correctly without segfaulting 14:34 red-001 paramat, 7272 seems to be the result of multiple bugs 14:50 paramat yes 15:38 celeron55 i think i did get an invitation to the minetest play store account like a year ago from nerzhul but looking at my email and irc logs and my google play console i probably didn't click the link in it 15:38 celeron55 i guess i was busy at the time 15:38 rubenwardy I got an invite, put I can only answer reviews 15:38 rubenwardy even if I could upload APKs I don't have the signing jey 15:38 rubenwardy *key 15:38 rubenwardy not sure if I can upload APKs 15:39 rubenwardy also, there is no minetest play store account 15:39 rubenwardy it's under nerzhul's personal account, which is insane 15:39 celeron55 the console or whatever, dunno how this even works 15:40 celeron55 i don't have the signing key either, at least i don't think i have 15:41 celeron55 the play store listing really is an afterthought and i still am not interested in handling it 15:41 celeron55 all this mobile crap makes me puke 15:41 celeron55 no matter how much money or users are in it 15:42 paramat lol me too 15:42 entuland ehehehe 15:43 paramat but yes it shouldn't be under nerz's personal account 15:43 rubenwardy I'm willing to pay the £17 to get a Minetest account 15:43 rubenwardy I was under the impression that celeron55 had the signing keys and admin access to the app however 15:44 celeron55 i did grep my IRC logs for nerzhul PMs with "key" or "sign" in them 15:44 entuland I guess you guys don't need a pointer from me, but hey, won't harm: https://support.google.com/googleplay/android-developer/answer/6230247 15:44 rubenwardy could he have emailed them? 15:45 rubenwardy yeah, you can transfer apps 15:45 paramat apparently nerz doesn't have much time for MT, and anyway it's better in case he gets abducted by aliens or something 15:45 rubenwardy however if you lose the key then you're fucked 15:46 celeron55 it's not acceptable to have so little time you don't have time to give control to someone else 15:46 celeron55 any amount of time above that is fine 15:47 celeron55 i'll make the account assuming it's possible to add apk upload permissions to others 15:48 celeron55 or, i'll use my existing one maybe 15:48 celeron55 not like i haven't paid this once to google already 15:50 celeron55 doesn't really look like it's possible to add that 15:52 celeron55 wait no 15:54 celeron55 yeah it's possible to do that 15:54 paramat merging #7456 in 5 mins (thanks for review) 15:54 ShadowBot https://github.com/minetest/minetest/issues/7456 -- Decoration API: Add lightweight ability to have complete coverage by paramat 15:54 celeron55 it's actually not my account i have paid for google play, i just have given full access to my account to another account... 16:11 paramat forgot, merging .. 16:20 paramat merged 16:21 paramat Krock did you test #7468 ? 16:21 ShadowBot https://github.com/minetest/minetest/issues/7468 -- [Don't squash me!] Rename CSM flavours to CSM restrictions by SmallJoker 16:28 paramat if added to the whitelist it can be merged now, because lint will be silenced 17:03 Krock paramat, checked whether it runs. but I didn't check whether the node restriction works correctly because it's a search & replace task, where the compiler says whether it succeeded or not 17:05 Krock well, thanks. 17:15 nerzhul i have much time for MT, why it's a problem 17:15 nerzhul the android problem is not solved, and we cannot rollback to old apk 17:15 nerzhul it doesn't work like that 17:15 nerzhul we just need to find a fix 17:15 nerzhul and yes, i got some holidays 17:15 nerzhul and it i remember i gave c55 keystore & secret 2 years ago 17:16 nerzhul + the right ot change the APK on the google play store 17:16 rubenwardy sure you can 17:16 rubenwardy you can rebuild th old version and reupload it 17:16 rubenwardy with an incremented version ID 17:16 Krock *I _don't_ have much time [..] ;) 17:16 nerzhul i can rebuild 0.4.16 yes, and change the version 17:16 nerzhul but it's not the solution to a bug 17:17 nerzhul in 2 weeks, nobody worked on it as i saw 17:17 rubenwardy it's a temporary solution to a game breaking bug where there are auto-updates 17:17 nerzhul i tested multiple builds to see if it's fixed in the interval without success 17:17 nerzhul i'm not sure we can rollback, don't forget MTG is not updated in the app cache 17:18 nerzhul if i set the old version, new users and current updated users will have the same problem 17:18 nerzhul this game cache is a problem 17:20 nerzhul i'm in holidays at home now, i will take time to find where it's the problem and fix it (it's not the only i will get with my children :p) 17:54 paramat nerzhul please can you contact celeron55 and organise a transfer of play store access to a MT account, with at least 2 core devs having access? see logs for this channel 17:55 nerzhul there is no transfer, he already has access 17:56 nerzhul and if i remember sfan5 has access too 17:57 nerzhul and i see rubenwardy too 17:57 celeron55 i don't think i have 17:57 celeron55 can you look it up? 17:57 nerzhul it seems sfan5 & celeron55 doesn't accepted it 17:58 nerzhul it's on your gmail access 17:58 sfan5 hm that's possible 17:58 nerzhul address 17:58 nerzhul i resend the invite celeron55 17:59 nerzhul and it seems sfan5 has a missing right, i added it 18:00 sfan5 hmm https://a.uguu.se/1TBQywWUjzC4_Bildschirmfoto_2018-06-24_19-59-51.png 18:00 sfan5 didn't even see that there before 18:00 nerzhul yeah it seems a missing access right was not enabled, i enabled it 18:01 nerzhul it will permit access to minetest 18:03 celeron55 now i accepted it 18:04 sfan5 the current build is definitely broken, is it possible to re-publish an older build? 18:05 celeron55 i definitely don't have the keystore though 18:07 sfan5 google sent me a mail in french 18:07 sfan5 lol 18:07 celeron55 same 18:09 paramat sfan5 see http://irc.minetest.net/minetest-dev/2018-06-24#i_5341751 it seems rolling back might be difficult? 18:09 sfan5 nothing a system("rm -rf /sdcard/Minetest/games/minetest_game") can't fix 18:11 nerzhul a little bit ugly but can work 18:15 sfan5 #7482 18:15 ShadowBot https://github.com/minetest/minetest/issues/7482 -- Fix alignment issues in MurmurHash by sfan5 20:01 paramat will merge trivial #7474 in 15mins 20:01 ShadowBot https://github.com/minetest/minetest/issues/7474 -- lua_api.txt: Update outdated documentation by ClobberXD 20:03 red-001 nerzhul, could you review #7481? 20:03 ShadowBot https://github.com/minetest/minetest/issues/7481 -- Fix mod channels crash by red-001 20:16 paramat merging 7474 20:19 paramat merged