| Time |
Nick |
Message |
| 00:02 |
|
YuGiOhJCJ joined #minetest-dev |
| 00:28 |
|
ANAND joined #minetest-dev |
| 01:16 |
|
Tmanyo joined #minetest-dev |
| 02:01 |
|
Player-2 joined #minetest-dev |
| 02:15 |
|
Cornelia joined #minetest-dev |
| 02:39 |
|
Tmanyo joined #minetest-dev |
| 04:21 |
|
Darcidride_ joined #minetest-dev |
| 04:22 |
|
Darcidride__ joined #minetest-dev |
| 05:37 |
|
ClobberXD joined #minetest-dev |
| 05:53 |
|
SuperTomato joined #minetest-dev |
| 05:57 |
|
ClobberXD joined #minetest-dev |
| 06:15 |
|
SuperTomato joined #minetest-dev |
| 07:02 |
|
ensonic joined #minetest-dev |
| 07:41 |
sfan5 |
pushing minor documentation fix https://a.uguu.se/nf00nSiwuYiF_1WJqBd4.txt in 5 minutes |
| 08:17 |
nerzhul |
nice |
| 09:37 |
|
entuland joined #minetest-dev |
| 10:20 |
|
fireglow joined #minetest-dev |
| 10:22 |
|
twoelk joined #minetest-dev |
| 10:26 |
|
lumberJ joined #minetest-dev |
| 10:38 |
|
YuGiOhJCJ joined #minetest-dev |
| 10:42 |
|
Beton joined #minetest-dev |
| 10:52 |
|
troller joined #minetest-dev |
| 11:05 |
|
lumberJ joined #minetest-dev |
| 11:30 |
|
troller joined #minetest-dev |
| 11:35 |
|
Fixer joined #minetest-dev |
| 11:48 |
|
lumberJ joined #minetest-dev |
| 12:00 |
nerzhul |
merging #7472 |
| 12:00 |
ShadowBot |
https://github.com/minetest/minetest/issues/7472 -- README.md: Improve formatting for consistency by ClobberXD |
| 13:07 |
|
Krock joined #minetest-dev |
| 13:25 |
red-001 |
small bugfix #7473 |
| 13:25 |
ShadowBot |
https://github.com/minetest/minetest/issues/7473 -- Fix crash caused by Lua error during startup by red-001 |
| 13:29 |
|
ANAND joined #minetest-dev |
| 13:32 |
Krock |
i.e. when the destructor is called when initMapgens is still ongoing? |
| 13:35 |
red-001 |
or more likely not called yet |
| 13:37 |
|
antims joined #minetest-dev |
| 13:39 |
Krock |
ah, that's more plausible. looks good. |
| 14:06 |
|
twoelk left #minetest-dev |
| 14:56 |
|
ensonic joined #minetest-dev |
| 16:03 |
|
Gael-de-Sailly joined #minetest-dev |
| 17:00 |
|
Krock joined #minetest-dev |
| 17:04 |
|
Foz joined #minetest-dev |
| 17:17 |
|
Foz joined #minetest-dev |
| 17:47 |
|
Cornelia joined #minetest-dev |
| 17:51 |
|
Lia joined #minetest-dev |
| 18:28 |
|
Darcidride joined #minetest-dev |
| 18:35 |
Sokomine |
got the following error: Error in `./minetest.0.5': double free or corruption (out): 0x00005615a061bf20 ** followed by a backtrace during normal gameplay (older world with my mg_villages mod). is that of intrest/would the backtrace be helpful? or shall i wait and see if the error occours again? |
| 18:42 |
sfan5 |
backtrace is definitely helpful |
| 18:42 |
Krock |
you could attempt to reproduce it when running minetest with "gdb minetest" and then adding the backtrace to this issue: #7272 |
| 18:42 |
ShadowBot |
https://github.com/minetest/minetest/issues/7272 -- Occasional crash on shutdown / other reported crashes |
| 18:52 |
sfan5 |
anyone mind merging #7471? |
| 18:52 |
ShadowBot |
https://github.com/minetest/minetest/issues/7471 -- Fix ipv6_server=true not accepting IPv4 connections on Windows by sfan5 |
| 18:53 |
Krock |
LGTM, mergign |
| 18:54 |
Krock |
How about #7473 ? Another easy fix |
| 18:54 |
ShadowBot |
https://github.com/minetest/minetest/issues/7473 -- Fix crash caused by Lua error during startup by red-001 |
| 18:55 |
sfan5 |
looks good to me |
| 18:56 |
Krock |
will merge in ~5 mins brb |
| 18:56 |
|
Taoki joined #minetest-dev |
| 19:01 |
|
fwhcat joined #minetest-dev |
| 19:04 |
Krock |
merging |
| 19:46 |
|
Player-2 joined #minetest-dev |
| 19:47 |
|
stujones11 joined #minetest-dev |
| 19:49 |
stujones11 |
#7463 |
| 19:49 |
ShadowBot |
https://github.com/minetest/minetest/issues/7463 -- Use capitalized project name for android temp path by stujones11 |
| 19:50 |
Krock |
is Minetest always installed into "Minetest" ? |
| 19:51 |
stujones11 |
That is the default setting, so yes |
| 19:52 |
stujones11 |
https://github.com/minetest/minetest/blob/master/src/defaultsettings.cpp#L410 |
| 19:54 |
Krock |
when why don't you return g_settings->getString("TMPFolder") there ? |
| 19:54 |
Krock |
s/when/then/ |
| 19:54 |
Krock |
ah, it's just "->get(" |
| 19:56 |
stujones11 |
That might be a better way if fs has access to g_settings |
| 19:57 |
Krock |
well, it's a global variable and handled properly as soon it's known by the source file (headers, or extern) |
| 19:58 |
stujones11 |
makes sense I guess :) |
| 19:58 |
stujones11 |
I will update the PR, not that anyone is ever likely to need to change that setting :p |
| 19:59 |
Krock |
it's also used (once) in builtin. Would be a waste to have a setting without using it in the core too |
| 20:00 |
stujones11 |
fair point |
| 20:01 |
Krock |
once it's chanced I don't see any reason to not merge this fix |
| 20:06 |
stujones11 |
Its an easy fix but I dont have time to rebuild and test tonight |
| 20:07 |
stujones11 |
perhaps you should remove the trivial label for now in case someone else merges it |
| 20:09 |
stujones11 |
Question: If I am adding a new cpp file, what is the correct way to credit myself in the heading comments? |
| 20:10 |
Krock |
Something with what you can be identified. can be a nickname, but the email address will be the important part there |
| 20:11 |
|
Foz joined #minetest-dev |
| 20:12 |
Krock |
IIRC inside the EU laws everything that's written by you would automatically be under your copyright. This notice seems just to be an international way to clarify who wrote the important part of it |
| 20:12 |
stujones11 |
Should I retain celeron55's copyright tho, looking at other files some have and some not |
| 20:13 |
Krock |
If the majority of the new code is yours, then include your notice only. No need to give credit for people who actually never wrote something |
| 20:13 |
Krock |
s/something/that code/ |
| 20:15 |
stujones11 |
Yeah, I am not too bothered about it personally, I just want to do it right :) |
| 20:16 |
Sokomine |
is the complete memory map necessary? |
| 20:24 |
stujones11 |
Krock: WIP is better, ty |
| 20:38 |
Krock |
Sokomine, it fills the issue too much. I'd limit it to the backtrace |
| 20:41 |
|
longerstaff13-ZN joined #minetest-dev |
| 20:44 |
|
longerstaff13-m joined #minetest-dev |
| 20:46 |
|
Fixer_ joined #minetest-dev |
| 20:59 |
|
twoelk joined #minetest-dev |
| 21:00 |
|
ensonic joined #minetest-dev |
| 21:24 |
|
proller joined #minetest-dev |
| 22:01 |
Sokomine |
mtg got really nice with that new pine forrest soil and all the other changes |
| 22:04 |
Sokomine |
0 |
| 22:26 |
|
proller joined #minetest-dev |
| 22:29 |
|
Gael-de-Sailly joined #minetest-dev |
| 23:54 |
|
dagreatnate1 joined #minetest-dev |
