Time Nick Message 01:27 paramat merging 7365 01:30 paramat i posted about merging that in -hub by mistake. will merge #7365 in 15mins if no objection 01:30 ShadowBot https://github.com/minetest/minetest/issues/7365 -- Schematic decorations: Fix placement bug when centred and rotated by paramat 01:51 paramat merging 7365 01:54 paramat done. no more floating logs 01:55 lumberJ nice 05:09 nerzhul paramat, i think merging without objection at 3h30 AM doesn't mean anything as every other coredev sleep... 11:07 ANAND Greetings! Any specific reason why switch-case isn't used here? https://github.com/minetest/minetest/blob/master/src/game.cpp#L1859 11:44 sfan5 how would you use a switch-case there? 12:15 ANAND since they're mutually exclusive, we could have `case KeyType::INVENTORY:` instead of 32 else ifs 12:15 ANAND since the values are essentially enums 12:16 ANAND no wait... 12:18 ANAND the current API doesn't allow that 13:56 ANAND Would it make sense to replace wasKeyDown() with a method that returns an object of type KeyPress? 13:56 ANAND Will that be more optimized? 13:57 ANAND so if we're checking if the inventory key was pressed, we do this 13:58 ANAND switch(getKeyDown()){ case KeyType::INVENTORY: {} } 13:59 ANAND oops.. the method should ideally return an instance of KeyType, not KeyPress 14:03 sfan5 you can press multiple keys you know... 14:09 ANAND the return value is an object consisting of multiple bools right? 14:15 sfan5 wasKeyDown() returns bool, a single one 14:18 ANAND ik... but nvm, sorry for the trouble :) 14:23 ANAND I'd love to be able to modify client-side settings (like mouse-sensitivity) right from within the game - esp. when leaving the game can have certain disastrous effects... ;) 14:23 ANAND Is any such functionality being planned for 0.5.0? 15:56 Krock Moving the discussion over here, nerzhul. Technically 0.4.17 is ready. If people miss features and bugfixes, they must switch to 0.5.x earlier then 15:56 nerzhul then we are is a free now ? 15:57 nerzhul or can we start the freeze on the discussion meeting on saturday 15:57 nerzhul and release in 2 weeks if no blocker ? 15:57 Krock I saw that GitLab fails due to project-unrelated errors 15:58 Krock a 2 week freeze would mean that the release took over a year to happen 8), with one week instead, it would be only "near to a year" 15:59 Krock but we should start the freeze asap. people have been waiting for it way too long 15:59 nerzhul at least we have so many many commits added then go 15:59 nerzhul sfan5, paramat are you okay ? rubenwardy ? 15:59 nerzhul it seems we are in a freeze since months on 0.4.17 :p 16:00 nerzhul we need a changelog too 16:00 nerzhul at least we have the PR 16:00 sfan5 not sure whether there's any more commits that need to be backported 16:00 nerzhul i should update the 0.5.0 changelog too at a point 16:00 nerzhul if we plan a 0.4.18 (i hope no) or 0.5.0 next month no need to backport :) 16:00 nerzhul 0.5.0 should be released at a point and cannot be perfect too 16:00 Krock the question was about adding https://github.com/minetest/minetest/commit/4bb41a19dc74fa31cb021dc3b5622814d67fbd6f 16:01 Krock well, the PR is the changelog .. basically 16:01 nerzhul this is an interesting fix 16:01 nerzhul the changelog is not user friendly :p 16:01 nerzhul and not ordered 16:01 nerzhul see http://dev.minetest.net/Changelog 16:02 nerzhul don't forget we are a game, not a library for devs 16:04 nerzhul :') 18:41 Krock paramat, I agree. The logs here also show that nerzhul and me think that it's time for a freeze 18:42 paramat core devs are more absent at the weekend so we should discuss now :) 18:42 paramat and hi 18:43 Krock already wanted to point out that you probably meant "active" but looking at the last meetings it appears that workdays are also quite well suited to talk :3 (may not be liked by everyone) 18:43 paramat there are some bugfixes since the 13th but some are dependent on 0.5 changes, and mine are minor 18:43 paramat yes 'active' 18:45 paramat i think freeze asap, today or tomorrow 18:47 paramat i don't think fixed meetings are practical, instead meet when some people are available, like hmmmm used to do 18:48 sfan5 are there any more commits that need to be backported? 18:48 sfan5 paramat: nothing prevents you from dicussing topics when multiple coredevs happen to be online 18:49 Krock So in the future there will be discussion overviews - likely one per month or similar? 18:50 Krock I see that the saturday meetings aren't optimal as they are right now, so splitting and spreading the discussion points seem more appropriate 18:50 nerzhul one per month can be better, and maybe open a discussion topic on the github discussion then for point in time questions ? 18:51 nerzhul sfan5 are you okay for a freeze ? 18:51 sfan5 generally yes 18:51 sfan5 but first "are there any more commits that need to be backported?" should be answered 18:51 nerzhul okay, we are 4 for it, i publish a communication about it on the forum. what is the expected release date ? 3 june ? 18:52 sfan5 just don't mention a release date 18:52 sfan5 but IMO a freeze period of 1 week is good eough 18:52 sfan5 +n 18:52 nerzhul okay, i give an estimation ? 1 or 2 weeks ? 18:53 Krock until next weekend..? 18:54 Krock as in: ~9 days 18:54 nerzhul sounds reasonable 18:56 nerzhul can a moderator stick https://forum.minetest.net/viewforum.php?f=18 ? 18:58 sfan5 done 18:59 nerzhul ty 18:59 Krock /topic needs updating 19:00 rubenwardy what a retarded topic 19:00 rubenwardy the entire 0.4.17 release is bug fix only 19:00 Krock rubenwardy, fix it. Improve it. Before the people see it. 19:01 rubenwardy only way to fix is delete 19:01 rubenwardy :P 19:03 BillyS Yes, I suppose the topic is a bit dated, isn't it? 19:04 paramat there will always be further bugfixes that didn't make it into 0.4.17 so i suggest not adding any more and freeze now while build is green? 19:04 paramat however, nothing super important that i can see 19:05 paramat but we will need a 0.4.18 after 0.5 19:28 paramat so it looks like we are officially frozen? no more backporting 19:31 paramat will merge #7371 in an hour or so 19:31 ShadowBot https://github.com/minetest/minetest/issues/7371 -- Vein ore: Fix bug caused by changing perlinmap Y size by paramat 19:33 Krock paramat, basically if (noise) delete noise; noise = new Noise(...); 19:34 paramat ah ok 19:34 paramat updated game#2128 to use paper in recipe, plus an optional ABM tweak 19:34 ShadowBot https://github.com/minetest/minetest_game/issues/2128 -- TNT: Raise cost of TNT by adding a TNT stick crafting stage by paramat 19:37 paramat ah yes, in most ore types the noise object is only created once, that's why. in vein ore the noise objects are recreated many times. ok will do that then 19:38 paramat .. in this PR 19:52 paramat some OPs have been renamed to guest 19:57 paramat updated #7371, thanks for the advice 19:57 ShadowBot https://github.com/minetest/minetest/issues/7371 -- Vein ore: Fix bug caused by changing perlinmap Y size by paramat 19:59 Krock np. lgtm 19:59 paramat will do after testing 20:22 nerzhul i really thing TDD is really a good thing and it's possible in many cases in mapgen :p 20:33 Hijiri_ can mods in the mod store have version constraints on dependencies / engine? 20:33 nerzhul oh github added the comment history when you edit it 21:05 paramat nerz removed 'if' lines, can i merge? 21:06 nerzhul paramat: delete doesn't need pointer verification, it's a noop if pointer is null 21:06 paramat ok cool 21:09 paramat merging #7371 in 5 mins 21:09 ShadowBot https://github.com/minetest/minetest/issues/7371 -- Vein ore: Fix bug caused by changing perlinmap Y size by paramat 21:18 paramat merging 21:20 paramat done 21:22 paramat good back to 100 PRs