Time  Nick       Message
00:10 ashtrayoz2 !help
00:10 ShadowBot  ashtrayoz2: help [<plugin>] [<command>]
00:12 ashtrayoz2 Krock:  thanks for the review on #7242.  I have updated it, hope if covers your concerns, and also some stuff that Shara said on related code/doco.
00:12 ShadowBot  https://github.com/minetest/minetest/issues/7242 -- Make extended drop table code available for mods to use for craftitems and tools. by ashtrayoz
03:03 ashtrayoz2 s/if/it/
09:18 ashtrayoz2 #7424 has another update.
09:18 ShadowBot  ashtrayoz2: Error: Delimiter not found in "HTTP Error 404: Not Found"
09:19 ashtrayoz2 Oops, I mean #7242
09:19 ShadowBot  https://github.com/minetest/minetest/issues/7242 -- Make extended drop table code available for mods to use for craftitems and tools. by ashtrayoz
10:42 Krock      ashtrayoz2, nice. Overall it looks better organised now. However, the documentation of "inherit_color" seems to be gone now - and the "max_items"/"items" are not documented anymore
10:42 Krock      they would need some kind of "DEPRECATED, see max_choices" or similar
10:46 shivajiva  I'm mildly annoyed that overriding auth has every error vector pointing at sauth when it has no errors in it, kinda misleading for people who can't filter it and look beyond to the real error
11:11 ashtrayoz2 I can manage something like that.
11:15 Krock      shivajiva, usually Lua provides a backtrace of the error source. The auth system changed a few times since 0.4.16, so issues with it aren't surprising
11:21 shivajiva  I know, it's just a bit of an inhibitor for people considering it as a possibility when the consensus is it causes errors purely because it's cited as the cause on the first line
11:22 shivajiva  like this
11:22 shivajiva  ERROR[Main]: ServerError: AsyncErr: ServerThread::run Lua: Runtime error from mod 'sauth' in callback item_OnPlace()
11:25 ashtrayoz2 Krock, something like (#7242) this?
11:25 ShadowBot  https://github.com/minetest/minetest/issues/7242 -- Make extended drop table code available for mods to use for craftitems and tools. by ashtrayoz
13:22 ashtrayoz2 Krock, good pickup.  Fixed.
17:56 paramat    Krock the new MTG book textures should be backported, see https://github.com/minetest/minetest_game/pull/1966#issuecomment-386898251
17:56 Krock      paramat, almost exact doesn't mean it's totally exact
17:56 Krock      interesting how we thought about writing about this now
17:56 paramat    rubenwardy
17:57 paramat    several core devs saw this as needed
17:58 paramat    Shara
17:59 paramat    it was close enough to need changing, and would need to be done in 0.4.18 anyway
18:00 paramat    it wasn't cosmetic so the backports rule doesn't apply
18:01 rubenwardy sure
18:02 Krock      if you get another dev agreeing to include these changes then for the discussion's sake I'll include it <.<
18:02 paramat    the colour profile commit removes error messages so is also needed :)
18:04 paramat    ^ Shara sofar
18:06 paramat    4 devs supported in the thread, that's enough :)
18:07 paramat    i should have explained why those commits were added to backports
18:10 Fixer      crash backtrace available https://github.com/minetest/minetest/issues/7272#issuecomment-386897544
18:12 paramat    although that might be a different bug
18:19 Shara      I'd rather see the book change go in. It wasn't done purely for cosmetic reasons, even though the change itself is cosmetic
18:19 Krock      sfan5, since you had written the guidelines - shall we remove that point (also for 0.4.18) and re-include the two commits or not?
18:21 sfan5      Krock: since the book thing is not purely cosmetic, just put it in
18:21 sfan5      but I'd still prefer to leave other (purely) cosmetic changes outside
18:24 Shara      The guidelines are fine. It's just a case of looking at why the change was made, not only what the change was
18:24 paramat    yes partly my fault for not explaining
18:28 Krock      paramat, do we need https://github.com/minetest/minetest_game/commit/21b3c841b too or just the two book commits?
18:32 Shara      It never hurts to fix license info, if that's all it's doing
18:48 Krock      added the two commits back in. deleting comments. case closed
19:23 paramat    thanks. erm
19:24 paramat    the license commit is not important, just a little simplification
19:24 paramat    no need to backport it
19:26 paramat    no need to delete those comments, we only delete comments of others in extreme cases, perhaps you're annoyed :)
19:28 paramat    maybe i'll go delete comments of yours i didn't like ;) (not serious)