Time  Nick       Message
10:50 Krock      Is #7253 ready for review as-is?
10:50 ShadowBot  https://github.com/minetest/minetest/issues/7253 -- Add updating to online content repository by rubenwardy
10:50 rubenwardy yeah
10:50 rubenwardy wondering if I should add update detection with that though
10:50 rubenwardy I thought that PR would be more painful actually
10:52 Krock      the PR title suggests that - yet only the API is there
10:53 rubenwardy it changes the button from [Uninstall] to [Update] when there's an update
10:53 rubenwardy https://github.com/minetest/minetest/pull/7253/files#diff-f52a94569d13d2345fbfb0450c1d4f4fR320
10:53 rubenwardy just wondering if I should do an alert in the main mainmenu if there's an update
10:53 Krock      so using "install_" as field is intended for the update procedure?
10:53 rubenwardy yeah
10:54 Krock      ah good. I see.
10:54 rubenwardy wait, hmmm
10:54 rubenwardy it should probably pass in a directory incase it's installed elsewhere
10:57 Krock      will it delete the old directory before installing/updating? If not, then deleted media will be kept as garbage
10:58 rubenwardy it writes over
10:58 rubenwardy so yeah