Time Nick Message 07:53 nerzhul ? 08:03 VanessaE ! 08:04 nerzhul it's a question about someone telling our of any contexte "permission to be present" 08:19 IcyDiamond Haha 08:21 IcyDiamond https://github.com/ValveSoftware/GameNetworkingSockets could this be of any use to minetest? 08:40 nerzhul IcyDiamond yes ofc i think i will try it (if it's stable and published) 08:40 nerzhul it's in my TODO list 08:40 IcyDiamond Cool 08:41 nerzhul oh it was published 08:41 nerzhul nice 08:41 nerzhul hmm protobuf and ujson deps it's anoying to have more deps 12:08 rubenwardy #7185 12:08 ShadowBot https://github.com/minetest/minetest/issues/7185 -- Add player inventory callbacks & refactor by SmallJoker 12:08 rubenwardy yessssssssssss 12:08 Krock [YESSS INTENSIFIES] 12:08 Shara YESSSSS 12:14 shivajiva getting closer :D 12:17 rubenwardy glad to see that done, it was on my todo list 12:22 Krock rubenwardy, I got that one also at least on 5 of my 8 total re-written ToDo lists on paper (ran out of space).. I guess it was the oldest one I had there 12:25 Krock in combination with the "Selected ItemStack black magic reduce" PR it's like a dream to move itemstacks around, mostly because they don't glitch around and the inventory can be restricted now 12:28 Krock of course it's LINT who doesn't like the changes 12:32 Krock === Will push trivial fix for #7184 https://pastebin.com/raw/UtVvzC2h in 15 minutes 12:32 ShadowBot https://github.com/minetest/minetest/issues/7184 -- Using #import in GCC is deprecated and issues several warnings. 12:46 Krock Pushing. Will merge #3208 afterwards 12:46 ShadowBot https://github.com/minetest/minetest/issues/3208 -- allow changing the velocity of objects relatively to their current velocity by HybridDog 12:47 rubenwardy nice 12:48 rubenwardy can you rename the latter's commit message? 12:48 rubenwardy to ObjectRef: Add add_velocity() 12:48 rubenwardy or similar 12:49 rubenwardy lol, nvm 12:49 Krock I can still amend if you want :D 12:49 * rubenwardy groans at that bad grammar 12:50 rubenwardy "relatively to their current velocity" 12:50 rubenwardy ewwww 12:50 rubenwardy XD 12:50 rubenwardy heh 12:50 Krock force pushing amended commit 12:50 rubenwardy hope that Shara never sees that 12:50 rubenwardy XD 12:53 Krock It never happened. 12:53 rubenwardy yes 12:54 Krock rubenwardy, you were 16 seconds faster than me 8) 12:54 rubenwardy hehe 13:12 * Shara saw nothing 13:41 nerzhul sounds good 13:41 nerzhul is there any meeting on the evening ? 13:41 nerzhul (today) 13:42 nerzhul if not can we talk about clang-tidy ? i really want to see a such tool in our CI to show the coding problem 13:43 nerzhul Krock seems LINT is lgtm on your PR issue on s_player.h 13:46 Krock I'd welcome a meeting but from what I've got on my list is the 0.4.17 release 13:46 Krock and only that.. would need more to add at least a bit diversity :D 13:48 nerzhul Krock add "introduce clang-tidy to the CI" 13:48 nerzhul :) 13:49 nerzhul and i will look at the introduction rules we can add on my PR, i already added somes, and if we are efficient we can add more rules each week after fixing some lgtm warnings :) 13:49 nerzhul (all are not lgtm but maybe does a good catch on problem we can have :) 13:49 rubenwardy Not sure what I'll be doing 13:54 nerzhul what do you mean ? 13:59 Krock Meeting 180331: nerzhul, nore, paramat, rubenwardy, sfan5, Shara, sofar -- would you have some time around 18:00/19:00 UTC to participate in the meeting? 14:00 sfan5 probably 14:01 Krock Easter is near, so I'm not too optimistic that people have time for it 14:01 Shara I should be here 14:04 nerzhul i can be there i think, depend on my wife, but i will try :) it will be lunch time for us 14:04 nerzhul and the 0.4.17 release date is the most important point 14:06 nerzhul maybe a discussion point about https://github.com/minetest/minetest/pull/7126 ? 14:06 nerzhul seems many have commented on it 14:06 Krock minor changes requested. ready to be merged afterwards 14:07 Krock I'm not sure what's to discuss there 14:07 nerzhul ergonomy (joystick placement ?) 14:07 nerzhul it's the only point to fix but the most important for player 14:08 paramat i might be able to do meeting but if so will be tired (long day) 14:09 rubenwardy I may be able to too 14:09 VanessaE "left side for joystick and right side for turn around" -1 for that. not discoverable, and violates how a joystick is normally used. 14:09 rubenwardy Won't be available for the next few hourd 14:10 rubenwardy Not sure what you mean Vanessa 14:10 rubenwardy It's discoverable due to the massive fat stick on the screen 14:10 rubenwardy ;) 14:10 VanessaE rubenwardy: no, the right side part. 14:10 rubenwardy That's currently the case now 14:10 VanessaE how will the user see that he/she can use the right half to turn. 14:11 VanessaE of course they can randomly thumb at the screen, but maybe there ought to be an image, something like a scrub bar. 14:11 nerzhul both joysticks should be shown, and we should just use same control as every game pad like XBox, switch, PSX etc 14:11 VanessaE nerzhul: you're not too far off. principle of least surprise. 14:15 rubenwardy That's something for a future PR 14:15 rubenwardy Alternatively the selection area could be joystick + a border 14:15 rubenwardy But you still won't know how tomturn 14:15 VanessaE turn with the joystick. 14:16 rubenwardy It's usual in games to show a finger to show where to drag 14:16 VanessaE if you're on a tablet, you don't need sidestepping. 14:16 rubenwardy It's good to get the basic code in, then iterate 14:16 rubenwardy Rather than bikeshedding now 14:16 nerzhul just download fortnite on android, look at the controls, it's what industry did on android :) 14:17 VanessaE looks like a virtual dualshock controller. 14:17 nerzhul yes, it's what we need :) 14:18 VanessaE perhaps, but kinda overengineered for MT, no? 14:18 Wayward_One I personally prefer the way the PR has it 14:18 nerzhul it's a first person game, what do you want ? 14:19 VanessaE well, there are about twice as many controls in such a controller as minetest can really make use of. 14:20 rubenwardy I'd like to get it in, then perform some testing on kids 14:21 VanessaE didn't there used to be a rule against "merge it in, tweak it later"? 14:22 Wayward_One Well, this is fully functional as-is, and already a huge improvement 14:22 rubenwardy What we have is basically multicraft anyway 14:22 rubenwardy And yes 14:23 VanessaE well ok. 14:24 VanessaE not like I can stand in the way of course. 18:18 Krock nerzhul, nore, rubenwardy, sfan5, Shara, sofar -- May we begin the meeting now? How many are we this time? 18:18 sfan5 sure 18:20 sofar have at it, it's the middle of the day here, I've got stuff planned/to do 18:21 Krock no problem. Carry on with your work :) 18:25 rubenwardy Here now 18:27 Shara here 18:28 Krock It would be nice to have nerzhul here to discuss the clang-tidy topic easier 18:29 Krock however, we can also start with the 0.4.17 release schedule 18:31 Krock There are a few commits that need backporting in #6746 . #6900 could be added there too for the sake of that lava lamp 18:31 ShadowBot https://github.com/minetest/minetest/issues/6746 -- Backport 0.4 by sfan5 18:31 ShadowBot https://github.com/minetest/minetest/issues/6900 -- core.rotate_node: Do not trigger after_place_node by SmallJoker 18:33 Krock Who's going to do that and when do we (finally) release 0.4.17? 18:41 sfan5 probably me 18:41 sfan5 when? no idea 18:42 Krock it's pretty stable and waiting much longer isn't worth it 18:43 Krock we also have windows binaries from the gitlab pipeline, which makes the release pretty fast 18:43 rubenwardy I agree 18:43 rubenwardy and making releases faster is a good thing 18:43 sfan5 you never know which important bug gets discovered and fixed before 0.5 finally releases 18:43 Krock the question above didn't mean to exclude me, but I surely appreciate if you're willing to cherry-pick the commits 18:43 sfan5 but I am not opposed to releasing .17 earlier 18:44 sfan5 also windows builds were never a problem during releases (except for MSVC but we don't do that anymore) 18:44 Krock rubenwardy, yeah. it's basically only writing a forum post plus updating the links 18:44 sfan5 you forgot the changelog 18:44 rubenwardy and the testing 18:44 rubenwardy and that 18:46 Krock haha. I underestimated it a little :) 18:49 rubenwardy it would be nice for the changelog to be mostly automated with tags or something 18:49 Krock but the commit messages aren't always that accurate 18:49 rubenwardy yeah 18:49 rubenwardy it's more to give all the bullets 18:50 rubenwardy which can then be modified 18:50 rubenwardy it's the sorting with is time consufing 18:50 rubenwardy when I did it 18:50 rubenwardy even though I used a bash script wit wait for key to sort 18:52 sfan5 pasting the commit messages into the changelog sucks 18:52 sfan5 it should provide an useful list of new features / bugfixes that is understandable by users to some degree 18:53 rubenwardy yrd 18:53 rubenwardy *yes 18:53 rubenwardy hence the need for post processing 18:53 rubenwardy remove things added since this release 18:53 rubenwardy simplify and remove overly technical things 18:53 rubenwardy combine things 18:54 Krock remove compiler fixes, refactors, typo fixes.. 18:54 Krock but I'll stay time-consuming if we want to keep it informative 18:56 Krock I can take care of the changelog, because it doesn't have to be done on the very same day. I'm saying that as next weekend would work for me, but the weekend afterwards is already planned 18:57 Krock in case we want to do it in 14 days 20:35 Wayward_One speaking of 0.4.17, both the 0.4.16 stable and 0.5.0-dev android versions build successfully, but 0.4.17-dev fails for me with this: https://pastebin.com/j4mjniaq 20:35 sfan5 known issue 20:36 Wayward_One ah, okay 20:36 sfan5 when merging changes I did not rewrite c++11 code into c++03 20:36 sfan5 but I didn't adjust the flags for cmake / android building 20:36 Wayward_One i see 20:52 nerzhul sorry for to be late dudes, i was too busy at home between my wife and childs :s 20:53 nerzhul i agree with sfan5 about user friendly understandable changelog 20:56 nerzhul i don't see a 0.4.17 release date, what about fixing it for middle or end of april ?