Time Nick Message 06:04 Cornelia I recently picked up a book on Vulkan and even though I'm barely through the first chapter I have been (slightly) tempted to write a vulkan renderer for minetest. :P 08:34 nerzhul Cornelia, should should patch irrlicht then 09:11 nerzhul #7158 is ready for a review, it's a little refactor after the prvious user provided refactor + cleanup 09:11 ShadowBot https://github.com/minetest/minetest/issues/7158 -- Cleanup sound manager class by nerzhul 12:33 nerzhul Krock: ty for the review 12:34 Krock np. was the only thing I could find in the PR 12:34 nerzhul okay it's nice, i'm moving that file, building without sound to be sure 12:36 nerzhul if it works are you okay with the PR ? 12:38 Krock yes 12:40 nerzhul this code move should help my cmake android build refactor as i will get a new module to make it working properly, currently build doesn't find sound libraries :) that can help 12:43 nerzhul okay it's working as intended with a minor include change in game.cpp 12:43 nerzhul i also fixed the Android.mk :) 12:46 nerzhul Krock: i think the singleton usage is the problem in the bug you mentioned. It's a singleton then not removed when we switch back from game 12:48 nerzhul i think the singleton is the problem 12:50 Krock yes, so we'd have to clean up the playing sounds when leaving one screen 12:50 nerzhul it seems the code cleanup it in the OpenALManager destructor 12:50 nerzhul but maybe something is wrong 12:50 nerzhul if you are okay i will merge #7158 after travis pass 12:51 ShadowBot https://github.com/minetest/minetest/issues/7158 -- Cleanup sound manager class by nerzhul 13:13 nerzhul Krock, travis pass, is this always okay ? :) 13:30 Krock nerzhul, functionally nothing was changed, so +1. 14:45 nerzhul merging #7158 14:45 ShadowBot https://github.com/minetest/minetest/issues/7158 -- Cleanup sound manager class by nerzhul 14:46 nerzhul ty Krock for the review 15:06 Krock Pushing fix for #7160 in 15 mins https://pastebin.com/raw/8pkGLmsB (tested) 15:06 ShadowBot https://github.com/minetest/minetest/issues/7160 -- Sounds do not stop playing 15:24 Krock pushing now... 17:13 rubenwardy reviews for #7099 please 17:14 ShadowBot https://github.com/minetest/minetest/issues/7099 -- Add formspec theming using prepended strings by rubenwardy 17:14 rubenwardy needs to be in 0.5.0 17:15 rubenwardy Krock, nerzhul, sfan5 ^ 17:18 Amaz rubenwardy: If a mod wants a formspec not to be themed in that way, would it need to remove the prepend before showing the formspec, and set it again afterwards? 17:18 rubenwardy no 17:18 rubenwardy no_prepend[] 17:19 Amaz Oh, okay :) 17:20 Amaz Thanks :) 17:24 Krock rubenwardy, why needs to be? Looks like a regular feature 17:24 rubenwardy it's an important change for mod compatibility, removes the need to depend on default for mods which only use inventories 17:25 Krock then why not move it to builtin? 17:25 Krock ah I see, it's also player-specific 17:25 rubenwardy moving to default would mean node formspecs can't use it 17:27 rubenwardy counter part: game#2098 17:27 ShadowBot https://github.com/minetest/minetest_game/issues/2098 -- Add formspec theming, remove sfinv's dependency on default by rubenwardy 17:27 rubenwardy so, there's 3 cases: 17:28 rubenwardy 1. mods which use the current variables - fine, as they still exist and are empty strings. No change 17:28 rubenwardy 2. mods which don't use the current variables, but should - they are now fixed 17:28 rubenwardy 3. mods which define their own background and bgcolor - fine, they display over the theme's one 17:29 rubenwardy 4. mods which either don't want a background, or define their own translucent one - require an addition of no_prepends[] 17:29 rubenwardy for 4, I've only seen tenplus1's skins do that 17:29 rubenwardy and it's not a bad break as such, ie: it's still usable 17:31 rubenwardy also, that was 4 cases :O 17:32 Krock 5. ??? 17:32 Krock 6. Profit! 17:32 Krock "client->getEnv().getLocalPlayer()->formspec_prepend" smells a lot like Java insanity but well.. seems to work 17:32 rubenwardy yeah 17:32 rubenwardy hmmm 17:33 rubenwardy I'll change that 17:33 rubenwardy to client->getFormspecPrepend() 17:33 rubenwardy cliner 17:33 rubenwardy *cleaner 17:37 rubenwardy thanks 17:52 Krock rubenwardy, added a few more comments. Review #0000001 done ;) 17:52 ShadowBot https://github.com/minetest/minetest/issues/0000001 -- GlowStone code by anonymousAwesome 17:52 Krock <3 ShadowBot 17:52 ShadowBot ♥ Krock. 17:56 Thomas-S Krock, if you want to continue reviewing formspec stuff, I'd be really glad if you could take a look on #7116 again ;) 17:56 ShadowBot https://github.com/minetest/minetest/issues/7116 -- Formspecs: Add a parameter to the box[] element by Thomas--S 17:56 rubenwardy FORMSPEC_API_VERSION sucks and can never actually be increased 17:56 Krock Thomas-S, it's basically only the error that bugs me, as it's probably shown in the chat in-game as soon a formspec is opened with that new param 17:58 Thomas-S This won't happen to a normal end-user, as with 0.5.0 only new clients can join new servers. This will only be a problem for -dev versions, as far as I can see. 17:58 Krock and 0.4.17 with newer mods 17:59 Thomas-S Either the mod auther detects which version is used, or the server owner has to use a compatible mod version. 18:00 rubenwardy it's client side though 18:00 rubenwardy although 0.5.0 is actually the edge case 18:00 rubenwardy *exception 18:00 rubenwardy as older clients can never connect 18:00 rubenwardy lol 18:01 Krock 0.5.0 would now be the best choice to use a better method of dealing with the formspec elements if not a whole new system it going to be added soon 18:02 rubenwardy probably worth just removing the check 18:10 Krock Thomas-S, alternatively you could assume `true` and replace an alpha value of 0xFF with 140. The irony would be that you can use #00FF0044 but not #00FF00FF to display the alpha correctly 18:11 Krock but well, a new param is better 18:12 Thomas-S I think the suggestion above would maybe be a bit complicated to understand for modders. :) 18:14 rubenwardy not a good idea 18:14 rubenwardy inconsistent 18:14 rubenwardy means you can't have a solid box, too 18:14 Krock exactly 18:14 Krock it would however work if we could check whether an alpha part is given in the string or not 18:15 Krock using 140 as default and overwrite if an alpha part is specified in parseHexColorString 18:40 Thomas-S Krock, I addressed your comment on "bool use_color_alpha ...". Do you really want me to modify the parseHexColorString, or was this only an idea? 18:41 Krock just brainstorming 21:15 paramat sorry i wasn't here for a potential meeting, anyway, i think we should release 0.4.17 soon as 0.5.0 may be months away 21:16 * rubenwardy re-adds the mod store 23:44 paramat game#2091 is ready for testing and review 23:44 ShadowBot https://github.com/minetest/minetest_game/issues/2091 -- Add 'spawn' mod to spawn new players in wood resource biomes by paramat