Time Nick Message 04:13 srifqi I got error when compiling for Android from recent master branch: https://gist.github.com/srifqi/eac2a58cf828b6e54013499bfb801d6a 05:25 paramat merging #7138 05:25 ShadowBot https://github.com/minetest/minetest/issues/7138 -- Lua_api.txt: Split long lines part 6 by paramat 05:31 paramat merged 08:21 nerzhul I push a commit to add more entries to gitignore (for android building + test_config.h) 09:10 nerzhul merging #7061 09:10 ShadowBot https://github.com/minetest/minetest/issues/7061 -- Fix node-nodebox lighting difference in direct sunlight by numberZero 10:32 srifqi nerzhul: There is a problem between 6c18494 and e800684 that makes my Android build failed. 10:32 srifqi Using 5e61f64 works. 10:58 nerzhul srifqi, i will fix that soon, i think it's the new file in server/ folder 11:01 nerzhul i think i will try to finish the android build rework at a point, but it's huge due to deps (not MT which is correctly compiled) 11:02 srifqi Okay. 11:02 nerzhul your problem is a linking issue, right ? 11:02 srifqi FYI, using 0358ae7 still not working. 11:02 srifqi Yup, problem with linking. 11:02 nerzhul talking about mods amanger ? 11:03 srifqi Yes, ServerModManager. 11:03 nerzhul it's easy to fix 11:13 nerzhul i push the android build fix 11:13 nerzhul srifqi it's pushed 11:13 nerzhul shoulbe okay now 11:28 srifqi wait, building rn 13:27 rubenwardy nerzhul, sfan5, celeron55 ^ 13:28 rubenwardy ignore the silly intro and sorry about the diagram 13:40 rubenwardy XD 14:08 srifqi nerzhul: sorry late response, it works already. 14:45 nerzhul Krock: hello, is #7137 okay for you ? 14:45 ShadowBot https://github.com/minetest/minetest/issues/7137 -- Print the mod loading time by HybridDog 14:51 Krock I wonder why we need such a precision but the PR looks functionally good 14:52 sfan5 I wonder if it would be better to use porting:: for consistency with other code 14:53 sfan5 and do a cleanup porting::getTime* -> std::chrono at once 14:53 celeron55 rubenwardy: seems to match with what we talked about 14:54 celeron55 this is clearly missing some details but i guess it doesn't matter 14:55 Krock I'd say use getTimeMs there and remove the .gitignore line, then merge. using chrono in some places, getTime in others is very inconsistent 16:23 nerzhul Krock maybe we can switch at a point yes 16:23 nerzhul and add a technical issue for this 16:34 nerzhul if needed maybe someone can do the refactor PR to use chrono where it's needed 16:34 nerzhul we can merge this as is as it doesn't add technical debt 17:44 nerzhul the cmake build migration is not easy as many libs doesn't have support for cmake or badly support for cmake + android... lol 17:47 nerzhul i need to get: irrlicht, curl, libiconv, freetype and libogg/libvorbis with cmake to make it succeed