Minetest logo

IRC log for #minetest-dev, 2018-02-13

| Channels | #minetest-dev index | Today | | Google Search | Plaintext

All times shown according to UTC.

Time Nick Message
00:20 BakerPrime joined #minetest-dev
00:35 YuGiOhJCJ joined #minetest-dev
00:41 Xio joined #minetest-dev
01:17 Tmanyo joined #minetest-dev
01:40 BakerPrime joined #minetest-dev
01:55 paramat joined #minetest-dev
03:16 AndroBuilder_ joined #minetest-dev
03:28 paramat joined #minetest-dev
03:45 paramat will merge #7024 #7032 #7036 in a few mins
03:45 ShadowBot https://github.com/minetest/minetest/issues/7024 -- Falling.lua: Delete falling node entities on contact with 'ignore' by paramat
03:45 ShadowBot https://github.com/minetest/minetest/issues/7032 -- Item entity: Delete in 'ignore' nodes by paramat
03:45 ShadowBot https://github.com/minetest/minetest/issues/7036 -- Dungeons: Avoid generation in multiple liquid nodes and 'airlike' by paramat
03:58 paramat merged
05:00 Darcidride__ joined #minetest-dev
07:49 twoelk joined #minetest-dev
10:57 YuGiOhJCJ joined #minetest-dev
11:38 Fixer joined #minetest-dev
12:31 Jordach joined #minetest-dev
12:48 pgimeno_ joined #minetest-dev
13:54 BakerPrime joined #minetest-dev
14:26 BakerPrime_ joined #minetest-dev
14:36 YuGiOhJCJ joined #minetest-dev
14:54 lisac joined #minetest-dev
15:28 red-001 #7039
15:28 ShadowBot https://github.com/minetest/minetest/issues/7039 -- Add `on_auth_fail` callback by red-001
16:13 Beton joined #minetest-dev
16:29 Gael-de-Sailly joined #minetest-dev
16:38 Robby joined #minetest-dev
16:39 RobbieF joined #minetest-dev
16:39 RobbieF left #minetest-dev
16:53 VanessaE again with this out of memory crap.  something between 0.4.16 and commit 3d0617c9 (on backports-0.4) has completely broken things.  a player just signing onto my server causes an OOM crash.
16:53 VanessaE wtf is going on?
16:56 pgimeno_ VanessaE: maybe you can bisect the exact commit?
16:56 VanessaE are you crazy?
16:56 VanessaE this is a production server
16:56 * pgimeno_ shrugs
17:00 pgimeno_ if it's better to let it crash every time a player signs onto the server than to take it down for some minutes during bisection, then I'm probably crazy
17:01 VanessaE it wouldn't be "some minutes".
17:01 VanessaE not on a world that big and ols
17:01 VanessaE oldd*
17:02 VanessaE there, disabled luajit
17:03 BakerPrime_ Yes, and I can say that it DID work. The server is fixed, LuaJIT is broken. Period. (I think)
17:05 VanessaE luajit had gc64 enabled, too
17:22 antims joined #minetest-dev
17:24 prawnsalad joined #minetest-dev
17:39 Darcidride joined #minetest-dev
17:43 Fixer VanessaE: can you show exact error on pastebin?
17:44 Krock joined #minetest-dev
17:44 VanessaE Fixer: it's just a generic OOM error like any other, always showing less than 1GB in use, in random mods/sections of code.
17:44 VanessaE (last time, builtin)
17:50 Fixer VanessaE: i had this problem for ages, try using build with lua
17:50 VanessaE read up, fi`
17:50 VanessaE read up, Fixer
17:51 VanessaE luajit has just been disabled.  I'm on stock lua now.
17:51 Fixer ok, this should help
17:52 Fixer VanessaE: wonder why low mem usage is reported, probably a bug somewhere
17:52 VanessaE who knows.
17:54 VanessaE minetest needs to report "mod so-and-so tried to allocate X MB" on a OOM crash
17:54 VanessaE (if it can)
18:00 Beton_ joined #minetest-dev
18:00 Fixer yeah
18:29 YuGiOhJCJ joined #minetest-dev
18:34 twoelk left #minetest-dev
19:24 ssieb joined #minetest-dev
19:34 paramat joined #minetest-dev
19:51 CBugDCoder joined #minetest-dev
19:57 Gael-de-Sailly joined #minetest-dev
19:58 Gael-de-Sailly joined #minetest-dev
20:09 behalebabo joined #minetest-dev
20:30 ThomasMonroe joined #minetest-dev
20:35 paramat 2 simple PRs game#2044 game#2046 the boat one is possibly trivial
20:35 ShadowBot https://github.com/minetest​/minetest_game/issues/2044 -- Boats: Prevent entering 'ignore' nodes by paramat
20:35 ShadowBot https://github.com/minetest​/minetest_game/issues/2046 -- Flower spread: Only spread to the same surface node by paramat
20:35 red-001 paramat, got some time to review #6982?
20:36 ShadowBot https://github.com/minetest/minetest/issues/6982 -- Make settings files per-world. by red-001
21:18 Gael-de-Sailly joined #minetest-dev
22:10 paramat erm
22:13 paramat i'm keen to review where i can, but i'm only good with certain parts of code, this isn't one of them. i'm also prioritising my review time and i see many higher priorities, sorry
22:19 red-001 well thought I would ask you since I'm considering also merging map_meta.txt with world.mt, and mapgen is kinda your field
22:35 paramat ah hmm thanks
22:36 paramat oh it's more radical than i realised, will look over it
22:38 Fixer this one seems good for review, not too big https://github.com/minetest/minetest/pull/6825
22:38 paramat what is the reason for merging those 2 files?
22:39 red-001 most of the C++ changes are just to avoid client settings like view range being saved in the world config
22:39 red-001 paramat, to make experimenting with mapgen flags easier
22:39 Fixer and this one too needs reviews, important https://github.com/minetest/minetest/pull/6786
22:41 red-001 also makes it easier for someone to mess up thier world which is why I haven't implemented it
22:43 paramat will test 6982
22:45 paramat 6982 is big so needs lots of attention
22:47 red-001 Fixer, is 6825 only for cinematic?
22:48 red-001 or does cimematic just happen to be enabled?
22:48 Fixer red-001: no, smooth yaw for objects, for example, carts, mobs, etc
22:51 paramat so i create a world, highlight it, then click 'world settings'?
22:52 red-001 that should open a modified version of advance settings with anything thats client only removed
22:53 paramat ok, it's very buggy, will reply in thread
23:14 red-001 paramat, like I said I haven't merged map_meta.txt with settings, just was considering doing so
23:17 paramat ok
23:17 paramat oh yeah misread
23:18 paramat is this why altering mapgen parameters doesn't work?
23:18 red-001 yes
23:18 paramat ok
23:18 red-001 fixed the two other issues
23:20 paramat map meta txt is already per world so setting mapgen parameters in world settings may be irrelevant, of course, duh
23:21 paramat but then you'd need to disallow changing some mapgen params in world creation i guess if they aren't going to work
23:22 red-001 well since mapgen now seems to be it's own top-level settings group I could just filter it out easily
23:23 paramat i think at the moment i prefer map meta txt stay separate and contain stuff that is already per-world, and therefore not be settable in world settings
23:23 red-001 done
23:23 paramat mapgen params would then be set in advanced settings as before
23:24 sofar just by relationship alone, mapgen settings would go with the world, not aside
23:25 Fixer +1
23:25 sofar don't think they would be compatible off the bat format wise though
23:25 sofar you probably have to serialize them first
23:26 sofar messy
23:26 sofar it's too bad they got their own config file code early on
23:27 red-001 the format is literaly a normal settings file with a special line at the end, or at least thats how world init treats it
23:28 red-001 I don't think anything else uses settings groups but all settings files should support them
23:30 paramat anyway users are used to setting mapgen params in advanced settings and know those will be saved per-world in map meta txt, so 'world settings' can be for other stuff
23:31 paramat probably simpler
23:31 sofar anyone who edits mapgen settings can edit them where ever we put them
23:31 sofar we're like down to 3 people
23:32 sofar I don't mind though, I'm just lamenting the fact they were separated from the start
23:32 sofar we should have had a world.conf and a client.conf from the get-go
23:33 paramat so yes i am happy to test this PR

| Channels | #minetest-dev index | Today | | Google Search | Plaintext