Minetest logo

IRC log for #minetest-dev, 2018-01-13

| Channels | #minetest-dev index | Today | | Google Search | Plaintext

All times shown according to UTC.

Time Nick Message
00:12 lhofhansl left #minetest-dev
00:14 EvergreenTree joined #minetest-dev
00:25 twoelk joined #minetest-dev
01:04 YuGiOhJCJ joined #minetest-dev
01:29 lhofhansl joined #minetest-dev
02:18 ssieb joined #minetest-dev
02:56 EvergreenTree joined #minetest-dev
04:19 Darcidride_ joined #minetest-dev
04:40 torgdor joined #minetest-dev
05:03 Icedream joined #minetest-dev
07:56 lhofhansl joined #minetest-dev
07:58 lhofhansl For the record. This all turned out to be bad implementation in NSSM, which floods the client with dirty blocks. I fixed it in NSSM, it's one-line fix.
08:14 nerzhul joined #minetest-dev
08:50 lhofhansl left #minetest-dev
09:06 nerzhul sfan5, if you are okay i will merge #6849 today
09:06 ShadowBot https://github.com/minetest/minetest/issues/6849 -- Add confirmation on new player registration by srifqi
09:06 nerzhul wow our changelog hasn't been updated since my last updateo n the 309 nov
09:55 Icedream joined #minetest-dev
10:31 Lymkwi joined #minetest-dev
10:57 YuGiOhJCJ joined #minetest-dev
11:00 pgimeno_ how do backports work?
11:01 pgimeno_ I mean, should I submit PRs for inclusion in stable-0.4 of fixes to bugs, or do the core developers backport the bugfixes?
11:03 sfan5 latter
11:04 pgimeno_ thanks, sfan5
11:06 nerzhul sfan5, if #6849 okay ? for you ?
11:06 ShadowBot https://github.com/minetest/minetest/issues/6849 -- Add confirmation on new player registration by srifqi
11:06 sfan5 yes
11:07 nerzhul then merging
11:15 Fixer joined #minetest-dev
11:17 nerzhul our 0.5 changelog is huge omg :p
11:18 nerzhul and we are late, i added from 30aug to 11 sept atm
11:18 nerzhul i think we should define what's missing before release 0.5 and work on it
11:27 red-001 can someone review #6032
11:27 ShadowBot https://github.com/minetest/minetest/issues/6032 -- Load texturepacks from the `textures` subfolder of subgames. by red-001
11:27 red-001 it's a pretty trivial change but fairly useful
11:30 nerzhul okay changelog is now updated from 30aug to 16 oct :p
11:37 paramat joined #minetest-dev
11:44 Gael-de-Sailly joined #minetest-dev
11:50 Darcidride_ joined #minetest-dev
11:59 Icedream joined #minetest-dev
12:31 Foz joined #minetest-dev
12:59 nerzhul red-001, i added my approval someone should do it maybe sfan5 paramat rubenwardy ?
13:01 Darcidride_ joined #minetest-dev
13:13 EvergreenTree joined #minetest-dev
13:46 Icedream joined #minetest-dev
13:48 EvergreenTree joined #minetest-dev
13:50 paramat for lua_api.txt generally are others ok with line continuation of bullet points being indented as here https://github.com/minetest/minetes‚Äčt/pull/6910#issuecomment-357433927 seems clearer and is used a lot in that file
13:53 paramat i'll merge #6910 in 20 mins if no objections to that formatting style for lua_api.txt
13:53 ShadowBot https://github.com/minetest/minetest/issues/6910 -- Add chat command params info to lua_api.txt by Ezhh
13:57 paramat Shara may well be making a PR after this merge to clean up bullet point indentation in lua_api.txt and make it consistent to that PR, so make any objections now :)
14:17 EvergreenTree joined #minetest-dev
14:17 Fixer joined #minetest-dev
14:38 srifqi joined #minetest-dev
14:47 nerzhul paramat, take a look at #6032 please :)
14:47 ShadowBot https://github.com/minetest/minetest/issues/6032 -- Load texturepacks from the `textures` subfolder of subgames. by red-001
14:50 paramat i have already :)
14:53 paramat merging #6910
14:53 ShadowBot https://github.com/minetest/minetest/issues/6910 -- Add chat command params info to lua_api.txt by Ezhh
15:01 paramat done
15:03 paramat Shara if you now make a cleanup PR for lua_api could you explain what you will do, so that it can be approved before you start?
15:04 Shara I was just planning a run through to make sure the two spaces after a new line in bullet points is consistent throughout
15:04 Shara At the moment it seems to switch between 2, 1 and 0 spaces
15:05 Shara So it's something very minor, just it means looking through over 5k lines of documentation
15:05 Shara (because lua_api is huge)
15:06 paramat that's fine for me
15:07 Shara Okay, will start soon then
15:08 paramat of course, since it's a big job, once you start we won't merge anything that causes a conflict
15:09 Shara Well, if it happens, it happens. And I don't expect things to be held up by it.
15:09 paramat ^ nerzhul sfan5 nore ok with that?
15:10 Shara All that I ask is, once I do make the PR, please don't leave it sitting too long.
15:10 Shara It should at least be very simple to review
15:12 paramat you're doing this for '^' bullet points too?
15:12 Shara Are they also effected by this? If they are I will
15:14 paramat ok fine for me
15:16 Shara Okay, will start as soon as I have a cup of tea next to me. :)
15:20 nerzhul okay with just code reformating ? no sorry :)
15:20 nerzhul if it's minor part yes, the whole code no
15:21 paramat just lua api
15:21 Shara It's documentation, which is currently inconsistent
15:21 Shara Not code
15:21 nerzhul if it's lua_api and client_lua_api no problem for me
15:22 paramat looking through most is correctly indented. line 2303 needs less indent
15:22 Shara paramat: I can leave you to do it if you want :P
15:24 Shara This is really just continuing work I already started in previous PRs, so I'm not sure why it would be a worry now
15:24 paramat no thanks
15:25 paramat just looking in case there are any issues that need resolving before work starts
15:25 nerzhul paramat, for #6032 you said rebased, waiting for review
15:25 ShadowBot https://github.com/minetest/minetest/issues/6032 -- Load texturepacks from the `textures` subfolder of subgames. by red-001
15:26 nerzhul but you didn't approve or disapprove anything :p
15:30 paramat i looked, haven't reviewed yet
15:34 srifqi paramat, #6911
15:34 ShadowBot https://github.com/minetest/minetest/issues/6911 -- Fix grammar in registration confirmation dialog by srifqi
15:39 paramat +1 for 6032 will merge later if no-one else does
15:39 paramat thanks
15:41 paramat +1
15:44 paramat once 6911 is updated i'll merge that later if no-one else has
15:44 srifqi Let me change the text first.
15:50 srifqi Done.
15:53 srifqi Travis seems to be slower. 6910 took more than 3 hours and still running.
16:06 sfan5 paramat: i'd be fine with that
16:07 paramat ok
16:31 CBugDCoder joined #minetest-dev
16:37 ButcherTibi_ joined #minetest-dev
17:33 paramat joined #minetest-dev
17:35 Shara paramat: There's a PR waiting for you :)
17:41 paramat just seen it
17:51 Gael-de-Sailly joined #minetest-dev
17:52 paramat will let you know when i have finished reviewing
17:53 Shara Thanks.
17:54 CBugDCoder joined #minetest-dev
18:18 rubenwardy left #minetest-dev
18:19 paramat done
18:21 Shara Will make replies on github, and thank you
18:23 paramat red-001 docs in 6032 need improvement, i'm +1 once that's done, then we'll merge it
19:00 numzero joined #minetest-dev
19:06 paramat phew
19:06 Shara :D
19:11 paramat just one more thing ..
19:12 nepugia paramat: i will not join github, if you want to discuss the patch fine, but i will not do it on github :)
19:13 paramat ok
19:13 nerzhul joined #minetest-dev
19:16 paramat nepugia feel free to explain the PR in this channel
19:16 paramat so that devs can see it
19:17 paramat 2 trivial PRs #6911 #6912 will merge in a few mins
19:17 ShadowBot https://github.com/minetest/minetest/issues/6911 -- Fix grammar in registration confirmation dialog by srifqi
19:17 ShadowBot https://github.com/minetest/minetest/issues/6912 -- Lua_api.txt: Improve bullet point indentation consistency by Ezhh
19:20 nepugia The PR is intended so mods dont have to depend on MTG in particular but rather on some crafting groups, currently i find it fairly difficult to create a mod with an survivial adaptation without either explicitly supporting the specific subgame, or reimplemening all ores and crafting materials i would need, this wouldnt make much sense either since you would e.g have 2 types of sand suddenly, as for the groups i tried t
19:20 nepugia pick some that i think are fairly common for crafting. I suppose i am quite biased in that direction since i only mod in one direction.
19:20 CBugDCoder joined #minetest-dev
19:21 nerzhul celeron55, we have a SSL issue on dev.minetest.net
19:25 nepugia With adding crafting groups subgame compatibility would be more easier, as for the pr itself i dont care much if it is accepted with the specific groups i have proposed, maybe other devs might find some more suited ones
19:26 paramat ok
19:26 paramat merging the above 2 PRs now
19:35 celeron55 nerzhul: it's not an issue, just a missing feature!
19:35 celeron55 report to whoever linked you with https to it for now
19:38 CBugDCoder joined #minetest-dev
19:45 paramat done
19:46 paramat trying to stay under 100 open PRs
19:51 nerzhul celeron55, it's me xD
19:52 Tmanyo joined #minetest-dev
19:56 CBugDCoder joined #minetest-dev
19:57 CBugDCoder joined #minetest-dev
20:17 Gael-de-Sailly joined #minetest-dev
20:18 compunerd joined #minetest-dev
20:23 Gael-de-Sailly joined #minetest-dev
20:23 fwhcat joined #minetest-dev
21:09 rubenwardy joined #minetest-dev
22:02 ButcherTibi_ joined #minetest-dev
22:06 ButcherTibi joined #minetest-dev
22:09 ButcherTibi joined #minetest-dev
22:09 ButcherTibi_ joined #minetest-dev
22:10 ButcherTibi joined #minetest-dev
23:25 EvergreenTree joined #minetest-dev
23:46 torgdor joined #minetest-dev
23:57 AntumDeluge joined #minetest-dev

| Channels | #minetest-dev index | Today | | Google Search | Plaintext