Minetest logo

IRC log for #minetest-dev, 2018-01-11

| Channels | #minetest-dev index | Today | | Google Search | Plaintext

All times shown according to UTC.

Time Nick Message
00:00 YuGiOhJCJ2 joined #minetest-dev
00:09 EvergreenTree_ joined #minetest-dev
00:24 Tmanyo joined #minetest-dev
00:31 celeron55_ joined #minetest-dev
02:13 EvergreenTree joined #minetest-dev
02:57 EvergreenTree joined #minetest-dev
02:59 ssieb joined #minetest-dev
03:16 ssieb joined #minetest-dev
03:36 paramat joined #minetest-dev
03:38 ssieb joined #minetest-dev
03:58 ssieb joined #minetest-dev
04:18 ssieb joined #minetest-dev
04:36 ssieb joined #minetest-dev
05:30 compunerd joined #minetest-dev
06:15 nerzhul joined #minetest-dev
10:11 nerzhul joined #minetest-dev
11:20 Fixer joined #minetest-dev
12:05 lisac joined #minetest-dev
12:09 YuGiOhJCJ joined #minetest-dev
12:29 behalebabo joined #minetest-dev
13:29 Fixer joined #minetest-dev
13:44 antims joined #minetest-dev
15:00 Fixer joined #minetest-dev
15:23 clavi joined #minetest-dev
16:52 Gael-de-Sailly joined #minetest-dev
17:22 Krock joined #minetest-dev
17:37 ircSparky joined #minetest-dev
17:42 Darcidride_ joined #minetest-dev
17:57 EvergreenTree joined #minetest-dev
18:58 ssieb joined #minetest-dev
19:31 paramat joined #minetest-dev
19:32 paramat Krock nerzhul are you able to approve #6838 ?
19:32 ShadowBot https://github.com/minetest/minetest/issues/6838 -- Fix ambient occlusion and dark lines at mapblock borders by numberZero
19:33 Krock Yes, it fixed most of the shadow bugs
19:48 paramat thanks, i can merge it later
20:25 Gael-de-Sailly joined #minetest-dev
20:43 EvergreenTree joined #minetest-dev
21:08 Gael-de-Sailly joined #minetest-dev
21:33 pgimeno_ Krock: Thanks for the review. I did read the code style guide, but it didn't mention what to do about 'else' explicitly, and I neglected to read the kernel style guide. In my discharge, I copied that style from the Minetest source: http://www.formauri.es/personal/pgimeno/pastes/grep-else-in-minetest.txt
21:35 Krock pgimeno_, please keep in mind that old code must not be well programmed or formatted code
21:36 pgimeno_ Krock: sure, that's just my excuse :P I can't distinguish old from new code. Anyway, I'll of course submit the fix. That was just a comment.
22:00 Tmanyo joined #minetest-dev
22:37 paramat joined #minetest-dev
22:51 book` joined #minetest-dev
23:11 Gael-de-Sailly joined #minetest-dev
23:15 AntumDeluge joined #minetest-dev

| Channels | #minetest-dev index | Today | | Google Search | Plaintext