Minetest logo

IRC log for #minetest-dev, 2017-12-06

| Channels | #minetest-dev index | Today | | Google Search | Plaintext

All times shown according to UTC.

Time Nick Message
02:24 ThomasMonroe joined #minetest-dev
03:33 ThomasMonroe joined #minetest-dev
04:01 ^v joined #minetest-dev
04:26 Puka joined #minetest-dev
05:41 torgdor joined #minetest-dev
06:08 Hunterz joined #minetest-dev
06:10 nerzhul joined #minetest-dev
06:31 Fritigern joined #minetest-dev
07:10 geospeck joined #minetest-dev
08:34 Darcidride joined #minetest-dev
08:42 troller joined #minetest-dev
08:57 ensonic joined #minetest-dev
09:44 geospeck joined #minetest-dev
10:20 nerzhul joined #minetest-dev
11:58 Jordach joined #minetest-dev
12:14 Fixer joined #minetest-dev
12:30 YuGiOhJCJ joined #minetest-dev
12:47 ThomasMonroe joined #minetest-dev
12:53 CBugDCoder joined #minetest-dev
13:23 geospeck joined #minetest-dev
13:27 lisac joined #minetest-dev
13:52 Taoki joined #minetest-dev
13:53 lisac joined #minetest-dev
13:59 Megaf The source to all macOS issues might just be because we are using a X server in macOS instead of using it's native "window server" https://github.com/minetest/minetest​/issues/2697#issuecomment-349647002
14:15 RobbieF joined #minetest-dev
14:15 RobbieF left #minetest-dev
14:37 compunerd joined #minetest-dev
14:39 antims joined #minetest-dev
15:05 geospeck joined #minetest-dev
15:06 lisac what happened to #6067?
15:06 ShadowBot https://github.com/minetest/minetest/issues/6067 -- [CSM] Add basic HUD manipulation. by red-001
15:23 nerzhul lisac, vanish
15:23 * lisac vanishes in a cloud of dust
15:58 MoNTE48 joined #minetest-dev
15:59 Krock joined #minetest-dev
16:19 Krock merging #4779 and #6741 in 10 minutes
16:19 ShadowBot https://github.com/minetest/minetest/issues/4779 -- Ensure no item stack is being held before crafting in inventory menu by lacc97
16:19 ShadowBot https://github.com/minetest/minetest/issues/6741 -- Auth handler: Player deletion & Iterator by sfan5
16:21 paramat joined #minetest-dev
16:21 paramat how about #4549 too Krock ?
16:21 ShadowBot https://github.com/minetest/minetest/issues/4549 -- Add coloured logs by HybridDog
16:21 paramat i was about to merge all 3
16:23 Krock of course
16:23 paramat \O/
16:29 lisac joined #minetest-dev
16:29 paramat simple PR just needs another +1 #6559
16:29 ShadowBot https://github.com/minetest/minetest/issues/6559 -- Set vertex color on upright sprites. by basicer
16:31 Krock will re-run failed xcode build for the colored logs PR before merging that one
16:35 Krock paramat, could you please tell me what meta field you would like to prevent from sending to the client in game#1968 ?
16:35 ShadowBot https://github.com/minetest​/minetest_game/issues/1968 -- Stairs: Code cleanup, improve descriptions. Locked chests: Mark meta as private by paramat
16:36 Krock none = no point in a mark_as_private call
16:38 rubenwardy Krock, I think he means to disable inventory sending
16:38 rubenwardy which I don't think has been implemented in the engine
16:39 paramat heh
16:40 sfan5 that's not implemented indeed
16:40 paramat i don't know what i'm doig there
16:40 paramat *doing
16:40 Krock then just remove that line and +1s will float in
16:41 paramat ok
16:43 paramat if i reduce player model animation speed to 10 or so the standing animation is much better, without affecting the speed of the other animations
16:50 paramat updated game#1968 removed meta commit
16:50 ShadowBot https://github.com/minetest​/minetest_game/issues/1968 -- Stairs: Code cleanup, improve descriptions. Locked chests: Mark meta as private by paramat
16:51 rubenwardy lgtm
16:59 paramat i'll merge that tomorrow with another PR, or something
17:02 paramat the other thing that bothers me about the player animation is the head turning left and right while walking, looks robotic
17:06 sfan5 Krock: my PR wasn't meant to be squashed
17:06 sfan5 but oh well ¯\_(ツ)_/¯
17:07 rubenwardy lol
17:08 paramat odd, the code suggests the player model 'animation speed' should affect all animations, but only affects standing (when seen in third person)
17:25 Puka joined #minetest-dev
17:30 Krock sfan5, uh sorry. Squashing was not explicitly mentioned in the PR and these are two features very near (code-wise) so I guess it's ok for this time :3
17:39 Darcidride_ joined #minetest-dev
17:44 Lone-Star joined #minetest-dev
17:46 Krock merging #4549 in 5 minutes. xcode throws a load of warnings, but they're due the build setup
17:46 ShadowBot https://github.com/minetest/minetest/issues/4549 -- Add coloured logs by HybridDog
17:47 rubenwardy XCode is all errors anyway
17:47 nerzhul joined #minetest-dev
17:47 geospeck joined #minetest-dev
17:52 rubenwardy 116 PRs!
17:55 rubenwardy that's down 24 in 102 days
17:56 rubenwardy not that great I guess. More impressive that 70% of PRs were opened this year
17:59 nerzhul rubenwardy, these days repo is quited :p
17:59 nerzhul but yes 0.5.0 is a very very huge release :p
18:00 rubenwardy repo is quited?
18:00 nerzhul quiet*
18:01 rubenwardy ah
18:01 rubenwardy it's mostly paramat and me aggressively closing PRs
18:01 rubenwardy but more pop up
18:01 rubenwardy quite a lot of the remaining ones are still quite useful, and worth adopting
18:02 rubenwardy It would be good to add "Improvement Needed" to any PRs which have been reviewed but no updated
18:02 rubenwardy that way devs can just look for PRs without that label to review
18:03 nerzhul rubenwardy, it's needed sometimes
18:04 rubenwardy huh?
18:20 paramat :) not really 'aggressively', dev guidelines are even stricter (close in 1 month if no author response), we're just being less overly soft :)
18:22 lhofhansl joined #minetest-dev
18:23 Hunterz joined #minetest-dev
18:24 paramat we're almost too soft for our own good :)
18:25 lhofhansl soft on what (missed the context)
18:25 lhofhansl ?
18:25 rubenwardy the reason we have so many PRs is because we were lax at reviewing them
18:25 rubenwardy so it's important to make sure that pr authors know where they stand
18:26 lhofhansl I agree. I was spending some time looking through last week... Too many! Either we should drive them forward or close them.
18:26 rubenwardy yeah
18:26 nerzhul paramat, 1 month is too close
18:26 nerzhul 6 months okay
18:27 rubenwardy I'd like to get down to 100 by new year's
18:27 rubenwardy nerzhul,  that's what the wiki says
18:27 lhofhansl I'd say one month with no response from the author should be enough to close it.
18:28 lhofhansl (can always be reopened :) )
18:29 lhofhansl Speaking of PRs. #6721 is ready this time.
18:29 ShadowBot https://github.com/minetest/minetest/issues/6721 -- Limit active object step time budget by lhofhansl
18:36 ensonic joined #minetest-dev
18:42 paramat anyway some PRs are marked as adoption needed, some of these will be closed if no interest
18:53 kilbith joined #minetest-dev
18:59 ensonic joined #minetest-dev
19:48 paramat joined #minetest-dev
20:06 lhofhansl going to merge #6721 in a few.
20:06 ShadowBot https://github.com/minetest/minetest/issues/6721 -- Limit active object step time budget by lhofhansl
20:15 troller joined #minetest-dev
20:40 troller joined #minetest-dev
20:47 book` joined #minetest-dev
20:47 MoNTE48 joined #minetest-dev
20:47 compunerd joined #minetest-dev
20:48 book` joined #minetest-dev
21:13 Fritigern joined #minetest-dev
21:14 ThomasMonroe joined #minetest-dev
21:38 troller joined #minetest-dev
21:39 Fritigern joined #minetest-dev
21:44 nerzhul joined #minetest-dev
22:01 Jordach joined #minetest-dev
22:01 TC01 joined #minetest-dev
22:01 thatgraemeguy joined #minetest-dev
22:01 garywhite joined #minetest-dev
22:07 thatgraemeguy joined #minetest-dev
22:07 thatgraemeguy joined #minetest-dev
22:27 Sokomine joined #minetest-dev

| Channels | #minetest-dev index | Today | | Google Search | Plaintext