Time Nick Message 01:38 lhofhansl Hi all. 01:38 lhofhansl Merging #6667 in a few. 01:38 ShadowBot https://github.com/minetest/minetest/issues/6667 -- Improve active object behavior - extend active object in view direction. by lhofhansl 01:57 lhofhansl Merged 6667 02:12 paramat oh ok, was going to anyway 02:13 paramat will merge #6650 #6628 in a moment 02:13 ShadowBot https://github.com/minetest/minetest/issues/6650 -- Zoom: Set zoom FOV per-player using a player object property by paramat 02:13 ShadowBot https://github.com/minetest/minetest/issues/6628 -- Android: Update build system for ndk-r16 by stujones11 02:13 basicer \o/ 02:14 ThomasMonroe yay 02:36 paramat merged 02:38 ThomasMonroe yay 02:52 paramat merging game#1956 02:52 ShadowBot https://github.com/minetest/minetest_game/issues/1956 -- Binoculars: Update to use 'zoom_fov' player property by paramat 02:57 paramat merged, down to 7 PRs =S 03:01 rubenwardy congrats 03:01 rubenwardy down to 100 PRs on minetest/minetest as a christmas present for everyone? :D 03:02 rubenwardy I really think #3818 should be replaced with an issue 03:02 ShadowBot https://github.com/minetest/minetest/issues/3818 -- Experiments and discussion about the main menu by celeron55 03:04 paramat agreed 03:04 paramat well, it sort of is an issue already 03:04 rubenwardy yeah, exactly 03:04 rubenwardy it's more something for discussion 03:04 paramat but maybe copy-paste into an issue? not sure if worth doing 03:05 paramat i somewhat cleared my engine backlog, now more time for MTG 03:06 rubenwardy Do you have a personal roadmap written somewhere? 03:06 rubenwardy or is it just private or stored mentally 03:07 paramat yes, i can link you to a gist in a few mins? 03:08 rubenwardy sure 03:08 rubenwardy I'm planning on writing mine out, and maybe doing some work over christmas 03:09 paramat https://gist.github.com/paramat/88efa9ab5375ac3f35dfce5167081f4a 03:09 paramat some are temporary simple things until better stuff comes 03:10 paramat like an ambience mod for fire and water sounds, until we have better engine code for that 03:10 paramat and a simple mob mod with 1 or 2 mobs, obviously later should be more, but .. 03:11 paramat i can't be bothered to write a complex mob mod with advanced AI etc. 03:11 paramat someone else can do that later 03:12 paramat volcanic rock is for my next mapgen (which i also need to work on) but will be ideal for lavacooling too, maybe 03:13 paramat the jungletree is a big one, mostly done too 03:14 paramat have spent many hours on a skins mod, need to work through the database more to select skins 03:19 paramat often we plan to do something in a complex way, adn because it's complex it doesn't get done. with some of these my approach is, better have something simple than nothing at all 03:19 paramat *and 03:23 rubenwardy yeah, sounds good 03:23 rubenwardy try and make it work with other mods 03:23 rubenwardy not sure how 03:30 paramat you mean the skins mod? work with non-mtg mods? 03:34 rubenwardy yeah, it should be possible for this MTG to set some players skins, and another mod to set other players skins 03:34 rubenwardy not quite show how 03:34 rubenwardy without requiring a skins.clear_choice(player) to be called by said mods 03:36 paramat hmm. well my skins mod is based on 'simple skins' almost identical 03:36 paramat but better =) 03:36 rubenwardy oh that's good 03:36 paramat i don't worry too much about non-mtg mods, everyone uses different mods, but if it can be done simply, sure 03:37 rubenwardy one of the aims of MTG is to be moddable 03:37 paramat anyway i'll open some PRs as some of these are half done 03:37 rubenwardy nice 03:37 rubenwardy jeez red-001 has a lot of PRs 03:38 rubenwardy about 9% his 03:42 paramat i'd just like some assurance he or nerz is going to work on server sent CSM 03:53 rubenwardy paramat, except for bug fixes which could be adopted, I think it might be worth closing PRs with no response from authors 03:53 rubenwardy the dev wiki even says this 03:53 rubenwardy there's been low adoption of old PRs 03:54 rubenwardy except for important issues, like irrlicht particles and meta-send bugs 03:54 rubenwardy also, might be worth reviewing this: https://github.com/minetest/minetest/labels/One%20approval 03:56 paramat agreed, closed PRs can always be reopened. how about close if no adoption interest in 1 month? 03:56 rubenwardy yeah, I guess 03:56 rubenwardy most have reacted that 03:57 paramat the guidelines say close if no response in a month, we're very lenient 03:57 rubenwardy yeah, exactly 03:58 rubenwardy closed #1845 03:58 ShadowBot https://github.com/minetest/minetest/issues/1845 -- Split block position in SQLite3 database by ShadowNinja 03:58 paramat ok, we could start with the oldest ones with the most negligence 03:58 paramat +1 03:59 rubenwardy #2604 is under a similar state 03:59 ShadowBot https://github.com/minetest/minetest/issues/2604 -- Add support for multiple listen addresses by ShadowNinja 03:59 rubenwardy heh, SN and nrzl are against closing 04:00 paramat close it 04:01 paramat it's getting ridiculous =) 04:02 paramat and SN isn't active 04:02 rubenwardy yeah 04:02 rubenwardy there's a bunch of c55 ones we should probably leave 04:02 rubenwardy it would be great to see the improved chunk sending algorithm 04:02 paramat keep the 'adoption needed' label for future searches 04:03 Hijiri #6688 is complete except the build system issue 04:03 ShadowBot https://github.com/minetest/minetest/issues/6688 -- Custom particle generators for particle spawners by raymoo 04:09 paramat i tend to start being stricter on PRs open for a year, after that i think we can do the 1 month thing 04:10 paramat being more strict may actually encourage authors to work on stuff 04:11 rubenwardy part of the problem is that PRs are neglected by core devs sometimes 04:12 rubenwardy other repos have bots which automatically add "needs review" labels whenever a commit is pushed. And "needs contributor response" when the a core dev proposes something 04:12 rubenwardy kinda spammy 04:14 rubenwardy closed #3818 04:14 ShadowBot https://github.com/minetest/minetest/issues/3818 -- Experiments and discussion about the main menu by celeron55 04:15 paramat hm good point about dev neglect, need to judge each case individually 04:15 paramat fine 04:15 paramat (for 3818) 04:17 rubenwardy #5592 is certainly a bit odd feeling 04:17 ShadowBot https://github.com/minetest/minetest/issues/5592 -- [WIP] Allow "drawtype:" in getIds() by Thomas--S 04:19 rubenwardy oooh 04:20 rubenwardy GitHub has a "First-time contributor" comment tag, that's useful 04:22 rubenwardy these are PRs that need reviews: is:pr is:open sort:created-asc -label:"improvement needed" -label:"wip" -label:"adoption needed" 04:22 rubenwardy oops 04:22 rubenwardy https://github.com/minetest/minetest/pulls?utf8=%E2%9C%93&q=is%3Apr+is%3Aopen+sort%3Acreated-asc+-label%3A%22improvement+needed%22+-label%3A%22wip%22+-label%3A%22adoption+needed%22 04:22 rubenwardy https://github.com/minetest/minetest/pulls?utf8=%E2%9C%93&q=is%3Apr+is%3Aopen+sort%3Acreated-asc+-label%3A%22improvement+needed%22+-label%3A%22wip%22+-label%3A%22adoption+needed%22+-label%3A%22action+needed%22 04:26 paramat ok 04:26 paramat i'll also try to go through some old and neglected ones 04:28 paramat sorry i think 6080 makes no sense 04:28 rubenwardy I'll reply in the issue as well, but tablets shouldn't find it too hard to use the full menu 04:29 paramat also see the commits, its a mess, unmergeable 04:29 rubenwardy but I'm not that stuck to it 04:29 rubenwardy can be squashed easily 04:29 rubenwardy stuck to it -> strongly opinioned 04:30 rubenwardy also, the review system is handy 04:31 rubenwardy gives nice bold "comments", and disables the merge button on disapprovals 04:32 paramat i'm just unsure it should have an approval yet, maybe after testing 04:32 rubenwardy #6080 04:32 ShadowBot https://github.com/minetest/minetest/issues/6080 -- Add option to change between full and simple main menu by PorygonZRocks 04:34 rubenwardy it was mostly trivial, but removed anyway 04:35 rubenwardy ha, #4549 had two approvals 04:35 ShadowBot https://github.com/minetest/minetest/issues/4549 -- Add coloured logs by HybridDog 04:36 rubenwardy just didn't update the labels 04:36 paramat duh 04:38 paramat #4772 can be closed in a few days, added a comment 04:38 ShadowBot https://github.com/minetest/minetest/issues/4772 -- [WIP] Hide map generators, warn about discouraged map generators and seed in world creation by subgame request by Wuzzy2 04:42 rubenwardy lol, we've gone down 20 reviews in 2.5 months 04:42 rubenwardy from 140 to 120ish 04:42 rubenwardy slow progress, but progress 04:45 paramat good, more reduction coming soon 04:45 rubenwardy I think it's much better to cut down on PRs than issues 04:46 rubenwardy lots of PRs are more likely to scare away contributors 04:46 rubenwardy anyway, I must sleep now. Night o/ 04:50 paramat good work 06:26 lhofhansl Ping on #6723 and #6721 06:26 ShadowBot https://github.com/minetest/minetest/issues/6723 -- Allow Irrlicht caching of animated meshes by lhofhansl 06:26 ShadowBot https://github.com/minetest/minetest/issues/6721 -- Limit active object step time budget by lhofhansl 20:13 sfan5 i wonder whether it was intended that paramats FOV changes break backwards compatibility 20:13 sfan5 i mean it's 0.5.0-dev but still mildly annoying 23:12 basicer Back down to 120 Pull Requests : ) 23:20 ThomasMonroe yay?