Time Nick Message 00:47 paramat thanks for 6708 00:47 rubenwardy :D 00:47 rubenwardy have you seen the bug in the comment? 00:47 rubenwardy it's a bug in master too 00:48 rubenwardy we only have 47 PRs older than this year 00:48 rubenwardy *only* 00:51 rubenwardy closed another one, duplicate of #6708 00:51 ShadowBot https://github.com/minetest/minetest/issues/6708 -- Add file and line to NodeDef field deprecation warning by rubenwardy 00:53 rubenwardy is Rogier-5 active anywhere? 00:56 paramat erm i don't understand the comment in 6708 00:57 paramat line 5 where? 00:57 rubenwardy in the code snippet 00:57 rubenwardy the comments indicate it 00:57 rubenwardy it gives the caller of the function that calls the deprecated function 00:57 rubenwardy not the line of the deprecated function 00:58 rubenwardy note that the NodeDef field warning points to the correct line 00:59 paramat oh i see 01:01 paramat however 'minetest.get_mapgen_params()' is deprecated, if that's relevant 01:02 rubenwardy that's the point lol :D 01:02 rubenwardy the PR is about deprecation messages 01:02 paramat "we only have 47 PRs older than this year" rising contributions and/or falling dev time 01:03 rubenwardy well, it means we've been fairly successful at closing old PR 01:04 paramat oh i was looking at 3957 which is about 'warn if field exists' 01:04 rubenwardy lol 01:05 paramat so i can't see how 6708 replaces it 01:05 paramat never mind, i don't understand 01:06 rubenwardy it's the suggestion given in the PR 01:06 rubenwardy 3957 adds a backtrace to warn fields 01:06 rubenwardy 6708 adds a file and line number to warn fields 01:06 rubenwardy warn fields is a function called when something in register_node is deprecated 01:06 paramat ahh 01:09 rubenwardy #6153 would be a shame to miss 01:09 ShadowBot https://github.com/minetest/minetest/issues/6153 -- Windows: Cpack wix installer by adrido 02:14 rubenwardy paramat, https://github.com/minetest/minetest/pull/6670#issuecomment-347729315 02:14 rubenwardy you'll like that 02:14 rubenwardy I voted against the first chat send PR, and it was rejected #5452 02:14 rubenwardy The PR was then remade when I was not around and merged: #5747 02:14 ShadowBot https://github.com/minetest/minetest/issues/5452 -- [CSM] Add send_chat_message() function by ronsoros 02:14 ShadowBot https://github.com/minetest/minetest/issues/5747 -- [CSM] Add send_chat_message and run_server_chatcommand API functions by paly2 02:17 paramat looking 02:19 paramat hmm 02:20 paramat 5452 didn't really have any support 02:21 rubenwardy none of them did 02:21 paramat considering the strength of feeling i think we have to take that into account and merge 6670 02:21 rubenwardy paramat, what do you think about merging #6709 with "flavor" 02:21 ShadowBot https://github.com/minetest/minetest/issues/6709 -- Spelling fixes for the client Lua API document. by BluebirdGreycoat 02:21 rubenwardy given the API is still flavor 02:21 rubenwardy *flavour 02:23 rubenwardy if this was a PR to add chat messages, and the thumbs was the other way around (3 up, 9 down) then it wouldn't be merged 02:23 paramat it's ok to merge, spelling mismatch between docs and code is not critical, and flavor will very likely be used in csm code soon 02:23 rubenwardy kk, merging now 02:24 rubenwardy done 02:26 rubenwardy lol paramat, approving after merge :D 02:28 paramat i'll add a comment to 6670 02:29 rubenwardy I wish http://dev.minetest.net/Client_scripting_plans was stuck to 07:00 nore IMHO, concerning #6662, we should give the choice to the user between downloading and installing mods manually (with a hash check to ensure the same mod runs on the server), or automatically from the server while the mod is signed by its author, giving the possibility to the user to trust some mod authors (and needing to individually accept mods that are not by these authors or are not signed) 07:00 ShadowBot https://github.com/minetest/minetest/issues/6662 -- CSM causes security issues 07:01 nore The rationale behind all that is that whatever sandbox we do, there will be a way, at some point, to escape it -- sandboxes *are* buggy 07:03 nore On the other hand, downloading mods separately by the client already implies trust in the given code - and malicious code can be far more easily detected and removed 07:03 nore (As with server-side mods) 07:06 ashtrayoz Might be OT, but: how do I get a voice on #minetest-hub? 07:16 jas_ ashtrayoz: ask Shara 07:17 jas_ (any op can give it to you, but shara can put you on the list.) 07:18 ashtrayoz jas_: thanks 07:22 ashtrayoz jas_: BTW (and mostly on topic), if your terminal needs engine support to preserve metadata, #6604 has been update with suggestions from sfan5 and paramat. It even has one thumbs-up :-) 07:22 ShadowBot https://github.com/minetest/minetest/issues/6604 -- Preserve node metadata as item metadata. by ashtrayoz 07:33 jas_ i keep meaning to test this, i will do so now (well, after my coffee is done making) 14:17 jas_ https://github.com/minetest/minetest/issues/6714 14:17 jas_ oops. #6714 14:17 ShadowBot https://github.com/minetest/minetest/issues/6714 -- minetest.sound_play Offset 14:17 jas_ (that's a feature request, hope it's ok.) 14:19 jas_ #6715 *steps away from github* 14:19 ShadowBot https://github.com/minetest/minetest/issues/6715 -- OpenAL device gets recreated each time the main menu is loaded. 14:20 kilbith https://www.youtube.com/watch?v=meWr1G7aO7E 14:21 kilbith !title 14:21 ShadowBot kilbith: Error: That URL appears to have no HTML title within the first 4KB. 14:26 jas_ n1 kilbith, now if only one could literally scroll inventory lists! ha 14:27 kilbith soon (tm) 14:37 nerzhul is this me or the CSM debate is ridiculous because solution is in tree since months, but we just don't have release MT ? 22:34 Hijiri anyone know how to fix this build failure https://travis-ci.org/minetest/minetest/builds/307565206?utm_source=github_status&utm_medium=notification 22:35 Hijiri also is there a current planned API for remote CSM? By that, I mean specific functions, architecture etc. 22:35 Hijiri I was under the impression that it would be file-based like current server and local CSM, but BBGC suggested a simpler API where the server just sends code strings to execute on the client 22:36 Hijiri Or maybe it was the server registers code strings to be sent to the client 22:37 Hijiri That would make more sense, since you could isolate script environments by mod (though you would want to provide some other way of interoperation) 22:41 Hijiri From what I can tell particles.cpp isn't built before it's needed by the linker