Time Nick Message 05:22 Hijiri they don't 05:23 Hijiri there are crafting callbacks though 05:23 Hijiri but no inventory callbacks 06:25 Anastasis Just a heads-up. In latest git, the file `src/CMakeFiles/minetest.dir/nodedef.cpp` failed to compile saying something like that there was no such thing as std::fmax(...). All I had to do to get it to build is add `#include ` at the top of that file. 06:26 Anastasis Sorry I got the file path wrong. 06:26 Anastasis `src/nodedef.cpp` 06:30 nerzhul hi Anastasis can you send a PR on github ? 06:49 paramat ah it was the global textures PR. thanks 07:27 paramat or if not a PR please open an issue to remind us 18:11 sfan5 paramat: can you "properly" review (as in approve) game#1921? 18:11 ShadowBot https://github.com/minetest/minetest_game/issues/1921 -- Add loot to dungeons by sfan5 18:37 paramat i will review it. you don't want to detect ice dungeons? could put snow in chests =) 18:38 sfan5 considering how rare those are (didn't ever find one) might as well put a chest full of mese 18:38 sfan5 so no it's not important to me right nowq 18:39 nerzhul sfan5, oh nice game improvement :) 18:39 nerzhul sfan5, i hope at a point we can have nice under mines too :D 18:40 sfan5 mineshafts are harder to implement so i didn't do those :P 18:42 paramat ok so ice dungeons fallback to normal, that's ok for me. i'll review asap 18:43 paramat #6519 is updated as requested and retested, i just need to improve the commit message 18:43 ShadowBot https://github.com/minetest/minetest/issues/6519 -- Biome API: Add underground decorations by paramat 18:46 sfan5 paramat: they won't actaully because ice is not a valid wall node 18:49 sofar code looks OK, +1 from me (went over it line by line) 18:49 sofar remember to remove the chat_send_all on merging :) 18:52 sfan5 you mean i can keep the torch placement? ;) 18:53 paramat ah ok, no problem 18:54 paramat +1 for #6552 18:54 ShadowBot https://github.com/minetest/minetest/issues/6552 -- Reduce server FOV with forward speed. by lhofhansl