Time  Nick          Message
10:06 nerzhul       helo :) merging #6411 in ~ 10 mins
10:06 ShadowBot     https://github.com/minetest/minetest/issues/6411 -- Customizeable max breath for players by SmallJoker
10:06 nerzhul       and #6414
10:06 ShadowBot     https://github.com/minetest/minetest/issues/6414 -- ServerEnv: Clean up object lifecycle handling by sfan5
10:19 sfan5         thanks for merging
10:20 nerzhul       no problem it's a review + button click :p
10:20 nerzhul       i don't see side effects on your PR, i hope ther ewill be not, this part is a little bit tricky but cleaner now
10:22 sfan5         i tried to test it as good as i could
10:25 nerzhul       :Ã
10:25 nerzhul       :)
12:03 nerzhul       merging #6413 in ~ 10 mins
12:03 ShadowBot     https://github.com/minetest/minetest/issues/6413 -- Add setting to display the itemstring after the tooltip in the inventory. by DTA7
12:07 thePalindrome Looking for opinions: Is "pitch shifting too far results in artifacts" worth opening an issue over?
12:08 thePalindrome If I shift part of the way in, say, audacity, the artifacts aren't present
12:08 thePalindrome Not sure if it's anything to do with minetest, or if it's openal
12:12 asl97         nerzhul: what about the other m_selected_item != NULL around the code?
12:12 asl97         change them all?
12:13 nerzhul       oh no, just do it in your modification, no need to refactor the whole code, it will make review difficult
12:29 thePalindrome Nvm my question, I need to submit an issue, this has gotten out of hand. Computing the pitch causes artifacts, whereas setting it as a constant with the same value, removes the artifact
12:37 asl97         nerzhul: imo, changing it just at that one location doesn't looks good but if that's how you want it.  ps, rebased.
13:24 jas_          *whistles*
13:26 jas_          https://gist.github.com/jastevenson303/35578fef0ff171fe22ba0a012b5a2be6
13:35 jas_          sfan5: something changed and i'm not sure what yet.  i tried to return on nil, but another nil popped up.  this is new, so i'm hesitant to try to fix my modding?
13:35 jas_          i can try first to take out commit that might be causing it
13:35 sfan5         how am i related to this
13:36 jas_          sorry
13:36 thePalindrome I'd try bisecting first, it'd be a lot easier to get it fixed ;)
13:37 jas_          hm i gotta man git-bisect then
13:44 thePalindrome git help bisect accomplishes the same
13:49 jas_          i do apologize!  i changed minetest.PLAYER_MAX_BREATH to minetest.PLAYER_MAX_BREATH_DEFAULT and all is well
13:50 jas_          (is there supposed to be an alias krock? or it's ok.)
20:41 Fixer         noticed some ultra slight shakinness when standing on entity like cow
20:48 sfan5         not new
23:32 rubenwardy    paramat, is there an issue about adding a get_biome(pos) function?
23:33 paramat       yes, i saw it last night, will add the feature for 0.5.0
23:34 paramat       it will return heat, humidity and biome at pos
23:34 rubenwardy    good, it's quite needed
23:34 paramat       very much