Time  Nick        Message
00:39 ShadowNinja red-001: ATM there is none.  My personal preference is that you don't use it for simple types like int or const char**, but use it for long yet obvious types like iterators.
07:28 nerzhul     i agree with ShadowNinja auto is useful for long types, trivial types can easily being written
07:34 nerzhul     can some coredev take time to review the PR, please... there are many good PR opened which needs approval/review...
07:34 nerzhul     red-001, can you fix #6066
07:34 ShadowBot   https://github.com/minetest/minetest/issues/6066 -- Move the code for taking and saving a screenshot to `RenderingEngine` by red-001
08:30 Krock       merging game#1812
08:30 ShadowBot   https://github.com/minetest/minetest_game/issues/1812 -- Carts: Do not connect rails with gunpowder by SmallJoker
08:39 paramat     Krock please could you review/approve game#1810 ? now tested
08:39 ShadowBot   https://github.com/minetest/minetest_game/issues/1810 -- Mapgen: Completely separate mgv6 ore registrations by paramat
08:40 Krock       okay, righht after 1808
08:40 paramat     1810 is fairly trivial actually
08:46 paramat     looking at our ore registrations it's amazing how shallow valuable ores are, all except mese block are above y = -128. the 3D tunnels mean you can easily walk to that depth
08:53 paramat     so as described here https://github.com/minetest/minetest_game/issues/1168#issuecomment-310882521 i would like to make them deeper in non-mgv6 mapgens, and with a better depth progression with value
09:03 Krock       but the "make deeper" isn't part of this PR - the ore params are the same
09:03 Krock       copypasta - trivial and LGTM
09:13 paramat     yes no change. thanks
09:16 Krock       np
09:18 paramat     and your sneak PR seems good now
09:21 Dumbeldor   paramat i go into your country :D
09:21 Dumbeldor   Cambridge !
09:24 paramat     welcome
09:32 paramat     Krock if possible could you add your opinion in game#1777 ?
09:32 ShadowBot   https://github.com/minetest/minetest_game/issues/1777 -- Crafting: Remove duplicate reversed recipes by paramat
09:32 paramat     i believe it was -1
09:38 Nox[Matrix] Rails with gunpowder?
09:40 Krock       neutral
09:41 paramat     ok
09:41 Krock       Nox[Matrix], yes. Let it burn and get warm feet while driving
09:42 Krock       the TNT node(s) at the end of the railway may cause permanent damage, so beware
09:43 paramat     Nox the 'continuous climb' idea is nice, we already have a 'continuous forward' key, maybe if on a ladder that could lock the current direction (up or down). not sure of the best implementation
09:45 Nox[Matrix] paramat: where the moon and the sun removed?
09:46 paramat     that's a bug on android
09:47 Nox[Matrix] Oh
09:48 Nox[Matrix] paramat: if it's known it's alright... It's not that important
09:48 Nox[Matrix] paramat: didn't know that we have a continuous forward key
09:50 paramat     sun and moon are important. the key is undefined by default, you have to assign it in .conf or advanced settings
09:51 paramat     i can't dev without it now, good for the hands
09:51 paramat     the key is named 'autoforward'
09:52 Nox[Matrix] paramat: I think on Android it's not possible?
09:54 Nox[Matrix] paramat: also yeah, the sun and the moon are important but right now it's not breaking the gameplay,
09:55 Nox[Matrix] The gameplay is for me the most important thing, and right now it's getting better
09:57 paramat     oh of course, touchscreen, bleah
09:58 paramat     DS-minetest did you test game#1786 ?
09:58 ShadowBot   https://github.com/minetest/minetest_game/issues/1786 -- add backface_culling to open chests and fencegates by DS-Minetest
09:58 paramat     oh ok
09:58 DS-minetest yes
09:59 paramat     just saw
09:59 DS-minetest heh
09:59 paramat     will merge with 1810 in a few mins
10:00 paramat     aargh need another +1
10:00 paramat     Krock ?^
10:00 paramat     game#1786
10:00 ShadowBot   https://github.com/minetest/minetest_game/issues/1786 -- add backface_culling to open chests and fencegates by DS-Minetest
10:00 paramat     or nore rubenwardy
10:02 DS-minetest I don't fully understand why the
10:02 DS-minetest oops
10:03 DS-minetest I don't fully understand why the reason why the mirrored recipes should be removed, no other mod will create a recipe of an existing item just mirrored
10:03 DS-minetest normally
10:03 Krock       paramat, where exactly is the profit of enabling backface culling?
10:04 paramat     i see none too, but this is to be consistent with 7b46d3b6afa7c14a6ed26368820334b1adfc5e4d
10:05 paramat     game#1764
10:05 DS-minetest Krock: I think, it's about performance since else the faces would have to be drawn twice
10:05 ShadowBot   https://github.com/minetest/minetest_game/issues/1764 -- Adding backface culling to stairs by MrRar
10:05 Krock       well then, whatever.
10:05 paramat     oops misunderstood
10:06 paramat     yes possible render perormance, also to be consistent with slabs which automatically have backface culling
10:07 paramat     so +1?
10:11 paramat     *performance
10:14 paramat     ~tell sfan5 https://github.com/minetest/minetest/pull/5533 seems good now, are you able to +1?
10:14 ShadowBot   paramat: O.K.
10:16 paramat     ~tell sfan5 are you ok with https://github.com/minetest/minetest_game/pull/1786 now?
10:16 ShadowBot   paramat: O.K.
10:17 paramat     sorry Krock was that 'whatever' a +1?
10:20 Krock       paramat, yes. Even if the improvement is minimal, the code looks good
10:22 paramat     ok good
10:24 paramat     i'll merge game#1070 game#1786 game#1810 in the next few mins
10:24 ShadowBot   https://github.com/minetest/minetest_game/issues/1070 -- Add placer's player name to tnt node metadata by jhcole
10:24 ShadowBot   https://github.com/minetest/minetest_game/issues/1786 -- add backface_culling to open chests and fencegates by DS-Minetest
10:24 ShadowBot   https://github.com/minetest/minetest_game/issues/1810 -- Mapgen: Completely separate mgv6 ore registrations by paramat
10:33 Krock       paramat, 1070 is quite controversial
10:36 Krock       hmm.. actually I can't see any reason to not merge it
10:36 paramat     phew
10:36 paramat     merging in a moment
10:36 Krock       stalling PRs is not what we want so let's merge it, yes
10:44 paramat     i was unsure about 1070 at first but that was my misunderstanding
10:44 paramat     oh, merged btw
10:45 paramat     now i can work on ore distribution
10:46 Nox[Matrix] paramat: thank you for working so hardly
12:11 paramat     Krock if possible could you review/approve #6051 ? simple and tested
12:11 ShadowBot   https://github.com/minetest/minetest/issues/6051 -- Dungeons: Add setting to prevent projecting dungeons by paramat
12:15 Krock       LGTM
12:15 paramat     thanks
12:18 Krock       I'm not a specialist in mapgen, thus I believe that's the best solution
12:19 Krock       oh, you ninja'd me :P
12:27 paramat     will merge #6051 #6071 in a few mins
12:27 ShadowBot   https://github.com/minetest/minetest/issues/6051 -- Dungeons: Add setting to prevent projecting dungeons by paramat
12:27 ShadowBot   https://github.com/minetest/minetest/issues/6071 -- Camera: Improve arm inertia by kilbith
12:37 paramat     merging
12:40 paramat     done
13:54 Fixer       https://github.com/minetest/minetest/pull/4425
13:54 Fixer       everyone forgot about this too
14:17 red-001     #4425
14:17 ShadowBot   https://github.com/minetest/minetest/issues/4425 -- Assertion failure: sanitize some values obtained from mods (yaw, velocity, etc.) by Rogier-5
17:08 Nox[Matrix] Why is it possible to place ladders on the ground
17:10 nerzhul     hello coredevs and non coredevs !
17:10 kilbith     heil
17:12 nerzhul     i'm not german, maybe talk to sfan5 :p
17:13 Nox[Matrix] kilbith: or me
17:31 Nox[Matrix] nerzhul: didn't know that sfan5 (IRC) speaks German
17:40 Fixer       Nox[Matrix]: why not?
17:40 Fixer       Nox[Matrix]: you can place them so IRL too
17:43 Nox[Matrix] Fixer: kek
17:43 Nox[Matrix] Fixer: yeah but floating over them is not possible
17:43 jcalve      not with that attitude
17:47 Fixer       falling through stairs in 2017
17:47 Fixer       and slabs
18:23 nerzhul     merging #6088 in ~5 mins
18:23 ShadowBot   https://github.com/minetest/minetest/issues/6088 -- Irrlicht cleanup: cleanup various object to use RenderingEngine by nerzhul
18:26 rubenwardy  Unit Test Results: PASSED  woo
18:26 rubenwardy  #5176
18:26 ShadowBot   https://github.com/minetest/minetest/issues/5176 -- Use JSON serialize to store ItemStack Metadata by rubenwardy
18:34 rubenwardy  pushed another test
18:34 rubenwardy  ShadowNinja,
19:34 rubenwardy  #6091
19:34 ShadowBot   https://github.com/minetest/minetest/issues/6091 -- Revert "[CSM] Add send_chat_message and run_server_chatcommand" by rubenwardy
19:43 nerzhul     your revert is wrong you revert C++11 converted constructors
19:44 nerzhul     and also there is a flavour PR which permits to control this which waits for some discussions about map.
19:46 rubenwardy  I don't think the "feature" is ever warranted, though
19:46 nerzhul     it depend on the usecase
19:46 nerzhul     for regular server owners flavour (when merged) permit to limit that (disable it)
19:47 nerzhul     but you can have other usecases, for example developing discussion bots inside minetest ? :)
19:47 nerzhul     it's a good educational case
19:47 rubenwardy  no, CSM really shouldn
19:47 rubenwardy  no, CSM really shouldn't be for that
19:47 nerzhul     CSM shouldn't do anything if i listen everybody, jsut remove it then ?
19:47 rubenwardy  for the usecase of educational bots, use CSM
19:47 rubenwardy  *SSM
19:48 nerzhul     SSM has no sense
19:48 nerzhul     you need only 1 server and multiple clients to discuss together and react on their clients :p
19:49 nerzhul     but this API is limited by server and client with a rate limit
19:49 nerzhul     now just finish flavour PR (waiting for inputs on node getters to finish it) and server owners can disable it
20:04 rubenwardy  ShadowNinja, would it be possible to make it so ShadowBot automatically posts issues and PRs here when they're created?
20:05 nerzhul     can be nice yes
20:25 nerzhul     pushing a fix for #6092
20:25 ShadowBot   https://github.com/minetest/minetest/issues/6092 -- Game crashes when up or down arrow keys are pressed while in pause menu
20:25 nerzhul     it's just a null pointer not checked