Time Nick Message 00:42 paramat will merge #6025 #6035 in a moment 00:42 ShadowBot https://github.com/minetest/minetest/issues/6025 -- Mgvalleys: Use existing 'lava_max_height' value in CavesRandomWalk by paramat 00:42 ShadowBot https://github.com/minetest/minetest/issues/6035 -- Mgv7: Avoid divide-by-zero errors by paramat 00:51 paramat merging 00:54 sfan5 one of the backface_culling prs is also ready 00:56 paramat yeah good, am tired though, maybe tomorrow 00:56 paramat complete 02:04 ShadowNinja I'll be pretty busy tomorrow, so I don't know if I'll have time for the meeting. If anyone else can handle it just let me know. 03:30 ThomasMonroe goodnight everyone 03:30 bigfoot547 Bye 09:43 nerzhul erf 09:44 nerzhul i pushed a trivial fix to wrong upstream (i would use a PR but failed)... seee #8a84e8992231e934c1276ba9b43a9eeaa7184b59 09:44 nerzhul https://github.com/minetest/minetest/commit/8a84e8992231e934c1276ba9b43a9eeaa7184b59 09:45 nerzhul s/fix/change/ 11:26 nerzhul hello 11:26 nerzhul merging #6036 in ~5 mins 11:26 ShadowBot https://github.com/minetest/minetest/issues/6036 -- C++11 cleanup on constructors guiEngine by Dumbeldor 11:28 red-001 nerzhul, could you re-review #6032? 11:28 ShadowBot https://github.com/minetest/minetest/issues/6032 -- Load texturepacks from the `textures` subfolder of subgames. by red-001 11:47 Krock nerzhul, mind also looking at #5973 quickly? It's a fix for entities glitching through nodes sometimes. The __builtin:item glitch has the root in the builtin code itself, which I'd like to have cleaned up first 11:47 ShadowBot https://github.com/minetest/minetest/issues/5973 -- LuaEntity: Depend collision on entity size by SmallJoker 11:47 Krock before modifying anything there 11:49 nerzhul Krock, if i correctly understand you remove the harcoded size for SAO and use the real properties, right ? 11:50 Krock correctly 11:50 nerzhul it seems CAO & SAO changes are very similar, maybe having a helper function to factorize code can be nice 11:51 Krock merging these two with a class would be desirable but the annoying part is that they differ in small areas 11:53 nerzhul okay 11:55 nerzhul and the removal of the -1 returns permits to have correct limits ? 11:57 Krock no, they're there to prevent from blocking out other cases 11:57 nerzhul why removing them ? 11:58 nerzhul they shoulds lgtm no? 11:58 Krock i.e. if there are two colliding sides, then the "else" case won't block out the other axis checking too 11:58 Krock moment 12:01 Krock apparently removing these return -1 doesn't do anything, as all axis are checked against colliding in each case 12:02 nerzhul okay 12:02 nerzhul we will see if this is a real problem later, i don't know the current behaviour 14:16 Krock Rather important fix to prevent from item loss: #6039 14:16 ShadowBot https://github.com/minetest/minetest/issues/6039 -- Inventory: Fix wrong stack size behaviour and item loss by SmallJoker 17:23 juhdanad #5870 is simple and has one approval. Could you review it, please? 17:23 ShadowBot https://github.com/minetest/minetest/issues/5870 -- Helper methods for hardware colorization by juhdanad 17:25 kilbith could you become a core-dev, please? 18:08 nerzhul merging #5870 in ~5 mins 18:08 ShadowBot https://github.com/minetest/minetest/issues/5870 -- Helper methods for hardware colorization by juhdanad 18:08 nerzhul and the trivial #6040 18:08 ShadowBot https://github.com/minetest/minetest/issues/6040 -- Emit liquid sound if the player walks in liquid by juhdanad 19:35 red-001 Because I want to go on #minetest-dev and ask for #5797 to be re-reviewed. 19:35 ShadowBot https://github.com/minetest/minetest/issues/5797 -- [CSM] Add function to set the FOV of the local player by bigfoot547 19:58 Dumbeldor Hi, can this be reviewed again, please ? #5793 19:58 ShadowBot https://github.com/minetest/minetest/issues/5793 -- [CSM] Add callback on open inventory by Dumbeldor 22:18 kilbith arm inertia wip: https://www.youtube.com/watch?v=ls9vxBTr0hg 22:19 kilbith ^ VanessaE