Minetest logo

IRC log for #minetest-dev, 2017-06-09

| Channels | #minetest-dev index | Today | | Google Search | Plaintext

All times shown according to UTC.

Time Nick Message
00:18 Tmanyo joined #minetest-dev
00:26 srifqi joined #minetest-dev
00:38 srifqi joined #minetest-dev
00:39 twoelk|2 left #minetest-dev
01:10 srifqi joined #minetest-dev
01:37 CalebDavis joined #minetest-dev
02:17 srifqi joined #minetest-dev
02:18 Puka joined #minetest-dev
02:19 AntumDeluge joined #minetest-dev
02:41 AntumDeluge joined #minetest-dev
03:04 behalebabo joined #minetest-dev
03:05 johnnyjoy joined #minetest-dev
03:50 srifqi joined #minetest-dev
04:30 srifqi joined #minetest-dev
04:34 QwertyDragon joined #minetest-dev
04:36 srifqi joined #minetest-dev
05:01 srifqi joined #minetest-dev
05:07 Hunterz joined #minetest-dev
05:09 srifqi joined #minetest-dev
05:18 srifqi joined #minetest-dev
05:29 nerzhul joined #minetest-dev
05:33 srifqi joined #minetest-dev
05:51 Fritigern joined #minetest-dev
06:58 Megaf joined #minetest-dev
07:12 book` joined #minetest-dev
07:31 QwertyDragon joined #minetest-dev
07:35 kilbith joined #minetest-dev
07:38 YuGiOhJCJ joined #minetest-dev
08:09 est31 joined #minetest-dev
08:15 Zeno` joined #minetest-dev
08:44 YuGiOhJCJ joined #minetest-dev
09:28 QwertyDragon joined #minetest-dev
09:32 jin_xi joined #minetest-dev
09:46 nerzhul joined #minetest-dev
09:46 nerzhul sfan5, are you there ?
09:46 nerzhul (hi)
09:48 Zeno` joined #minetest-dev
09:56 sfan5 nerzhul: yes
10:02 nerzhul sfan5, the buildbot script trigger exit 1 on gitlab
10:02 nerzhul i should change the last step
10:02 sfan5 uh?
10:02 nerzhul https://gitlab.com/nerzhul​/minetest/builds/18267618
10:02 nerzhul seems [ "x$NO_PACKAGE" = "x" ] && make package return 1
10:03 sfan5 yeah thats normal bash behaviour
10:03 sfan5 add exit 0 to the end
10:03 nerzhul yeah
10:03 nerzhul but if package fail it will success :)
10:03 sfan5 no because of -e
10:03 nerzhul if [] make package else exit 0 fi is better no ?
10:03 sfan5 no
10:03 nerzhul set -e don't exec the exit 0 ?
10:04 nerzhul if outside of condition i mean
10:04 sfan5 set -e will cause it to fail if make package fails
10:04 nerzhul nice
10:04 sfan5 it won't reach the exit 0
10:04 nerzhul then i will just push a little exit 0 at the end
10:04 sfan5 yea
10:05 nerzhul i pushed the fix
10:06 johnnyjoy joined #minetest-dev
10:30 DS-minetest joined #minetest-dev
10:58 Raven262 joined #minetest-dev
11:09 Fritigern joined #minetest-dev
11:18 cd2 joined #minetest-dev
11:41 Fixer joined #minetest-dev
11:44 CalebDavis joined #minetest-dev
11:52 calculon joined #minetest-dev
12:03 nerzhul joined #minetest-dev
12:11 Taoki joined #minetest-dev
12:18 behalebabo joined #minetest-dev
12:19 johnnyjoy joined #minetest-dev
12:25 behalebabo joined #minetest-dev
12:26 Darcidride joined #minetest-dev
12:30 johnnyjoy joined #minetest-dev
12:41 Taoki joined #minetest-dev
12:51 cx384 joined #minetest-dev
13:12 Wayward_One joined #minetest-dev
13:14 RobbieF joined #minetest-dev
13:20 nerzhul sfan5: can we merge #5917 ? it needs one more review, i'm okay with this
13:20 ShadowBot https://github.com/minetest/minetest/issues/5917 -- CSM: Fix documentation error for register_on_*_chat_messages by DS-Minetest
13:21 sfan5 doesn't that break backwards compat
13:24 nerzhul backward compat with CSM declared as API can change ? :p
13:24 nerzhul no backward compat on CSM it's declared no stable in 0.4.16
13:27 sfan5 okay then
13:28 nerzhul nice merging in ~10 mins
13:37 DS-minetest joined #minetest-dev
13:53 antims joined #minetest-dev
13:56 kilbith joined #minetest-dev
13:56 kilbith dynamic light wip: https://lut.im/jWf4JNdlwM/Ri8T4jtjF7a534Qb.png
13:57 Calinou is that just god rays?
14:13 nerzhul sounds to be another minetest, i hope you can share the code with us else no interest on -dev because there is no code to review :)
14:15 kilbith I don't intend to backport it
14:16 nerzhul then don't share it, it's the minetest dev here, not fork dev
14:17 nerzhul choose #minetest or other chan
14:31 Zeno` joined #minetest-dev
14:40 DS-minetest joined #minetest-dev
14:41 johnnyjoy joined #minetest-dev
15:07 behalebabo joined #minetest-dev
15:40 Player_2 joined #minetest-dev
15:52 twoelk joined #minetest-dev
16:27 CalebDavis joined #minetest-dev
16:30 johnnyjoy joined #minetest-dev
16:48 Krock joined #minetest-dev
16:55 Hunterz joined #minetest-dev
17:18 red-001 Krock, are you ok with #5852 now?
17:18 ShadowBot https://github.com/minetest/minetest/issues/5852 -- Improve the path select GUI by red-001
17:18 red-001 I fixed the line
17:18 nerzhul red-001: did you fix the other pr i commented today ?
17:18 nerzhul (network striptease on chat)
17:19 red-001 @red-001remove temp var
17:20 nerzhul yeah it's that
17:20 nerzhul it seems you talk to yourself, i do it sometimes :p
17:21 nerzhul @nerzhul hey
17:21 nerzhul maybe i'm crazy, but i'm too young to be crazy
17:23 Raven262 One can't be too young to be crazy.
17:24 Raven256 I agree
17:24 Raven256 it's never too early
17:25 Raven262 Yeah
17:25 Krock Raven262, yes that PR looks good now
17:25 Raven262 Too bad that the main part of my name is the number, not the noun
17:28 Raven262 Wait is the next minetest version planned to be 0.5?
17:29 corvo272 maybe
17:29 corvo272 we might get a 0.4.17
17:29 Raven262 Ok
17:29 corvo272 since 0.5 might break a lot of old stuff
17:29 Corvus262 Damn
17:30 Corvus262 I was kinda hoping for 0.5
17:30 Corvus262 Idk why, probably no reason at all, just it would seem that some greater progress was made.
17:39 nerzhul Krock: can you review #5950 please ?
17:39 ShadowBot https://github.com/minetest/minetest/issues/5950 -- Fix sending color codes to clients that don't support them. by red-001
17:40 nerzhul atm 0.5 doesn't break anything exception compilator for non C++11 compiler , then data is not affected :p
17:55 Krock nerzhul, how about the code style guidelines for >=C++11 for-loops?
17:56 Krock Those from the Linux kernel say that there have to be spaces around + - * / and :  (more too)
17:57 corvo266 we need to decide if we just want a space after the : or also before
17:58 ShadowNinja Before and after.
18:08 YuGiOhJCJ joined #minetest-dev
18:15 Krock okay. nerzhul: corrected it & approved
18:19 kilbith joined #minetest-dev
18:28 nerzhul Krock: but Linux kernel doesn't have for range based loops :p
18:28 Puka joined #minetest-dev
18:29 Krock nerzhul, still, we use their style guidelines
18:29 nerzhul if you can merge it, please do it , i will be back in some hours (maybe) heh
18:32 Krock merging in 15 mins
18:33 nerzhul i added the discussion in the meeting heh :)
18:45 YuGiOhJCJ joined #minetest-dev
19:05 est31 left #minetest-dev
19:05 Thomas-S I think that MeshMakeData::fill(MapBlock) isn't used anywhere. Can someone confirm this?
19:10 PsychoVision joined #minetest-dev
19:13 Nobody joined #minetest-dev
19:20 corvo266 Krock, updated #5948 to address your comment
19:20 ShadowBot https://github.com/minetest/minetest/issues/5948 -- Add a server-sided way to remove color codes from incoming chat messages by red-001
19:21 Krock you change your name too often
19:21 Krock corvo266, minetest.conf.example doc missing
19:24 corvo266 is it meant to regenerated for all PR's?
19:29 Thomas-S As far as I know, the autogeneration of minetest.conf.example doesn't work correctly at the moment. I think you have to manually update it all the time.
19:30 corvo266 Thomas-S, it was fixed
19:31 Krock corvo266, it's more or less just copypasta. They both should be kept synced
19:31 Thomas-S Oh, ok. Thanks for the information!
19:33 johnnyjoy joined #minetest-dev
19:47 Wuzzy joined #minetest-dev
19:49 Wuzzy Why is there a minetest.after delay of 0.2 seconds in on_rightclick in the Minetest Game chest?
19:49 Wuzzy Why not just calling show_formspec directly?
19:49 kilbith I guess because it's for showing the opening animation first
19:51 kilbith !seen sofar
19:51 ShadowBot kilbith: I saw sofar in #minetest-dev 2 weeks, 6 days, 22 hours, and 46 seconds ago saying "shrug, your loss :P"
19:53 Wuzzy also, this code looks like its asking for a crash :)
19:53 Wuzzy i wonder what happens if clicker disappears in the 0.2 seconds time frame :)
19:54 kilbith it always smell a hack whenever you spot a minetest.after
19:54 Wuzzy exactly!
19:55 Wuzzy you must be very careful when using minetest.after, esp. when juggling with player objects
19:55 Wuzzy i had o many crashes thanks to that already :D
19:55 kilbith segfaulting even
19:56 rubenwardy it's a common mistake to persist player objects between callbacks, even in local scope
19:58 Wuzzy sooo...
19:58 Wuzzy is it true what kilbith said?
19:58 Wuzzy 0.2 delay only for animation? so it is not *really* needed?
19:59 kilbith I assume the intention was to mimick MC here
19:59 Wuzzy by the way: https://github.com/minetest/minetest/issues/5488
20:01 AntumDeluge joined #minetest-dev
20:01 behalebabo joined #minetest-dev
20:08 johnnyjoy joined #minetest-dev
20:19 Wuzzy sfan5: speaking of chests.. any input on this one?: https://github.com/minetest/minetest/issues/5894
20:19 sfan5 idk
20:19 sfan5 sounds like a bug at block boundaries
20:20 Wuzzy yeah, that was my guess too. those number look suspicious :)
20:20 Wuzzy but i also really have no idea whats going on
20:23 behalebabo joined #minetest-dev
20:25 johnnyjoy joined #minetest-dev
20:32 Wuzzy sfan5: iiiiinteresting..... I just noticed that when you do meta:set_string("infotext", "bla")  in on_construct, the bug does not occour.
20:38 RobbieF left #minetest-dev
20:47 johnnyjoy joined #minetest-dev
20:59 CalebDavis joined #minetest-dev
20:59 Fixer joined #minetest-dev
21:03 DS-minetest joined #minetest-dev
21:10 jsgrant_ joined #minetest-dev
21:14 nerzhul joined #minetest-dev
21:16 johnnyjoy joined #minetest-dev
21:26 Miner_48er joined #minetest-dev
21:44 _god_ joined #minetest-dev
21:47 so_this_broke joined #minetest-dev
21:47 so_this_broke joined #minetest-dev
22:24 bigfoot547 joined #minetest-dev
22:35 twoelk|2 joined #minetest-dev
22:36 bigfoot547 left #minetest-dev
22:37 bigfoot547 joined #minetest-dev
23:03 jin_xi joined #minetest-dev
23:41 jsgrant_ joined #minetest-dev

| Channels | #minetest-dev index | Today | | Google Search | Plaintext