| Time |
Nick |
Message |
| 00:47 |
|
garywhite joined #minetest-dev |
| 01:32 |
|
ratmix joined #minetest-dev |
| 02:04 |
|
Tmanyo joined #minetest-dev |
| 02:32 |
|
Miner_48er joined #minetest-dev |
| 02:58 |
|
est31 joined #minetest-dev |
| 03:18 |
|
Hunterz joined #minetest-dev |
| 05:02 |
|
Zeno` joined #minetest-dev |
| 05:03 |
|
Hunterz joined #minetest-dev |
| 05:04 |
|
nerzhul joined #minetest-dev |
| 05:11 |
Zeno` |
should red-001 be added as a contributor? He has a bucket load of commits |
| 05:11 |
Zeno` |
https://github.com/minetest/minetest/commits/master?author=red-001 |
| 05:12 |
Zeno` |
Seems like he should be added to me |
| 05:21 |
nerzhul |
Zeno`, yes without doubt |
| 05:21 |
nerzhul |
he contribute on many CSM features |
| 05:22 |
blue-001 |
I wouldn't mind |
| 05:22 |
blue-001 |
just credit me as "red-001 <red-001 outlook.ie>" |
| 05:31 |
nerzhul |
Zeno`, can you approve/look at #5801 please ? |
| 05:31 |
ShadowBot |
https://github.com/minetest/minetest/issues/5801 -- Read meta after node digging to ensure it is correct by paramat |
| 07:23 |
Zeno` |
red-001, ok I'll add that in a few hours |
| 07:24 |
Zeno` |
I can't do it now because I'm in Windows *shudder* |
| 07:26 |
|
kilbith joined #minetest-dev |
| 07:31 |
|
Zeno` joined #minetest-dev |
| 08:06 |
|
nerzhul joined #minetest-dev |
| 08:11 |
|
Hunterz joined #minetest-dev |
| 08:17 |
kilbith |
VanessaE has nothing to do in the credits: https://github.com/minetest/minetest/pull/5800#discussion_r117926993 |
| 08:18 |
Calinou |
you don't have to commit core code to be a contributor |
| 08:19 |
Calinou |
this is plain silly, IMO |
| 08:19 |
kilbith |
actually people that *ask* to be in the credits should not be honored at all |
| 08:19 |
Calinou |
if this section was called "Engine developers", then maybe I would respect that |
| 08:19 |
Calinou |
but contributing to open source software is not just about engine code |
| 08:19 |
kilbith |
Calinou, that have been the rule here for years |
| 08:19 |
kilbith |
you're just frustrated because you did not contribute |
| 08:19 |
Calinou |
uh, I don't get mad because I'm not in the credits |
| 08:20 |
Calinou |
(but I do have a few merged PRs, nothing big though) |
| 08:20 |
Calinou |
there are other places where I'm in the credits anyway :P |
| 08:20 |
kilbith |
you'd have like 100 people in the credits if you add people like VanessaE |
| 08:20 |
Zeno` |
I am considering adding Shara as well to active contribs |
| 08:20 |
kilbith |
oh my god |
| 08:21 |
Zeno` |
pending a response from celeron55 regarding minetest-hub |
| 08:21 |
kilbith |
script kiddies have nothing to do here |
| 08:21 |
Shara |
Wait - what now? |
| 08:22 |
kilbith |
Calinou, btw all you've done for the engine is just tweaking some numbers |
| 08:23 |
kilbith |
I see plenty of wanabee developers like that on github |
| 08:23 |
kilbith |
for the most they're hipsters |
| 08:23 |
Shara |
I very much hope that is not directed at me. |
| 08:23 |
Calinou |
I find it's pretty belitting to tell that to people who have been in the community for years |
| 08:23 |
Calinou |
and "script kiddies" is definitely not the expression you're looking for |
| 08:24 |
Shara |
I make a PR as and when I find reason to. The fact that I have not done anything huge does not make me a script kiddy. That's kind of ridiculous. |
| 08:25 |
VanessaE |
... |
| 08:26 |
Shara |
For the record - I suggested red be added, and did not suggest I be added. |
| 08:26 |
kilbith |
red deserves this place |
| 08:27 |
nerzhul |
contributor means having commits in core engine |
| 08:27 |
nerzhul |
else just add everybody who do issues on the list. |
| 08:27 |
kilbith |
exactly |
| 08:32 |
Zeno` |
VanessaE, are you still a moderator on the forum? |
| 08:33 |
VanessaE |
yeah |
| 08:33 |
Zeno` |
ok, well I stand by my decision |
| 08:33 |
kilbith |
this is bullshit |
| 08:33 |
VanessaE |
I just don't actively read the forum, so much as respond to maintenance requests |
| 08:33 |
|
Fritigern joined #minetest-dev |
| 08:34 |
|
YuGiOhJCJ joined #minetest-dev |
| 08:34 |
Calinou |
nerzhul: well, there's a middle ground |
| 08:35 |
Zeno` |
So all those people who look after the forum and look after IRC channels are not contributing? |
| 08:36 |
Zeno` |
That's like saying the IT department of a company don't contribute to the company because they don't generate revenue |
| 08:36 |
kilbith |
code talks. bullshit walks. |
| 08:37 |
kilbith |
you're drawing a new arbitrary line about who is a contributor |
| 08:37 |
Calinou |
that way of thinking is quite problematic in the open source world, I find |
| 08:37 |
Calinou |
artists, UX designers, and even translators deserve praise |
| 08:38 |
Calinou |
else we'd be stuck with ugly, unusable software only available in English. |
| 08:38 |
Calinou |
are you sure this is what you want? |
| 08:38 |
Zeno` |
I consider a contributor to be anybody who puts a lot of time and effort into the project |
| 08:40 |
Zeno` |
And, yes, drawing the line is HARD. Which is why I hate updating that file |
| 08:40 |
Zeno` |
but to say someone contributes less just because they don't directly write code that gets into the engine isn't right |
| 08:41 |
kilbith |
let's add 125 people to the credits then |
| 08:41 |
kilbith |
it'll be a very honorific place, really |
| 08:43 |
sfan5 |
i feel like adding people who haven't committed code leads to way too many problem about who deserves to be in there and who doesn't |
| 08:44 |
sfan5 |
so i'd really just strictly keep the contributor list to those that have contributed to git |
| 08:45 |
Zeno` |
So those who keep the forum running and those that consistently submit detailed backtraces and those that look after the IRC channels don't contribute? |
| 08:46 |
Zeno` |
Have a look at the credit list of any AAA game. They list Art Directors and Music Directors, all sorts of nonsense that has nothing to do with code |
| 08:46 |
Zeno` |
(as they should be) |
| 08:48 |
|
fireglow[m] joined #minetest-dev |
| 08:50 |
sfan5 |
no |
| 08:50 |
sfan5 |
but the list in the credits tab has historically always been just a list of code contributors, not whoever else might be involved |
| 08:50 |
Zeno` |
it's a PR btw. If something needs changing then just say so |
| 08:51 |
Zeno` |
But I will not retract my current decisions |
| 08:51 |
Zeno` |
mainly because I believe in what I've said |
| 08:51 |
Zeno` |
but I don't make the final decision |
| 08:53 |
shivajiva |
If the issue is people being credited for non code aspects of the project make some categories, simple |
| 09:03 |
VanessaE |
well here's a compromise then: just delete my name from the commit. |
| 09:08 |
nerzhul |
Zeno`, point noted |
| 09:30 |
|
silwol joined #minetest-dev |
| 09:38 |
Zeno` |
no it won't be deleted by be |
| 09:39 |
Zeno` |
#5800 (added Shara) |
| 09:39 |
ShadowBot |
https://github.com/minetest/minetest/issues/5800 -- Update credits by Zeno- |
| 09:43 |
|
lisac joined #minetest-dev |
| 09:55 |
|
kilbith_ joined #minetest-dev |
| 10:12 |
|
Fixer joined #minetest-dev |
| 10:15 |
|
srifqi joined #minetest-dev |
| 12:01 |
|
hfranqui joined #minetest-dev |
| 12:12 |
|
fireglow[m] joined #minetest-dev |
| 12:16 |
|
silwol joined #minetest-dev |
| 12:27 |
|
RobbieF joined #minetest-dev |
| 12:40 |
|
DS-minetest joined #minetest-dev |
| 12:43 |
|
Hunterz joined #minetest-dev |
| 13:03 |
Fixer |
do i need to post separate bug for this? https://github.com/minetest/minetest/issues/5776#issuecomment-303389421 |
| 13:04 |
sfan5 |
you don't needto |
| 13:04 |
sfan5 |
edit the main description and i can reopen it |
| 13:05 |
Fixer |
is this manifestation of the same bug? |
| 13:05 |
|
iZacZip joined #minetest-dev |
| 13:05 |
Fixer |
i have no idea how to rename it, i can open a new issue without problems, unless it is same bug |
| 13:07 |
sfan5 |
looks like a very similar or even the same bug to me |
| 13:08 |
Fixer |
i decided to open two new bugs |
| 13:09 |
sfan5 |
i think one might've been enough :D |
| 13:12 |
Fixer |
https://github.com/minetest/minetest/issues/5804 (first part, i hope it is still engine problem) |
| 13:15 |
Fixer |
https://github.com/minetest/minetest/issues/5805 (part two) |
| 13:22 |
|
est31 left #minetest-dev |
| 13:35 |
|
twoelk joined #minetest-dev |
| 13:54 |
|
octacian joined #minetest-dev |
| 14:11 |
|
omar___ joined #minetest-dev |
| 14:30 |
|
Fixer joined #minetest-dev |
| 14:51 |
Fixer |
nerzhul: cursor in last position fixed in login and other 1 line fields it seems, but not in multiline |
| 14:51 |
VanessaE |
that reminds me, |
| 14:52 |
VanessaE |
one other thing that needs fixed is password/username entry always pushing all but the last two or three chars out of the field |
| 14:52 |
VanessaE |
you type [123456 ] and you get [*** ] |
| 14:53 |
VanessaE |
(I should expect the whole width of the field would be used) |
| 14:53 |
nerzhul |
Fixer, noted |
| 14:53 |
nerzhul |
maybe it's not the same component ? |
| 14:54 |
Fixer |
no idea |
| 15:00 |
|
Hunterz joined #minetest-dev |
| 15:21 |
|
Raven262 joined #minetest-dev |
| 15:28 |
|
lisac joined #minetest-dev |
| 16:03 |
|
Krock joined #minetest-dev |
| 16:03 |
|
Krock joined #minetest-dev |
| 16:22 |
|
garywhite joined #minetest-dev |
| 16:55 |
|
paramat joined #minetest-dev |
| 16:55 |
|
dax joined #minetest-dev |
| 17:12 |
|
rubywarden joined #minetest-dev |
| 17:13 |
|
rubenwardy__ left #minetest-dev |
| 17:14 |
|
DI3HARD139 joined #minetest-dev |
| 17:49 |
paramat |
please can anyone review #5798 ? fixes floating decorations #5796 |
| 17:49 |
ShadowBot |
https://github.com/minetest/minetest/issues/5798 -- Mgv6 mudflow: Remove decoration if 'dirt with grass' below flows away by paramat |
| 17:49 |
ShadowBot |
https://github.com/minetest/minetest/issues/5796 -- Floating decorations in v6 at default settings (caused by mudflow?) |
| 17:51 |
paramat |
also #5801 needs 1 approval, tested and fixes crash |
| 17:51 |
ShadowBot |
https://github.com/minetest/minetest/issues/5801 -- Read meta after node digging to ensure it is correct by paramat |
| 17:52 |
|
nerzhul joined #minetest-dev |
| 17:53 |
nerzhul |
Zeno`, sfan5 Krock #5801 needs to be merged to fix a mt crash |
| 17:53 |
ShadowBot |
https://github.com/minetest/minetest/issues/5801 -- Read meta after node digging to ensure it is correct by paramat |
| 17:53 |
Zeno` |
merge |
| 17:53 |
Krock |
paramat, 5801 LGTM |
| 17:53 |
paramat |
thanks |
| 17:53 |
sfan5 |
looks pretty trivial to me |
| 17:53 |
sfan5 |
nerzhul: 5801 lgtm too |
| 17:54 |
nerzhul |
nice it's merged |
| 17:55 |
nerzhul |
https://github.com/minetest/minetest/projects/2 |
| 17:55 |
nerzhul |
here is the remaining things to look at for this release |
| 17:55 |
nerzhul |
i will add the formspec cursor issues |
| 17:57 |
nerzhul |
sfan5, for 5803 i can push return 4 to master to fix it |
| 17:57 |
nerzhul |
here https://github.com/minetest/minetest/commit/ad9fcf859ec2347325830e09504ae96968b51ea8#diff-9444313da8be4290e9304a4b1faed804R1734 |
| 17:57 |
sfan5 |
would be nice yes |
| 17:58 |
nerzhul |
paramat, lua api return is the number of value your wrote on stack, if you add a thing or remove the thing ensure you return the wrong number :) |
| 17:59 |
nerzhul |
the return 3 causes lua to move values to left and drop the first wrote value |
| 17:59 |
nerzhul |
i push the fix |
| 18:02 |
nerzhul |
Fixer, are you around ? |
| 18:03 |
paramat |
yes just looking at 5803 now |
| 18:03 |
Fixer |
nerzhul: yes, but little later |
| 18:03 |
nerzhul |
not for a test, just a question |
| 18:03 |
Fixer |
yes |
| 18:03 |
nerzhul |
#5805 uses which mod ? |
| 18:03 |
ShadowBot |
https://github.com/minetest/minetest/issues/5805 -- Impossible to set cursor position at the end of some lines in multiline text area |
| 18:04 |
nerzhul |
paramat, it's fixed in master :) |
| 18:04 |
Fixer |
nerzhul: minetest_game book |
| 18:04 |
|
halt_ joined #minetest-dev |
| 18:04 |
nerzhul |
oh native mt_game, it is in 0.4.15 tag ? not added in master after that ? |
| 18:04 |
|
Grandolf joined #minetest-dev |
| 18:04 |
paramat |
'return 3' did not know that needed increasing |
| 18:05 |
Fixer |
nerzhul: it is yesterdays minetest_game or so |
| 18:05 |
Fixer |
or few days old |
| 18:05 |
paramat |
thanks and sorry |
| 18:05 |
nerzhul |
now you know, the number correspond to the main stack values you return back :) |
| 18:09 |
nerzhul |
Fixer, okay i can reproce it, now i need to fix it |
| 18:09 |
Fixer |
thanks |
| 18:09 |
Zeno` |
what's a stack? |
| 18:09 |
nerzhul |
in Lua ? |
| 18:10 |
Zeno` |
anywhere |
| 18:10 |
Fixer |
Zeno`: are you irc? |
| 18:10 |
* Fixer |
runs away |
| 18:10 |
nerzhul |
it's when i push a huge amount of books on your head |
| 18:10 |
Zeno` |
but my head hurts |
| 18:10 |
nerzhul |
it's not in the specification |
| 18:11 |
Krock |
Zeno`, the equivalent for it would be recisely 4.1 big macs |
| 18:11 |
Krock |
*precisely |
| 18:11 |
Zeno` |
can we not use stacks? |
| 18:12 |
Zeno` |
they sound a bit over-complicated |
| 18:12 |
nerzhul |
Fixer, okay i see #1469424075affce7c27bb44e5a5cbd51485e44b2 is not the good solution for this problem |
| 18:12 |
nerzhul |
it fixes the last line but cause problem on other line |
| 18:12 |
nerzhul |
without it, the problem is only on the last char of the whole text blocks |
| 18:14 |
nerzhul |
Fixer, the problem was already there or introduced in tihs release cycle ? |
| 18:16 |
Fixer |
nerzhul: no idea, but i don't remember it earlier, could be |
| 18:16 |
Dumbeldor |
#5792 its good ? :) |
| 18:17 |
ShadowBot |
https://github.com/minetest/minetest/issues/5792 -- Snake case for screen options in minetest.conf by Dumbeldor |
| 18:18 |
nerzhul |
i think \n is count as a valid clickable character and \0 no |
| 18:18 |
paramat |
waving cyclops? |
| 18:23 |
|
kilbith joined #minetest-dev |
| 18:24 |
nerzhul |
okay issue fixed for multiline strings but not for single line... hmmm |
| 18:32 |
|
kilbith joined #minetest-dev |
| 18:33 |
nerzhul |
oh nice i think the problem is in IGUIFont in irrlicht |
| 18:33 |
nerzhul |
idx is wrong |
| 18:33 |
nerzhul |
did we change fonts ? |
| 18:34 |
nerzhul |
s32 idx = font->getCharacterFromPos(txtLine->c_str(), x - CurrentTextRect.UpperLeftCorner.X); |
| 18:35 |
nerzhul |
this call returns the value which cause problem |
| 18:50 |
|
Listener joined #minetest-dev |
| 18:50 |
nerzhul |
okay i have the bugfix |
| 18:55 |
|
Listener left #minetest-dev |
| 18:59 |
nerzhul |
guys, please look at #5806 when you get time (Fixer too) |
| 18:59 |
ShadowBot |
https://github.com/minetest/minetest/issues/5806 -- Revert 1469424075affce7c27bb44e5a5cbd51485e44b2 and fix wrong char position when doing mouse selection on intlGUIEditBox by nerzhul |
| 19:43 |
|
octacian_ joined #minetest-dev |
| 19:49 |
VanessaE |
[05-23 15:48] <xxxxxx> Argh, I've been trying to connect for 30 minutes straight |
| 19:49 |
VanessaE |
:( |
| 19:50 |
VanessaE |
(and then as soon as he complains, he gets in) |
| 19:51 |
red-001 |
lol |
| 19:52 |
VanessaE |
I hope someone can fix that ^ soon. |
| 19:53 |
VanessaE |
#5799 |
| 19:53 |
ShadowBot |
https://github.com/minetest/minetest/issues/5799 -- Client timeouts during and after sign-in, after "connecting" phase is over. |
| 20:19 |
|
octacian joined #minetest-dev |
| 20:26 |
cheapie |
[15:25:36] <qwrwed> ~37 timeouts [15:25:42] <qwrwed> In a row |
| 20:46 |
Fixer |
nerzhul: seems better, yet it has one downside %))) |
| 20:57 |
|
Sokomine joined #minetest-dev |
| 21:02 |
|
RobbieF left #minetest-dev |
| 21:18 |
nerzhul |
which downside ? |
| 21:19 |
Fixer |
nerzhul: https://github.com/minetest/minetest/pull/5806#issuecomment-303518028 |
| 21:24 |
Fixer |
nerzhul: this may interest you in future: https://github.com/probonopd/AppImageKit/wiki/Creating-AppImages |
| 21:25 |
|
twoelk left #minetest-dev |
| 21:30 |
nerzhul |
Fixer, yeah the shift on the last line is a little bit painful to handle :p |
| 21:30 |
Fixer |
nerzhul: not only last line |
| 21:30 |
Fixer |
nerzhul: same problem on one line text field and it somehow crop up everywhere in multiline, then fixes itself, then again |
| 21:31 |
nerzhul |
one text line is similar to last line of multiline it's the same handling |
| 21:41 |
|
DI3HARD139 joined #minetest-dev |
| 21:46 |
|
paramat joined #minetest-dev |
| 21:51 |
nerzhul |
this last line is just painful.. |
| 21:58 |
nerzhul |
okay i got it ! |
| 21:58 |
nerzhul |
pfiou |
| 21:58 |
Fixer |
Final Fix VIII |
| 22:00 |
nerzhul |
Fixer, #5587 cannot reproduce it |
| 22:00 |
ShadowBot |
https://github.com/minetest/minetest/issues/5587 -- Backspace stops working in formspecs |
| 22:00 |
nerzhul |
fixed: #5806 is now okay |
| 22:00 |
ShadowBot |
https://github.com/minetest/minetest/issues/5806 -- Revert 1469424075affce7c27bb44e5a5cbd51485e44b2 and fix wrong char position when doing mouse selection on intlGUIEditBox by nerzhul |
| 22:01 |
nerzhul |
i also fixed the function code style; sfan5 if you get some time to look at this |
| 22:03 |
Fixer |
nerzhul: 5587 seems fixed |
| 22:03 |
Fixer |
will retry 5806 |
| 22:04 |
nerzhul |
yeah 5587 was probably buggy on the MacOSX failure but after i fixed it i fix it :) (backspace is a non printable char heh) |
| 22:16 |
Fixer |
testing |
| 22:18 |
Fixer |
nerzhul: looks like all my issues are fixed |
| 22:18 |
Fixer |
nerzhul: found unrelated book bug %) |
| 22:20 |
nerzhul |
i think it's not related with formspec, nice just add comments, and i hope another coredev can look at the PR and validate it, it's one of our bugs for this release |
| 22:20 |
nerzhul |
sfan5, nore #5806 |
| 22:20 |
ShadowBot |
https://github.com/minetest/minetest/issues/5806 -- Revert 1469424075affce7c27bb44e5a5cbd51485e44b2 and fix wrong char position when doing mouse selection on intlGUIEditBox by nerzhul |
| 22:20 |
nerzhul |
rubenwardy, sofar |
| 22:20 |
sfan5 |
i'll take a look tomorrow |
| 22:20 |
Fixer |
i will test it some more |
| 22:20 |
Fixer |
right now |
| 22:20 |
Fixer |
and will post few comments |
| 22:21 |
nerzhul |
nice ty |
| 22:22 |
Fixer |
yeah, looks ok |
| 22:22 |
nerzhul |
if some lua lovers can look at #5763 to help us to fix that for release could be nice |
| 22:22 |
ShadowBot |
https://github.com/minetest/minetest/issues/5763 -- Subgame list on new world creation disappears if subgame name has square brackets |
| 22:38 |
paramat |
doesn't seem critical, square brackets is asking for trouble |
| 22:55 |
rubenwardy |
#5808 |
| 22:55 |
ShadowBot |
https://github.com/minetest/minetest/issues/5808 -- Add formspec escaping to subgame list in create world dialog by rubenwardy |
| 23:00 |
Fixer |
was this fixed via other PR? https://github.com/minetest/minetest/pull/4907 |
| 23:01 |
Fixer |
do i need to close this? https://github.com/minetest/minetest/issues/5120 |
| 23:09 |
Fixer |
updated my waving water shader related bug, new pic: https://cloud.githubusercontent.com/assets/16494741/26379995/a9cf1b50-4024-11e7-8801-8cd56bc8adbd.png |
| 23:14 |
|
est31 joined #minetest-dev |
| 23:16 |
|
est31 left #minetest-dev |
| 23:22 |
|
halt_ joined #minetest-dev |
| 23:23 |
paramat |
no i didn't do a PR for 4907, hardly worth it, it's only minimal |
| 23:23 |
paramat |
it's so simple someone else can do it |
| 23:23 |
Fixer |
ok |
| 23:24 |
paramat |
but maybe i'll do it now |
| 23:24 |
paramat |
so keep 5120 open |
| 23:24 |
|
halt_ joined #minetest-dev |
| 23:26 |
|
Iosif joined #minetest-dev |
| 23:35 |
|
halt_ joined #minetest-dev |
| 23:46 |
|
halttheranger joined #minetest-dev |
| 23:47 |
|
halttheranger joined #minetest-dev |
| 23:49 |
|
Halt__ joined #minetest-dev |
