Minetest logo

IRC log for #minetest-dev, 2017-05-06

| Channels | #minetest-dev index | Today | | Google Search | Plaintext

All times shown according to UTC.

Time Nick Message
00:03 octacian joined #minetest-dev
00:03 octacian joined #minetest-dev
00:34 YuGiOhJCJ joined #minetest-dev
00:42 octacian_ joined #minetest-dev
00:50 kaeza joined #minetest-dev
01:10 paramat joined #minetest-dev
01:17 YuGiOhJCJ joined #minetest-dev
01:49 ssieb joined #minetest-dev
02:44 PyroDev joined #minetest-dev
03:15 sofar so are we switching to meson too?
03:19 VanessaE ?
03:19 benrob0329 what?
03:41 proller__ joined #minetest-dev
06:09 delores joined #minetest-dev
06:10 nerzhul joined #minetest-dev
06:34 Hunterz joined #minetest-dev
07:31 Zeno` 256 is not a good max stack size VanessaE
07:31 Zeno` maybe 255 :p
08:02 DS-minetest joined #minetest-dev
08:16 cx384 joined #minetest-dev
08:38 lisac joined #minetest-dev
08:39 iZacZip joined #minetest-dev
09:19 troller joined #minetest-dev
09:22 Krock joined #minetest-dev
09:22 Krock joined #minetest-dev
09:27 VanessaE Zeno`: but...my OCD! :)
09:28 Krock well, 256 isn't 2 digits long
09:29 VanessaE it is in hex :D
09:29 VanessaE (well 255 is)
09:29 Krock but 255 isn't divideable
09:29 Krock (by 2, 4 or 9)
09:30 Krock well yes it is, but there are leftovers
09:30 VanessaE what's with the two-digit thing anyway?
09:30 VanessaE I've never seen any problems displaying three+ digit stack sizes
09:30 Krock space on android/small screens
09:30 VanessaE oh
09:30 VanessaE sounds to me like a font size issue then
09:31 Krock 80(h)  would be a good number
09:31 Krock but I'm afraid people won't like dealing with hexadecimals
09:31 VanessaE no, they won't :P
09:32 Krock won't + won't = will  (horray!)
09:32 VanessaE heh
09:32 DS-minetest joined #minetest-dev
09:33 VanessaE now all that said,
09:33 VanessaE I'm looking at the default 800x600 window and honestly, there's way more than enough room for three digits in both the inventory and hotbar
09:33 VanessaE and I use a larger-than-usual font, too
09:34 VanessaE no one anywhere still uses a screen that small, except for mobile users
09:34 VanessaE so the obvious solution is to use a smaller font for the item count on android/iOS builds.
09:35 Krock 5px fonts \o/
09:35 VanessaE no, silly...  select one of those "narrow" or "condensed" fonts
09:35 VanessaE they even come in bold.  same height, narrow width, still easy to read
09:35 Krock but then the chat would be narrow too, same as the whole GUI
09:35 VanessaE and you only have to have room for digits, not text, so you can utterly ignore the whole font save for the digits.
09:35 VanessaE nonono
09:36 VanessaE only change the font used for the itemcounts
09:36 Krock so.. a new font + settings for it
09:36 VanessaE more or less yeah
09:36 VanessaE that's the only logical choice,.
09:36 nerzhul VanessaE, comparing desktop to android is not good, because android DPI is not same DPI as desktops
09:36 nerzhul this affect the font rendering
09:36 VanessaE nerzhul: I know.  if anything, probably way higher DPI than my screens
09:37 VanessaE I have an old android tablet that's about the same height and slightly longer- in actual physical size - than the 800x600 window as it appears on my monitor
09:38 VanessaE and that old POS is way too weak to run MT
09:38 VanessaE so you can figure one that's good enough to run it, probably has a better screen too
09:38 VanessaE plus it's higher resolution than that
09:39 VanessaE and, again, pick a "narrow" or "condensed" font of the same point size as whatever's being used now
09:39 VanessaE that way the relative height won't change on mobile/android
09:39 VanessaE and you get more room for digits.
09:39 VanessaE simple, obvious. :)
09:40 Calinou my phone is 530 dpi or so, my laptop 315 dpi, my desktop 92 dpi
09:41 Calinou good programs can support those
09:41 Calinou (but unfortunately, Minetest is far from there out of the box)
09:41 Calinou it's doable to make it nice on the laptop, but not on the phone
09:47 Zeno` 256 doesn't fit into 8-bits VanessaE
09:47 Zeno` you know that :p
09:48 Zeno` 256 is 100b :P
09:48 Zeno` err 100 hex
09:49 burli joined #minetest-dev
09:49 VanessaE yeah I know but this ain't running on a Commodore 64 either :P
09:49 Zeno` yes, but...
09:49 Zeno` it's the principle!
09:49 VanessaE hah!
09:51 VanessaE so store it with 0 in the byte = 1 in the count, 255=256, and none at all == nil/NULL :)
09:52 red-001 only if you want to be able to store 0
09:52 Zeno` doesn't work :P
09:53 VanessaE Zeno`: not buying the BS? ;)
09:53 Zeno` I guess we could change it to a pointer so we can check for NULL
09:53 Zeno` nope, not buying it at all :P
09:53 VanessaE I tried. :)
09:55 Krock but BS is 10.0
09:55 VanessaE I was waiting for that
09:55 Krock ^^
09:57 Zeno` stupid value
09:57 Zeno` lol
09:58 Zeno` it's not actually 10.0 btw
09:58 VanessaE I suppose it's really 9.999999999999999999 or something? :)
09:58 Zeno` yeah
10:35 Fritigern joined #minetest-dev
10:53 Fixer joined #minetest-dev
11:04 kilbith joined #minetest-dev
13:09 Hunterz joined #minetest-dev
13:10 DI3HARD139 joined #minetest-dev
14:12 behaleba- joined #minetest-dev
14:14 kilbith joined #minetest-dev
15:20 DS-minetest joined #minetest-dev
15:41 cx384 joined #minetest-dev
15:45 fireglow joined #minetest-dev
16:29 iZacZip_m joined #minetest-dev
16:47 Miner_48er joined #minetest-dev
17:16 torgdor joined #minetest-dev
17:52 nerzhul red-001, can you finish #5544 please ?
17:53 ShadowBot https://github.com/minetest/minetest/issues/5544 -- [CSM] add `on_item_use` by red-001
18:01 red-001 working on it right now
18:03 ShadowNinja Alright, the developer meeting starts now.  Here are the public meeting notes: http://sprunge.us/ZYdb
18:03 ShadowNinja Krock: Progress on #4035?
18:03 ShadowBot https://github.com/minetest/minetest/issues/4035 -- Additional hooks for inventory manipulations callbacks. by Foghrye4
18:05 ShadowNinja Looks like it's rebased, but not cleaned up.
18:05 ShadowNinja nore: #1439 still needs to be finished.
18:05 ShadowBot https://github.com/minetest/minetest/issues/1439 -- Add configurable key bindings for selecting next/previous hotbar item and changing the volume by Wuzzy2
18:06 ShadowNinja I'll merge #1949 shortly after the meeting.
18:06 ShadowBot https://github.com/minetest/minetest/issues/1949 -- Use a settings object for the main settings by ShadowNinja
18:06 nore oops, had not seen the comments on it
18:06 nore will fix soon
18:06 ShadowNinja I haven't had a chance to work on #1845 (maybe in two weeks or so).
18:07 ShadowBot https://github.com/minetest/minetest/issues/1845 -- Split block position in SQLite3 database by ShadowNinja
18:07 ShadowNinja sofar: Any comments on #1988?  You worked on it.  Do you think it's worth finishing up and merging?
18:07 ShadowBot https://github.com/minetest/minetest/issues/1988 -- Fix #1374 by adding a listpredict piece to the formspec by MinerDad7
18:08 ShadowNinja #2056: we agreed to merge it last meeting, but nobody was assigned.  Any volunteers?
18:08 ShadowBot https://github.com/minetest/minetest/issues/2056 -- Use object property "stepheight" for player stepheight too. by sapier
18:08 Krock ShadowBot, well yeah, it's rebased but I'm stuck with a fatal error where I can't get any helpful information from the minidump
18:08 Krock * ShadowNinja
18:09 ShadowNinja Krock: Oh, that's fun...
18:09 ShadowNinja Also, #2852 needs someone to merge.
18:09 ShadowBot https://github.com/minetest/minetest/issues/2852 -- Make players respect makes_footstep_sound in the object properties by TeTpaAka
18:09 Krock already spent hours on searching where this is coming from but well.. I'm out of ideas
18:12 ShadowNinja celeron55, nerzhul, sfan5, sofar: Y'all here?  :-)
18:12 sfan5 yes
18:12 nore I can merge #2852 btw, seems like it's ready for it
18:12 ShadowBot https://github.com/minetest/minetest/issues/2852 -- Make players respect makes_footstep_sound in the object properties by TeTpaAka
18:13 Krock indeed, looks good
18:13 ShadowNinja nore: Great.  Anyone for 2056?
18:14 nore I can give it a try
18:15 * ShadowNinja mumbles something about one person doing all the work.
18:15 ShadowNinja nore: O.K.
18:16 Krock well, doesn't "player_stepheight" need a rangelimit against being >= 0?
18:16 ShadowNinja Next: Add support for multiple listen addresses (#2604)
18:16 ShadowBot https://github.com/minetest/minetest/issues/2604 -- Add support for multiple listen addresses by ShadowNinja
18:17 ShadowNinja It's a really big patch, but it can't be split up a whole lot because a lot of it is interrelated.
18:17 nore I think it's a good thing to have
18:18 nore depending on how easy it is maybe split the refactor & feature commits
18:18 nore (if that's not already done)
18:18 nore but I'm for that patch anyway, even though it is big
18:21 ShadowNinja Alright.  Any other opinions?
18:22 Krock was looking through the changes a bit and overall looks promising. Should be rebased and merged
18:22 nore (pushing #2852)
18:22 ShadowBot https://github.com/minetest/minetest/issues/2852 -- Make players respect makes_footstep_sound in the object properties by TeTpaAka
18:22 sfan5 nice to have IMO
18:24 ShadowNinja Alright.  I'll look into rebasing it when I have time.
18:25 ShadowNinja How about Make the player collisionbox settable (#2738) ?
18:25 ShadowBot https://github.com/minetest/minetest/issues/2738 -- Make the player collisionbox settable by TeTpaAka
18:27 nore that's a feature I'd very much like to have
18:29 Krock hacky but ok for me
18:31 rubenwardy joined #minetest-dev
18:31 kaeza joined #minetest-dev
18:32 Krock m_collisionbox(-BS * 0.30, 0.0, -BS * 0.30, BS * 0.30, BS * 1.75, BS * 0.30),
18:32 red-999 left #minetest-dev
18:32 Krock doesn't look like an offset
18:33 ShadowNinja Looks good to me too.  Needs rebase but the patch is trivial so that should be easy.  Anyone to merge it?
18:33 ShadowNinja Krock: Yeah, the offset is probably done somwhere else.
18:34 Krock I see. content_sao is the problem there. sending the data with this offset
18:36 ShadowNinja Anyone volunteer to merge it?  (please don't make nore do it again :-P)
18:36 nore #2056 is rebased btw :)
18:36 ShadowBot https://github.com/minetest/minetest/issues/2056 -- Use object property "stepheight" for player stepheight too. by sapier
18:37 nore (the refactor was already merged so it was easy enough)
18:38 ShadowNinja nore: Great :-)
18:38 ShadowNinja I guess I'll merge 2738.
18:38 ShadowNinja Next: Clean up numeric.h and split FaceFositionCache from it #3256
18:39 ShadowBot https://github.com/minetest/minetest/issues/3256 -- Clean up numeric.h and split FaceFositionCache from it by ShadowNinja
18:39 sfan5 sounds good to me
18:39 ShadowNinja Pretty trivial, just really needs approval.
18:40 Krock did nerzhul write these functions? Otherwise I wonder where the copyright notice is coming from
18:40 nore ShadowNinja: btw, about #5598: "However this should be using snprintf to prevent overflow (along with a more reasonably sized buffer) ." what value do you suggest?
18:40 ShadowBot https://github.com/minetest/minetest/issues/5598 -- Add configurable key bindings for selecting next/previous hotbar item and changing the volume by Ekdohibs
18:43 ShadowNinja nore: Hmmm, I guess the size could vary due to the gettext call, so 100 is probably pretty reasonable (although you could seperate the call and dynamically allocale the memory based on strlen).
18:45 ShadowNinja nore: I'd probably dump the alignment though, we don't want this patch noise whenever anyone changes a line.
18:45 nore hmmm is there a way to do that? (I don't know how to get the length of the gettext call.)
18:45 nore ok for the alignment, undoing that
18:46 ShadowNinja nore: Just x = gettext("foo") malloc(strlen(x)+SOME_CONSTANT) or such.  I wouldn't bother though, just use snprintf so it can't overflow.
18:46 behalebabo joined #minetest-dev
18:47 nore ok
18:48 ShadowNinja Any other comments on 3256?  I suppose I'll merge it from sfan5's comment.
18:49 nore ShadowNinja: untested but looks good to me
18:49 Krock ShadowNinja, how about the copyright notices of the new files? Are they correct?
18:50 ShadowNinja Krock: In which PR?
18:50 Krock 3256, the cleanup
18:51 Krock speaking of the author of these functions. it's not too important
18:52 ShadowNinja Krock: Looks like nrz wrote the cache, although the uncached version was there before: https://github.com/minetest/minetest/commi​t/7c8793cbea1ea83109b7d9d6974d3f6991efcec8
18:53 nerzhul yeah it was me because this is an expensive calcul i saw before
18:53 Krock ah I see. the function already exists since 2012, so it's fine
18:53 nore 5598 updated with both changes
18:54 nerzhul sorry i'm late :)
18:55 ShadowNinja Alright, I think that'll be all for today.  I'll get to merging stuff now.
18:56 Krock nore, gettext("Volume changed to 100%") and 0% will both require a special translation this way :/
18:56 nore so :) can #5598 and #5710 be merged?
18:56 ShadowBot https://github.com/minetest/minetest/issues/5598 -- Add configurable key bindings for selecting next/previous hotbar item and changing the volume by Ekdohibs
18:56 ShadowBot https://github.com/minetest/minetest/issues/5710 -- Use stepheight from CAO instead of hardcoded value by Ekdohibs
18:56 nore Krock: they do
18:56 nerzhul nore, let me a minute
18:57 nore but this allows messages such as "volume muted" or things like that as well
18:57 nore so it's not a bad thing I think
18:57 Krock alright
18:58 nore ow. I just saw that issues+PRs > 1000 now
19:00 Krock nore, +1 on merge from me
19:00 paramat joined #minetest-dev
19:00 Krock s/on/for/
19:00 Krock hello paramat
19:00 paramat (just woke up :})
19:00 nore hey paramat
19:02 nore merging #5710 as soon as travis is finished
19:02 ShadowBot https://github.com/minetest/minetest/issues/5710 -- Use stepheight from CAO instead of hardcoded value by Ekdohibs
19:03 nore same for #5598 if it's ok as well
19:03 ShadowBot https://github.com/minetest/minetest/issues/5598 -- Add configurable key bindings for selecting next/previous hotbar item and changing the volume by Ekdohibs
19:03 red-001 fixed issues with and updated #5544
19:03 ShadowBot https://github.com/minetest/minetest/issues/5544 -- [CSM] add `on_item_use` by red-001
19:09 nerzhul nore, i added some comments on pr you want to merge
19:09 nore fixing
19:09 nerzhul nice red-001
19:10 nerzhul can someone look at 5544 it's now okay, and the Dumbeldor comment on factorizing code is fixed
19:11 Dumbeldor Yeah !
19:12 Krock +1
19:12 nerzhul merging Krock
19:12 nerzhul (not Krock merged, but the pr :p)
19:13 Krock thanks god.  *phew*
19:13 nore nerzhul: fixed
19:13 nerzhul nice nore
19:14 nore ok, merging both PRs then
19:14 nerzhul it's nice to merge PR, i hope at a point there will be issue review permitting to close useless issues :p
19:15 paramat some issues / PRs are labelled 'possible close', it's good to go through those and add your opinion
19:15 red-001 well right now more PRs and issues are closed/merged then opened https://github.com/minetest/minetest/pulse/monthly
19:16 nerzhul yeah, this cycle end is hard
19:16 nerzhul this is a very very active release cycle :p
19:17 red-001 yeah we already have more commits then the previous cycle
19:17 nerzhul and many more feature, less performance problems, as many of those are now fixed
19:17 red-001 434 vs 418
19:18 nerzhul this month was the most active since middle 2015 :p
19:18 nerzhul https://github.com/minetest/minete​st/graphs/contributors?from=2016-0​1-11&to=2017-05-06&type=c
19:18 nerzhul 2016 was very very slow :p
19:20 behalebabo joined #minetest-dev
19:23 nore both merged :)
19:24 nerzhul nice
19:24 red-001 nice
19:27 ShadowNinja nerzhul: Can you fix the failing travis build on master: https://travis-ci.org/minet​est/minetest/jobs/229267252
19:29 nerzhul seems the end user failed on his empty lines
19:29 nerzhul i'm passing clang-format on those files
19:30 nerzhul pushed
19:32 Taoki joined #minetest-dev
19:34 Taoki joined #minetest-dev
19:43 iZacZip_m joined #minetest-dev
20:02 ShadowNinja clang-format wants "class Foo\n{\n" but isn't out code style "class Foo {\n"?
20:02 ShadowNinja having a lne with just the { doesn't really help readability at all.
20:03 nerzhul ShadowNinja, for me it was the clang-format configuration
20:03 nerzhul (i configured it as i thought it was)
20:08 Fixer about screen size autosave on windows
20:09 Fixer i'm maximazing my minetest window, when I restart, I end up with this: https://i.imgur.com/BPZUOWe.png
20:12 nerzhul Fixer, what is the problem ?
20:12 Taoki joined #minetest-dev
20:12 Fixer nerzhul: window is not properly placed and not maximised
20:13 nerzhul i see, we record only the size, placement and maximized should be other parameters, maybe we should save them too
20:13 nerzhul i see it's a win XP no ? can you look on a more recent windows ?
20:13 Krock we have a fullscreen variable somewhere but that doesn't seem to be used for this right now
20:13 Fixer nerzhul: i maximise it, it saves the position, i restart, end up with this https://i.imgur.com/V2nkW9e.png (win7)
20:14 nerzhul Win7 seems more reasonable than previous screen
20:14 nerzhul Krock, yes there is a fullscreen boolean in config, but i don't know if we have a binding to enable it outside of configuration, can be a good point ,especially for windows
20:15 Krock what we need now is a function to detect the fullscreen (maximize mode)
20:16 ShadowNinja Note that fullscreem =/= maximized window.  Fullscreen has no borders or OS GUI components.
20:19 Krock just tested fullscreen. looks like I should adjust the window size :3  http://i.imgur.com/PmS0tmY.png
20:20 Krock strange enough that this error appears. works fine
20:22 Fixer nerzhul: previous screen is also win7
20:23 nerzhul okay Fixer
20:23 Fixer it is maximised window not a fullscreen
20:25 YuGiOhJCJ joined #minetest-dev
20:28 Krock well great, irrlicht only supports maximizing it, if possible
20:29 paramat thanks for 2738!
20:29 Fixer https://github.com/minetest/minetest/issues/5711
20:30 Fixer created an issue for this
20:33 Fixer fuck
20:33 Fixer another bug
20:34 Krock (horray!)
20:35 Fixer kinda bug
20:36 Fixer if i disable size autosave... it still leaves me with crappy window size, because it is still recorded in minetest.conf
20:37 Krock resize before disabling. That's not a bug.
20:38 behalebabo joined #minetest-dev
20:41 paramat #5704 fairly simple
20:41 ShadowBot https://github.com/minetest/minetest/issues/5704 -- Shaders: Remove unused water surface shader by paramat
20:45 Fixer Krock: by definition if I untick autosave window size, it should not save it and use default size, not the size I just used :/
20:46 Krock https://github.com/minetest/minetest/blob​/master/src/defaultsettings.cpp#L127-L129
20:47 Krock it adjusts the screenW/H settings
20:47 Krock and they'll be the new defaults unless removed
20:47 Krock since you may would like to keep the new size
20:48 Fixer no i don't
20:48 Fixer if i want to keep the new size - i will enable autosave
20:48 Fixer captain obvious o/
21:15 Fixer strangest gameplay bug I seen: can't walk past this https://i.imgur.com/lyaoajV.png (newest mt)
21:17 kaeza Fixer, walk as in sneaking?
21:18 Fixer does not help
21:18 kaeza or just walking
21:18 Fixer does not help
21:18 Fixer https://github.com/minetest/minetest/issues/5713
21:20 Fixer this too https://i.imgur.com/jKATw8o.png
21:20 Fixer kek
21:20 kaeza cannot reproduce here
21:20 Fixer kaeza: connect to hometown server
21:20 kaeza maybe another time
21:22 Fixer lets see singleplayer
21:22 kaeza sneaking through doors bug is known I think
21:23 Fixer can reproduce in singleplayer
21:23 Fixer https://i.imgur.com/vRxbu9b.png can't walk into this
21:24 paramat ? =/
21:25 Fixer ! =D
21:25 kaeza http://irc.minetest.net/minet​est-dev/2017-03-16#i_4831659
21:25 Fixer kaeza: does not matter
21:26 Fixer this works https://i.imgur.com/5rD3VCn.png
21:27 paramat maybe player collisionbox PR?
21:30 Fixer paramat: May 6 should contain the regression
21:30 nrzkt joined #minetest-dev
21:31 Fixer paramat: you mean this? https://github.com/minetest/minetest/commi​t/45ab62d6a3d90ab3b97aec88251a766cb5dd1899
21:31 Fixer Use stepheight from CAO instead of hardcoded value ?
21:31 paramat no, custom player collisionbox
21:32 Fixer Make the player collisionbox settable ?
21:32 paramat yeah
21:32 Fixer i will need to compile few times to check it
21:33 Fixer will compile 43d1f37
21:55 Fixer paramat: so I've compiled 43d1f37, just before that collisions PR - no bug for me, that means 3 last commits has this regression, probably that collisions PR
21:57 Fixer will check in a few mins
21:57 paramat ok thanks
21:58 paramat it may be something to do with the 'offset by 1 node' thing
22:05 paramat we did not test it carefully before merge, so, may need to be reverted
22:05 Fixer can confirm it is Make the player collisionbox settable
22:07 Fixer regression in it
22:11 paramat ok thank you
22:11 paramat please can anyone revert that commit? i don't know how yet
22:13 kaeza git revert $HASH ?
22:13 red-001 iirc github has a gui for doing that
22:14 red-001 nvm that wouldn't work here
22:15 rubenwardy joined #minetest-dev
22:15 kaeza Fixer, oh, I didn't know that was merged
22:16 kaeza my client is badly outdated :/
22:16 Fixer paramat: or maybe wait till tommorrow, maybe there will be quick fix
22:16 Fixer kaeza: i'm using latest and greatest
22:24 Foz joined #minetest-dev
22:26 MoNTE48 joined #minetest-dev
23:14 kaeza joined #minetest-dev
23:29 paramat joined #minetest-dev
23:37 kaeza joined #minetest-dev
23:41 YuGiOhJCJ joined #minetest-dev
23:42 paramat maybe it's because the collisionbox has not been set for the player in MTG?
23:42 paramat it was hardcoded before. will try
23:42 paramat (hardcoded in the engine)

| Channels | #minetest-dev index | Today | | Google Search | Plaintext