Time Nick Message 00:08 red-001 could someone review #5544? 00:08 ShadowBot https://github.com/minetest/minetest/issues/5544 -- [CSM] add `on_item_use` by red-001 01:26 sofar will merge #5407 in a bit 01:26 ShadowBot https://github.com/minetest/minetest/issues/5407 -- Hardware coloring for item stacks by juhdanad 01:42 VanessaE \o/ 01:45 sofar FUCK 01:46 sofar pushed a wrong branch 01:46 sofar goddammit 01:46 sofar stupid, sorry, my bad 01:50 sofar fricken working with git for 12 years and I still make noob mistakes like that 01:52 VanessaE meh just force-push to fix it 01:53 VanessaE you're still within the 10min window 01:53 VanessaE no you're not 01:53 VanessaE shit 01:53 VanessaE well do it anyway, no one's gonna complain (are they?) 01:54 sofar already did it within like 30 seconds, lol 01:54 VanessaE ok :) 02:19 GreenDimond !tell MinetestBot you are a jerk 02:19 ShadowBot GreenDimond: O.K. 02:19 GreenDimond whoops. 02:19 GreenDimond -_- wrong channel. 03:10 ShadowNinja *Sigh* I see pulls being closed for little reason other than them being ignored until they gained merge conflicts. 03:11 ShadowNinja I've got a ton of work in a bunch of old PRs which haven't been resolved yet, and I'm disuaded from writing anything new because it seems likely that will just stay ignored as an open PR for years. 03:24 VanessaE :( 03:28 paramat we don't close PRs from being ignored by devs, only when the author doesn't respond to a request in a month (dev rules) 03:29 paramat we're being lenient, many more could be closed under that rule 03:29 paramat the main problem is lack of dev time to review/test 03:33 ShadowNinja For example #1188. It needs a rebase, but it would be pretty easy. And the only reason it needs a rebase in the first place is because it was ignored for a year. 03:33 ShadowBot https://github.com/minetest/minetest/issues/1188 -- getTime refactoring by Selat 03:36 paramat ignored by the author for almost a year, but understandable as they rebased it multiple times 03:41 ShadowNinja It was rebased and ready to merge, with no reason not to merge it (as far as I can tell), but it was just ignored until the author eventually left and stopped repeatedly rebasing it. 03:41 paramat yes very understandable, a 36 file refactor is a nightmare to maintain and rebase 03:43 ShadowNinja It even has two approvals. Rebasing it isn't that hard since the actuall changes are pretty minor and resolution should be pretty obvious. 03:45 ShadowNinja I see no good reason why that PR shouldn't have been merged 10 months ago. 03:46 ShadowNinja Maybe we should have regularly scheduled meetings where we go through the PR backlog and make desicions and what to do with them. 03:57 sofar I don't mind doing rebasing, but I often just don't check approved backlog 03:59 ShadowNinja It doesn't help when you need approvals and its hard to get anyone to do them. 04:00 ShadowNinja If we do a meeting, due to time zone differences we'll have to either have people come in at odd times, or just do it for one section of the world. 04:01 ShadowNinja If we do on Sat/Sun odd may not be as much of an issue. 04:01 nore I would +1 PR meetings, I guess it would need to be during the weekends so that more people can be around at the same time 04:01 nore in what time zones are the core devs btw? 04:02 ShadowNinja Eastern US here. 04:03 nore usually France for me, but western US until august 04:06 ShadowNinja Based on IP, paramat is in England, and I think sfan is somewhere in Europe. 04:06 nore sfan is in Germany IIRC 04:06 ShadowNinja If we include western US that's a pretty big TZ diff. 04:07 nore hmmm 04:07 nore well, 8am in western US would be like 6pm in central Europe or something like that 04:07 nore it's still manageable 04:13 paramat i'm UK 04:16 paramat hmmmm used to have spontaneous meetings like that with 2 other devs, planned meetings are not really possible 04:16 paramat or even desirable 04:17 sofar I don't think it's a bad idea to try 04:17 sofar if nobody shows up nothing is lost 04:17 sofar if 3-4 people show up it's worth it 04:17 nore +1 04:18 sofar 8am, heh, that's rough 04:19 ShadowNinja I could send a poll to the devs in PM or a private channel and see iff it works. Does that sound good? 04:19 sofar 8:30 am on a weekday I'm at work and can chat 04:19 VanessaE speaking of hmmmm I've tried to msg him a couple of times to invite him back. no response. :( 04:19 ShadowNinja ^ 8am in what TZ :-) 04:19 nore ShadowNinja: good yeah! :) 04:20 nore sofar is in western US as well 04:21 nore for me anytime between 7-8am and midnight is ok, but I know sofar doesn't like to wake up that early :) 04:21 sofar well, weekdays I'm up at 6:45 am, I'm just busy with the kids and getting them to school 04:22 nore woah, meta_set_nodedef is the oldest PR still open 04:22 nore but it's completely broken :/ 04:22 nore and as I said, it would probably be easier to rewrite from scratch than to rebase 04:25 paramat my sleep cycle is a bit random sometimes but i'm usually synced to USA more than UK 04:40 paramat #5519 nore sofar could you add your opinion on the concept? (not necessarily reviews) 04:40 ShadowBot https://github.com/minetest/minetest/issues/5519 -- Sneak: Add option for old move code by paramat 04:41 paramat it's quite major so i would like lots of support 05:00 sofar merging #5480 in a bit 05:00 ShadowBot https://github.com/minetest/minetest/issues/5480 -- [CSM] Localplayer api lua by Dumbeldor 05:01 sofar paramat: at this point I'd like to burn the house down and kill all sneak bullshit with fire 05:01 VanessaE cheapie ^ 05:06 paramat very understandable :] 05:07 VanessaE sofar: I guess while you're at it, turn PB&J Pup into toast :-/ 05:13 paramat ShadowNinja i can't be bothered with that scheduling app, i'm often available UTC 1800 to 0400 05:13 sofar VanessaE: if people are too (effin) lazy to submit a PR to remove code, then I'm not listening to them 05:14 VanessaE heh 05:17 sofar that whole thread is just a bitching session 05:20 sofar red-001: #5492 needs a rebase now 05:20 ShadowBot https://github.com/minetest/minetest/issues/5492 -- [CSM] Add local particles and particlespawners. by red-001 05:48 VanessaE 2017-04-09 07:43:15: ERROR[Main]: ServerError: AsyncErr: environment_Step: Runtime error from mod 'pipeworks' in callback environment_Step(): Runtime error from mod '??' in callback l_add_item(): Invalid float vector dimension range 'y' (expected -2.14748e+06 < y < 2.14748e+06 got -3.3609 05:48 VanessaE why why why??? :( 05:48 VanessaE that's THREE mods this is happening in now 05:51 nore wtf 05:51 cheapie [00:00:54] merging #5480 in a bit 05:51 ShadowBot https://github.com/minetest/minetest/issues/5480 -- [CSM] Localplayer api lua by Dumbeldor 05:51 cheapie Expect a chat6 update soon :) 05:52 sofar uh 05:53 VanessaE print(dump(self.start_pos)) --> y=-336091086 wat? 05:53 VanessaE that's impossible, there's NO way my code can create such insane coords 05:53 sofar VanessaE: did that include 5480? 05:53 VanessaE 5480? 05:53 VanessaE #5480 05:53 ShadowBot https://github.com/minetest/minetest/issues/5480 -- [CSM] Localplayer api lua by Dumbeldor 05:53 VanessaE oh, no 05:53 sofar or is that just a random crash? 05:54 VanessaE it's a new crash 05:55 VanessaE but why is l_add_item() not just aborting/bailing out when given bad coords? 05:57 VanessaE looking at my code, the variable that's passing bad coords to that call is getting its numbers from self:getpos() 05:58 nore VanessaE: beware that this isn't an engine call 05:58 nore it's pipeworks' luaentity 05:59 VanessaE damn it. 06:00 VanessaE getpos = function(self) 06:00 VanessaE return vector.new(self._pos) 06:00 VanessaE end, 06:00 nore yup, you've got to look at how self._pos is modified 06:00 VanessaE I'm checking 06:01 nore could it be because you can get a huge dtime? 06:01 VanessaE damned if I know. 06:03 nore it might be that 06:03 nore IIRC there are strange things with dtime happening when pausing the game in singleplayer, for instance 06:05 sofar did the game get paused? 06:05 VanessaE no. 06:05 VanessaE happening on startup. 06:05 sofar does it carry the `core.after` patch I made a few days back? 06:05 VanessaE core.after? I don't know 06:06 VanessaE it's at 18c930d3 right now 06:15 VanessaE this sort of crash has been plaguing areas mod as well, and I forget which one was the third mod 06:18 cheapie Hmm... 06:18 cheapie VanessaE: Is that the whole error message up there, or was there more after the "9"? 06:19 VanessaE 2017-04-09 08:17:25: ERROR[Main]: e+07). 06:19 Zeno` VanessaE, does #335 require any special engine version to reproduce? 06:19 ShadowBot https://github.com/minetest/minetest/issues/335 -- fix screen flickering black when rendering to texture by doserj 06:20 VanessaE no idea, Zeno` 06:20 Zeno` err you know which one I mean 06:20 cheapie VanessaE: So -3.3609e+07? 06:20 VanessaE cheapie: yes 06:20 * cheapie continues researching 06:20 Zeno` https://github.com/minetest-mods/mesecons/issues/335 <-- this one 06:22 VanessaE Zeno`: I don't know if a specific engine build is needed, but the server on which it occurs is at 18c930d3 06:22 Zeno` ok, I'll let this test run for another half hour and then repeat it 06:24 cheapie VanessaE: Can you add a print(dump(self._pos)) in the function at luaentity.lua:176 (in pipeworks)? 06:25 sofar is there a way to increase falling damage? 06:25 VanessaE already did that actually 06:25 VanessaE vector.new 06:25 VanessaE { 06:25 VanessaE y = -74200885.669897, 06:25 VanessaE print(dump(vector.new(self._pos))) 06:25 VanessaE is how it gets that one. 06:26 cheapie So that's (partial) output from vector.new()? 06:26 VanessaE yeah. 06:26 VanessaE the X and Z are normal. 06:26 cheapie Is the input invalid as well? 06:26 VanessaE only Y is getting thrown off 06:26 VanessaE I'm still trying to track down how it's getting the bad input 06:29 cheapie IDK why it's going through vector.new() in the first place, but that's probably not the problem... 06:30 VanessaE nope, the coords are similar before or after. 06:31 cheapie Maybe try just patching around it for now, but put some checking in setpos to see if that gets "tripped"? 06:44 Zeno` I guess we ignore compiler warnings now? :D 06:46 Zeno` http://dpaste.com/0ADNJZ5 07:23 VanessaE seems that pipeworks somehow got garbage data from its luaentities "storage" file, but how the garbage got there, nore and I don't know. 07:23 VanessaE (except that it's a table that's serialized and deserialized. 07:23 VanessaE ) 10:05 EDAKIRI Thanks for the game, everyone. I have enjoyed it. 10:08 sfan5 Zeno`: nerzhul likes to just merge stuff and worry about compiler warnings later 10:10 Zeno` oh... that's a good plan 10:52 celeron55 you can double your commits if you first add some warnings and then get rid of them in a second commit! 10:56 Krock and actually fix the bugs caused by the changes in a 3rd commit 10:56 Krock and the 4th commit would be "nevermind, this didn't work, reverting." 11:19 Zeno` lol celeron55 12:25 Krock what the hell is going on with the collision detection?! 12:25 Krock detects Y change but the player isn't damaged afterwards 12:25 sfan5 now you know why i didn't want to touch too much with my sneaking changes 12:26 Krock yeah, it's still somewhat confusing. the collision is actually being added to the collision vector 12:52 paramat #5527 is ready to go, 2-node climb as much requested, and simple sneak ladders work too. perhaps we could merge soon so it gets wider testing long before release? 12:52 ShadowBot https://github.com/minetest/minetest/issues/5527 -- Sneak glitch: Detect ledge for 2-node climb-up by paramat 12:57 paramat Zeno` ^ in case you're interested 14:03 Zeno` to be honest if people can't even bother with compiler warnings then what is the point? 14:04 Zeno` "just ignore it, it's your compilers fault" is not an answer 14:05 Zeno` if it really *is* the compilers fault then write code that suppresses the warnings :/ 14:11 Fixer Is it possible to draw a mapblock borders via CSM? 14:11 red-001 not yet(tm) 15:27 red-001 #5550 15:27 ShadowBot https://github.com/minetest/minetest/issues/5550 -- [CSM] Move `.list_players` and `.disconnect` to builtin. by red-001 15:48 nore why does #1118 get in *every* milestone when it's not ready and won't be? 15:48 ShadowBot https://github.com/minetest/minetest/issues/1118 -- Meta set nodedef by Ekdohibs 15:49 paramat hehe 15:57 Fixer maybe it becames ready miraculously 15:57 Fixer by someone suddenly improving it 16:04 nore heh 16:04 nore not me, I'm not able to :) 16:06 paramat the number of set milestones is quite optimistic 17:47 paramat i assume the 3s damage disable is because when an admin teleports a player they would not know the exact y of terrain level and players would get damaged from the fall 17:47 sfan5 that sounds like a stupid solution to a stupid problem 18:01 red-001 almost 900 issues 18:02 Krock paramat, same as my thoughts about this timer 18:02 Krock red-001, soon 1000, but each one will make it more difficult for the players to find more, different issues 18:05 red-001 I have a feeling a lot of them are old issues that are no longer relevent 18:07 Fixer 237 of them are marked as bugs 18:08 Krock 381 feature requests 18:11 red-001 have there been any other reports of #5418 ? 18:11 ShadowBot https://github.com/minetest/minetest/issues/5418 -- Server crash with clientmod 18:13 Fixer can someone label those? https://github.com/minetest/minetest/issues?utf8=%E2%9C%93&q=is%3Aissue%20is%3Aopen%20no%3Alabel 18:13 Fixer and those https://github.com/minetest/minetest_game/issues?utf8=%E2%9C%93&q=is%3Aissue%20is%3Aopen%20no%3Alabel 18:16 red-001 doesn't the client already disconnect if it loses connection? #4564 18:16 ShadowBot https://github.com/minetest/minetest/issues/4564 -- [Request] Make client timeout if RTT < 0. 18:16 Fixer red-001: nope 18:17 red-001 huh 18:17 * red-001 checks 18:21 red-001 just check it kicks me telling me I timedout about 30s after I killed the server 18:22 Krock celeron55, could we please add a new rule for issues overall? It's quite annoying to have several bug reports in one issue, example: #5132 . Either they should be edited to only one issue or closed with an [invalid] tag. 18:22 ShadowBot https://github.com/minetest/minetest/issues/5132 -- Bug in nodeboxes and collision check. And ghost slabs again, in version 0.4.15 18:22 Krock ^ need other opinions here too. coredevs. 18:25 celeron55 Krock: do we really not have a rule for that? it seems like common sense... 18:26 Krock I've looked through the wiki pages but it seems to be limited to PRs 18:26 Fixer it does, i think paramat tried to enforce it 18:26 Fixer it is rarely crop ups, I once posted doublebug, but later i split it in two 18:28 celeron55 https://github.com/minetest/minetest/blob/master/CONTRIBUTING.md#issues 18:28 celeron55 it should be added here 18:29 celeron55 it really doesn't say there should be one issue per issue, which seems obvious but i guess not then 18:29 celeron55 i think the most important reason is discussion 18:30 celeron55 if there are multiple issues in an issue, it's cumbersome to try to comment about any of them specifically 18:31 celeron55 or refer to them from a PR or a commit 18:35 Krock just the fact that the issue wasn't closed from someone else yet.. yeah. 18:38 paramat i agree with that close 18:38 paramat the author has done that before too 18:39 paramat most issues in that issue are fixed or duplicate anyway 18:52 Fixer paramat: https://github.com/minetest/minetest/issues/2283 can be closed 18:54 paramat wow it's actually merged, ok 18:54 Krock not entirely sure. we could leave it open for further improvements 19:13 paramat closed #4793 19:13 ShadowBot https://github.com/minetest/minetest/issues/4793 -- Out of memory with remove_node in vines mod 19:13 Fixer https://github.com/minetest/minetest/issues/4528 "we will work on this after release (0.4.15)" :p 19:14 paramat is true, could be years after :] 19:16 Fixer yeah, lol 19:26 red-001 paramat, for #5255 do you want me to revent `lua_toboolean(L, 4) ? 0 : 1;` back to `lua_toboolean(L, 4);` ? 19:26 ShadowBot https://github.com/minetest/minetest/issues/5255 -- Add option to also check the center to `find_node_near` by red-001 19:26 Krock ^ but that would result in wrong behaviour, no? 19:27 red-001 I meant `!lua_toboolean(L, 4);` 19:28 Krock but the cubic radius is an integer; nonsense to use boolean expressions there 19:28 Krock it may be correct but .. eh 19:28 Krock s/correct/valid,working/ 19:29 red-001 iirc the c++ standard says that true == 1 and false == 0 in all cases but I see your point 19:40 red-001 the rebase need tag can be removed from #5255 and #5492 19:40 ShadowBot https://github.com/minetest/minetest/issues/5255 -- Add option to also check the center to `find_node_near` by red-001 19:40 ShadowBot https://github.com/minetest/minetest/issues/5492 -- [CSM] Add local particles and particlespawners. by red-001 19:42 red-001 wow I see there was a mass closing of issues 19:42 paramat red i'm not sure what is correct, just asking to address the comments :] 20:12 red-001 could someone review #5499? 20:12 ShadowBot https://github.com/minetest/minetest/issues/5499 -- [CSM] Add `on_joinplayer` and `on_leaveplayer` callbacks. by red-001 20:50 red-001 #5553 20:50 ShadowBot https://github.com/minetest/minetest/issues/5553 -- [CSM] Use more gettext by red-001 23:28 est31 friendly reminder, seems like I'm still listed as active core dev. would be nice if I could be moved to the previous core dev section 23:28 est31 https://github.com/minetest/minetest/blob/master/builtin/mainmenu/tab_credits.lua#L31 23:39 VanessaE one of the users on my server has an oddity with his chats, 23:39 VanessaE [04-09 19:39] [0010][0010] A while ago. [0010] It seems to put a space in every time i type a capital letter, which is where the box is. could that be it [0010] ? 23:39 VanessaE except the [0010] is a little unicode box. 23:40 Fixer what client he uses? 23:40 VanessaE says he's using a mac mini, with Minetest 0.4.15 (official build?) 23:40 Fixer good night %) 23:40 VanessaE night 23:42 VanessaE (official build is 'yes') 23:42 VanessaE seems to happen any time he has to hit the 'shift' key 23:54 VanessaE #4074 seems to be the fix 23:54 ShadowBot https://github.com/minetest/minetest/issues/4074 -- Fix #4057 (weird Shift behavior) by neoascetic 23:54 VanessaE (does not appear it was ever merged)