Time Nick Message 03:33 sofar Merged #5305 03:33 ShadowBot https://github.com/minetest/minetest/issues/5305 -- Fix multiple death messages (#3565) by presstabstart 03:42 sofar any comments on #5416 ? 03:42 ShadowBot https://github.com/minetest/minetest/issues/5416 -- Windows: Skip cmd for release builds by adrido 03:42 sofar temted to merge it as well 03:43 sofar testing joystick patch with my controller 03:57 sofar merging #5506 03:57 ShadowBot https://github.com/minetest/minetest/issues/5506 -- Add Joystick type detection and Xbox controller support by rubenwardy 03:59 sofar paramat: we need to do the milestone for mtg as well, completely didn't think of that until now 04:05 sofar nore: did you test #5437? 04:05 ShadowBot https://github.com/minetest/minetest/issues/5437 -- Fix problems when overriding the hand by Ekdohibs 04:11 sofar well, it tests OK 04:13 sofar Will merge #5437 04:13 ShadowBot https://github.com/minetest/minetest/issues/5437 -- Fix problems when overriding the hand by Ekdohibs 04:14 VanessaE sofar: can you add #5186 to the milestone also? 04:14 ShadowBot https://github.com/minetest/minetest/issues/5186 -- Soft node overlay by juhdanad 04:15 sofar VanessaE: done, but I'm doubtful that one will make it tbh 04:15 VanessaE thanks. I hope it makes it, but ok. 04:34 sofar ick, I forgot to squash one 04:35 VanessaE skimming through mt_game issues, I wonder if a milestone is needed there too... 04:35 VanessaE (I don't have any specific suggestions, just that some stuff here and there looks like it might want to be addressed before release) 04:38 sofar merging #5526 04:38 ShadowBot https://github.com/minetest/minetest/issues/5526 -- Add the REQUIRE_LUAJIT option by YuGiOhJCJ 04:53 VanessaE also, #5057 should be added to the 0.4.16 milestone. I've tested this one extensively, it works well. 04:53 ShadowBot https://github.com/minetest/minetest/issues/5057 -- Undersampling by numberZero 04:53 VanessaE (please :) ) 05:07 Zeno` seems reasonable to me, VanessaE 05:08 Zeno` done then :P 05:09 sofar ah, thanks 05:10 nerzhul hi Zeno` ! 05:10 Zeno` hi nerzhul 05:10 Zeno` hi sofar 05:10 VanessaE greetz, Zeno` 05:10 nerzhul long time we saw you :) 05:11 Zeno` didn't realise you will still here sofar... I should enable timestamps heheh 05:11 Zeno` nerzhul, I've been watching in the background ;) 05:11 sofar Zeno`: it's ok, was fixing master breakage, lol 05:13 nerzhul hi sofar 05:13 sofar bon matin 05:13 nerzhul sofar, please look my comment on #4981 05:13 ShadowBot https://github.com/minetest/minetest/issues/4981 -- [WIP] Damage cheat fix: server side by nerzhul 05:14 nerzhul "bon matin" ? it's a litteral translation from english but we never say that :) we way "Bonjour" 05:14 nerzhul merging #5416 05:14 ShadowBot https://github.com/minetest/minetest/issues/5416 -- Windows: Skip cmd for release builds by adrido 05:14 sofar yeah but "jour" means day 05:15 sofar not morning 05:19 sofar #5526? 05:19 ShadowBot https://github.com/minetest/minetest/issues/5526 -- Add the REQUIRE_LUAJIT option by YuGiOhJCJ 05:20 nerzhul yes you can merge 05:21 QwertyDragon Minetest 0.4.15-dev-94358a7 :) ty 05:29 nerzhul sofar, are you in holidays ? 05:31 kaeza is it intentional that `load` function is disabled? 05:31 kaeza in client-side I mean 05:31 nerzhul yes 05:31 kaeza why? 05:32 nerzhul we forbid every unsecure function at CSM dev startup, in lua you should use require keyword instead 05:32 nerzhul but... builtin uses load if i remember 05:32 kaeza uh, `load` is used to compile code from strings 05:32 kaeza is also used* 05:34 sofar nerzhul: nope 05:34 kaeza oh well, I can use loadstring/setfenv 05:34 sofar no holidays 05:35 nerzhul kaeza, there is dofile for include other files 05:35 kaeza nerzhul, I need to load code from a string at runtime 05:35 kaeza i.e. no files involved at all 05:36 kaeza loadstring+setfenv combo works, so meh 05:38 nerzhul it's a bit more complicated for you but more secure for end users , load is unsecure and permits to load more than strings if i remember 05:39 nore what happens if an user tries to load bytecode btw? 05:39 nore (with things such as loadstring, and bytecode calling for instance io functions) 05:40 kaeza nore, nice catch there 05:40 nerzhul io functions are forbidden nore 05:41 nore nerzhul: they are, but I wonder what happens if it is in already-compiled bytecode 05:41 * nore should just test 05:42 kaeza nerzhul, Lua does not validate bytecode, and it's recommended to just filter that if you want security 05:42 nerzhul nore, it they are in bytecode you call a Lua binding, but if it's not available it should just fail no ? 05:43 kaeza AFAIK it's as easy as checking if the code starts with an escape character (0x1B, 27) 05:43 kaeza http://lua-users.org/wiki/SandBoxes 05:47 kaeza http://lua-users.org/lists/lua-l/2010-08/msg00487.html 06:49 nerzhul pushing clang-format on 11 tiny header files and remove them from blacklist 06:50 nerzhul whitelist* 06:51 red-001 bytecode should be filtered already 06:53 nerzhul 168 pr, wow thanks sofar for permitting some merges, we have so many work to do but it's better :p 07:03 sofar mostly low hanging fruit 07:03 sofar just keep pacing away at it 09:51 celeron55 it's interesting how a bit of undersampling doesn't really hurt at all 09:52 celeron55 it's almost a stylistic choice 10:05 Calinou yes, but no filtering :( 13:41 benrob0329 Should a 1.0.0 milestone start to be planned out? 13:51 nrzkt benrob0329: no 13:51 Fixer 1.0.0 will be released in year 2100 13:52 benrob0329 Minetest is gaining support and playerbase fastercas time goes on 14:26 Krock the mgv7 floatlands are enabled by default, right? 14:27 Fixer last time i tried them they were disabled, hold on 14:28 Fixer Krock: disabled by default 14:28 Krock okay 14:37 Krock #5534 14:37 ShadowBot https://github.com/minetest/minetest/issues/5534 -- Settings: Update documentation by SmallJoker 14:49 Krock thanks rubenwardy :) 14:49 Krock that was quick 14:51 nrzkt Krock: wow so many problems in doc 14:51 DS-minetest um 14:52 Krock nrzkt, also found some more settings that aren't documented but these are not supposed to be used from regular players (debugging keys) 14:52 Krock thanks for for Lua's "match" function. Regex makes the life much easier :) 14:52 Krock -for 14:57 nrzkt Krock: grep -R "blah " :D 14:57 Krock lol 15:02 kilbith gcc warnings : https://hastebin.com/setehiwama.cpp 15:03 kilbith (comparing non-signed and signed values) 15:06 kilbith also : https://hastebin.com/atagebacey.c 15:10 nrzkt Krock: merging #5534 15:10 ShadowBot https://github.com/minetest/minetest/issues/5534 -- Settings: Update documentation by SmallJoker 15:10 Krock ok 15:12 nrzkt Krock: can you look at #5499 ? i fixed the doc point you mentionned on red-001 pr 15:12 ShadowBot https://github.com/minetest/minetest/issues/5499 -- [CSM] Add `on_joinplayer` and `on_leaveplayer` callbacks. by red-001 15:13 * Krock headdesks 15:13 Krock sofar didn't mean it this way 15:13 Krock his comment was about BOTH functions 15:14 nrzkt oops i misread :p 15:14 nrzkt maybe you can update it to fix it ? :D 15:14 Krock i.e. * `minetest.register_on_joinplayer(func(name))` 15:14 Krock * Called when a remote player disconnects from the server 15:14 Krock err 15:14 Krock *connectes 15:14 nrzkt the feature edit PR from callers should be sometimes used by us to fix trivial things instead of waiting the PR owner death :p 15:14 nrzkt i should go i cannot fix it :) 15:16 Krock fixed 15:20 red-001 on_joinplayer is also called for the client itself 15:20 red-001 not just remote players 15:21 red-001 but I suppose all player already on the server part covers that 15:30 red-001 could someone review #5528? 15:30 ShadowBot https://github.com/minetest/minetest/issues/5528 -- Move chat command handling code from c++ to lua. by red-001 15:41 benrob0329 If/when a mob api is added, can mobs be spawnes like biom decorations? 15:42 benrob0329 if they don't despawn, then if 2 of the same mobs exist, a baby has a chanse of being spawned 15:43 benrob0329 And for every consecutive mob in a range, the odds of one spawning a baby increase 16:01 Krock Pushing MSVC compiling fix for cavegen.cpp in ~10 minutes: https://pastebin.com/raw/tdFDT1yc 16:19 rubenwardy What was the error? 16:20 Krock non-constant array length 16:20 Krock pointers don't have a restriction there 16:23 rubenwardy odd http://stackoverflow.com/a/20011090/1604177 16:25 Krock "VS only supports up to the C89 standard, and AFAIK MS has no plans to support the later C standards at all. " ^ 16:25 Krock M$ once more outdated, lean and mean 16:27 Krock and for some reason the cmd window is gone. --console arg and setting in the minetest.conf is not working. 16:28 * Krock thinks the compiler looks a bit suspicious 16:33 * Krock notices that it actually works and the irrlicht messages now are hidden 17:08 red-001 updated #5492 17:08 ShadowBot https://github.com/minetest/minetest/issues/5492 -- [CSM] Add local particles and particlespawners. by red-001 17:50 rubenwardy Krock: update 17:50 rubenwardy *updated 17:51 Krock ack 17:54 rubenwardy just compiling and rerunning tests... 18:08 rubenwardy pushing in 10 trivial fix https://github.com/rubenwardy/minetest/commit/271d7c31e69db0bb6c5cf2cfb6e97ba129045d3e 18:08 rubenwardy !title 18:08 ShadowBot Fix signed/unsigned conversion warning · rubenwardy/minetest@271d7c3 · GitHub 18:10 sofar :+0.5: 18:18 rubenwardy done 18:26 VanessaE nerzhul: about 54ffc4e9, how bad of a leak was it? 18:27 rubenwardy if that's localplayer, not very 18:27 VanessaE on a server 18:28 nerzhul VanessaE, no impact on server 18:28 VanessaE ok. 18:28 nerzhul it's just for client, one object remain in memory after each disconnection 18:29 VanessaE I only ask because I've been trying to track down a severe leak and happened to notice that commit. 18:30 VanessaE (severe as in 5+ GB after ~12 hours) 18:30 nerzhul VanessaE, remember Lua mods can also trigger leaks 18:30 VanessaE yeah I know. I assume it's some mod somewehre 18:30 VanessaE mesecons possibly, not sure yet 18:30 VanessaE just grasping at straws :) 18:31 rubenwardy try valgrind 18:31 rubenwardy although the full memchecker is slow 18:31 rubenwardy not as slow as callgrind though 18:31 nerzhul valgrind is not good for production use but the leak can be shown fast, and if it's in the lua objects you cannot track it 18:33 VanessaE besides, if valgrind can't track individual lua objects, then it's no better really than my normal stats page :) 18:34 halt_ hey rubenwardy if ur still on, i noticed ur ctf has been down for a while, is it temp down or perminantly? 18:34 * GreenDimond wonders that^ too... 18:34 rubenwardy wrong channel, and permanently 18:35 halt_ k thnx 19:01 halt_ my minetest on my dell optiplex 780 (windows 10) doesnt seem to load public servers, it sits on media i think its my wifi adaptor as it has the bandwidth of a rpi1 but im not sure, any way i could see what the problem is? 19:08 VanessaE did you build with cURL support? 19:08 halt_ i just downloaded it from minetest.org and unzipped 19:09 VanessaE no idea then 19:09 halt_ lol k 19:09 VanessaE (I would assume it is) 19:09 red-001 minetest.org? 19:09 VanessaE and yeah 19:09 VanessaE don't get it from minetest.org 19:09 VanessaE that's not the official source 19:09 VanessaE minetest.net is 19:10 halt_ yea, though minetest.org would be oldcoders "spoon" of minetest 19:10 red-001 someone should tell oldcoder the build is not working 19:10 VanessaE something like that. 19:10 VanessaE just go get it from minetest.net or build it yourself if you can 19:10 VanessaE or better, 19:11 VanessaE https://minetest.kitsunemimi.pw/builds/ 19:11 VanessaE get it from here 19:11 red-001 ^ 19:11 halt_ it works on ubuntu 16.04 but seems faulty on windows 10 :/ 19:11 VanessaE those are the official development builds. 19:11 halt_ kk 19:11 red-001 building on windows is a pain 19:11 halt_ hmm i gtg soon :/ 19:12 red-001 so much so that installing linux is an easier solution then figuring it out 19:13 halt_ yea ive got ubuntu 16.04 deul-booted on here but id rather have mt working on both sides :/ 19:14 VanessaE you shouldn't dual-boot. you should use a virtual machine for the secondary OS. 19:14 VanessaE it's much more convenient 19:14 red-001 it forces you to make one os your primary 19:15 VanessaE red-001: which is easy to swallow. make it linux. :) 19:15 halt_ whats the differance bewtween a primary and secondary os? 19:15 halt_ im still a noobie at this stuff :P 19:15 red-001 anyway if you have a decent system re-booting isn't excaully time consuming 19:15 nerzhul VanessaE, no need for minetest.net or .org just use github releases 19:16 VanessaE that works, too 19:16 nerzhul https://github.com/minetest/minetest/releases 19:16 nerzhul official, inalterable :p 19:16 VanessaE wait, why are we discussing this in -dev? 19:16 red-001 dunno 19:16 red-001 I suppose because it started out as a bug report 19:16 VanessaE heh ok 19:16 halt_ lol yea 19:17 VanessaE anyways do what nerzhul said, or get minetest from sfan5's site if you need a development build. 19:17 halt_ k thnx 4 helping 20:18 Hijiri Is there a case where minetest.serialize data is deserialized in CPP, to be used in CPP? 20:18 Hijiri Ideally on the client 20:20 celeron55 there aren't 20:21 celeron55 we've used json for cases like that 20:21 Hijiri alright 20:21 celeron55 (altough, not sure if any of them get close to that anyway) 20:21 Hijiri I am thinking maybe the meta tool override thing should just have the whole definition so it can be used later for overriding other things 20:22 Hijiri and was worried about the additional restrictions JSON has on structure 20:22 celeron55 it's generally kind of bad to have that much flexibility in data that's transferred over network to C++ as the sending code could parse and optimize it beforehand 20:22 Hijiri do you think I should add a new meta thing instead of just using meta ref fields? 20:24 celeron55 not sure, but performance and cross-version compatibility is important 20:25 Hijiri alright 20:27 sofar Hijiri: itemstack meta "description" is displayed as tooltip already 20:27 sofar look at that? that's use from c++ 20:28 nerzhul sofar, okay for #5499 now? 20:28 ShadowBot https://github.com/minetest/minetest/issues/5499 -- [CSM] Add `on_joinplayer` and `on_leaveplayer` callbacks. by red-001 20:28 sofar sec, debugging some C code here 20:28 rubenwardy Hijiri, item meta is stored as part of the item string, and sent to the client whenever it changes 20:29 rubenwardy old metadata was done the same way 20:34 Hijiri I mean, should it be separate API-wise from the current meta data 20:34 Hijiri then the modder isn't explicitly serializing a definition and the C++ code can serialize it itself 20:35 Hijiri (for example saving tool capabilities using the existing tool capabilities serializer/deserializer) 20:36 Hijiri and only serializing the fields that override support exists for 20:37 Hijiri description is a meta field, but there's no real way to make it smaller since it's just a display string 20:37 Hijiri tool capabilities is more ordered and could be stored more packed 20:45 red-001 I'm getting a 413 when trying to post on the forum 20:46 red-001 werid it's working now 20:47 red-001 oh I think it was caused by trying to upload a screenshot 20:49 GreenDimond I get forum errors a ton. 20:50 GreenDimond But when I use chrome it goes smoothly. 20:50 GreenDimond On firefox, I get errors sometimes even when editing or replying to a post. 20:50 Hijiri I've never had an error like that when posting, and I use firefox 20:54 red-001 https://github.com/vlapsley/minetest/tree/mapgen_carpathian 21:17 rubenwardy #5538 21:17 ShadowBot https://github.com/minetest/minetest/issues/5538 -- Create API to allow safe teleporting 21:24 nerzhul rubenwardy, please be more precise 21:24 rubenwardy sofar linked to that in another channel 21:31 nerzhul pushing some header clang-format + merging #5531 21:31 ShadowBot https://github.com/minetest/minetest/issues/5531 -- Store legacy metadata separate from new item meta data by rubenwardy 21:31 nerzhul oh no, not merging rubenwardy pushed commits, then just first tak 21:31 nerzhul task 21:32 nerzhul maybe we can now merge #5480 sofar ? 21:32 ShadowBot https://github.com/minetest/minetest/issues/5480 -- [CSM] Localplayer api lua by Dumbeldor 21:32 sofar no 21:32 rubenwardy yeah, I realised that I missed one place where it was checking for empty string - conversion from old formats 21:33 nerzhul why no ? 21:33 rubenwardy it's now fixed (and I grepped again to make sue) 21:33 sofar just commented 21:33 sofar nerzhul: I have not been able to reliable get the handle 21:33 sofar it worked a few times 21:33 sofar but, for the past 20 runs it completely failed 21:33 sofar if it doesn't work then it shouldn't be merged 21:33 nerzhul as i said you will not get the handle if you try to get it before player is connected 21:33 sofar my code tries to get it every second 21:34 sofar forever 21:34 sofar until it gets a handle 21:34 sofar the last time it tried for 15 minutes 21:34 nerzhul wtf 21:34 nerzhul look at this https://github.com/minetest/minetest/pull/5480/files#diff-34f48ad91ac6c202ac60b0348ae90e30R1869 21:34 sofar exactly 21:34 nerzhul did you enable client modding ? 21:34 sofar yes because it also, in the same lua client mod file, added particles 21:35 sofar I even print out the handle every time I fetch it 21:35 sofar nil 21:35 sofar nil 21:35 sofar nil 21:35 sofar etc 21:35 nerzhul what do you call ? 21:35 nerzhul core.localplayer ? 21:35 sofar I'll try again tonight, don't have the code because I'm at work 21:35 nerzhul okay 21:36 sofar if someone else verifies it, ok, let them post their code 21:36 sofar I'm fairly sure I may be doing it wrong 21:36 sofar but, I had it working 21:36 sofar so, idk 21:36 sofar I can try in ~5hrs from now or so 21:37 nerzhul when loading csreen disappear and you are ingame the creation call was done 21:37 nerzhul just call minetest.localplayer or core.localplayer 21:37 sofar that's what my code does 21:37 nerzhul strange 21:38 sofar very 21:39 sofar https://gist.githubusercontent.com/sofar/96b1c80601a2865cbc9c6e195a10c6dd/raw/e0d3fa81409f2de0c8085ab031872a7635f76971/init.lua 21:39 sofar try it yourself? 21:44 Dumbeldor :o 21:44 Dumbeldor i try 21:46 nerzhul hmmm i should fix the cmake build CMakeLists.txt in lib/ folder by default doesn't respect the default values, due to cmake scopes, in src it was masked, i got the fix, i'm finishing testing 21:47 Dumbeldor sofar: https://pastebin.com/hdeERRzc 21:48 sofar that's a wild stab, you have no idea how long a client will take to finish loading 21:48 sofar it could take 5 minutes 21:48 nerzhul sofar, you should listen for connection event 21:48 sofar how? 21:48 rubenwardy why are client scripts initialised before the game has loaded? 21:48 rubenwardy that's odd 21:48 nerzhul no 21:48 nerzhul mods are loaded with env 21:49 sofar explain how my lua code is broken 21:49 nerzhul this permits to prevent a complete client loading on server before crashing due to a mod 21:49 sofar with actualy working code, please 21:49 nerzhul wait a minute i'm on a build fix 21:49 sofar lol 21:50 nerzhul i cannot switch my branches during a compilation :p 21:52 numzero there is `git worktree` :p 21:56 nerzhul yes but i don't want to open clion two times :p 21:56 Dumbeldor sofar: minetest.register_on_connect(à does not exist i think :( 21:57 sofar :) 21:57 sofar nerzhul: I open my client several times a lot 21:57 sofar it's nice 21:58 nerzhul exact my bad we don't have a callback on player in worl 21:58 nerzhul world 21:58 Dumbeldor :D 21:58 nerzhul we need a such thing to permits mods to trigger behaviour on connection 21:59 Dumbeldor Yep 21:59 sofar right 21:59 sofar Ideally, I do 21:59 sofar minetest.register_on_connect(function() 21:59 sofar me = minetest.localplayer 21:59 Dumbeldor Yeah 21:59 sofar do_stuff() 21:59 sofar end 21:59 nerzhul it's not very difficult, Dumbeldor can you provide the patch ? the callback should be done just after making player available 22:00 Dumbeldor In a new PR ? 22:00 nerzhul yes 22:00 sofar also 22:00 Dumbeldor Fine 22:00 sofar assert(me) 22:00 sofar :) 22:00 Hijiri or me = assert(minetest.localplayer) if we want to code golf 22:01 Dumbeldor I don't know very well the lua. Can you test if a variable is empty no? 22:01 Hijiri yeah 22:01 Hijiri if it's "empty" it has the value nil 22:01 Dumbeldor Okay 22:01 Hijiri assert errors if its argument is falsey (false or nil), and returns the argument otherwise 22:08 nerzhul okay build is good on travis on my repository, i'm pushing a cmake default build fix to restore the original behaviour 22:10 nerzhul seems MacOSX is in holidays on travis :p no more OSX builds in CI 22:11 nerzhul guys can you vote on which PR you prefer #5539 or #5537 22:12 ShadowBot https://github.com/minetest/minetest/issues/5539 -- Document that write_json will error on unserializable types. by raymoo 22:12 ShadowBot https://github.com/minetest/minetest/issues/5537 -- Modify minetest.write_json to match the documentation. by raymoo 22:12 nerzhul personnaly 5539 is better for me because serializing unk things to nil just hides a potential serialization problem error in some specific cases 22:21 numzero 5539 is better 22:21 Hijiri I agree 22:21 Hijiri my original reason to do 5537 was potentially to hackily serialize item definitions 22:22 Hijiri but that doesn't really fit with the intended use case 22:22 Hijiri usually modders don't want to override the entire definition, so they would only be providing serializable parts anyway (assuming I was serializing with JSON) 22:30 Dumbeldor Aye sofar review #5540 ? :) 22:30 ShadowBot https://github.com/minetest/minetest/issues/5540 -- [CSM] Add event on_connect player API lua by Dumbeldor 22:31 Dumbeldor I will write the documentation there. ;) 22:37 Dumbeldor Done 22:55 GreenDimond Was anything regarding entities changed in 0.4.15-dev? LNJ's 'Storage Drawers' mod isn't working " the drawer visual entity doesn't spawn on MT 0.4.15-dev (so you can't click it to add/remove items), do you know if something was changed there?" -LNJ So I was wondering if there was anything changed in 0.4.15-dev that would make that happen.