| Time |
Nick |
Message |
| 00:00 |
twoelk |
fixer related? |
| 00:00 |
Fixer |
i have few ideas, need to check day/night cycle, have suspicion about it |
| 00:00 |
* twoelk |
has lights on his cycle that he uses at day and night |
| 00:01 |
Fixer |
vrange 20, looking at sky, nothing in my view - 70fps (and limiter is disabled), videocard performance is ok |
| 00:01 |
Fixer |
it should be near 200... |
| 00:02 |
VanessaE |
paramat: let's put it this way... what good reason was there to add those dirt nodes with the forest litter? :) |
| 00:02 |
Fixer |
https://i.imgur.com/JRTAuTj.png |
| 00:02 |
paramat |
there was good reason, forest surfaces are important |
| 00:03 |
paramat |
same for dead needles in coniferous forest, they really improve the world |
| 00:03 |
VanessaE |
ok. how about silver sand? :) |
| 00:04 |
VanessaE |
(rhetorical questions, btw) |
| 00:04 |
VanessaE |
point being, you have your reasons for adding stuff, as do the rest of us |
| 00:04 |
Fixer |
are there any changes about fps_max/wanted_fps etc in code? |
| 00:04 |
VanessaE |
Fixer: those aren't even used anymore are they? |
| 00:04 |
VanessaE |
(well maybe max is) |
| 00:05 |
Fixer |
this bug is very strange |
| 00:05 |
kaeza |
silver sand is an offering to the spirit of Minetest, obv |
| 00:05 |
Fixer |
and it happend after day/night transition while alt-tabbing, this is suspicious |
| 00:05 |
Fixer |
it is not the first time |
| 00:05 |
twoelk |
I'm all for adding tin. maybe also marble and granit in contrast to quarz |
| 00:05 |
Fixer |
silver sand is amazing with it new blocks |
| 00:05 |
kaeza |
while we're discussing things to add, can we have some basic furniture in MTG? |
| 00:05 |
Fixer |
its |
| 00:06 |
twoelk |
kaeza: 1+ |
| 00:06 |
VanessaE |
^ take what you want from homedecor, but please don't change the look. |
| 00:06 |
kaeza |
just tables and chairs for now |
| 00:06 |
paramat |
anyway, if there's a good reason to add silver, that's ok, but i don't see one, very many people do not use mods that require moreores ores. mithril no, we already have a magickal mese ore we don't need more fantasy ores. tin has a good reason so that's ok |
| 00:06 |
VanessaE |
silver naturally just goes along with gold |
| 00:06 |
paramat |
silver sand has a good reason too |
| 00:06 |
VanessaE |
it's just a natural paring, like peas and carrots, or peanut butter and jelly ;) |
| 00:07 |
twoelk |
stan and laurel? |
| 00:07 |
VanessaE |
siskel and ebert :P |
| 00:07 |
paramat |
yeah i'm unsure about silver, we already have a silvery metal, steel |
| 00:07 |
VanessaE |
but seriously, if you talk about gold in the real world, someone will always bring up silver (or even suggest it in lieu of gold) |
| 00:07 |
VanessaE |
steel is not silvery by any means. |
| 00:08 |
VanessaE |
(well not as I'd define it) |
| 00:08 |
VanessaE |
and way different properties. I don't remember what uses it, aside from homedecor's brass recipe. |
| 00:08 |
paramat |
perhaps silver could have a much shinier texture than steel |
| 00:08 |
VanessaE |
yeah |
| 00:09 |
* twoelk |
doesn't like gold and silver usage in tools and weapons anyways |
| 00:09 |
VanessaE |
as for mithril or whatever you'd call it, do remember that "the other game" has lapis lazuli. |
| 00:09 |
VanessaE |
(I have no idea what it's used for there, though) |
| 00:09 |
paramat |
i'm just thinking about uses, silver doesn't seem as fundamental as gold, even if for just decoration, but maybe .. |
| 00:10 |
paramat |
nevermind about what MC has :] |
| 00:11 |
kaeza |
VanessaE, just lapis lazuli blocks, and blue dye last time I checked |
| 00:11 |
VanessaE |
*checks MC wiki* ... lapis is used for ... not much. it can be made into decorative blocks, blue dye, and whatever the hell enchanting is for in that game,. |
| 00:11 |
twoelk |
lapislazuli combined with gold or pyrite just looks amazingly beautiful |
| 00:11 |
Fixer |
this testing results means that i'm fucked |
| 00:12 |
Fixer |
i'm so fucked |
| 00:12 |
VanessaE |
so the MC team thought that those two are good enough reasons. seems to me MT shouldn't need anything more |
| 00:12 |
Fixer |
i need to literally bisect this somehow |
| 00:12 |
Fixer |
and catch that bug |
| 00:12 |
Fixer |
that will need weeks |
| 00:12 |
Fixer |
holy shit |
| 00:12 |
VanessaE |
(though I *would* at least prefer to see new stuff put to immediate use in some recipe, if possible) |
| 00:13 |
Fixer |
this sucks so much :( |
| 00:14 |
Fixer |
just won't go past 80fps... wth |
| 00:14 |
VanessaE |
paramat: it's not "MC has it, so let's add it too just to keep up". it's rather, "MC devs thought there was a reason to add it, so we have at least that much reason too". |
| 00:15 |
twoelk |
somehow that referance to mc devs feels wrong |
| 00:15 |
Fixer |
MT have a lot in common with MC, even bugs are the same sometimes, but that does not mean it needs to be copied, but a lot of MC aspects are well thought out, like inventory management |
| 00:15 |
VanessaE |
no one's saying to copy MC. |
| 00:15 |
VanessaE |
G*d no |
| 00:15 |
Fixer |
it is so damn fast and efficient |
| 00:16 |
Fixer |
at least we have shift-click |
| 00:16 |
VanessaE |
but for every item we discuss adding, we really need to consider if MC has it (or an equivalent). If it does, then that alone is a good enough reason to add it to MT -- barring a good reason NOT to (e.g. the proposed code sucks, or the texture is ugly, or it's trademarked/copyrighted, etc) |
| 00:17 |
Fixer |
is fps meter is broken O_o |
| 00:17 |
Fixer |
o_____O ? |
| 00:18 |
* twoelk |
hands Fixer a basic measuring rod |
| 00:18 |
Fixer |
not broken, fraps confirmed |
| 00:18 |
Fixer |
out of ideas, i'm fucked, will bisect this, so pissed |
| 00:18 |
Fixer |
that will take a ton of time |
| 00:18 |
VanessaE |
what are you trying to fix? |
| 00:18 |
Fixer |
random permanent fps drop |
| 00:18 |
VanessaE |
oh. |
| 00:19 |
Fixer |
hoooly crap |
| 00:19 |
VanessaE |
just playing for a while will do that. |
| 00:19 |
Fixer |
160fps |
| 00:19 |
Fixer |
wtf??? |
| 00:19 |
Fixer |
bug is gone |
| 00:19 |
Fixer |
WTF |
| 00:19 |
VanessaE |
go on VE-S, run from spawn to the extreme west end of West St, then come back. your fps will be lower at spawn than when you started. |
| 00:19 |
Fixer |
wtf was that? |
| 00:19 |
Fixer |
how to explain? |
| 00:19 |
VanessaE |
(keep your view range set low, say 50m) |
| 00:20 |
Fixer |
VanessaE: don't start this again, that is different issue |
| 00:20 |
twoelk |
Fixer are you sure your machine and setup is not influenced by something outside of minetest? |
| 00:20 |
VanessaE |
Fixer: there are two FPS killers that I've found.. one is that ^^^ and the other is loading lots of entities. |
| 00:20 |
Fixer |
twoelk: nothing changed in my PC, videocard and CPU is also healthy |
| 00:20 |
twoelk |
room temperature? |
| 00:20 |
Fixer |
VanessaE: two entities |
| 00:20 |
Fixer |
twoelk: everything is normal, room temp is 21*C |
| 00:21 |
twoelk |
buildup of dust on fan? |
| 00:21 |
Fixer |
NO |
| 00:21 |
Fixer |
temps are checked and ok |
| 00:21 |
Fixer |
no throttling or anything |
| 00:21 |
twoelk |
;-P |
| 00:21 |
Fixer |
it just went back to 160 fps |
| 00:21 |
Fixer |
-_____________________________- |
| 00:22 |
Fixer |
like after 20 minutes it went back to normal |
| 00:22 |
epoch |
garbage collected? |
| 00:22 |
Fixer |
epoch: i'm on MP server, not my problem |
| 00:23 |
Fixer |
at least not lua one |
| 00:23 |
twoelk |
just for the records, firefox is behaving strangely lately on my setup - sometimes jittering other stuff when open in the background |
| 00:24 |
Fixer |
twoelk: i will investigate outside causes like rainlendar and other, it is strange, when alt-tabbed it was at 160fps already... |
| 00:24 |
Fixer |
180 now... |
| 00:24 |
|
jin_xi joined #minetest-dev |
| 00:24 |
Fixer |
THIS IS FINE |
| 00:24 |
epoch |
I'm getting 1 FPS, but my hardware is pretty crap. |
| 00:25 |
Fixer |
wait a second |
| 00:26 |
Fixer |
this 20 minutes thing may suggest smth |
| 00:26 |
Fixer |
map unloading? |
| 00:30 |
twoelk |
some saving to database? (maptolocal?) |
| 00:31 |
Fixer |
https://cloud.githubusercontent.com/assets/16494741/24481841/cc90141e-14f5-11e7-8d91-8bf620b44394.png vs https://cloud.githubusercontent.com/assets/16494741/24482359/41c9a8aa-14f9-11e7-88cd-33bec32c08cb.png |
| 00:31 |
Fixer |
??? |
| 00:32 |
Fixer |
need to bisect this for sure |
| 00:32 |
Fixer |
will start tommorrow |
| 00:33 |
Fixer |
gn |
| 00:55 |
paramat |
" for every item we discuss adding, we really need to consider if MC has it (or an equivalent). If it does, then that alone is a good enough reason to add it to MT" nope, obviously |
| 01:02 |
|
twoelk left #minetest-dev |
| 01:06 |
VanessaE |
why nope? |
| 01:31 |
epoch |
attempting to make a minecraft clone is the job of a mod? |
| 01:34 |
VanessaE |
who said anything about cloning it? |
| 01:34 |
VanessaE |
I was referencing their decision process. |
| 01:35 |
epoch |
if any item could be added only because minecraft has it, then every item from minecraft would be added. |
| 01:35 |
VanessaE |
given MC's success, if they say it's good enough, we'd do well to keep that in mind. |
| 01:35 |
VanessaE |
(where "it" means specifically adding a node or something) |
| 01:36 |
VanessaE |
so if MT wants to reject something that's found in MC, there needs to be a compelling reason to do so. |
| 01:46 |
epoch |
is devs saying "we don't want to write or maintain it" compelling enough? |
| 01:47 |
VanessaE |
well put it this way: if it really were, would MT exist at all? |
| 01:47 |
epoch |
I figure since minetest exists they actually wanted to make it exist. |
| 01:48 |
epoch |
since they haven't added all the items from minecraft I figure they wouldn't enjoy doing it. |
| 01:49 |
epoch |
I write open source software for fun, but if I get to a point where it isn't fun anymore I stop. |
| 01:50 |
VanessaE |
that's why you have contributors. |
| 01:50 |
VanessaE |
I get your point though |
| 01:51 |
epoch |
contributors increase workload of a project leader unless the contributors can be trusted to review and merge their own pull requests. |
| 01:52 |
epoch |
and after the additions have been put it in, they're still there after the contributor gets bored and wanders off to never be seen again. |
| 01:52 |
VanessaE |
well I give up trying to convince anyone. |
| 02:15 |
paramat |
#5478 updated, will merge with game#1673 in 30+ mins. sofar in case you want to look |
| 02:15 |
ShadowBot |
https://github.com/minetest/minetest/issues/5478 -- Paramtype2: Add missing type CPT2_GLASSLIKE_LIQUID_LEVEL by paramat |
| 02:15 |
ShadowBot |
https://github.com/minetest/minetest_game/issues/1673 -- Glasslike_framed nodes: Add 'glasslikeliquidlevel' paramtype2 by paramat |
| 02:23 |
VanessaE |
blah, Minetest still doesn't handle fullscreen properly in a multi-head environment |
| 02:27 |
paramat |
will also merge game#1675 (trivial typo fix) |
| 02:27 |
ShadowBot |
https://github.com/minetest/minetest_game/issues/1675 -- Carts: Remove '+' added in commit 077316b by paramat |
| 02:27 |
VanessaE |
meanwhile, undersampling actually looks acceptable to me |
| 02:27 |
VanessaE |
and gives me a pretty good boost in performance as well. |
| 02:35 |
VanessaE |
(the test zone is VE-Survival spawn, looking from the clear block toward the public mine (at ~315 degrees yaw). Before: barely 25 fps at 40m, with HDX256. Now, I get 25fps at 80-90m (some variance) with HDX256 |
| 02:47 |
|
johnnyjoy joined #minetest-dev |
| 03:13 |
sofar |
VanessaE: who is @andersje? |
| 03:14 |
VanessaE |
? |
| 03:14 |
VanessaE |
er, |
| 03:14 |
VanessaE |
I recognize the name but I don't remember who he is |
| 03:15 |
VanessaE |
why? |
| 03:17 |
sofar |
stained_glass mod, he transferred it to me |
| 03:17 |
VanessaE |
ah yes |
| 03:17 |
sofar |
but, no discussion or issue opened first |
| 03:17 |
VanessaE |
https://github.com/andersje/stained_glass/pull/3 |
| 03:18 |
VanessaE |
he acted on my suggestion. not sure why he didn't contact you first. |
| 03:18 |
|
eidy joined #minetest-dev |
| 03:23 |
paramat |
merging games 1673 1675 during next few mins |
| 03:27 |
paramat |
complete |
| 03:29 |
epoch |
is it a bug or a feature that I can catch myself from a huge fall without damage on a sneak elevator? |
| 03:30 |
epoch |
I figure it is a bug, but boy is it handy digging straight down. |
| 03:39 |
paramat |
erm |
| 03:40 |
paramat |
bug, we're trying to avoid damage evasion |
| 03:41 |
epoch |
yeah, darn. oh well. bugs are more important than safely falling 500 blocks. |
| 03:41 |
epoch |
:) |
| 03:42 |
epoch |
I'll setup a better test environment to make sure all recent stuff hasn't affected it. |
| 03:42 |
paramat |
what commit are you on? |
| 03:43 |
epoch |
I was on that... liquids in glasses branch. going to the pullup branch. |
| 03:44 |
paramat |
there is an issue open for this, it was thought the new code fixes this, and it does mostly, but ther are a few rare situations where damage can still be avoided, so it's undesirable but not a huge problem |
| 03:44 |
paramat |
*there |
| 03:45 |
epoch |
a rope would be a nice item. |
| 03:46 |
epoch |
would need to use a lot of wool or something to make it. |
| 03:47 |
epoch |
I guess I could just make ladders all the way down the tunnel. that might take a while, but not as long as it would to build stairs. |
| 03:47 |
* epoch |
waits for minetest to rebuild |
| 03:51 |
paramat |
merging #5478 |
| 03:51 |
ShadowBot |
https://github.com/minetest/minetest/issues/5478 -- Paramtype2: Add missing type CPT2_GLASSLIKE_LIQUID_LEVEL by paramat |
| 03:55 |
paramat |
complete |
| 04:01 |
|
eidy joined #minetest-dev |
| 04:02 |
|
lordfingle joined #minetest-dev |
| 04:09 |
epoch |
just tested. bug works awesome. |
| 04:10 |
paramat |
awesome to have a bug? :] |
| 04:11 |
paramat |
i doubt my pullup branch will fix that bug |
| 04:11 |
epoch |
it doesn't. |
| 04:11 |
paramat |
hehe |
| 04:11 |
paramat |
game#1676 |
| 04:12 |
ShadowBot |
https://github.com/minetest/minetest_game/issues/1676 -- Leafdecay: Do not restart aready running timers by paramat |
| 04:12 |
epoch |
can hop on the elevator at the top and slowly lower yourself down by letting go of sneak for a second. |
| 04:12 |
epoch |
or just jump down and hope you can time it right. |
| 04:12 |
|
est31 joined #minetest-dev |
| 04:13 |
epoch |
or only start the "elevator" where you want to stop and hold shift and jump all the way down. |
| 04:14 |
epoch |
works without holding jump. |
| 04:15 |
lordfingle |
I have been getting an intermittent issue for a couple of months where lua seems to stop executing on the server. (Windows 32bit - Feb 2017 - 0.4.15) I have tried every level of DEBUG I can think of on the lua and C++ side. It seems to happen more when there's mapgen going on...I am not getting memory errors at all. I have tried progressively adding and removing mods, and adding tracing but the issue seems so |
| 04:15 |
lordfingle |
random. Any suggestions? |
| 04:19 |
epoch |
(I bet I could dig myself an elevator to lower myself down an already dug shaft) |
| 04:21 |
epoch |
>_> I also keep getting hit through walls. |
| 04:24 |
epoch |
I haven't looked at the code that runs the lua, but... |
| 04:24 |
epoch |
hrm. |
| 04:25 |
epoch |
maybe I should. |
| 04:25 |
lordfingle |
why not? it's educational |
| 04:27 |
epoch |
I'm going to bet the fun code is in src/script |
| 04:31 |
lordfingle |
nope. thats just where all the cmake/build stuff goes |
| 04:31 |
epoch |
the lua_api dir in that dir though. |
| 04:31 |
epoch |
l_mapgen.cpp maybe? |
| 04:32 |
lordfingle |
Correct sorry. lua_api is where the minetest api is defined |
| 04:32 |
epoch |
if it isn't giving any debug info it might be that some error value returned from some function isn't checked. |
| 04:33 |
lordfingle |
hmmm maybe |
| 04:33 |
epoch |
or it is and just isn't being logged. |
| 04:33 |
lordfingle |
interestingly when I quit, the exe stays in memory. My working theory is it's stuck in a loop somewhere |
| 04:35 |
epoch |
which map generator are you using? |
| 04:35 |
lordfingle |
v7 |
| 04:35 |
epoch |
infinite loop might be an accidental integer overflow or something weird. |
| 04:35 |
paramat |
going up sneak ladder is very controllable too, hold sneak and tap jump occasionally |
| 04:36 |
paramat |
just confirmed that sneaking on slabs in lower half of node is fixed |
| 04:37 |
epoch |
wait, so the main program exits but there's still another going? |
| 04:38 |
* epoch |
greps for fork |
| 04:38 |
lordfingle |
Running on a single machine. I startup in a mode similar to singleplayer, where both client and server are in the same process. When I quit the client (and the issue is happening) the exe stays in memory. |
| 04:39 |
|
book` joined #minetest-dev |
| 04:39 |
lordfingle |
I have confirmed that the problem happens on the official Dec 2016 release version of 0.4.15 as well |
| 04:40 |
lordfingle |
If I quit before lua stops working, the exe quits normally. |
| 04:49 |
|
ssieb joined #minetest-dev |
| 04:51 |
paramat |
sneak on a 1/16th nodebox seems to work now |
| 04:54 |
paramat |
so looking through #5438 there are only minor issues left with new sneak, and my PR might successfully add 2 node jump, so we're making good progress |
| 04:54 |
ShadowBot |
https://github.com/minetest/minetest/issues/5438 -- Sneaking on 1/16th slab bug, and other sneak issues |
| 04:56 |
|
MrIbby joined #minetest-dev |
| 05:05 |
|
nerzhul joined #minetest-dev |
| 05:08 |
|
Hunterz joined #minetest-dev |
| 05:36 |
|
Vadtec joined #minetest-dev |
| 06:14 |
|
MrIbby joined #minetest-dev |
| 07:13 |
|
^v joined #minetest-dev |
| 07:14 |
|
proller joined #minetest-dev |
| 07:33 |
|
nrzkt joined #minetest-dev |
| 09:06 |
|
kilbith joined #minetest-dev |
| 09:26 |
|
fireglow[m] joined #minetest-dev |
| 09:35 |
|
silwol joined #minetest-dev |
| 09:35 |
|
Megaf[m] joined #minetest-dev |
| 09:44 |
|
proller joined #minetest-dev |
| 09:56 |
|
YuGiOhJCJ joined #minetest-dev |
| 10:13 |
|
jin_xi joined #minetest-dev |
| 10:35 |
|
proller joined #minetest-dev |
| 11:12 |
|
proller joined #minetest-dev |
| 11:54 |
|
lordfingle joined #minetest-dev |
| 11:57 |
|
xunto joined #minetest-dev |
| 12:23 |
|
RobbieF joined #minetest-dev |
| 12:28 |
|
Fritigern joined #minetest-dev |
| 12:49 |
|
proller joined #minetest-dev |
| 13:09 |
|
Darcidride joined #minetest-dev |
| 13:09 |
|
troller joined #minetest-dev |
| 13:22 |
|
troller joined #minetest-dev |
| 13:35 |
|
blaze joined #minetest-dev |
| 13:40 |
|
glut32 joined #minetest-dev |
| 13:43 |
|
xtremehacker_ joined #minetest-dev |
| 13:43 |
|
octacian joined #minetest-dev |
| 13:48 |
|
twoelk joined #minetest-dev |
| 13:53 |
|
twoelk left #minetest-dev |
| 14:11 |
|
twoelk joined #minetest-dev |
| 14:54 |
|
Fixer joined #minetest-dev |
| 15:13 |
|
est31 joined #minetest-dev |
| 15:18 |
|
RobbieF joined #minetest-dev |
| 15:28 |
|
MoNTE48 joined #minetest-dev |
| 15:42 |
|
troller joined #minetest-dev |
| 16:21 |
|
troller joined #minetest-dev |
| 16:52 |
|
nerzhul joined #minetest-dev |
| 17:01 |
|
twoelk|2 joined #minetest-dev |
| 17:02 |
|
Krock joined #minetest-dev |
| 17:02 |
|
Krock joined #minetest-dev |
| 17:03 |
|
Grandolf joined #minetest-dev |
| 17:22 |
|
kaeza joined #minetest-dev |
| 17:35 |
|
Hunterz joined #minetest-dev |
| 17:54 |
|
dmurph_ joined #minetest-dev |
| 17:59 |
|
thatgraemeguy joined #minetest-dev |
| 17:59 |
|
thatgraemeguy joined #minetest-dev |
| 18:00 |
|
exoplanet joined #minetest-dev |
| 18:00 |
|
exoplanet joined #minetest-dev |
| 18:00 |
|
Shara joined #minetest-dev |
| 18:03 |
|
Darcidride_ joined #minetest-dev |
| 18:22 |
|
kaeza joined #minetest-dev |
| 18:23 |
|
diemartin joined #minetest-dev |
| 18:28 |
nerzhul |
merging #5486 |
| 18:28 |
ShadowBot |
https://github.com/minetest/minetest/issues/5486 -- Windows: Set window icon by adrido |
| 18:29 |
Krock |
uh, that's quite fast |
| 18:34 |
|
troller joined #minetest-dev |
| 18:41 |
|
thatgraemeguy joined #minetest-dev |
| 18:41 |
|
thatgraemeguy joined #minetest-dev |
| 18:42 |
|
^v joined #minetest-dev |
| 19:00 |
red-004[IRC] |
should csm be able to disconnect the client form the server? |
| 19:02 |
nerzhul |
red-004[IRC], i this we should have a such call, it can be interesting |
| 19:02 |
nerzhul |
especially if we permit to customize main menu at a point |
| 19:02 |
red-004[IRC] |
what about exiting to os? |
| 19:04 |
nerzhul |
i'm not really for this |
| 19:05 |
|
paramat joined #minetest-dev |
| 19:12 |
paramat |
rubenwardy sofar Krock #5485 |
| 19:12 |
ShadowBot |
https://github.com/minetest/minetest/issues/5485 -- First commit for fine pointed by MarkuBu |
| 19:15 |
paramat |
sneaking on 1/16th nodes seems fixed now in latest MT #5438 |
| 19:15 |
ShadowBot |
https://github.com/minetest/minetest/issues/5438 -- Sneaking on 1/16th slab bug, and other sneak issues |
| 19:22 |
paramat |
#5382 could anyone review caverns? luckily i know what i'm doing here |
| 19:22 |
ShadowBot |
https://github.com/minetest/minetest/issues/5382 -- Cavegen/Mgv5/Mgv7: Add optional giant caverns by paramat |
| 19:22 |
red-004[IRC] |
done #5487 |
| 19:22 |
ShadowBot |
https://github.com/minetest/minetest/issues/5487 -- [CSM] Add function and chat command to disconnect from server. by red-001 |
| 19:25 |
nerzhul |
red-004[IRC], can you test calling disconnect in a on_shutdown callback please ? i want to see what happens |
| 19:26 |
red-004[IRC] |
nothing |
| 19:27 |
red-004[IRC] |
iirc it sets a is_shuting down flag to true or something like that |
| 19:28 |
red-004[IRC] |
huh |
| 19:28 |
nerzhul |
okay nice |
| 19:28 |
red-004[IRC] |
I was wrong |
| 19:28 |
nerzhul |
you should prevent this call on on_shutdown i think |
| 19:28 |
nerzhul |
or document it |
| 19:29 |
red-004[IRC] |
it causes a werid shutdown loop |
| 19:29 |
nerzhul |
then please fix it :p |
| 19:39 |
|
ssieb joined #minetest-dev |
| 19:43 |
|
Player_2 joined #minetest-dev |
| 19:55 |
Dumbeldor |
Can you review #5480 please |
| 19:55 |
ShadowBot |
https://github.com/minetest/minetest/issues/5480 -- Localplayer api lua by Dumbeldor |
| 19:57 |
nerzhul |
players into database is nearly finished, one point remaining, migrate from sqlite to pg, and pg to sqlite :) |
| 19:57 |
nerzhul |
#5475 needs a big eye |
| 19:57 |
ShadowBot |
https://github.com/minetest/minetest/issues/5475 -- WIP: player data to Database by nerzhul |
| 19:59 |
red-004[IRC] |
fixed the boot loop that could occur with #5487 |
| 19:59 |
ShadowBot |
https://github.com/minetest/minetest/issues/5487 -- [CSM] Add function and chat command to disconnect from server. by red-001 |
| 20:02 |
red-004[IRC] |
Dumbeldor, what happens when someone tries to use the localplayer ref while the client is loading? |
| 20:02 |
nerzhul |
red-004[IRC], it's not available |
| 20:02 |
nerzhul |
look at the callback |
| 20:02 |
Dumbeldor |
Yep nerzhul |
| 20:03 |
nerzhul |
in fact you can have localplayer as soon as luastack is created bu localplayer object is not very reliable |
| 20:03 |
nerzhul |
i discussed with him to delay the reference creation, it's now done when client send TOCLIENT_READY to server, it's before removing the loading screen client have all data |
| 20:04 |
nerzhul |
oh Dumbeldor you miss a think |
| 20:04 |
nerzhul |
you should check if client side modding is enabled before calling m_script->on_client_ready |
| 20:04 |
|
electrodude512 joined #minetest-dev |
| 20:04 |
red-004[IRC] |
you need to document the api |
| 20:04 |
Dumbeldor |
Ah yes nerzhul ! :o |
| 20:05 |
red-004[IRC] |
apart from that looks good to me |
| 20:05 |
red-004[IRC] |
maybe try merging some functions together |
| 20:06 |
nerzhul |
red-004[IRC], which functions ? |
| 20:06 |
nerzhul |
movement_speed maybe no ? |
| 20:06 |
red-004[IRC] |
yes |
| 20:06 |
nerzhul |
Dumbeldor, then you have to work :p |
| 20:07 |
red-004[IRC] |
the get_movement_* functions could be merged together and return a table |
| 20:08 |
red-004[IRC] |
maybe the get_physics_override_* functions could also be merged |
| 20:09 |
nerzhul |
red-004[IRC], it's already done |
| 20:09 |
Dumbeldor |
I have already merged together ;) |
| 20:10 |
red-004[IRC] |
github seems to cache stuff in werid ways form time to time |
| 20:10 |
red-004[IRC] |
it was showing me the old code |
| 20:10 |
Dumbeldor |
xD |
| 20:10 |
nerzhul |
red-004[IRC], CTRL + F5 |
| 21:01 |
|
RobbieF left #minetest-dev |
| 21:06 |
|
jin_xi joined #minetest-dev |
| 21:10 |
Dumbeldor |
red-004[IRC]: you can review ? :) |
| 21:11 |
|
Puka joined #minetest-dev |
| 22:01 |
red-004[IRC] |
Dumbeldor, added comments |
| 22:01 |
Dumbeldor |
thanks, but I go sleep :p |
| 22:02 |
Dumbeldor |
i look tomorrow bye |
| 22:53 |
|
troller joined #minetest-dev |
| 23:00 |
|
DI3HARD139 joined #minetest-dev |
| 23:18 |
Fixer |
paramat: why you don't try reproducing decay here? https://cloud.githubusercontent.com/assets/16494741/24323147/0789c918-117a-11e7-92cc-9cd1eacbf825.png v7, coordinates on screen |
| 23:18 |
Fixer |
paramat: link https://github.com/minetest/minetest_game/issues/1663#issuecomment-289215928 |
| 23:28 |
paramat |
it may depend on the order you remove trunks in |
| 23:29 |
paramat |
there's a tree node on the left that may be within 3 nodes of the leaves on the left |
| 23:29 |
Fixer |
oh |
| 23:29 |
paramat |
but i could try it yeah |
| 23:30 |
paramat |
but that might not explain MarkuBu's first post |
| 23:30 |
paramat |
but that has seed and co-ords too so i could test |
| 23:31 |
paramat |
#5453 seems good can anyone review? bugfix |
| 23:31 |
ShadowBot |
https://github.com/minetest/minetest/issues/5453 -- Fix upside down textures by numberZero |
| 23:48 |
VanessaE |
2017-03-30 19:47:59: ERROR[Main]: ....minetest/games/minetest_game/mods/default/functions.lua:372: Attempt to override non-existent item moretrees:jungletree_trunk |
| 23:48 |
VanessaE |
^^^ in the default.register_leafdecay() call, but that node IS defined. |
| 23:51 |
VanessaE |
nevermind, figured it out. just a confusion in my mod. |
| 23:56 |
|
Tmanyo joined #minetest-dev |
