Time  Nick       Message
01:53 paramat    game#1587
01:53 ShadowBot  https://github.com/minetest/minetest_game/issues/1587 -- Biomes: New ground node and textures for rainforest by paramat
03:13 paramat    proposal for new surface and decorations in temperate conifer forest (updated) https://github.com/minetest/minetest_game/issues/1570#issue-207693728
03:15 VanessaE   the ground texture could be a *little* more vibrant/noisy but +1
03:51 paramat    yes, maybe a little more contrast
03:52 VanessaE   yeah
03:55 paramat    plus i will use 2 types of fern
03:57 VanessaE   there are several types in plantlife as i recall, you're certainly welcome to use all of them
04:08 paramat    ok
06:40 paramat    will merge #5289 in a moment
06:40 ShadowBot  https://github.com/minetest/minetest/issues/5289 -- Dungeongen: Add and improve parameters by paramat
06:47 paramat    merging ..
06:51 paramat    .. complete
07:06 Zeno`      nice
07:08 paramat    now i can go nuts with dungeons
08:36 celeron55  http://i.imgur.com/RnMRgoQ.png
12:06 est31      lol
12:26 Fixer      this is fine!
14:44 Krock      Anyone up for a quick documentation review? #5311
14:44 ShadowBot  https://github.com/minetest/minetest/issues/5311 -- lua_api: Document minetest.features by SmallJoker
15:11 octacian   Krock: the documentation looked good to me just FYI.
15:16 Krock      k, thanks, octacian
16:18 VanessaE   juhdanad: sorry about the restart after login, I was working on mod updates.  it should be safe now.
16:18 juhdanad   No problem. But that is not related to development...
16:19 VanessaE   I know.
16:19 VanessaE   I figured your being there was. :P
16:26 VanessaE   juhdanad: speaking of development, did that overlay thing you were working on pan out? looking forward to removing some hacks in my mods :)
17:17 octacian   I'm working on a PR to show the owner of keys in the key description. At the same time, I have to move to the new key-based itemstack meta. Should moving to the new key-based itemstack meta be in a separate PR?
17:21 juhdanad   VanessaE: the overlay PR is waiting for #5227.
17:21 ShadowBot  https://github.com/minetest/minetest/issues/5227 -- [squashed] Refactor content_mapblock by numberZero
17:23 VanessaE   ok.
17:24 nore       octacian: I think one pr for both would be ok
17:24 octacian   nore: OK, submitting PR right now.
17:28 octacian   game#1589
17:28 ShadowBot  https://github.com/minetest/minetest_game/issues/1589 -- Keys: Show owner in description by octacian
17:50 octacian   nore: I added the compatibility code to my PR
17:50 octacian   Now, on to make books show the title in their description :D
17:57 octacian   sofar: seeing as you made the keys mod originally, would you be willing to review game#1589?
17:57 ShadowBot  https://github.com/minetest/minetest_game/issues/1589 -- Keys: Show owner in description by octacian
18:41 octacian   game#1590
18:41 ShadowBot  https://github.com/minetest/minetest_game/issues/1590 -- Books: Show title in description by octacian
19:45 sofar      octacian: you made one small error in the conversion
19:51 sofar      octacian: left another comment for you
20:00 octacian   sofar: OK, will look.
20:02 octacian   sofar: I don't quite see where the error is in the conversion code. I tested it and it works fine.
20:07 octacian   sofar: oh wait NVM. Found and fixed issue. I must've changed that after testing and didn't retest.
20:07 octacian   Pushing fix.
20:12 octacian   sofar: just pushing a change to show what the key is for. e.g. "Key to a Steel Door (owned by singleplayer)"
20:12 sofar      that looks good
20:12 octacian   ok
20:13 sofar      squash it if it's good
20:13 sofar      much easier to review
20:13 octacian   BTW, I'm going to make a PR introducing a workbench to rename items after this
20:13 sofar      do you know how?
20:13 octacian   How to do what? I typically just amend. It's quicker than squashing.
20:14 sofar      ah, you did already
20:14 sofar      nvm
20:14 sofar      github is sometimes slow to remove the old commits from the thread view
20:14 octacian   no, I didn't.
20:14 octacian   That was the fix to the other issue.
20:14 octacian   Now I'm pushing description chance :D
20:15 octacian   sofar: OK, all requested changes made and pushed.
20:18 octacian   Yay! That makes 2 dev approvals xD
20:20 octacian   sofar: also, if you've got time, could you review https://github.com/minetest/minetest_game/pull/1590?
20:21 sofar      actually
20:23 * sofar    comments once more
20:23 octacian   sofar: I thought about that.
20:23 octacian   However, the key is also owned by the player who owns the chest
20:23 octacian   Make sense?
20:24 sofar      no, that's nonsense
20:24 sofar      the key has no owner
20:24 octacian   IDK, maybe it's better to just entirely remove the parenthesis in order to avoid any confusing in the first place
20:24 octacian   I guess that's true.
20:24 octacian   From the MT sense though.
20:24 octacian   Gimme one moment
20:24 octacian   Will push
20:24 sofar      I'd remove the parentheses :)
20:24 sofar      really, this is all about english being so damn terse
20:25 octacian   Yep xD
20:25 sofar      We could easily say "A key that opens a chest that is owned by octacian"
20:25 octacian   That's way too long
20:25 sofar      exactly
20:25 octacian   And, puhsed.
20:25 octacian   * pushed
20:25 sofar      but in german or french it'll be that long
20:25 octacian   true
20:26 octacian   I really, REALLY, REALLY, dislike French.
20:26 sofar      bwahahaha
20:26 sofar      you canadian you
20:26 octacian   (I'm learning it as a second language ATM)
20:26 sfan5      why would you learn french as a second language ;_;
20:26 octacian   I hate how unspecific it is
20:27 octacian   sfan5: you got another suggestion? :P
20:27 * sofar    muzzles sfan5 before he can say "germ"
20:27 sfan5      depends on the alternatives
20:27 sfan5      spanish probably
20:27 sofar      french is a fine language
20:27 sofar      spanish is a fine language
20:27 Fixer      "A key that opens a chest that is owned by octacian"
20:27 sofar      german is a fine language
20:27 Fixer      wat?
20:27 octacian   Yeah, spanish doesn't seem like too bad a language.
20:27 sofar      dutch is fucked up :)
20:28 Fixer      "octacian's chest key"
20:28 octacian   Fixer: it's actually "Key to a Locked Chest owned by octacian"
20:28 Fixer      sofar: you just selfhating
20:28 Fixer      :trollface:
20:28 sfan5      Fixer: "key to octacian's chest" sounds nicer
20:28 nore       French is a nice language ^^'
20:28 octacian   Again, that's true. It does.
20:29 octacian   sofar: what do you think about sfan5's suggestion? It sounds nicer to me too.
20:29 nore       "clé du coffre de octacian" is short and not ambiguous btw
20:29 octacian   eh, wth. I'm changing it again.
20:30 nore       <+sofar> but in german or french it'll be that long <-- so no :p
20:30 sofar      octacian: sure, that works
20:30 sofar      octacian: did you test the old book conversion?
20:30 octacian   sofar: yes, it seems fine to me.
20:31 octacian   What I did is wrote the conversion part first, then updated the code to write to meta.
20:31 octacian   ..meaning that it was tested numerous times.
20:31 kaeza      "owned by $player" is horrible for translation BTW
20:31 kaeza      at least for spanish
20:31 kaeza      /random
20:31 Fixer      i have problems with german language, because of gluing text together in long words
20:33 kaeza      inanimate objects have genders in some languages (not a fan of linguistics, so I'll let somebody else explain :P)
20:33 Fixer      we are discussing this in wrong channek
20:33 kaeza      yep
20:34 octacian   sofar: OK, pushed final change.
20:34 sfan5      oh this is -dev didnt even notice
20:34 octacian   Should be ready to merge at any point.
20:34 octacian   le
20:34 octacian   * lel
20:37 sofar      octacian: "On the Origin of Species" by Charles Darwin
20:38 octacian   OK?
20:38 sofar      octacian: data.description = "\"" .. fields.title .. "\" by " .. data.owner
20:38 octacian   ah, I understand.
20:38 octacian   I need to show who it is by. Will do.
20:39 sofar      I think that's nicer
20:39 octacian   Same.
20:39 sofar      one question though
20:39 sofar      do you ever remove the old :get_metadata data from converted books?
20:40 sofar      I think you should
20:40 sofar      line 25 or so is a good place
20:41 sofar      rough connection?
20:41 octacian   Yeah. Connection isn't always that great.
20:41 sofar      <sofar> do you ever remove the old :get_metadata data from converted books?
20:41 sofar      <sofar> I think you should
20:41 sofar      <sofar> line 25 or so is a good place
20:41 octacian   It disconnects me once or twice everyday.
20:41 octacian   Yes, the old metadata is overwritten when I write the new meta with :from_table().
20:41 sofar      ah ok
20:42 sofar      just making sure
20:42 red-002    oh great apple change the name back to MacOs
20:42 red-002    as if that's not going to be really confusing
20:42 octacian   red-002: it's been MacOS for over 3 months
20:43 sofar      octacian: commit message: "show title and author of book in description"
20:44 sofar      oh, you haven't pushed an update yet
20:44 * sofar    tones down expectations
20:46 octacian   sofar: OK, will change at the same time.
20:46 octacian   I was getting more food :D
20:47 octacian   sofar: e.g. "The Test of Minetest by singleplayer:
20:47 octacian   does that look good?
20:48 sofar      no, do the quotes like I wrote it
20:48 sofar      "On the Origin of Species" by Charles Darwin
20:48 octacian   Thought you'd say that, but wasn't sure lol
20:49 sofar      "Relativity: The Special and General Theory" by Albert Einstein
20:49 octacian   OK, pushing.
20:49 sofar      "Moby-Dick; or, The Whale" by Herman Melville
20:49 octacian   (with updated commit message)
20:53 sofar      https://github.com/minetest/minetest_game/pull/1590#issuecomment-282586542
20:53 sofar      brb reading that book
20:55 octacian   sofar: sorry, but none of Charles Darwin's books are worth reading :P
20:55 * sofar    slaps you with a copy of Relativity
20:55 octacian   Ah, much better.
20:55 sofar      (it's not very thick)
20:55 sofar      hmm what to do
20:56 sofar      procrastinate or laundry folding?
20:56 octacian   That's a tough choice...
21:05 Fixer      sofar: is that key idea secure after all?
21:05 sofar      yes
21:06 sofar      the client has no means to send modified itemstacks to the server, so the client can never make a new key
21:06 Fixer      sofar: what if i save map with local map saving and read it?
21:06 sofar      again, the client has the secret, but you can never change the server's version of the key itemstack
21:08 Fixer      cool
21:09 Fixer      also, should we also show coordinates in key tooltip?
21:09 sofar      no, we never do
21:09 Fixer      ok
21:09 Fixer      good
21:10 Fixer      sofar: i wonder if we also can rename keys tooltips
21:10 octacian   Fixer: um, we can. That's how my PR works is by renaming the tooltip.
21:10 octacian   Same thing with books.
21:10 Fixer      say I want to name a key!
21:10 Fixer      i want this
21:11 octacian   That's where my WIP PR comes into place: a workbench allowing you to rename any itemstack.
21:11 octacian   by setting the `description` meta value of any itemstack, we can change the text shown on hover
21:12 Fixer      niiiice
21:13 octacian   Fixer: wasn't it you who created a thread on the forums that was updated whenever a new feature was added to MT?
21:13 octacian   Cause I lost the link
21:13 Fixer      yes
21:13 Fixer      i need to update it again
21:13 octacian   Could you give me the link?
21:14 Fixer      https://forum.minetest.net/viewtopic.php?f=5&t=15230
21:51 octacian   I'm working on a PR introducing a workbench to rename items.
21:51 octacian   Any ideas for the recipe?
21:51 octacian   Can't decide myself, and it's kinda important as the texture will depend on the recipe.
21:56 octacian   I was thinking something like "steel ingot", "", "steel ingot"; "wood", "steel ingot", "wood"; "wood", "", "wood";
21:56 celeron55  what's the real life counterpart to even doing that
21:56 octacian   celeron55: IDK, but I think we really need it.
21:56 celeron55  real items don't really have such metainformation 8)
21:57 octacian   Well... IRL the only way to do something like that, would be to have a labeler
21:58 VanessaE   celeron55: here it is.  :)  http://1.bp.blogspot.com/-DS6uR_AxR-o/U44mTxzZo8I/AAAAAAAAAc0/ZSofvk4N06g/s1600/LabelMaker.png
21:58 paramat    labelgun
21:58 VanessaE   ninja'd :D
21:58 paramat    lol
21:58 octacian   celeron55: hey, at least I'm not trying to add an Anvil :P
21:58 celeron55  octacian already ninjaed both of you
21:58 VanessaE   well shit :)
21:58 octacian   Anyways, anyone got idea? Or should I go with my original idea for now?
21:59 octacian   *ideas
22:01 paramat    well your recipe looks like a label-stamping bench, with a slot for the item on top, seems reasonable
22:01 octacian   Yeah, that's the concept.
22:02 paramat    unfortunately a label gun seems too modern to be universal enough
22:02 octacian   Yes.
22:02 octacian   Plus, IDK how it would work for items.
22:04 octacian   What do you guys think about moving sounds from MTG to somewhere in builtin? I think it would be nicer as mods wouldn't have to depend on default and initial subgame creation would be easier.
22:04 paramat    ew no
22:05 octacian   lol thought you'd say that.
22:05 paramat    all subgame media has to stay in the subgame
22:05 octacian   Seriously though, one way or another, I personally think that the sounds should be somewhere outside of default.
22:05 octacian   (there's lots of default-haters around)
22:06 nore       however, what about moving them to a mod called "sounds"?
22:06 octacian   That would be some improvement.
22:06 octacian   Mods wouldn't all have to depend on default.
22:07 octacian   What's with concatenating multiple strings together for formspecs when you could just use multi-line strings?
22:09 sofar      octacian: I wouldn't make a workbench node myself
22:10 octacian   sofar: ok..?
22:10 sofar      octacian: maybe a nametag tool that you can combine with the item-to-be-named on the craft grid
22:10 octacian   That'd probably be actually better
22:10 sofar      although that's probably a bit tricky
22:10 octacian   However, it would be a bit hard
22:11 sofar      however, it seems that would be a much more logical way for players
22:11 sofar      it can be done
22:11 octacian   yes.
22:11 sofar      minetest.register_on_craft
22:12 octacian   That exists?
22:12 octacian   such a tool should be in craftitems or tools?
22:13 sofar      look at the book copy method, I think you can use some of it
22:14 sofar      yeah, the nametag would be just an item, not a node
22:14 octacian   Yeah, IK, I was just asking if I should put it in craftitems.lua or tools.lua
22:14 sofar      craftitems.lua:165
22:14 octacian   ok
22:15 octacian   So the nametag should probably be in craftitems.lua...
22:15 sofar      easy, you can use the same method I think
22:15 sofar      yes, just define it and the recipe and the on_craft handler in the same section
22:15 Fixer      insane idea: name tools after combining them with a written book o_O
22:16 octacian   I'll put it right after books.
22:16 octacian   Fixer: that's not insane... It's almost exactly what I'm about to do.
22:16 sofar      octacian: also, ingredients for nametags?
22:16 octacian   IDK
22:16 sofar      octacian: how about 1 copper bar == 4 tags?
22:16 octacian   Maybe some paper too?
22:16 sofar      hmm
22:17 sofar      I wouldn't, since you should write with ink on paper
22:17 octacian   True
22:17 octacian   I feel like a single copper bar is a tiny bit too easy though.
22:17 octacian   Maybe not though
22:17 sofar      I don't think we have use for copper bars
22:17 sofar      so that's a nice addition
22:17 octacian   That's true.
22:17 octacian   We do use them for bronze, but again, there isn't really much of a use at all for bronze
22:18 octacian   Maybe use bronze bar instead of copper?
22:21 paramat    no copper is good, soft metal ideal for stamping a name onto
22:22 octacian   Ah, true. Will use.
22:22 twoelk     copper becomes rather valueable when you have the technic modpacks installed
22:35 octacian   sofar: I'm still unsure as to how to go about this, though I have made progress. Books register an additional craft recipe for duplication. I'd have to recipe a craft recipe with the nametag for every node and item this way.
22:35 * octacian will be afk for 40m.
22:38 sofar      octacian: I see
22:39 octacian   ..so I may have to go back to a workbench after all.
22:39 octacian   OK, I'm really gone now xD
23:06 octacian   sofar: I have a solution.
23:07 octacian   I'm going to create both a nametag and a workbench.
23:10 nerzhul    octacian, this discussion is not intended to be on -dev but in #minetest
23:11 octacian   nerzhul: at this point, I guess that's true. sorry :D
23:11 octacian   or -project :P
23:25 paramat    well, i think it's for a PR to MTGame so perhaps ok here
23:29 octacian   Well, discussion was going a bit further than needed IMO.
23:29 sofar      definitely ok in here
23:29 octacian   Whatever though xD
23:29 * sofar    smacks nerzhul with a mintest_game PR
23:32 octacian   For the nametag texture I modified the one used in another one of BlockMen's old mods, making it look like it had something written on it and gave it a more "coppery" look