Time  Nick        Message
01:28 garywhite   paramat: https://forum.minetest.net/viewtopic.php?f=3&t=9266 two_steps is advertising his hacked client again
01:35 paramat     i'm not a forum moderator, VanessaE ?
02:02 kaeza       garywhite, trashed
02:29 paramat     thanks
02:39 paramat     will merge #4953 in a moment
02:39 ShadowBot   https://github.com/minetest/minetest/issues/4953 -- Meshes: Make object mesh face shading consistent by paramat
02:43 paramat     merging
02:48 paramat     done
02:48 Zeno`       paramat, I personally don't think you need to worry about optimising #4961
02:48 ShadowBot   https://github.com/minetest/minetest/issues/4961 -- Mapblock mesh shading: Improve simple slope face shading by paramat
02:49 Zeno`       but if you're worried maybe use valgrind/cachegrind and get a real life performance profile?
02:49 Zeno`       you're adding two(?) conditionals
02:49 Zeno`       that's nothing
02:49 paramat     ok good :] i might see if i can simplify it though
02:49 Zeno`       k
04:40 paramat     this turned out surprisingly well #5028
04:40 ShadowBot   https://github.com/minetest/minetest/issues/5028 -- Mgv7 floatlands: Less dark skybox when underneath by paramat
19:14 ShadowNinja Pushing #4614.
19:14 ShadowBot   https://github.com/minetest/minetest/issues/4614 -- Enable mod security by default by ShadowNinja
20:56 nrzkt       merging #5022
20:56 ShadowBot   https://github.com/minetest/minetest/issues/5022 -- Cleanup content_sao by factorizing similar code parts + little perf fix by nerzhul
21:27 ShadowNinja Rebased #2604.
21:27 ShadowBot   https://github.com/minetest/minetest/issues/2604 -- Add support for multiple listen addesses by ShadowNinja
21:29 ShadowNinja That PR has a few unrelated things bundled in.  I'm working on seperating what I can now.
21:31 sofar       nice
21:45 red-001     could someone review #5000?
21:45 ShadowBot   https://github.com/minetest/minetest/issues/5000 -- Simpler serverlist search by red-001
22:01 ShadowNinja Also see #5030 and #5031 now (split out of 2604 ^)
22:01 ShadowBot   https://github.com/minetest/minetest/issues/5030 -- Organize defaultsettings.cpp by ShadowNinja
22:01 ShadowBot   https://github.com/minetest/minetest/issues/5031 -- Server list cleanup by ShadowNinja
22:02 ShadowNinja Those are nice and small and easy to review... ;-)
22:32 kaeza       the keymap_toggle_camera changes in 5030 look fugly TBH
22:32 kaeza       it was cleaner as it was
22:58 ShadowNinja #5032 also split out.
22:58 ShadowBot   https://github.com/minetest/minetest/issues/5032 -- Main menu tweaks by ShadowNinja
23:00 ShadowNinja Can anyone review those?  They're quite small and I'd like to get them in quickly since they'll have conflicts with other pulls.
23:02 ShadowNinja nrzkt, sfan5, sofar, Zeno`: ^
23:04 Zeno`       SN: yeah
23:04 Zeno`       it looks very simple
23:04 Zeno`       +1 from me
23:04 Zeno`       >= 2 approvals
23:04 Zeno`       *done*
23:08 est31       oh, rebase errors
23:15 ShadowNinja 5032 merged, still waiting on 5030 and 5031.
23:18 est31       I share paramat's opinion on 5030, it should be either redone, or read through very carefully, making sure nothing regressed
23:20 ShadowNinja I'll go over all of it.
23:34 ShadowNinja est31: I've gone through it, does it seem good now (I'll prabably apply Zeno's suggestion too).
23:35 est31       ok
23:36 est31       thanks for going over it again
23:40 Zeno`       I don't see a lot of point starting it from scratch
23:49 ShadowNinja I'm doing further organization now.  What do you think about sorting the entries in a category?
23:51 paramat     ?