Time Nick Message 00:48 Zeno` paramat, is there a function for finding the inside surfaces of caves? 00:48 Zeno` And if not is this something that's practical (well, rather do you think people would use it)? 00:49 Zeno` I've written it in Lua of course, just hoping I didn't miss an internal function somewhere 01:12 paramat erm 01:12 paramat the large and small caves of mgv6, and the large caves of all other mapgens, have 'gennotify' 01:13 paramat which records a position in the cave 01:14 paramat but gennotify doesn't record positions for the 3D noise tunnels 01:14 Zeno` hmm ok 01:14 paramat because they're continuous i guess, there is no one significant point 01:15 Zeno` yeah 01:15 paramat there is a PR somewhere that extends gennotify to notify of the massive caverns in mgvalleys 01:15 Zeno` yeah valleys is what I'm looking at actually 01:15 paramat anyway, extending gennotify would be the way to do it 01:16 paramat i think the PR was by duane-r 01:16 paramat at least the massive caverns have significant positions 01:17 Zeno` https://github.com/minetest/minetest/pull/3648 01:17 paramat yeah 01:17 Zeno` hmm 01:17 Zeno` I might re-open that 01:17 Zeno` not sure yet 01:17 Zeno` by reopen I mean adopt the code 01:18 paramat the implementation could be better 01:18 Zeno` not sure. Have to do some tests 01:18 paramat simpler and faster would be good 01:19 Zeno` I'm not sure it does exactly what I want but locating large caverns first might cut down on how many nodes Lua has to iterate over 01:19 Zeno` not sure... looking at it 01:19 paramat the other gennotifys return a very rough position, from which mods can add their own code to locate a useful position in the structure, so the gennotify position only needs to be very rough 01:20 paramat i think that was my objection to duane's method, overkill 01:22 Zeno` possibly yeah 01:22 Zeno` I'm going to have to use voxelmanip anyway so really I just want to know if there is a large cave or not (and the location of some random position in that cave) 01:22 Zeno` I might keep going with just doing it in Lua for now 01:25 paramat also of course, the massive caves are only in mvalleys, which is fairly experimental, gennotify is more for more standard caves 01:26 Zeno` yeah 01:50 jordan4ibanez How would I go about turning a .mts file into a table? 01:51 paramat i think there's a serialisation function .. 01:51 jordan4ibanez It seems to spit random garbage into the terminal 01:52 paramat https://github.com/minetest/minetest/blob/master/doc/lua_api.txt#L2553 01:53 paramat although i haven't used that yet 01:53 paramat good videos and good work btw 01:54 jordan4ibanez Thank you very much 01:55 jordan4ibanez This is my code http://pastie.org/10988696 01:55 jordan4ibanez It is resulting in this http://i.imgur.com/nJHKJmw.png 01:58 paramat hm 01:58 paramat can't access your paste atm 01:59 paramat yes i can 02:01 paramat could be a bug i guess, but i'm not totally sure the correct way to use this 02:01 paramat could you open an issue in engine with this info? 02:02 paramat at least then we won't forget 02:02 paramat any better with use comments false? 02:05 paramat hang on, shouldn't you set the format as lua? 02:07 paramat yes try "lua" 02:08 paramat no wonder you got nonsense :] 02:11 jordan4ibanez Oh there we go, I thought that was the schematic input! Thanks paramat 02:12 paramat good 02:23 paramat wow torches are super bright now, no one will complain about dim torches again. and yes i'll get used to them 02:33 paramat have been lighting up dungeons and noticing the difference 02:35 paramat http://i.imgur.com/7J3XBdU.png minetest mega-fortress using core dungeongen 03:15 jordan4ibanez Now there is a new hurdle, there's no way to convert http://pastebin.com/raw/qVV1ixWm to a table that I can find in the api 03:16 sofar which schematic is that? 03:16 sofar jordan4ibanez: isn't that e.g. https://github.com/minetest-mods/saveschems/blob/master/init.lua#L324 ? 03:17 jordan4ibanez sofar: Yes 03:17 jordan4ibanez Wait if there's an mts_save is there an mts_load? 03:18 jordan4ibanez I am having a hard time understanding how schematics function 03:19 paramat isn't that already a table though? 03:19 jordan4ibanez paramat: When you serialize it from the .mts file it becomes a table written in a string 03:22 paramat aha 03:23 paramat lua may have built-in functions for converting string to table 03:34 paramat so-far and i have worked with schems a bit so feel free to ask, but best discuss in minetest channel as it's not dev 03:51 Zeno` the only schematics I've worked with I generated from a hacky C program I wrote heh 05:02 sofar jordan4ibanez: there's no "mts" load. There's only a "mts place" I think 05:02 sofar that's why we keep the saveschems thing around 09:01 * rdococ probably has to go now. will be back in 6 and a half hours. 13:05 nrzkt can someone look at #4999, this PR is quite easy and require another approval 13:05 ShadowBot https://github.com/minetest/minetest/issues/4999 -- support older PostGreSQL versions by zeuner 15:39 sfan5 nrzkt: clang version 3.9.1 (tags/RELEASE_391/final) on Arch 15:40 nrzkt sfan5: thank, it's a warning, and i forget to compile with clang on my machine, thanks for the review, i will fix that this evening, maybe or tomorrow 15:40 nrzkt can you review #4999 it's quite trivial but interesting for Debian servers 15:40 ShadowBot https://github.com/minetest/minetest/issues/4999 -- support older PostGreSQL versions by zeuner 15:40 sfan5 in a minute 15:40 nrzkt thanks a lot :) 15:43 sfan5 pushing this small fix in 5 mins http://sprunge.us/DRHf?diff 15:45 sfan5 nrzkt: i don't know much about postgres but you have my +1 for 4999 15:46 rdococ ih 16:02 nrzkt sfan5: cool, thanks okay for your fix 16:03 nrzkt merged 4999 18:29 nrzkt sfan5, i fixed points mentionned by your review 19:24 nrzkt will merge #5009 soon and #4985 19:24 ShadowBot https://github.com/minetest/minetest/issues/5009 -- Add staticdata parameter to add_entity by Rui-Minetest 19:24 ShadowBot https://github.com/minetest/minetest/issues/4985 -- Environment & IGameDef code refactoring by nerzhul 19:38 juhdanad #4986 is done! 19:38 ShadowBot https://github.com/minetest/minetest/issues/4986 -- Hardware node coloring by juhdanad 19:41 nrzkt juhdanad, github says you should rebase 19:41 juhdanad But I have just rebased... 19:42 nrzkt are you sure you updated your local master branch ? 19:42 nrzkt clientenv.cpp, game.cpp mapblock_mesh.cpp/.h 19:42 nrzkt previous mentioned pr merged. 19:42 juhdanad Yes, it has conflicts with #5009. 19:43 ShadowBot https://github.com/minetest/minetest/issues/5009 -- Add staticdata parameter to add_entity by Rui-Minetest 19:43 juhdanad Should I rebase now or wait a bit? 19:43 * An0n3m0us test 19:44 paramat sfan5 and all #5014 19:44 ShadowBot https://github.com/minetest/minetest/issues/5014 -- Sky: Do not darken in dark places when above water_level by paramat 19:47 paramat oops you've already approved 19:47 paramat i'll wait for more input on that one 20:17 juhdanad I successfully rebased again! 20:26 sofar juhdanad: didn't you arr the raycast thing? 20:26 sofar *add 20:27 sofar juhdanad: is there a lua API for that? 20:27 juhdanad I can not add it, I'm not a core dev. 20:28 sofar that's not what I'm asking :) 20:30 sofar juhdanad: I'm not expecting you to be superman :) 20:31 juhdanad sofar: it has conflicts yet, but I will rebase soon. 20:37 sofar juhdanad: ohh there's a PR ? 20:38 sofar juhdanad: pr no? 20:39 sofar juhdanad: #4828? 20:39 ShadowBot https://github.com/minetest/minetest/issues/4828 -- Improved line_of_sight by juhdanad 20:43 juhdanad sofar: I was thinking about #4421. 20:43 ShadowBot https://github.com/minetest/minetest/issues/4421 -- Expose getPointedThing() as Raycast by juhdanad 21:43 juhdanad sofar: do you have any suggestions to make ItemStacks with the same node unmergeable? 21:44 juhdanad What happens if they have different metadata? 21:45 sofar juhdanad: we've tried to solve that problem before, and it really needs a solution 21:46 sofar juhdanad: it also solves the key name problem, if we'd standardize on how to embed a `description` in metadata 21:46 sofar juhdanad: you could have books with titles 21:46 sofar and `named` items 21:46 juhdanad So is hardware coloring useless until this issue is solved? 21:46 sofar no, it's not useless at all 21:47 sofar it's just not as nice as it could be 21:59 juhdanad #4421 is also rebased! 21:59 ShadowBot https://github.com/minetest/minetest/issues/4421 -- Expose getPointedThing() as Raycast by juhdanad 22:04 sofar juhdanad: #3449 was one of the concepts we explored 22:04 ShadowBot https://github.com/minetest/minetest/issues/3449 -- Display custom metedata description instead of node name in tooltip. by sofar 22:07 sofar sadly, it all ended with 22:07 sofar https://github.com/minetest/minetest/pull/3984#issuecomment-238214282 22:10 nore sofar: that's sad it was closed 22:10 nore this pr definitely needs to be rebased / to be reimplemented in a perhaps better way 22:12 sofar nore: aye, there's so many good stuff that can come from it 22:13 nore when item metadata is done with key-value storage, we can add something that overrides any property of the item as well 22:14 nore so it could for instance change dig times or other things like this 22:17 sofar tool enchantments, yes 22:19 nrzkt yes item buffs 22:21 sofar scribbly notes/ post-its would be possible too: "get eggs and milk" 22:21 sofar and you could pick up and place signs without losing the sign text, and still see the sign text while in your inventory 23:03 Zeno` hi 23:04 Zeno` I get this lighting glitch http://tinypic.com/view.php?pic=2isijnr&s=9#.WHQVkGcvA18 in 0.4.15 release (not my screenshot but I see the exact same thing) 23:04 Zeno` But I don't get it using HEAD 23:05 Zeno` was there a deliberate fix for it (I can't see any) or was it one of the other light/rendering related commits that accidentally fixed it 23:05 Zeno` those rendering issues are quite common (using 0.4.15) on that server I've been told 23:05 Zeno` and it's pretty ugly for a release version of the client ;) 23:06 sofar any mods? 23:06 Zeno` server side? yeah I suppose 23:06 Zeno` but why does that affect the client and behave differently in 0.4.15 (glitched) than head? 23:06 sofar moretrees? 23:06 Zeno` Shara? 23:07 Zeno` it looks like moretree yes 23:07 Zeno` I can join again if Shara doesn't answer 23:07 Shara Hello 23:07 Zeno` I don't get why I don't see it in HEAD though. 23:07 Shara There is no moretrees on that server 23:09 Shara It's a valleys mapgen server. Different trees on there are from ethereal. 23:09 Shara Which I heard did not have the same lighting issues as moretrees. 23:10 Zeno` I guess I could bisect it :3 23:10 Shara sofar: Are there any other mods that are known to possibly cause it? 23:10 Zeno` i hate bisecting when I have to join a server to see the issue though heh 23:11 Shara Zeno, poke sniper for access to the server if it helps. 23:11 Zeno` It won't help... it's client-side for sure 23:11 Shara Boo then :( 23:11 Zeno` well, at least the glitch being hidden if not fixed is client side 23:12 Shara Yea, but not many players are running dev version 23:12 Zeno` I know :( 23:13 paramat looks like a moretrees lighting bug 23:13 Zeno` and it's ugly for a release version 23:13 Shara paramat: I know, but there is no moretrees there. 23:13 Zeno` paramat, but why does the glitch not show in client HEAD (but it does using release 0.4.15)? 23:13 paramat oh, not moretrees then, it could be caused by a sapling growing 23:14 Shara Even default saplings? 23:14 paramat yes sometimes 23:14 paramat that's how bad bulk node light updates are 23:14 Zeno` paramat, which commit since 0.4.15 fixed the glitch do you know? 23:14 paramat there's a PR that might fix these bugs 23:14 Zeno` paramat, it's already fixed in the client 23:14 paramat afaik there have been no kight fixes since 0.4.15 23:15 Zeno` somehow 23:15 paramat (light) 23:15 Shara It's excessive on this server for some reason. Few messages every day asking me to fix them. 23:15 Zeno` since I don't see the glitch using HEAD 23:15 Zeno` but I do with 0.4.15 23:15 paramat ah so client version affects what you see 23:15 Zeno` yeah :) 23:16 Zeno` It's not my server, so nothing is changing server-side. Just which version of the client I use 23:16 paramat weird 23:17 Shara I suspect paramat is right about saplings though. I think every dark area I saw overlapped trees 23:18 paramat you would think that the light values there are stored in the world, so why a shadow dependent on client? 23:18 Zeno` I'm going to bisect to see if I can find what accidentally fixed it 23:20 paramat i can't see any obvious commits that would change this 23:21 nrzkt Zeno`, https://github.com/minetest/minetest/commit/094a5a73d3b9817d07c52754749f0828c4005b8c ? 23:22 paramat the light curve, i can't see how though, but maybe 23:23 paramat plus that's clientside 23:23 nrzkt guys, what about removing this tag ? https://github.com/minetest/minetest/releases/tag/sapier-20120115 23:23 nrzkt https://github.com/minetest/minetest/releases/tag/20120204_luaentity_allfaces 23:23 nrzkt and this 23:23 nrzkt https://github.com/minetest/minetest/releases/tag/sapier-20120207 23:23 nrzkt these tags doesn't match any real version scheme 23:23 Zeno` umm 23:24 Zeno` err 23:24 Zeno` $ git bisect good b387f95; git bisect bad 231ac33 23:24 Zeno` Some good revs are not ancestor of the bad rev. 23:24 Zeno` git bisect cannot work properly in this case. 23:24 Zeno` Maybe you mistake good and bad revs? 23:24 Zeno` :-o 23:24 Zeno` what's going on there? 23:25 nrzkt paramat, Zeno` okay for removing previous mentioned tag ? 23:25 paramat erm not sure 23:25 nrzkt maybe 0.5.0-dev branch too 23:25 Zeno` sofar, can you try that bisect with your repo? 23:25 Zeno` sofar, to rule out my repo being corrupt or broken somehow? 23:26 Zeno` don't finished it... just see if it starts for you :) 23:26 Zeno` s/finished/finish 23:26 paramat the tag names may be weird but those are still actual releases 23:27 paramat so i feel more input needed 23:28 paramat bu then, they are old and all 0.4.dev 23:28 Zeno` oh nvm. I 23:29 Zeno` oh nvm. I'm going a backwards bisect so I need to swap good/bad 23:29 Zeno` this should be umm... interesing 23:29 paramat and they are very close in time to surrounding releases 23:30 nrzkt paramat, yes, maybe 0.3.X 23:30 paramat well, removing those is fine by me 23:31 paramat they're only tags 23:31 nrzkt okay, done, there is no number doesn't make sense, and yes it's just tags 23:36 Zeno` commit 094a5a73d3b9817d07c52754749f0828c4005b8c 23:36 Zeno` Author: Auke Kok 23:36 Zeno` ^--- that fixes the glitch 23:36 Zeno` CC sofar 23:37 Zeno` dunno how, but it does 23:40 Zeno` So I don't know if we should make an "emergency release" or not 23:40 Zeno` The glitch is pretty annoying (and so is preparing a release heh) 23:41 Zeno` Since no (very, very few) Windows players build their own client... 23:41 Zeno` I'm not sure 23:42 Shara I sometimes think I am the only one who does (and that's because I have to...) 23:43 Zeno` Shara, install linux 23:43 Shara Fight that one out with both my work place and my university please :)