Minetest logo

IRC log for #minetest-dev, 2016-12-18

| Channels | #minetest-dev index | Today | | Google Search | Plaintext

All times shown according to UTC.

Time Nick Message
00:00 shymega left #minetest-dev
00:09 octacian joined #minetest-dev
00:39 Human_G33k joined #minetest-dev
02:11 lhofhansl1 joined #minetest-dev
02:14 lhofhansl1 #4922
02:14 ShadowBot https://github.com/minetest/minetest/issues/4922 -- Fix occlusing culling counting by lhofhansl
02:14 lhofhansl1 One-liner that makes occlusion culling more effective.
02:14 lhofhansl1 (I think the previous behavior was a bug)
02:17 est31 lhofhansl1: can you move the count++ to the top instead?
02:17 est31 its quite a hack imo to use the return value of ++count
02:17 est31 or bad style or whatever
02:20 lhofhansl1 Of course. I didn't see anything about this in the style guide. That's what ++xyz is for, though :)
02:20 lhofhansl1 Absolutely no problem to change it, though.
02:23 lhofhansl1 updated
02:47 Zeno` joined #minetest-dev
03:16 paramat joined #minetest-dev
03:18 paramat so, can anyone +1 #4847 ? although we should wait for Rogier-5's testing before a merge
03:18 ShadowBot https://github.com/minetest/minetest/issues/4847 -- Fix unnecessary block loading and duplicating objects by juhdanad
03:25 hmmmm why bother testing
03:25 hmmmm you can plainly see what it does
03:26 hmmmm if the emergethread refactor i did still had an open PR, and somebody pointed it out to me that loadBlock gets called unnecessarily, i would've just fixed it and that'd be the end of it
03:37 Zeno` paramat, I +1 it as well
03:37 Zeno` I only have an issue with some code that's badly structured but, meh, and I won't let that stop me +1'ing
03:37 paramat excellent
03:41 paramat if no-one has done so i'll merge that and 4922 tomorrow
03:42 Zeno` paramat, where is the change you made to caves?
03:42 hmmmm for bonus points, i tried coming up with a better structured piece of code but the logic really does not allow that...
03:42 Zeno` paramat, nvm found it
03:43 Zeno` hmmmm, yeah probably tricky. The solution I came up with was no better heh
03:43 paramat the 3D noise tunnels are epic now
03:43 Zeno` caves were the thing I hated most about mgv7
03:44 Zeno` they were more like wormholes
03:44 hmmmm the original caves or the V5/V6 hybrid?
03:44 Zeno` I like the v6 caves
03:44 Zeno` but the new caves seem better now
03:44 hmmmm i like both of them for different reasons
03:45 paramat i'm happy that sfan5 complained about the narrow tunnels
03:45 hmmmm once i get back to coding up minetest i'm sure i'll be able to come up with a better cave system
03:45 Zeno` well the narrow tunnels is probably what I disliked most (the "wormholes")
03:45 hmmmm i'm going on vacation soon
03:45 hmmmm btw
03:45 Zeno` they didn't seem natural
03:45 Zeno` hmmmm, going to see relatives?
03:45 hmmmm no, going to see minetest
03:46 Zeno` oh :D
03:46 hmmmm i have 2 weeks of PTO that i need to somehow use up by the end of the fiscal year
03:46 Zeno` does PTO expire over there?
03:46 paramat hey cool
03:46 hmmmm it varies from company to company
03:47 hmmmm the new trend is use-it-or-lose-it because Accounting doesn't like the idea of having a potentially huge payout when somebody leaves
03:47 Zeno` in AU we can let it accumulate for as long as we want (but some companies enforce you to take it, but if you don't they can't just say they won't pay you that money owing)
03:47 Zeno` well here, bigger companies just say "you're taking the PTO like it or not"
03:47 Zeno` you can't lose it though
03:47 Zeno` I had 18 weeks PTO at one point lol
03:47 hmmmm nice
03:47 Zeno` yeah
03:48 Zeno` until I got bored
03:48 hmmmm i dunno man, it's not just minetest though
03:48 hmmmm i'm at a slump in life in general
03:48 hmmmm so tired all the time
03:48 Zeno` every 10 years we get an additional 8-10 weeks on top of normal annual leave
03:48 hmmmm i've let you all down for sure
03:49 Zeno` yeah. fatigued all the time == not good
03:51 * Zeno` doesn't feel let down
03:52 Zeno` hmmmm has gotta look after hmmmm before minetest :)
03:52 paramat let us down? that's too hard on yourself
03:54 hmmmm you know, i don't think it's actually that difficult to make a unit test for EmergeManager/EmergeThread
03:54 hmmmm just gotta make a TestServerMap that tracks some calls and dummys out other things
03:55 hmmmm we'd catch tons of these logic errors by writing unit tests for them
04:17 Misero joined #minetest-dev
04:20 DI3HARD139 joined #minetest-dev
04:23 Misero is this channel also geared towards modding, or just the core of the game?
04:37 paramat #minetest channel for modding
04:38 paramat hmmmm in case you haven't seen this #4839
04:38 ShadowBot https://github.com/minetest/minetest/issues/4839 -- Support for recursive refining map generators
04:41 hmmmm that's an issue, not a PR
04:41 hmmmm i haven't read it yet, but this is basically minecraft's algorithm
04:41 est31 oh, very interesting issue submission
05:02 garywhite joined #minetest-dev
05:18 Zeno` what do people think about intentionally blurring the image so that we can support eyesight correction for people with lenses?
05:18 Zeno` e.g. if they can't find their glasses they can still play
05:21 garywhite That's pretty dumb...Then that screws up others
05:21 garywhite (No offense Zeno`)
05:21 Zeno` it would be adjustable
05:23 Zeno` I wonder if that'd actually work
05:23 Zeno` maybe the OS could do it
05:23 garywhite Windows 7 Profession doesn't
05:24 Zeno` but in theory... I wonder if it could
05:24 * Zeno` thinks
05:56 hmmmm wat
05:56 hmmmm that's the most dumb thing i've heard in a long time
05:56 hmmmm it's only going to make it blurrier, not the opposite
05:58 hmmmm man that sounded really dumb to me and i'm completely drunk right now
05:58 chatter joined #minetest-dev
05:58 chatter hey guys
06:02 chatter joined #minetest-dev
06:06 Zeno` hmmmm, it might work
06:07 Zeno` especially with high DPI screens at a cost of resolution
06:07 chatter joined #minetest-dev
06:07 hmmmm you lose detail with blurring, i don't get how it could improve the situation
06:07 hmmmm do you just mean scale up graphics something so it's higher resolution?
06:07 Zeno` I'm not sure either, but I haven't done any research
06:07 Zeno` not sure
06:08 Zeno` do the same thing that lenses do
06:08 hmmmm well if you're confident it works, try it out :p
06:08 Zeno` to correct vision
06:08 Zeno` I'm not confident at all lol
06:08 hmmmm hint: there's a reason why it doesn't already exist
06:08 * Zeno` tries to find research papers on it
06:08 hmmmm lenses don't make things blurrier, it has to do with changing the focal point of incoming light rays
06:08 Zeno` yes
06:08 Zeno` hmm
06:09 Zeno` maybe a 3d monitor
06:09 hmmmm i don't think you're gonna be able to do it without adding some kind of physical device because it has to do with the way the light itself is reflected
06:11 est31 yeah
06:12 est31 pixels on a screen send their light beams in all directions
06:12 est31 what you need is for differently directed light beams to come out of the same pixel
06:12 est31 or idk
06:17 chatter joined #minetest-dev
06:28 chatter joined #minetest-dev
06:34 chatter joined #minetest-dev
06:40 chatter joined #minetest-dev
07:21 Miner59 joined #minetest-dev
07:26 lhofhansl1 left #minetest-dev
07:34 Miner59 joined #minetest-dev
07:35 Miner59 Hello, can someone say if my issue with formspecs will get fixed some time? I just wanted to say I made a better screenshot now and made a test mod for your own tests: https://github.com/minetest/minetest/issues/4844
07:47 Miner59 joined #minetest-dev
08:10 Hunterz joined #minetest-dev
08:42 Krock joined #minetest-dev
08:45 lumidify joined #minetest-dev
08:46 DFeniks joined #minetest-dev
08:52 RichardTheTurd joined #minetest-dev
08:53 Thomas-S joined #minetest-dev
08:59 Zeno` will merge #4847 in 10 minutes or so
08:59 ShadowBot https://github.com/minetest/minetest/issues/4847 -- Fix unnecessary block loading and duplicating objects by juhdanad
09:16 Optical_Long joined #minetest-dev
09:21 Krock Zeno`, what about rogier's comment?
09:21 Zeno` Krock, my interpretation is that after release he will make a new PR
09:21 Krock ok
09:21 Zeno` Did you interpret it differently?
09:23 Zeno` I.e. as I understand the comment there are still existing issues that are not addressed but the current PR fixes most of them
09:23 Zeno` and that the remaining can come after release because they're not trivial
09:24 Krock yes, as long it's trivial there's no problem with waiting
09:25 Zeno` well the current PR has been reviewed and adding the further fixes would make it non-trivial and not mergable before release
09:27 Krock huh? bugfixes are on to merge as long it's not a feature
09:27 Krock s/on/ok
09:27 AcidNinjaFWHR joined #minetest-dev
09:28 Zeno` possibly yeah
09:29 Zeno` the further changes don't actually look all that "non-trivial"
09:29 Zeno` https://github.com/Rogier-5/minetest/commi​t/948c2fa8eb8a0bf57122e5028863a3b04321c5bb
09:29 Zeno` I'll email him
09:29 Zeno` thanks Krock
09:30 Krock uhm.. np, I guess?
09:32 Zeno` well it was a valid comment
09:32 Zeno` s/comment/question
09:33 Krock ^^
09:45 jin_xi joined #minetest-dev
09:59 troller joined #minetest-dev
10:07 juhdanad joined #minetest-dev
10:08 juhdanad Hi, are there any questions about #4847?
10:08 ShadowBot https://github.com/minetest/minetest/issues/4847 -- Fix unnecessary block loading and duplicating objects by juhdanad
10:08 juhdanad Zeno
10:09 juhdanad I mean Zeno wrote me an e-mail, but I don't know exactly what should I confirm.
10:14 Zeno` juhdanad, hi :)
10:14 Zeno` I meant
10:14 Zeno` hmm
10:14 Zeno` well, nothing really. I found no issues with the PR
10:15 Zeno` Rogier-5's comment seems to "extend" your PR though
10:15 Zeno` meaning that your PR is ok for now and that the other stuff should wait until later
10:15 Zeno` as I understand it
10:16 Zeno` I just wanted to make sure that *you* are still ok with your PR
10:16 Zeno` I am, and I guess hmmmm is
10:17 juhdanad Of course I'm okay.
10:19 Zeno` ok cool
10:19 Zeno` and Rogier-5 or yourself can do that other stuff he mentioned after release
10:20 Zeno` as far as I can see your PR is already an improvement and Rogier5's suggestion (at a quick glance) just improves upon an improvement and should be a separate PR anyway
10:20 Zeno` all cool. Thanks :)
10:21 juhdanad Rogier's branch is different form mine: he prevents trying to load blocks that are not on the disk - it's about performance, not a bugfix.
10:21 Zeno` yeah, so different PR
10:21 Zeno` I just wanted to make sure I was understanding everything correctly
10:21 juhdanad My pull fixed a bug, because blocks that were already in memory were loaded again.
10:22 Zeno` yup
10:22 juhdanad Okay then, thanks for your support!
10:22 Zeno` you're welcome. As I said, I just wanted to make sure. But everything is cool now :)
10:24 Zeno` P.S. I actually meant to email Rogier5 ROFLOL
10:24 Zeno` but I just grabbed the email from the patch and it doesn't matter now ;)
10:29 Krock joined #minetest-dev
10:29 Krock joined #minetest-dev
10:44 troller joined #minetest-dev
10:54 Optical_Long joined #minetest-dev
10:56 juhdanad joined #minetest-dev
11:11 lumidify joined #minetest-dev
11:15 mlucena joined #minetest-dev
11:52 proller joined #minetest-dev
11:54 Optical_Long joined #minetest-dev
11:58 proller joined #minetest-dev
12:20 blaze joined #minetest-dev
12:28 Fixer joined #minetest-dev
12:30 DuCake joined #minetest-dev
12:34 Calinou joined #minetest-dev
12:52 Human_G33k joined #minetest-dev
13:14 lumidify joined #minetest-dev
13:16 DuCake joined #minetest-dev
13:18 red-001 joined #minetest-dev
13:18 Fixer new occlusion changes have pretty big fps boost, much more stuff occluded
13:19 red-001 huh when was that updated?
13:20 est31 today
13:20 est31 https://git.io/v15wU
13:20 Fixer *in some situations
13:23 Fixer tested in 4 scenes
13:30 Fixer # of occluded blocks in scenes compared to priv build: -2% ; +18% ; +41% ; +12%
13:31 Fixer blocks in range was about the same
13:44 Fixer aaaand, I feel it is way to agressive
13:46 Fixer will check privious build
13:57 Fixer i think you need to revert it
14:36 gege01 joined #minetest-dev
14:36 crazyR joined #minetest-dev
14:43 juhdanad joined #minetest-dev
15:24 red-001 joined #minetest-dev
15:27 DFeniks joined #minetest-dev
15:48 lumidify joined #minetest-dev
16:25 Void7 joined #minetest-dev
17:07 hmmmm joined #minetest-dev
17:29 red-001 joined #minetest-dev
17:30 proller joined #minetest-dev
17:36 lumidify joined #minetest-dev
17:55 sfan5 Fixer: i agree
17:55 sfan5 the occlusion change causes frequent blinking
18:04 YuGiOhJCJ joined #minetest-dev
18:54 garywhite joined #minetest-dev
18:56 johnnyjoy joined #minetest-dev
19:36 nrzkt joined #minetest-dev
19:39 red-001 joined #minetest-dev
20:06 Human_G33k joined #minetest-dev
20:42 Darcidride joined #minetest-dev
21:25 proller joined #minetest-dev
21:31 ShadowNinja est31: I updated the security ro-modpath thing and explained that bit of code.  Does it look good to you now?
21:39 ShadowNinja est31: Also, GitHub says yo commented on my other security-related patch (the RRPC one) but I con't find the comments.  Is GitHub broken or did you say something about it?
22:38 Player_2 joined #minetest-dev
22:51 longerstaff13 joined #minetest-dev
23:45 kaeza joined #minetest-dev

| Channels | #minetest-dev index | Today | | Google Search | Plaintext