Time Nick Message 00:14 octacian sofar: Isn't something like that used for the door? 00:15 octacian sofar: yep, doors_blank.png, 1x1px. 00:21 TommyTreasure is this the proper forum to ask about modifications to mods? 00:22 octacian TommyTreasure: ask on #minetest 00:22 TommyTreasure ty 00:22 octacian and BTW, this is IRC, not a forum. forums are at forums.minetest.net 00:23 TommyTreasure i understand, but my question may not be proper for the actual forum. 03:26 ShadowNinja My RRPC/Security fix is done now: #4919. 03:26 ShadowBot https://github.com/minetest/minetest/issues/4919 -- Fix RemoveRelativePathComponents (again) and fix mod security with paths starting with "..". by ShadowNinja 03:38 ShadowNinja est31: I fixed my other security PR too. 14:42 paramat i'm now feeling #4847 could be merged for release, just needs another +1 14:42 ShadowBot https://github.com/minetest/minetest/issues/4847 -- Fix unnecessary block loading and duplicating objects by juhdanad 14:44 sfan5 paramat: the patch itself would probably still count as trivial, in any case you have my +1 14:45 sfan5 also if you have some spare time i suggest testing how a few mods perform with active_block_range = 3 14:47 paramat i could mod-profile mtgame with setting 3 14:48 paramat and 2, to see the effect 14:49 paramat as you can see from my comment i think 3 may be fine 14:50 paramat Rogier-5 is doing some testing on 4847, if that goes well i think we can merge it 14:51 paramat hmmmm +1s and considers it fairly safe 14:51 Fixer don't forget about furnace fixes 14:51 paramat nope 14:52 paramat sofar shall we merge game#1457 now? 14:52 ShadowBot https://github.com/minetest/minetest_game/issues/1457 -- Furnace: Erase src_time if no more items left in src. by sofar 14:54 paramat sfan5 sofar how about game#1460 ? tuning gains is harmless, but if you prefer i could change it to only fix glass gains (which i set too low recently) 14:54 ShadowBot https://github.com/minetest/minetest_game/issues/1460 -- Sounds: Edit some sound gains, mostly footsteps by paramat 14:54 sfan5 seems fine to me 14:55 sfan5 the main part of feature freeze is not throwing new features in without time to test them extensively 14:55 sfan5 a few sound adjustments are nothing :) 14:55 paramat yeah 14:56 paramat sofar is also keen to make some footsteps a little quieter 15:01 paramat looking at various sound gain values i suspect many have never been properly tuned, just set at 1.0 or 0.5 15:02 paramat i might work more on levels after release 15:10 paramat so later i hope to merge games 1457 and 1460 17:22 sofar paramat: the furnace PR is fine to merge now 17:22 sfan5 paramat: yes this means entities are only active in that radius 17:23 sofar paramat: I'm travelling in the next week so I'll be not responding much 17:37 paramat ok. ok 18:13 paramat i'll merge games 1457 and 1460 in 30 mins 18:14 garywhite game#1457 18:14 ShadowBot https://github.com/minetest/minetest_game/issues/1457 -- Furnace: Erase src_time if no more items left in src. by sofar 18:14 garywhite game#1460 18:14 ShadowBot https://github.com/minetest/minetest_game/issues/1460 -- Sounds: Edit some sound gains, mostly footsteps by paramat 19:26 MrDurden Hello!! I have a question, It takes a lot of time to compile everything, for each test, will I have to wait so much? Isn't there a faster way? Thanks 19:28 Krock for a release build it takes longer than for a debug one 19:28 Krock because the optimizations require some time 19:28 Krock what is "lot of time" for you? >20 mins? 19:29 MrDurden More than 5 minutes .-. It's because I never compiled big projects before 19:30 MrDurden I am just trying to understand the code and modify it a bit, so I can learn .-. 19:30 MrDurden Thanks for answering :3 19:31 Fixer https://github.com/minetest/minetest_game/issues/1462 reproduced 19:31 Krock np. My first build took 00:31:30.54 on my old single core CPU 19:31 Krock then it fell to about 20 or 15 minutes 19:32 Fixer full build of minetest in VM with debian takes me about 17 minutes, core i3 3.3GHz. But usually i have script that compiles changes only so it takes just few minutes 19:32 MrDurden How do I know if I am building in the debug mode or not? 19:32 MrDurden I am using this command: 19:32 Fixer very large exe file 19:32 Krock MrDurden, debug builds tend to be horribly slow but they will be done in some few seconds (for incremental) 19:33 MrDurden cmake . -DRUN_IN_PLACE=TRUE 19:33 MrDurden Ok, thx :D 19:33 Krock -DCMAKE_BUILD_TYPE=Debug is the param you need 19:34 MrDurden Ok, thanks! 19:35 MrDurden I will see if I can modify the character's hand 19:35 Krock ^^ good luck 19:36 MrDurden Thx :D 19:55 paramat will merge games 1457 1460 in a moment 20:06 paramat merging 20:12 paramat merged 20:13 paramat all game milestones now closed 20:13 garywhite paramat would you consider looking at a new brick texture maybe for 0.4.16? 20:13 garywhite I don't want to try to interfere with 0.4.15's release 20:15 paramat sure i'll look at it, are you able to make a pull request? 20:15 garywhite No, but I can post an image here 20:15 garywhite Well a link to it 20:15 garywhite https://usercontent.irccloud-cdn.com/file/SmgCYSTt/Brick%20texture 20:16 paramat best open an issue and post the texture plus a screenshot, if it's liked enough someone might make the PR 20:17 garywhite OK, I can also add it into a repository if it's easier 20:17 paramat you can just drag-and-drop images into a post 20:17 garywhite ok, I'll post into mt_game 20:18 garywhite Do I post it into minetest_game? 20:20 sfan5 that texture is too flat 20:20 garywhite This is from one side 20:20 garywhite It wraps around fully 20:21 sfan5 obviously it does 20:22 garywhite Since there's one brick texture, I overwrote the brick texture in one of your dev builds and ran it. I made a stone brick texture also, but it's garbage 20:27 garywhite paramat: Created an issue for review in game#1463 20:27 ShadowBot https://github.com/minetest/minetest_game/issues/1463 -- Change brick texture 20:40 garywhite paramat I made an error in taking that photo, default:snow cut off the bottom 20:43 garywhite Forget it, game#1462 closed 20:43 ShadowBot https://github.com/minetest/minetest_game/issues/1462 -- breaking then right-clicking a chest causes a crash 20:44 garywhite Sorry 20:44 garywhite Wrong one, I meant game#1463 20:44 ShadowBot https://github.com/minetest/minetest_game/issues/1463 -- Change brick texture