Minetest logo

IRC log for #minetest-dev, 2016-12-02

| Channels | #minetest-dev index | Today | | Google Search | Plaintext

All times shown according to UTC.

Time Nick Message
00:00 longerstaff13 joined #minetest-dev
00:06 AcidNinjaFWHR joined #minetest-dev
00:07 twoelk left #minetest-dev
00:41 Void7 joined #minetest-dev
01:20 Tmanyo joined #minetest-dev
01:54 Tmanyo joined #minetest-dev
02:09 paramat joined #minetest-dev
02:12 paramat new biomes are tested https://github.com/minetes​t/minetest_game/pull/1432 can anyone give approval? sofar ? if merged i will merge the corresponding engine change too https://github.com/minetest/minetest/pull/4831
02:13 paramat game#1432
02:16 Robby joined #minetest-dev
02:17 AcidNinjaFWHR hi
02:18 AcidNinjaFWHR oh damn this 0.4.15 will be really good
02:35 ptv joined #minetest-dev
02:49 Robby joined #minetest-dev
03:17 STHGOM joined #minetest-dev
03:17 STHGOM joined #minetest-dev
03:35 lhofhansl joined #minetest-dev
03:40 exio4 joined #minetest-dev
03:51 lhofhansl joined #minetest-dev
03:55 Rincewind` hi lhofhansl
03:55 Rincewind` lhofhansl, if you're happy with the wording of #4827 I'll merge
03:55 Rincewind` err
03:58 fling joined #minetest-dev
04:13 lhofhansl Looks good. Thanks!
04:23 Zeno` np
04:24 lumidify joined #minetest-dev
05:03 garywhite To the devs: https://forum.minetest.net/v​iewtopic.php?f=3&t=15972
05:13 est31 replied
05:13 est31 but its not really dev related
05:14 paramat joined #minetest-dev
05:24 lhofhansl1 joined #minetest-dev
05:32 lhofhansl joined #minetest-dev
05:38 lhofhansl joined #minetest-dev
05:42 lumidify joined #minetest-dev
05:44 paramat est31 if possible could you look at https://github.com/minetest/minetest/pull/4826 'Optimize block sent: Fix rendering issue'?
06:07 Hunterz joined #minetest-dev
06:33 nrzkt joined #minetest-dev
06:44 lumidify joined #minetest-dev
07:39 lhofhansl joined #minetest-dev
08:21 jin_xi joined #minetest-dev
08:30 nrzkt joined #minetest-dev
08:35 nrzkt joined #minetest-dev
08:41 Darcidride joined #minetest-dev
09:02 lumidify joined #minetest-dev
09:03 YuGiOhJCJ joined #minetest-dev
09:31 lumidify joined #minetest-dev
09:40 Amaz If any devs could look at #4833, which fixes #4832, I'd appreciate it!
09:48 troller joined #minetest-dev
09:56 Zeno` qwok, done
09:56 Zeno` qwok!
09:56 Zeno` I meant ok lol
10:11 Amaz Thanks :)
10:11 longerstaff13 joined #minetest-dev
10:20 Zeno` merging #4830
10:23 Optical_Long joined #minetest-dev
10:26 nrzkt what is that ? bot is away
10:28 longerstaff13 joined #minetest-dev
10:31 longerstaff131 joined #minetest-dev
10:35 Zeno` https://github.com/minetest/minetest/commi​t/144da5f522bf057ac612ef1fa09478d0215f6d0d
10:35 Zeno` i.e. nothing significant
10:36 longerstaff13 joined #minetest-dev
10:42 Optical_Long joined #minetest-dev
10:44 longerstaff131 joined #minetest-dev
10:51 troller joined #minetest-dev
10:56 proller__ joined #minetest-dev
10:56 longerstaff13 joined #minetest-dev
11:04 Fixer joined #minetest-dev
11:14 IKRadulov joined #minetest-dev
11:15 lumidify joined #minetest-dev
11:18 IKRadulov Modding : I am tring to use the player:attach() method . I give for first param [parent] minetest.get_node(pos) . But it trows me a error that userdata is expected . How can I resolve this ?
11:19 nrzkt Kulgan`: trivial
11:37 lumidify joined #minetest-dev
11:40 johnnyjoy joined #minetest-dev
13:16 lumidify joined #minetest-dev
13:37 Fixer_ joined #minetest-dev
14:13 STHGOM joined #minetest-dev
14:18 Darcidride joined #minetest-dev
14:29 Hunterz joined #minetest-dev
14:31 lhofhansl joined #minetest-dev
14:33 lhofhansl1 joined #minetest-dev
14:37 Foghrye4 joined #minetest-dev
14:55 turtleman joined #minetest-dev
15:14 lumidify joined #minetest-dev
15:42 hmmmm joined #minetest-dev
15:51 blaze joined #minetest-dev
15:56 VanessaE as I figured, those sawtooth patterns in my servers' memory usage weren't coming from Minetest, they were coming from log files being written to /dev/shm (just goes to show how big they are).
15:57 Darcidride joined #minetest-dev
15:58 est31 interesting
15:59 Fixer_ aha
16:02 juhdanad joined #minetest-dev
16:03 juhdanad Hi! May I also be mentioned in #4827?
16:04 est31 yes!
16:05 est31 thanks for pointing out
16:05 * VanessaE pokes ShadowBot
16:05 guest joined #minetest-dev
16:09 juhdanad Me thanks too!
16:11 juhdanad I also need your opinion: my lighting code is one level brighter than the old one, which means the light spreads one node further from sun.
16:11 juhdanad This is basically good, but makes the two versions incompatible.
16:12 juhdanad When playing on an old server with a new client, there are extra computations because the server always re-sends blocks with dimmer light.
16:13 juhdanad Should I make sunlight dimmer again?
16:17 est31 the extra computations are only if the server is old and the client is new?
16:18 est31 juhdanad: ^
16:18 juhdanad Or if the server is new and the client is old (but I have to test this one)
16:18 juhdanad Testing.
16:24 juhdanad est31: yes, there are extra computing but I couldn't make the game crash.
16:24 juhdanad *is
16:24 est31 then its no big deal
16:24 est31 most servers are up to date
16:25 juhdanad Okay, thanks!
16:26 est31 the reverse is far more often to be found
16:26 est31 old client vs new server
16:27 est31 18 servers on the serverlist don't use 0.4.14 or later
16:28 est31 all other servers use >= 0.4.14
16:28 est31 (in total, there are 164 servers on the serverlist)
16:28 est31 if you want to see more stats, look at: https://gist.github.com/est31/66602d589b225b27afd5
16:29 juhdanad Why is it secret?
16:29 est31 I just dont want it to be listed
16:30 est31 most of my github gists are secret :)
16:30 est31 feel free to share it, its public info
16:31 Fixer_ anyone seen this? https://i.imgur.com/WGT6waX.png
16:32 Fixer_ i think it is specific to vanessa's server only
16:34 VanessaE probably some mod texture
16:35 johnnyjoy joined #minetest-dev
16:35 Fixer_ yeah, could be
16:41 diemartin joined #minetest-dev
16:42 johnnyjoy joined #minetest-dev
16:49 proller__ joined #minetest-dev
16:50 juhdanad joined #minetest-dev
16:52 juhdanad Fixer_: yes, I also observed that some of my inventory slots were distorted (in the hotbar) on VanessaE's creative server.
16:59 troller joined #minetest-dev
17:01 johnnyjoy joined #minetest-dev
17:02 lhofhansl joined #minetest-dev
17:04 johnnyjoy joined #minetest-dev
17:06 proller joined #minetest-dev
17:08 jin_xi joined #minetest-dev
17:22 lumidify joined #minetest-dev
17:26 Foghrye4_ joined #minetest-dev
17:27 proller joined #minetest-dev
17:29 red-001 joined #minetest-dev
17:37 red-001 joined #minetest-dev
17:42 johnnyjoy joined #minetest-dev
17:47 garywhite joined #minetest-dev
17:47 diemartin joined #minetest-dev
17:51 lhofhansl1 joined #minetest-dev
17:55 fling joined #minetest-dev
17:55 red-001 updated #4474
17:55 red-001 the code is even simpler now
17:58 Gael-de-Sailly joined #minetest-dev
18:00 johnnyjoy joined #minetest-dev
18:05 johnnyjoy joined #minetest-dev
18:12 longerstaff13 joined #minetest-dev
18:16 Optical_Long joined #minetest-dev
18:17 diemartin joined #minetest-dev
18:21 Krock joined #minetest-dev
18:21 Krock joined #minetest-dev
18:32 lumidify joined #minetest-dev
18:39 STHGOM joined #minetest-dev
18:39 STHGOM joined #minetest-dev
18:42 ssieb joined #minetest-dev
18:46 diemartin joined #minetest-dev
18:59 paramat joined #minetest-dev
19:00 Wuzzy joined #minetest-dev
19:00 lumidify joined #minetest-dev
19:01 paramat juhdanad, this light level issue may be a problem, needs consideration
19:02 juhdanad It is easy to make the world 1 level dimmer, if you want.
19:04 juhdanad paramat: If you wish to experiment, create an old server, connect with a new client, dig a horizontal 1x2 tunnel and place a node to the entrace.
19:05 juhdanad paramat: You will see two light updates instead of one: first the client decreases light, then you get the even dimmer block from the server.
19:08 YuGiOhJCJ joined #minetest-dev
19:12 YuGiOhJCJ joined #minetest-dev
19:12 paramat does this happen on single-node light updates only?
19:13 juhdanad Yes, if liquid flow counts as single node.
19:13 paramat light levels are critical and the values are used to control behaviours
19:14 paramat so, if there is a single column of light-sun (15) falling in a cave, the face-neighbours must have 14, not 15
19:15 juhdanad This is what my new code does.
19:15 paramat 14 or 15?
19:15 juhdanad The old gave face-neighbors 13.
19:16 paramat weird
19:16 juhdanad Mine is 14.
19:16 paramat so the old code was wrong
19:17 sofar yeah, doesn't surprise me
19:17 paramat and a meselamp of 14 will have face-neighbours of 13?
19:17 juhdanad Yes, and I didn't notice it while writing the new code.
19:17 rubenwardy joined #minetest-dev
19:18 juhdanad And yes, a meselamp's neighbors will be 13 in both implementations.
19:18 paramat ahh
19:18 paramat so your change is specific to level 15?
19:19 juhdanad Yes, it is.
19:19 paramat ok i'm less worried now
19:19 Fixer joined #minetest-dev
19:21 juhdanad https://github.com/minetest/mine​test/blob/master/src/light.h#L43 You can see the old code did not create air with light level 14.
19:24 nrzkt joined #minetest-dev
19:29 paramat juhdanad may not be relevan but see https://github.com/minetest/minetest/commi​t/7233a1228eb161cbcbb46c6e801cabd89ef3d2ab this is mapgen lighting update, and was brightened by 1 here
19:29 paramat just mentioning it because i thought of this
19:31 juhdanad The intended light level was increased, bus as I see, diminish_light() filtered out everything above 13.
19:33 paramat that commit seems correct though because 'lightspread()' above reduces by 1 before spreading
19:34 paramat anyway this is no issue, just mentioned it because i remembered a light level change commit :)
19:36 paramat est31 please could you look at #4826 ? needs merging
19:36 paramat https://github.com/minetest/minetest/pull/4826 Optimize block sent: Fix rendering issue
19:36 est31 not today, sorry
19:37 paramat ok
19:39 paramat hmmmm nore nrzkt sfan5 sofar rubenwardy please can someone check https://github.com/minetest/minetest/pull/4826 'Optimize block sent: Fix rendering issue' high priority fix
19:40 paramat small commit and some of it is already approved
19:42 octacian I think mod security is broken again...
19:42 paramat 5 days to freeze btw
19:43 octacian I can't open files in world directory now.
19:44 paramat please can anyone review https://github.com/minetest/minetest/pull/4061 'Add loaded blocks to transforming_liquid-queue similar to updateLiquid'? well tested, needs another +1
19:47 lumidify joined #minetest-dev
19:48 paramat sofar rubenwardy please could you add your approvals to newbiomes https://github.com/minetes​t/minetest_game/pull/1432 and the engine commit https://github.com/minetest/minetest/pull/4831 ?
19:48 paramat sfan5 i will probably merge new biomes later
19:49 paramat i'd still like approval though
19:50 diemartin joined #minetest-dev
19:51 rubenwardy I can't comment on the code, but when I tried `newbiomes` I quite liked it
19:52 paramat it's the same as that mod
19:52 Darcidride joined #minetest-dev
19:54 paramat sofar seems to like it too, so i will merge later if no objections
19:57 rubenwardy am I right in thinking that there's currently no biome backwards compatibility, apart from reverting the file?
19:58 rubenwardy Might be worth storing biome defs in the world to stop breakages. Not my area though, so feel free to ignore me :P
19:58 paramat it will create straight biome borders between old and newly generated world
19:58 rubenwardy what about big cliffs?
19:58 paramat indeed biome defs are not stored per-world
19:59 paramat nooo terrain is unchanged
19:59 paramat :)
19:59 rubenwardy oh good
19:59 rubenwardy not so bad then
19:59 paramat mgv7 terrain is stable now
19:59 paramat the biomes are officially unstable
20:00 lumidify joined #minetest-dev
20:05 YuGiOhJCJ joined #minetest-dev
20:17 sfan5 paramat: can you give a very short tl;dr of what changed?
20:17 sfan5 afaik there's the silver sand(?) is now used with the biome pr
20:17 sofar yes, and most of the biome points have moved
20:17 paramat first post in https://github.com/minetes​t/minetest_game/pull/1432
20:17 sofar so distribution is different now
20:18 paramat silver sand is used for cold desert
20:18 sfan5 ah sorry
20:18 sfan5 reading that now
20:18 sfan5 wait we have swamp biomes?
20:18 paramat also more details and screenshots in #1022
20:18 YuGiOhJCJ joined #minetest-dev
20:19 paramat swamp is the part of rainforest that is in shallow water
20:19 sfan5 sounds pretty nice from the description
20:19 paramat the jungletrees now spawn in 1 or 2 deep water so the swamps are bigger
20:19 sfan5 you have my +1
20:19 paramat phew thanks
20:22 paramat wow 8 months of work
20:24 johnnyjoy joined #minetest-dev
20:24 paramat so i'll merge lots of stuff later, including Optimize block sent: Fix rendering issue #4826 it can't wait any longer
20:29 red-001 updated #4472
20:29 red-001 @@
20:30 red-001 "Make serverlist searchable"
20:42 lumidify joined #minetest-dev
20:50 garywhite So does that mean that the server list will be searchable in 0.4.15?
20:51 Krock if merged, yes
20:51 red-001 if it gets one more approval
21:12 millersman joined #minetest-dev
21:14 milllersman joined #minetest-dev
21:16 lumidify joined #minetest-dev
21:19 Darcidride joined #minetest-dev
21:24 juhdanad joined #minetest-dev
21:41 proller joined #minetest-dev
21:45 Darcidride joined #minetest-dev
21:54 lhofhansl joined #minetest-dev
22:05 johnnyjoy joined #minetest-dev
22:05 DI3HARD139 joined #minetest-dev
22:09 johnnyjoy joined #minetest-dev
22:20 proller joined #minetest-dev
22:21 lhofhansl joined #minetest-dev
22:22 johnnyjoy joined #minetest-dev
22:26 johnnyjoy joined #minetest-dev
22:42 paramat joined #minetest-dev
22:56 lhofhansl joined #minetest-dev
23:10 kaeza joined #minetest-dev
23:12 sfan5 merging https://github.com/minetest/minetest/pull/4474 (>= 2 approvals)
23:19 paramat i'll merge games 1432 1434 and engine 4831 later
23:23 paramat and maybe 4826 too, allthough i'd like someone to check it
23:24 paramat i'll have another look at it
23:42 YuGiOhJCJ joined #minetest-dev
23:48 paramat +1 for 4826 will merge later
23:48 YuGiOhJCJ joined #minetest-dev
23:49 paramat ^ lhofhansl

| Channels | #minetest-dev index | Today | | Google Search | Plaintext