Minetest logo

IRC log for #minetest-dev, 2016-11-14

| Channels | #minetest-dev index | Today | | Google Search | Plaintext

All times shown according to UTC.

Time Nick Message
01:00 Taoki joined #minetest-dev
04:05 VargaD joined #minetest-dev
04:08 lordfingle joined #minetest-dev
04:08 lordfingle Hi Devs!
04:09 lordfingle Looks like I've made a rather alarming discovery.  It seems to me that there's no non-english version of Android.  (Android doesn't appear to support intllib/Gettext)  Is this right?
04:10 AntumDeluge joined #minetest-dev
06:12 Hunterz joined #minetest-dev
07:02 Zeno` #4705
07:03 ShadowBot https://github.com/minetest/minetest/issues/4705 -- Adding particle blend, glow and animation by Foghrye4
07:03 Zeno` I like more documentation (even if it's "complicated") than less!
07:03 Zeno` oh para isn't here... grrr
07:12 Zeno` is there a git am command to automatically fix whitespace errors?
07:37 nrzkt joined #minetest-dev
07:43 est31 joined #minetest-dev
08:44 lordfingle joined #minetest-dev
09:17 est31 joined #minetest-dev
09:22 paramat joined #minetest-dev
09:34 Zeno` hmmmm, are you awake?
09:36 Zeno` celeron55, please comment on #4705 . The majority opinion seems to be to merge, but it's getting ridiculous
09:36 ShadowBot https://github.com/minetest/minetest/issues/4705 -- Adding particle blend, glow and animation by Foghrye4
09:39 hmmmm i'll take a look tomorrow morning
09:39 hmmmm way, way, way too late right now
09:40 Zeno` ok, hmmmm
09:41 Zeno` The "feeling" I get is that paramat is blocking it just because he doesn't understand it though
09:41 Zeno` and that's not right
10:00 proller__ joined #minetest-dev
10:01 celeron55 it seems this is not bad code but the focus is weird
10:03 Amaz joined #minetest-dev
10:34 asl97 joined #minetest-dev
10:45 Zeno` the "focus"?
11:17 celeron55 i mean, i would imagine it's not really like particles is the thing minetest is missing the most
11:33 Zeno` yeah, but it's not something that's going to make minetest worse
11:34 Zeno` in fact, it has a lot of potential
11:35 Zeno` sofar already has ideas that he can use it for
11:35 celeron55 i mean, it's not wrong; just weird
11:35 Zeno` hmm
11:35 celeron55 and i kind of like weird
11:36 Zeno` the code is good, the documentation is good. I really don't know what the hassle is
11:37 Zeno` I spoke to sofar just a few hours ago and he is happy with it (apart from the whitespace errors which are nothing at the end of the day)
11:38 Zeno` I like it
11:38 Zeno` i *think* est31 likes it as well, but I dunno
11:38 Zeno` either way there are at least 2 of us who want it merged
11:48 celeron55 regardless, i do think the documentation is bad
11:50 celeron55 the api or system doesn't use any concepts that i don't understand yet it's still difficult for me to understand what's the best way to use the api
11:52 Zeno` fair observation
11:53 Zeno` I don't have a problem with it, but maybe that's because I read the code first
11:53 Zeno` it's a good point
11:58 Zeno` *technically* though it should be able to be merged now. PRs only require 2 approvals right? I'm not going to merge it, just asking
12:00 Zeno` this kind of "blocking" imo, holds the project back. We all want what's best. I doubt any of us would knowingly merge something damaging
12:01 Zeno` paramat suggesting that it cannot be approved until kwoleker agrees is bullshit IMO
12:02 Zeno` s/approved/merged
12:04 est31 Will merge #4767 soon
12:04 ShadowBot https://github.com/minetest/minetest/issues/4767 -- Rename nodeupdate and nodeupdate_single and make them part of the official API by est31
12:06 Zeno` I object!
12:07 Zeno` I have a lot of respect (heaps actually) for both paramat and hmmmm, but this blocking of legit and useful PRs is... dumb
12:07 Zeno` est31, I don't really object
12:07 est31 ok
12:08 Zeno` added a +1
12:10 Zeno` est31, I don't think you need to add your own approval :)
12:10 Zeno` if you're a coredev and at least one other coredev agrees then just commit
12:10 Zeno` pretty sure that's the rule
12:13 Darcidride joined #minetest-dev
12:19 nore Zeno`: +1, although I have not reviewed the code, this PR seems legit and quite useful, and paramat's objection looks not really founded
12:20 nore I would need to review the code more closely to give a real +1, but I +1 the concept
12:28 Zeno` thanks nore. I'm all open for debate, because it's healthy. But at a certain point it becomes counterproductive imo
12:41 nrzkt joined #minetest-dev
12:47 blaze joined #minetest-dev
12:50 blaze joined #minetest-dev
14:11 KaadmY joined #minetest-dev
14:11 Zeno` I've merged #4705
14:11 ShadowBot https://github.com/minetest/minetest/issues/4705 -- Adding particle blend, glow and animation by Foghrye4
14:11 Zeno` I don't need paramat going on with that bullshit
14:15 sfan5 what did i miss?
14:15 paramat joined #minetest-dev
14:15 paramat naughty
14:15 Zeno` no
14:15 sfan5 paramat: the tool break sound pr @ engine needs a revisit
14:15 paramat est31 sfan5 please revert
14:15 Zeno` the PR deserved to be merged and it had way more than 2 approvals
14:15 paramat even the supporters insist on waiting for hmmmm's clarification
14:15 paramat that's not how it works
14:16 sfan5 play then we'll just ignore hmmmm it seems
14:16 sfan5 s/play/okay/
14:16 Zeno` paramat, that *is* how it works
14:16 paramat if there's serious controversy and questions then we wait
14:16 Zeno` The only controversy was coming from you
14:16 sfan5 kek
14:16 sfan5 anyway
14:17 Zeno` everything else was minor
14:17 paramat erm no, from celeron55 too
14:17 sfan5 although i disagree with the "just do it now" approach here's what we can do:
14:17 sfan5 if a better solution turn up before the release we revert this and use the better one
14:17 paramat and hmmmm seems to have serious reservations too
14:17 Zeno` no, celeron55's comments were for the most part supportive
14:17 sfan5 the obligation to support an API starts with a new release
14:18 Zeno` paramat, don't you get it? hmmmm does not have the final say
14:18 paramat i have never said that, read my comment
14:18 paramat please revert
14:18 Zeno` paramat, I won't
14:18 paramat not you :]
14:18 Zeno` why does it need to be reverted?
14:19 paramat i also asked a reasonable request for a parameter, that needs addressing https://github.com/minetest/minetes​t/pull/4705#issuecomment-260315521
14:19 Zeno` Oh well. In your words I'm just a fool and write ridiculous things.
14:19 paramat because you've ignored c55 and hmmmm's reservations
14:19 sfan5 wait what is this
14:19 sfan5 and why did i not see it
14:20 sfan5 >specify length of a frame in seconds. Negative and zero values disable animation.
14:20 sfan5 that should use nil instead of negative values
14:20 Zeno` sfan5, you can make a PR to fix the docs
14:20 sfan5 the code would need a fix too but yeah
14:21 paramat this PR was clearly in need of further improvement, it should not have been merged, Zeno has gone nuts
14:21 Zeno` paramat, I don't think so. I did what needed to be done
14:21 paramat it's not just me wh has reservations
14:21 paramat drunk?
14:21 Zeno` excuse me?
14:22 paramat your comments about me on IRC have been unnacceptable and untrue
14:22 paramat est31 sfan5 celeron55 please revert
14:22 Zeno` paramat, what comments?
14:22 sfan5 paramat: the docs could use improvements but i don't see a conflict with "length"
14:22 paramat nore nrzkt please revert
14:23 Zeno` paramat, you're the only one attacking a person and not the commit as far as I know
14:23 celeron55 wait wtf what
14:23 celeron55 Zeno`: stop drinking so much beer
14:23 nrzkt paramat, revert what ?
14:23 paramat we don't so impulsive things like this, i'm actually resigned to this being merged eventually, but it needs improvement
14:24 Zeno` celeron55, the PR is fine
14:24 celeron55 revert it
14:24 Zeno` improvements can happen later just like any other PR
14:24 paramat with my comment addressed and with better docs i was close to being neutral on this
14:24 sfan5 that is what the before-merge phase is for
14:24 celeron55 or just reset --hard HEAD^ if possible
14:25 Zeno` celeron55, I'm sorry. I won't revert it
14:25 paramat we can't allow people to go 'ah fuck it, merged!'
14:25 celeron55 in that case i need to drop your write privilege to the repo
14:25 Zeno` if that's the case, then ok
14:25 Zeno` I lost my privs for a good cause
14:26 Zeno` please think about that though
14:26 celeron55 you lost them for nothing, because someone else will revert this; we don't merge when there is controversy
14:26 sfan5 who who'll revert it now?
14:26 Zeno` ok, thanks for all the fish :/
14:26 celeron55 i'm at work, i don't care who does it
14:27 paramat anyway, i forgive you zeno
14:27 paramat sorry i can't revert
14:27 sfan5 force push or revert?
14:27 nrzkt revert can be done from webinterface for information
14:27 sfan5 revert i guess
14:27 Zeno` paramat, nice of you to say that. Since I'm no longer a core dev! heheh. But yes, I appreciate the forgiveness
14:27 nrzkt you have a button in the merge notif
14:28 paramat you're a top guy :]
14:28 sfan5 .
14:30 nore Uuuuuh
14:30 nore Please don't let that pr sink into oblivion though
14:31 paramat it won't, it has lots of support
14:31 nrzkt nore, maybe let this PR into skyrim then
14:31 paramat i actually support the basic intent
14:31 sfan5 warning: 118 lines add whitespace errors.
14:31 sfan5 maybe that should be fixed too :)
14:31 nore Yeah
14:31 paramat yes as sofar requested
14:32 nore But that is easy enough to fix
14:32 nore Zeno`: are you sure of your decision?
14:32 Zeno` my decision to merge?
14:33 nore Not to revert
14:33 Zeno` look, if someone reverts it I'm not going to complain
14:34 nore I mean, now that we know it is going to be accepted as soon as it is fixed
14:34 Zeno` despite the whitespace errors, though, I think that it needs to be merged. And I can't change my mind on that. I'm sorry
14:34 Zeno` yeah sure
14:34 sfan5 it needs to be merged, but not now
14:34 Zeno` ok, revert
14:35 paramat i don't want to lose you as a dev
14:35 Zeno` can I revert it using github?
14:35 Zeno` or do I have to do it locally?
14:36 nore Hm, I don't know
14:36 asl97 Zeno`: it's has already been done by sfan5
14:36 Zeno` ok sfan5 has done it
14:36 Zeno` all good
14:36 Zeno` but that PR is GOOD
14:36 sfan5 >This value will leave z-buffer writeable
14:36 sfan5 why is that in the docs
14:37 sfan5 IMO it doesn't matter to modders
14:37 Zeno` paramat, I think c55 has already removed me
14:37 paramat well i want you back
14:38 asl97 Zeno`: i don't think so https://github.com/orgs/minetest/people
14:38 asl97 i still see the minetest member tag thingy
14:38 asl97 next to your name
14:39 Zeno` paramat, please don't call me a fool and say that my comments are silly
14:39 Zeno` attack the comments for sure
14:39 nore asl97: people != those allowed to push
14:39 Zeno` just not me personally
14:39 paramat well, 'fool' was when you merged it
14:39 Zeno` maybe the comment *are* stupid
14:39 Zeno` ok
14:40 Zeno` paramat, you *know* I respect you
14:40 Zeno` I donated money to you ffs
14:40 Zeno` I just disagree with your opposition towards this PR
14:41 paramat the comments that annoyed me were addressed in https://github.com/minetest/minetes​t/pull/4705#issuecomment-260322198
14:42 Zeno` ok, I'm tired. Can we be friends again?
14:42 paramat i never wasn't :]
14:42 paramat the comments were not a big deal though
14:43 Zeno` ok, agreed
14:44 paramat and sorry i somewhat provoked you
14:44 Zeno` it's in the past
14:45 Zeno` I've already forgotten it
14:45 FirePowi joined #minetest-dev
14:47 Zeno` I don't dwell on things that happened in the past :) We're cool, mate
14:53 paramat neat ;]
15:00 Zeno` how do I reopen #4705?
15:00 ShadowBot https://github.com/minetest/minetest/issues/4705 -- Adding particle blend, glow and animation by Foghrye4
15:01 paramat yeah i guess it can't be
15:01 Zeno` hmm, not good
15:02 Amaz I think that Foghrye has to make a new pull...
15:02 Zeno` I'll ask him
15:03 paramat i think so too
15:04 Zeno` maybe his new PR can sneak through without so much controversy? :D lol. /me runs
15:04 paramat i think we're through the worst
15:05 paramat unsurprisingly it's full supermoon
15:05 Fixer joined #minetest-dev
15:11 Zeno` yeah lunacy is everywhere
15:12 Hunterz joined #minetest-dev
15:24 sfan5 ugh the docs are even indented with tabs
15:25 Zeno` https://www.youtube.com/watch?v=u9Dg-g7t2l4
16:00 hmmmm joined #minetest-dev
16:27 sfan5 sofar: can you take a look at https://github.com/minetes​t/minetest_game/pull/1372 ?
16:30 lumidify joined #minetest-dev
16:40 lisac joined #minetest-dev
16:47 diemartin joined #minetest-dev
16:47 nrzkt joined #minetest-dev
16:49 Hunterz joined #minetest-dev
16:55 DI3HARD139 joined #minetest-dev
17:01 Foghrye4__ joined #minetest-dev
17:06 lumidify joined #minetest-dev
17:14 Krock joined #minetest-dev
17:14 Krock joined #minetest-dev
17:32 nrzkt joined #minetest-dev
17:51 red-001 joined #minetest-dev
18:10 corvus_262 joined #minetest-dev
18:11 corvus_262 Hello. Does anyone know how to use paramtype2="meshoptions"?
18:12 yellow-1000 is it not documented in lua_api.txt?
18:12 Krock it is
18:12 Krock line ~611
18:13 Krock requires a new indev build with sofar's fancy plants
18:13 corvus_262 oh
18:13 sofar yup
18:13 Krock it's not contain in the last stable, thus you'll have to use a nightly build or one from the forums if you're a winblows user
18:14 yellow-1000 sofar what is your opinion on #4642 ?
18:14 ShadowBot https://github.com/minetest/minetest/issues/4642 -- Allow the join/leave message to be overridden by mods. by red-001
18:14 corvus_262 i'm on linux and i just updated minetest.
18:15 Krock yellow-1000, do we need that?
18:16 yellow-1000 It could be useful for custom subgames
18:16 lumidify joined #minetest-dev
18:18 yellow-1000 e.g "Player joined team blue" for a subgame like ctf
18:21 yellow-1000 also It would allow all the people that want join/leave messages to be in blue to use a mod
18:22 yellow-1000 or use a diffrent colour or something for mods/admins joining
18:38 jin_xi joined #minetest-dev
18:48 AcidNinjaFWHR joined #minetest-dev
19:02 Samson1 joined #minetest-dev
19:03 sfan5 merging game#1372 in 15 minutes (2 approvals reached)
19:03 ShadowBot https://github.com/minetest​/minetest_game/issues/1372 -- Don't show item overlay if slot is occupied (bookshelf, vessels shelf) by sfan5
19:13 lumidify joined #minetest-dev
19:30 rubenwardy joined #minetest-dev
19:39 est31 joined #minetest-dev
19:53 ssieb joined #minetest-dev
20:12 lumidify joined #minetest-dev
20:23 diemartin joined #minetest-dev
20:34 AcidNinjaFWHR joined #minetest-dev
20:35 lisac joined #minetest-dev
20:45 proller__ joined #minetest-dev
21:16 Taoki joined #minetest-dev
21:30 nrzkt joined #minetest-dev
21:36 xunto1 joined #minetest-dev
22:16 FirePowi joined #minetest-dev
22:18 Tmanyo joined #minetest-dev
22:22 red-001 joined #minetest-dev
22:27 Tmanyo joined #minetest-dev
22:27 crazyR joined #minetest-dev
22:31 nerzhul_ joined #minetest-dev
23:44 Tmanyo joined #minetest-dev
23:54 Samson1 joined #minetest-dev
23:56 diemartin joined #minetest-dev

| Channels | #minetest-dev index | Today | | Google Search | Plaintext