Time  Nick       Message
05:37 paramat    github slow for anyone else?
05:41 paramat    editing comments is very slow, perhaps this has been de-prioritised
05:43 paramat    #4745
05:43 ShadowBot  https://github.com/minetest/minetest/issues/4745 -- Digging cracks: Make crack animation optional by paramat
05:56 paramat    will merge #4753 soon (trivial)
05:56 ShadowBot  https://github.com/minetest/minetest/issues/4753 -- Nodeupdate: Add missing documentation to lua_api.txt by paramat
06:00 paramat    will also merge #4653
06:00 ShadowBot  https://github.com/minetest/minetest/issues/4653 -- Halo: highlight selected face by sofar
06:02 est31      paramat: don't merge it
06:03 est31      you stabilize a bad function
06:03 est31      see my comment
06:03 paramat    hm
06:04 paramat    i should remove the docs for 'nodeupdate_single' then
06:04 Zeno`      everything is slow for me today :(
06:05 paramat    (.. which i added a while back)
06:05 est31      nodeupdate_single should get the same treatment
06:05 est31      you noted its not part of the official api, so we don't have to keep it
06:06 paramat    yes same treatment
06:07 Zeno`      hmm
06:07 Zeno`      what
06:07 Zeno`      what's wrong with cracks?
06:08 paramat    see commit message
06:08 Zeno`      I did, but I don't get it
06:09 est31      I like cracks
06:09 Zeno`      I do as well. I also play with no sound
06:09 Zeno`      the only games I play with sound are FPS and driving sims
06:10 Zeno`      anyway, I'm ambivalent
06:10 paramat    it's an option to reduce mesh update load
06:11 est31      I'm not really a fan of the pr
06:11 est31      and the load is not that large
06:11 est31      unless you have really complicated models in your mesh
06:20 est31      but shrug
06:20 est31      as long as disabling cracks its not the default
06:20 est31      is*
06:20 est31      I'm mostly fine with it I think
06:21 est31      I would oppose disabling cracks on a per node basis though
06:21 paramat    yeah me too
06:30 paramat    there was an issue about high client load during digging. players often dig a lot of nodes, with 10 mesh updates per node and with diamond tools that can dig 4 nodes per second
06:33 paramat    i'll let that sit and gather opinion, no rush for this one
06:34 paramat    will merge 4653 and (updated) 4753 in a moment
06:44 Hijiri     http://lpaste.net/337727
06:44 Hijiri     preemptive scheduling for coroutines!
06:44 Hijiri     lua computers might come soon
06:45 Hijiri     only issue is checking memory use, but probably I can do something hacky with collectgarbage("count")
06:46 paramat    now merging
06:50 paramat    complete
06:55 paramat    game#1385
06:55 ShadowBot  https://github.com/minetest/minetest_game/issues/1385 -- Add ambience mod for fire and water sounds
07:00 Hijiri     oh yeah, forgot to beg for reviews: #4685
07:00 ShadowBot  https://github.com/minetest/minetest/issues/4685 -- Add control information to player interacts by raymoo
07:02 Zeno`      I don't /think/ the small traffic increase matters much
07:03 Zeno`      there are much better ways to grief or spam a server than digging lots of holes
07:04 Zeno`      +1 from me
07:05 Zeno`      est31, merge it?
07:05 Zeno`      I'll merge in 15 mins if there are no objections
07:06 est31      yes merge is fine
07:22 Zeno`      merged
07:23 Hijiri     thanks
07:29 Zeno`      :)
07:29 Zeno`      Hijiri> oh yeah, forgot to beg for reviews: #4685     <--- the right thing to say haha :D
07:29 ShadowBot  https://github.com/minetest/minetest/issues/4685 -- Add control information to player interacts by raymoo
07:30 Zeno`      sad, but true
07:30 Zeno`      we just forget lots of things tbh because we need more devs
08:50 Zeno`      hi nrzkt
08:51 nrzkt      hi Zeno`
09:21 Foghrye4__ Once paramat said that 1-2 core devs intend to create client Lua API. Does someone really doing something?
09:30 Zeno`      I have not heard of the plan
09:30 Zeno`      I am not against it... I just haven't heard of it
09:32 Foghrye4__ There is #4577 which is already adding client-side API. A guy either should be encouraged to go on or his pull should be rejected.
09:32 ShadowBot  https://github.com/minetest/minetest/issues/4577 -- Client-side mods by duckbrain
09:32 Foghrye4__ ... or merged/
09:36 est31      should be merged IMO
09:36 est31      but I haven't looked at it
09:36 est31      and I don't want to merge something as big as this without looking
09:36 est31      also, note that the change currently is behind a setting, so it can be changed in the future
09:45 nrzkt      est31, too big for the incoming release, should wait for the next cycle i think to discuss about it
09:45 est31      it will be disabled by default anyway
09:45 est31      that's how it should be dealt with for a time I think
09:46 est31      we can't expect for a pr to get client side modding in perfect state imo
09:46 nrzkt      include disable code ? then just wait for merging. If you accept merging client side modding but not factorisation or SAO attributes it's just... lol
09:47 nrzkt      on*
09:49 est31      well the assumption is that duckbrain is more careful with their changes than you.
09:49 est31      but if you want, we can wait until after the release to be sure.
09:50 nrzkt      i think it's better to implement directly the proper design, have the complete 0.4.16-devel to implement test enhance it, instead of hurry up and add this disabled one month before release
09:50 nrzkt      directly with*
09:51 nrzkt      and merging an attribute which are declared in two child class in the parent class should not cause damages as it's just... C++ inheritance :)
09:51 nrzkt      i should go, see you later :)
10:06 est31      #4767
10:06 ShadowBot  https://github.com/minetest/minetest/issues/4767 -- Rename nodeupdate and nodeupdate_single and make them part of the official API by est31
12:21 Foghrye4__ Hate to admit it - but paramat right about glow. I couldn't think out any use of glow as colour variable. Whoever know what I'm talking about, I would like to read your opinions now.
16:30 Zeno`      #4769
16:30 ShadowBot  https://github.com/minetest/minetest/issues/4769 -- Credit where credit is due
16:57 Krock      well, I think releases should be only dedicated to one or multiple people when something special happened
16:58 Krock      yes sure, credits are nice but then we might want to dedicate 0.4.16 again to modders
16:58 Krock      and again and again..
16:58 Krock      maybe it's just me thinking this way
16:59 Zeno`      Krock, minetest would have died long ago if it wasn't for the people making mods and running servers
16:59 Krock      yes I agree but it's this way like always
16:59 red-001    tbh I think giving someone a special tag/rank on the forums would be more visible then the credits tab
17:00 Zeno`      I believe that a release recognising their contributions is appropriate
17:00 red-001    that could be just me through
17:00 Krock      yeah, maybe once but then remove it with the next release again
17:00 Zeno`      heck, I don't care if they have a tab all to their own in the next release
17:00 Zeno`      Krock, yeah. It can be removed afterwards
17:01 Zeno`      it's a dedication for the release
17:01 Krock      :+1: from my side, this time
17:01 Krock      \o/ Wuzzy
17:03 Zeno`      red-001, I know what you're saying
17:03 Wuzzy      Note to engine devs: I am currently proposing a simple non-strict naming convention to reserve item+entity field names starting with “_” to mod usage (e.g. “_custom_field”)
17:03 Wuzzy      https://github.com/minetest/minetest/pull/4770
17:03 Zeno`      but I think we should ack them in an actual release
17:03 Wuzzy      https://github.com/minetest/minetest/issues/4704
17:05 Krock      ack
17:06 Zeno`      nak ;P
17:51 red-001    could someone review #4472 ?
17:51 ShadowBot  https://github.com/minetest/minetest/issues/4472 -- Make serverlist searchable. by red-001
21:09 red-001    does anyone disagree with #3980 ?
21:09 ShadowBot  https://github.com/minetest/minetest/issues/3980 -- Standardizing API naming and calling conventions.