Time  Nick      Message
12:32 paramat   any support for #4747 ?
12:32 ShadowBot https://github.com/minetest/minetest/issues/4747 -- Draw bottom of the sky box in fog color. by lhofhansl
12:33 paramat   will merge #4724 #4750 in 2 hours
12:34 ShadowBot https://github.com/minetest/minetest/issues/4724 -- Improve number of blocks sent and occlusion culling. by lhofhansl
12:34 ShadowBot https://github.com/minetest/minetest/issues/4750 -- Document block_send_optimize_distance in minetest.conf.example by lhofhansl
13:28 Zeno`     paramat, 2 hours?!
13:29 Zeno`     just merge 4724 and 4750 now :)
13:29 Zeno`     I haven't looked at the other one
13:30 Zeno`     4747 seems fine also
13:31 Zeno`     Just Do It(TM)(R)(C)(All Rights Reserved)
13:36 hmmmm     paramat, please don't become a nerzhul
13:37 Zeno`     hmmmm you have a problem with those PRs?
13:37 hmmmm     4724 is not trivial as its effects are subtle.  the other PR is a documentation change, i'm fine with that one
13:38 Zeno`     I didn't look at the tags, I gotta admit
13:39 Zeno`     they look fine to me, but *shrug*
13:40 hmmmm     i didn't realize it had a lot of exposure at first
13:40 hmmmm     just not on IRC it seems
13:40 hmmmm     get up, see "merging in 2 hours!" say oh crap
13:42 hmmmm     well it doesn't help that the original code uses a lot of magic values
13:42 Fixer     can you hide terminal window by default (and add option in config to show/hide it)? 99% of time it clatters taskbar...
13:42 Fixer     you = devs
13:42 hmmmm     what's 1.42?  why is it squared?  sqrt(2) is 1.44 so that probably isn't what it was meant to be...
13:45 Zeno`     yeah I asked about that as well
13:45 Zeno`     it's still magic to me but I think it the hypotenuse or something
13:46 hmmmm     sqrt(1^2 + 1^2 + 1^2) = sqrt(3) = 1.732...
13:46 hmmmm     sure, makes sense but...
13:46 Zeno`     I did make a comment about it in the PR
13:46 hmmmm     why is it divided by 2?
13:47 hmmmm     isOccluded seems to take parameters in terms of nodes, not blocks
13:47 * Zeno`   opens the PR again
13:48 Zeno`     does the initial commit comment (point (2)) make sense?
13:49 Zeno`     perhaps that should be in the code. /me thinks
13:51 hmmmm     ahh oops
13:51 hmmmm     i didn't see the * MAP_BLOCKSIZE i guess
13:51 paramat   hmmmmm they have the necessary approvals
13:52 hmmmm     okay
13:52 Zeno`     personally I think they're fine. The only minor objection I might have had is the magic values
13:52 Zeno`     but... I dunno
13:52 hmmmm     well i still haven't figured out what 1.42^2 is but seeing as how that's really a magic value it's not our fault if something is incredibly broken
13:53 hmmmm     because the new value is not magic
13:53 paramat   oh the first post is out of date concerning point 2
13:53 paramat   see the discussion below
13:53 paramat   the new value is the max diagonal of a block
13:54 Zeno`     oh yeah
13:54 Zeno`     explained
13:54 paramat   except for the central point which can be half
13:54 Zeno`     but maybe it should be a comment in the code. BUT considering they were all magic to begin with, I dunno
13:54 Zeno`     it's a minor nitpick for me
13:54 paramat   sure more comments might be good
13:55 hmmmm     this PR should be a huge performance improvement
13:57 paramat   i think a comment as to why the central point offset is half could be added, i could do that on merge
13:58 paramat   btw 2hrs because i'm eating
14:01 paramat   'morning' routine etc :] (at 2 pm)
14:03 Zeno`     geez, you eat for a long time
14:03 paramat   lol
14:04 paramat   the 1.42^2 was an incorrect value for the max diagonal it seems
14:04 Zeno`     I'm more interested now in how it takes you 2 hours to eat
14:05 Zeno`     lol
14:05 Zeno`     even *I* don't eat that much
14:05 paramat   'morning routine'!
14:05 Zeno`     routines are good I guess
14:06 Zeno`     I usually wake up, have an aspirin and a beer. Job done!
14:06 Zeno`     (heh j/k)
14:08 Zeno`     having a beer for breakfast is ridiculous. Obviously whiskey is better
14:21 Fixer_    https://github.com/minetest/minetest/pull/3811 anyone wants this? it gets older each day and now needs rebase
14:22 Fixer_    paramat: "For now i suggest we consider using an edited version of tenplus1's ambience mod for flowing water and fire." // i remember you working on fire, but you probably forget about flowing water sound?
14:24 paramat   i'm working on new fire sound code. this *could* be extended to do water ambience too within the same code
14:30 paramat   on merge i'll add a comment to 4724 explaining the magic number
15:03 paramat   hmmmm there have been many requests for a 'get biome at point' API (for non-mgv6 mapgens), hopefully one that can return the actual biome name. not high priority though, for release i just have one request, settable dungeon parameters
15:25 paramat   will merge 4724 4747 4750 in a moment
15:29 paramat   merging
15:35 paramat   complete
15:36 paramat   now lots to do in game ..
15:55 Fixer_    do we really need to save fly/fast/noclip into minetest.conf? worlds and servers have different privs anyway, maybe save that info per world or per player?
15:56 paramat   those are per player
15:57 Fixer_    but then why we write it to minetest.conf?
16:00 Fixer_    in old 0.2 or 0.3 days it was needed, because it had one world only, but now I feel it is not needed anymore, (and should be saved per player(?), and on connect to server you receive your fly/noclip/whatever settings)
16:20 paramat   #4751 adds the previously mentioned comments to occlusion culling, removes unnecessary code and uses '/ 2.0f' because 'endoff' is a float
16:20 ShadowBot https://github.com/minetest/minetest/issues/4751 -- Occlusion culling: Add comments, minor code improvements by paramat
16:59 Foghrye4_ Hey, this mate, duckbrain, wrote he made it. #4577 - I totally need this thing.
16:59 ShadowBot https://github.com/minetest/minetest/issues/4577 -- Client-side mods by duckbrain
17:04 paramat   1 or 2 core devs already intend to add clientside mods
17:04 paramat   game#1377
17:04 ShadowBot https://github.com/minetest/minetest_game/issues/1377 -- Default: Make snow walkable again by paramat
17:05 Foghrye4_ But they just intend to do it, and this guy already did it! Is he made it bad?
17:07 Foghrye4_ paramat, at least you may remove WIP label.
17:07 paramat   no idea, but it will need review by those intending to do it
17:26 paramat   game#1378
17:26 ShadowBot https://github.com/minetest/minetest_game/issues/1378 -- Remove snow footstep 1
18:00 paramat   game#1380
18:00 ShadowBot https://github.com/minetest/minetest_game/issues/1380 -- Make nyancat and nyancat rainbow luminous
18:04 Hijiri    could someone review #4685?
18:04 ShadowBot https://github.com/minetest/minetest/issues/4685 -- Add control information to player interacts by raymoo
18:16 paramat   #4753
18:16 ShadowBot https://github.com/minetest/minetest/issues/4753 -- Nodeupdate: Add to core. namespace and to official API by paramat
19:30 Krock     paramat, #4753 needs legacy code
19:30 ShadowBot https://github.com/minetest/minetest/issues/4753 -- Nodeupdate: Add to core. namespace and to official API by paramat
19:31 Krock     in case mods use these functions already somewhere
19:34 paramat   ok, i'll need help with this so do leave suggestions in the comments