Minetest logo

IRC log for #minetest-dev, 2016-10-28

| Channels | #minetest-dev index | Today | | Google Search | Plaintext

All times shown according to UTC.

Time Nick Message
00:13 Zeno` joined #minetest-dev
00:13 hmmmm joined #minetest-dev
00:28 Hijiri I need some help with network format stuff
00:28 Hijiri I want to append player control info to interact packets
00:28 Hijiri However, the current last thing in the packet is variable-length
00:28 Hijiri I don't know how I should specify the start index of the player pos stuff
00:28 Hijiri (where in the code the index of the beginning of each part of the packet is listed in comments)
00:28 Hijiri could I just put [???] as the start position?
00:41 Hijiri Does reading a longString move the read pointer of a packet?
00:41 Hijiri oh, it does
01:12 kaeza joined #minetest-dev
01:20 Zeno` paramat, have you looked at Jooo's activity?
01:20 Zeno` (referring to #2092)
01:20 ShadowBot https://github.com/minetest/minetest/issues/2092 -- GUIFormSpecMenu::OnEvent by Joooo
01:21 Zeno` he hasn't had any github activity for 18 months
01:21 paramat i might have done
01:21 Zeno` I doubt he's going to rebase it
01:22 paramat it's not even completed work
01:22 Zeno` close it I reckon
01:22 paramat me too
01:24 paramat as well as lack of review, PR authors are often guilty of leaving stuff unfinished and unattended
01:24 Zeno` I think the author just lost interest in programming (or github)
01:24 Zeno` their activity history is just about empty hehe
01:25 Zeno` I'll close it. It'll never be finished and a lot of that affected code has changed since then anyway
01:25 paramat +1
01:30 paramat in the rules: "If a pull request or an issue does not get a response from its author in one month (when requiring more details), it is closed."
01:30 Zeno` well, it's been way more than a month :)
01:31 paramat for PRs that drag on i tend to start making a fuss after a year
01:31 Zeno` although maybe that rule should also include something about "no activity from author" as well
01:32 Zeno` i.e. if they don't even use github anymore they're not likely to even see any requests heh
01:32 Zeno` unless they have email notifications
01:33 Zeno` looks like MinerDad7 has left the scene as well (#1963)
01:34 Zeno` wow, it doesn't seem that long ago that I was reading that same PR heh
01:36 Zeno` #1188
01:36 ShadowBot https://github.com/minetest/minetest/issues/1188 -- getTime refactoring by Selat
01:36 Zeno` can it be rebased when merging? Or are they complicated conflicts?
01:38 Zeno` probably easy. There are hardly any changes in the conflicting file
01:41 Zeno` it'd be nice for liquids to work properly at chunk boundaries
01:41 Zeno` but... tricky
01:43 kaeza joined #minetest-dev
01:57 paramat back in a moment
02:08 paramat closed #1963
02:08 ShadowBot https://github.com/minetest/minetest/issues/1963 -- Add doxygen comments to itemdef.h by MinerDad7
02:11 hiradur joined #minetest-dev
02:12 paramat i don't know anything about rebasing on merge, i can only squash on merge. 1188 seems popular
02:16 paramat going through old issues / PRs is much needed, a while ago i went through issues and 50 could be closed immediately
02:31 kaeza_ joined #minetest-dev
02:33 harrison joined #minetest-dev
02:56 Hijiri #4685
02:56 ShadowBot https://github.com/minetest/minetest/issues/4685 -- Add control information to player interacts by raymoo
02:56 paramat #4684
02:56 ShadowBot https://github.com/minetest/minetest/issues/4684 -- Reconsideration of vertical generation / sending limits for mapblocks
02:59 Hijiri also could someone look at #4663
02:59 ShadowBot https://github.com/minetest/minetest/issues/4663 -- Make attached particle spawners respect the parent's yaw by orwell96
03:23 kaeza_ joined #minetest-dev
03:30 Wayward_One #4683
03:30 ShadowBot https://github.com/minetest/minetest/issues/4683 -- Build error: "undefined reference to '...'"
03:51 kaeza_ joined #minetest-dev
04:44 kaeza_ is there any reason for disabled mods to be listed in `world.mt`?
04:57 kaeza_ This seems to work fine: https://github.com/kaeza/minetest/commit/​f8bb8f90c52caf288aa18ae8d5387f654ce5b295
04:58 sofar disabled worldmods?
04:58 sofar dunno
04:59 kaeza_ if you have lots of mods in `mods/`, those `load_mod_whatever = false` lines just add noise for nothing
05:01 kaeza_ and you can bet somebody will complain about lack of privacy when distributing worlds :P
05:04 kaeza is it PR worthy or can somebody just fetch the commit and push it?
05:14 paramat a PR would be needed for consideration, there may be good reason for the way it is, possibly faster or less ambiguous
05:23 Zeno` I disable mods by adding = false
05:23 Zeno` for testing I might have them enabled or disabled
05:24 Zeno` depending on what I'm testing
05:31 nrzkt joined #minetest-dev
05:31 kaeza uh, actually
05:32 kaeza it seems they ARE removed, at least theoretically
05:32 Zeno` hmm
05:33 Zeno` I'd better check the scripts I use for testing in that case :)
05:34 kaeza on second read, no, only mods not present anymore
05:42 kaeza does settings:remove(key) even work?
05:48 torgdor joined #minetest-dev
05:54 kaeza sooo... I am doing something wrong, or this thing is broken
06:02 kaeza https://gist.github.com/kaeza/3​b93c02742ce630ffead419130ed20f5
06:09 red-001 joined #minetest-dev
06:38 sofar kaeza: s is never closed?
06:55 jin_xi joined #minetest-dev
06:58 kaeza sofar, closed?
07:03 kaeza sofar, there's no mention in the API that `Settings` object must be "closed" in any way
07:05 kaeza from the API, I assume that's handled by :write() internally
07:17 Hunterz joined #minetest-dev
07:32 nrzkt joined #minetest-dev
07:50 kaeza hmm, so on write(), it updates the configuration instead of plain overwriting it
07:51 kaeza which means that deleted entries in the in-memory `Settings` object are not removed from the file
07:51 kaeza :/
07:53 kaeza_ joined #minetest-dev
08:05 kaeza so that was the reason
09:04 proller joined #minetest-dev
09:34 nrzkt joined #minetest-dev
09:36 Calinou joined #minetest-dev
09:45 Karazhan joined #minetest-dev
10:05 AnotherBrick joined #minetest-dev
10:36 AcidNinjaFWHR joined #minetest-dev
10:37 AcidNinjaFWHR joined #minetest-dev
10:48 Amaz joined #minetest-dev
11:05 AcidNinjaFWHR joined #minetest-dev
11:09 Fixer joined #minetest-dev
11:31 AcidNinjaFWHR_ joined #minetest-dev
11:34 AcidNinjaFWHR joined #minetest-dev
11:53 turtleman joined #minetest-dev
12:06 CWz_ joined #minetest-dev
12:07 Thomas-S joined #minetest-dev
12:40 Sokomine joined #minetest-dev
13:01 nnnn20430 joined #minetest-dev
13:31 STHGOM joined #minetest-dev
13:31 STHGOM joined #minetest-dev
13:53 sfan5 pushing http://sprunge.us/TLQF?diff in 10 mins
14:02 garywhite joined #minetest-dev
14:24 est31 Anyone: can you try out minetest in your native language and check whether it works? Please only if you actually speak that language
14:24 est31 post the reply in this thread, together with the language tried: https://github.com/minetest/minetest/issues/4638
14:24 est31 I intend to only ship languages that got a positive comment in 0.4.15
15:06 Fixer_ joined #minetest-dev
15:09 troller joined #minetest-dev
15:09 red-001 joined #minetest-dev
15:21 red-002 joined #minetest-dev
15:40 jin_xi joined #minetest-dev
15:48 red-001 joined #minetest-dev
16:11 jomat joined #minetest-dev
16:11 Darcidride joined #minetest-dev
16:17 blaze joined #minetest-dev
16:24 Krock joined #minetest-dev
17:09 Darcidride joined #minetest-dev
17:14 kaeza joined #minetest-dev
17:15 harrison joined #minetest-dev
17:28 * garywhite appears
17:28 garywhite It makes you look arrogant when you protect your server's spawn under the username "god".
17:29 hmmmm joined #minetest-dev
17:36 juhdanad joined #minetest-dev
17:39 AcidNinjaFWHR joined #minetest-dev
18:11 Karazhan joined #minetest-dev
18:13 troller joined #minetest-dev
18:36 juhdanad Could someone explain me how to cause lighting bugs with TNT, please?
18:39 sofar that would be fixer :)
18:39 sofar lol
19:29 red-001 joined #minetest-dev
19:41 Fixer_ hi
19:41 Fixer_ crap
19:41 Fixer_ i can help for sure
19:41 Fixer_ but he is gone
19:42 Fixer_ say to him that I can help him
19:47 Fixer_ nevermind, I wrote to him
19:52 blaze joined #minetest-dev
19:55 FirePowi joined #minetest-dev
20:05 troller joined #minetest-dev
20:21 kaeza_ joined #minetest-dev
20:29 est31 sfan5: do you know korean?
20:29 est31 korean isn't RTL, but still stuff could go wrong beyond font rendering
20:29 sfan5 no i don't know korean
20:29 sfan5 however it should be okay if the translation look the same in-game as in the .mo
20:38 est31 we should assemble a list of known working languages
20:38 est31 and then only ship with those
20:39 sfan5 okay did i get this right
20:39 sfan5 mod security prohibits reading files at runtime?
20:39 est31 #4638
20:39 ShadowBot https://github.com/minetest/minetest/issues/4638 -- Don't ship with broken languages
20:40 est31 sfan5: it should prohibit reading files outside the world dir
20:40 est31 and the mod dir
20:40 sfan5 okay then it's broken
20:40 sfan5 https://github.com/minetest-mods/mg/issues/10
20:40 sfan5 i've just verified
20:40 sfan5 2016-10-28 22:37:32: ERROR[Main]: ServerError: Lua: Runtime error from mod 'mg' in callback environment_OnGenerated(): Attempt to access external file minetest/bin/../mods/mg/schems/well.we with mod security on.
20:41 est31 that looks like a bug
20:42 sfan5 well it looks like there isn't a modname at CUSTOM_RIDX_CURRENT_MOD_NAME
20:47 sfan5 so far i've found two issues with mod security
20:47 sfan5 doesn't seem very production ready to me
21:06 Fixer_ est31: ukrainian language works
21:07 Fixer_ est31: russian also worked earlier in 0.4.13 for sure
21:11 juhdanad joined #minetest-dev
21:13 Amaz left #minetest-dev
21:17 juhdanad I'm currently trying to reproduce TNT lighting glitches...
21:35 Fixer_ juhdanad: hi
21:35 Fixer_ juhdanad: ok, did you read my message on github?
21:35 juhdanad Yes, I did.
21:36 Fixer_ juhdanad: start "Flat" world
21:36 juhdanad OK, done.
21:37 Fixer_ juhdanad: good way to reproduce is blow up a huuuge crater, quite deep, after that make a big tnt bridge 1 node wide over that crater, than try to start it from one side and wait
21:39 juhdanad Does the crater need to be wide?
21:40 Fixer_ juhdanad: yes, try wide one, let me search for screens
21:40 Fixer_ juhdanad: or... wait for me
21:41 juhdanad I did it! I flew along with the explosion chain and the final TNT node made its surroundings dark.
21:41 juhdanad Thanks, Fixer!
21:42 Fixer_ nice
21:42 Fixer_ np
21:42 Fixer_ it is weird old bugs
21:42 juhdanad Also, I think lava casting creates bright patches because the light spreads to unloaded chunks.
21:42 Fixer_ could be
21:42 Fixer_ i suspect that too
21:43 Fixer_ my cast was huge in size
21:43 Fixer_ and some area may have been unloaded during the test
21:44 juhdanad My code assumes that the lighting is correct everywhere except in the changed nodes. But the newly-loaded blocks won't have correct light. They still contain the lava's old light.
21:44 juhdanad And they won't disappear so.
21:45 juhdanad The solution (I think) is to check if the loaded blocks have correct light and if not, re-light them.
21:57 Calinou when I change font_size to 20, it does not do anything after restarting Minetest, is this a bug? I didn't change the font from the default
21:57 Calinou Freetype is enabled and used
21:57 Calinou (default value is 16)
21:58 juhdanad For me, font size works well.
21:59 Calinou in fact Minetest seems to ignore all my font settings…
21:59 Calinou :(
21:59 Calinou I'm on Linux by the way
21:59 Calinou self-compiled Git from today
21:59 juhdanad Me too.
21:59 Calinou ah that's because Minetest is using the fallback font
22:00 Calinou ._.
22:00 Calinou if I change the fallback font size, it works
22:13 Calinou juhdanad: is your Minetest installed system-wide through "sudo make install"?
22:13 Calinou if so, I won't bother creating an issue, else it might be worth reporting
22:15 juhdanad No, it is in my home folder.
22:22 troller joined #minetest-dev
22:28 Calinou that might be why
22:28 Calinou submitted: https://github.com/minetest/minetest/issues/4693
22:34 Fixer joined #minetest-dev
22:38 DI3HARD139 joined #minetest-dev
22:51 proller joined #minetest-dev
23:25 garywhite joined #minetest-dev

| Channels | #minetest-dev index | Today | | Google Search | Plaintext